From 14d3b2c3ca477ccdce115cfe840e83fd76be6331 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 16 May 2025 18:09:46 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/issue_templates/Bug.md | 14 + .rubocop_todo/capybara/visibility_matcher.yml | 1 - .../components/review_drawer.vue | 3 + .../graph/components/job_group_dropdown.vue | 6 +- .../graph/components/job_item.vue | 2 +- .../components/stage_column_component.vue | 12 +- .../stylesheets/page_bundles/pipeline.scss | 16 +- config/gitlab_loose_foreign_keys.yml | 4 + ...equired-pipeline-configuration-premium.yml | 2 +- .../14-8-sast-analyzer-removals.yml | 4 +- .../15-8-third-party-registries.yml | 2 +- ...mn_to_external_audit_event_destinations.rb | 13 + ...tive_column_to_amazon_s3_configurations.rb | 13 + ..._to_google_cloud_logging_configurations.rb | 13 + ...o_group_external_streaming_destinations.rb | 13 + ...stance_external_audit_event_destination.rb | 13 + ...mn_to_instance_amazon_s3_configurations.rb | 13 + ...nstance_external_streaming_destinations.rb | 13 + ...nce_google_cloud_logging_configurations.rb | 13 + ...ks_enabled_to_project_security_settings.rb | 10 + ..._tags_foreign_key_on_ci_runner_taggings.rb | 22 ++ ..._terraform_module_metadata_semver_patch.rb | 16 + db/schema_migrations/20250508094430 | 1 + db/schema_migrations/20250514150058 | 1 + db/schema_migrations/20250514150138 | 1 + db/schema_migrations/20250514150201 | 1 + db/schema_migrations/20250514150707 | 1 + db/schema_migrations/20250514152911 | 1 + db/schema_migrations/20250514152921 | 1 + db/schema_migrations/20250514152941 | 1 + db/schema_migrations/20250514152958 | 1 + db/schema_migrations/20250514161148 | 1 + db/schema_migrations/20250514220951 | 1 + db/structure.sql | 29 +- doc/.vale/gitlab_base/OutdatedVersions.yml | 2 +- doc/administration/guest_users.md | 1 - doc/api/oauth2.md | 2 +- doc/development/ai_features/availability.md | 279 ++++++++++++++++++ .../documentation/styleguide/_index.md | 5 + .../documentation/styleguide/word_list.md | 16 + .../visual_studio_code/_index.md | 4 +- .../visual_studio_code/cicd.md | 10 +- .../img/ci_variable_autocomplete_v16_6.png | Bin .../img/pipeline_alert_v17_6.png | Bin .../img/select-project-account_v17_7.png | Bin .../img/show_merged_configuration_v17_6.png | Bin .../img/status_bar_pipeline_v17_6.png | Bin .../img/view_job_output_v17_6.png | Bin .../img/vscode_view_changed_file_v17_6.png | Bin .../advanced_search/elasticsearch.md | 15 + doc/security/two_factor_authentication.md | 46 ++- doc/update/deprecations.md | 8 +- .../configuration/enabling_the_analyzer.md | 6 +- ...postman_collection_edit_variable_v13_9.png | Bin ...ostman_environment_edit_variable_v13_9.png | Bin ...api_fuzzing_postman_request_edit_v13_9.png | Bin .../configuration/enabling_the_analyzer.md | 6 +- ...postman_collection_edit_variable_v13_9.png | Bin ...ostman_environment_edit_variable_v13_9.png | Bin .../dast_api_postman_request_edit_v13_9.png | Bin .../browser/configuration/authentication.md | 6 +- ...dast_auth_browser_scan_highlight_v16_9.png | Bin ...uth_browser_scan_search_elements_v16_9.png | Bin .../img/dast_auth_report_v16_9.jpg | Bin .../sast/gitlab_advanced_sast.md | 2 +- .../sast/img/code_flow_view_v17_7.png | Bin 0 -> 84495 bytes .../img/cluster_agent_security_tab_v14_8.png | Bin doc/user/clusters/agent/vulnerabilities.md | 2 +- doc/user/enterprise_user/_index.md | 150 ++++------ .../get_domain_verification_code_v16_0.png | Bin .../img/retry_domain_verification_v16_0.png | Bin doc/user/group/epics/epic_boards.md | 2 +- ...sue_board_add_list_between_lists_v17_6.png | Bin 0 -> 5747 bytes .../terraform_module_registry/_index.md | 227 ++++++++------ ...o_factor_authentication_troubleshooting.md | 2 +- doc/user/project/codeowners/_index.md | 2 +- doc/user/project/codeowners/advanced.md | 2 +- .../img/codeowners_in_UI_v15_10.png | Bin .../img/direct_group_members_v17_9.png | Bin .../img/merge_request_maintainers_v17_9.png | Bin ...i_approvals_code_owners_sections_v15_9.png | Bin .../optional_code_owners_sections_v17_4.png | Bin .../img/sectional_code_owners_v17_4.png | Bin doc/user/project/codeowners/reference.md | 8 +- doc/user/project/description_templates.md | 2 +- .../group_file_template_settings_v11_5.png | Bin .../issues/img/closing_pattern_v17_4.png | Bin 0 -> 10467 bytes doc/user/project/issues/managing_issues.md | 2 +- doc/user/project/merge_requests/changes.md | 2 +- .../merge_requests/creating_merge_requests.md | 2 +- .../merge_requests/img/explain_code_v17_1.png | Bin 0 -> 18520 bytes .../forking_workflow_branch_select_v15_9.png | Bin .../img/change_path_v12_10.png | Bin .../pages_forked_sample_project.md | 2 +- .../img/code_suggestions_error_v17_4.svg | 0 .../img/code_suggestions_loading_v17_4.svg | 0 .../img/open_settings_v17_5.png | Bin .../img/visual_studio_status_bar_v17_4.png | Bin .../repository/code_suggestions/set_up.md | 6 +- .../code_suggestions/troubleshooting.md | 2 +- .../files/jupyter_notebooks/_index.md | 2 +- .../img/jupyter_notebook_v17_10.png | Bin locale/gitlab.pot | 36 +++ package.json | 2 +- spec/db/schema_spec.rb | 4 +- spec/features/projects/compare_spec.rb | 4 +- spec/features/webauthn_spec.rb | 8 +- spec/frontend/boards/project_select_spec.js | 3 +- .../graph/components/graph_component_spec.js | 9 +- .../registration_dropdown_spec.js | 2 +- .../components/revision_dropdown_spec.js | 2 +- .../database/no_cross_db_foreign_keys_spec.rb | 6 +- spec/models/ci/runner_tagging_spec.rb | 39 +++ .../terraform_module/metadatum_spec.rb | 14 +- .../loose_foreign_keys_shared_context.rb | 4 +- yarn.lock | 8 +- 116 files changed, 912 insertions(+), 310 deletions(-) create mode 100644 db/migrate/20250514150058_add_active_column_to_external_audit_event_destinations.rb create mode 100644 db/migrate/20250514150138_add_active_column_to_amazon_s3_configurations.rb create mode 100644 db/migrate/20250514150201_add_active_column_to_google_cloud_logging_configurations.rb create mode 100644 db/migrate/20250514150707_add_active_column_to_group_external_streaming_destinations.rb create mode 100644 db/migrate/20250514152911_add_active_column_to_instance_external_audit_event_destination.rb create mode 100644 db/migrate/20250514152921_add_active_column_to_instance_amazon_s3_configurations.rb create mode 100644 db/migrate/20250514152941_add_active_column_to_instance_external_streaming_destinations.rb create mode 100644 db/migrate/20250514152958_add_active_column_to_instance_google_cloud_logging_configurations.rb create mode 100644 db/migrate/20250514220951_add_validity_checks_enabled_to_project_security_settings.rb create mode 100644 db/post_migrate/20250508094430_drop_tags_foreign_key_on_ci_runner_taggings.rb create mode 100644 db/post_migrate/20250514161148_cleanup_bigint_conversion_for_pkgs_terraform_module_metadata_semver_patch.rb create mode 100644 db/schema_migrations/20250508094430 create mode 100644 db/schema_migrations/20250514150058 create mode 100644 db/schema_migrations/20250514150138 create mode 100644 db/schema_migrations/20250514150201 create mode 100644 db/schema_migrations/20250514150707 create mode 100644 db/schema_migrations/20250514152911 create mode 100644 db/schema_migrations/20250514152921 create mode 100644 db/schema_migrations/20250514152941 create mode 100644 db/schema_migrations/20250514152958 create mode 100644 db/schema_migrations/20250514161148 create mode 100644 db/schema_migrations/20250514220951 create mode 100644 doc/development/ai_features/availability.md rename doc/editor_extensions/{ => visual_studio_code}/img/ci_variable_autocomplete_v16_6.png (100%) rename doc/editor_extensions/{ => visual_studio_code}/img/pipeline_alert_v17_6.png (100%) rename doc/editor_extensions/{ => visual_studio_code}/img/select-project-account_v17_7.png (100%) rename doc/editor_extensions/{ => visual_studio_code}/img/show_merged_configuration_v17_6.png (100%) rename doc/editor_extensions/{ => visual_studio_code}/img/status_bar_pipeline_v17_6.png (100%) rename doc/editor_extensions/{ => visual_studio_code}/img/view_job_output_v17_6.png (100%) rename doc/editor_extensions/{ => visual_studio_code}/img/vscode_view_changed_file_v17_6.png (100%) rename doc/user/application_security/api_fuzzing/{ => configuration}/img/api_fuzzing_postman_collection_edit_variable_v13_9.png (100%) rename doc/user/application_security/api_fuzzing/{ => configuration}/img/api_fuzzing_postman_environment_edit_variable_v13_9.png (100%) rename doc/user/application_security/api_fuzzing/{ => configuration}/img/api_fuzzing_postman_request_edit_v13_9.png (100%) rename doc/user/application_security/api_security_testing/{ => configuration}/img/dast_api_postman_collection_edit_variable_v13_9.png (100%) rename doc/user/application_security/api_security_testing/{ => configuration}/img/dast_api_postman_environment_edit_variable_v13_9.png (100%) rename doc/user/application_security/api_security_testing/{ => configuration}/img/dast_api_postman_request_edit_v13_9.png (100%) rename doc/user/application_security/dast/browser/{ => configuration}/img/dast_auth_browser_scan_highlight_v16_9.png (100%) rename doc/user/application_security/dast/browser/{ => configuration}/img/dast_auth_browser_scan_search_elements_v16_9.png (100%) rename doc/user/application_security/dast/browser/{ => configuration}/img/dast_auth_report_v16_9.jpg (100%) create mode 100644 doc/user/application_security/sast/img/code_flow_view_v17_7.png rename doc/user/clusters/{ => agent}/img/cluster_agent_security_tab_v14_8.png (100%) rename doc/user/{ => enterprise_user}/img/get_domain_verification_code_v16_0.png (100%) rename doc/user/{ => enterprise_user}/img/retry_domain_verification_v16_0.png (100%) create mode 100644 doc/user/group/epics/img/issue_board_add_list_between_lists_v17_6.png rename doc/user/project/{ => codeowners}/img/codeowners_in_UI_v15_10.png (100%) rename doc/user/project/{ => codeowners}/img/direct_group_members_v17_9.png (100%) rename doc/user/project/{ => codeowners}/img/merge_request_maintainers_v17_9.png (100%) rename doc/user/project/{ => codeowners}/img/multi_approvals_code_owners_sections_v15_9.png (100%) rename doc/user/project/{ => codeowners}/img/optional_code_owners_sections_v17_4.png (100%) rename doc/user/project/{ => codeowners}/img/sectional_code_owners_v17_4.png (100%) rename doc/user/{group => project}/img/group_file_template_settings_v11_5.png (100%) create mode 100644 doc/user/project/issues/img/closing_pattern_v17_4.png create mode 100644 doc/user/project/merge_requests/img/explain_code_v17_1.png rename doc/user/project/{repository => merge_requests}/img/forking_workflow_branch_select_v15_9.png (100%) rename doc/user/project/pages/{ => getting_started}/img/change_path_v12_10.png (100%) rename doc/{editor_extensions => user/project/repository/code_suggestions}/img/code_suggestions_error_v17_4.svg (100%) rename doc/{editor_extensions => user/project/repository/code_suggestions}/img/code_suggestions_loading_v17_4.svg (100%) rename doc/{editor_extensions/visual_studio_code => user/project/repository/code_suggestions}/img/open_settings_v17_5.png (100%) rename doc/{editor_extensions => user/project/repository/code_suggestions}/img/visual_studio_status_bar_v17_4.png (100%) rename doc/user/project/repository/files/{ => jupyter_notebooks}/img/jupyter_notebook_v17_10.png (100%) diff --git a/.gitlab/issue_templates/Bug.md b/.gitlab/issue_templates/Bug.md index 711a00a9fa1..9ad6f69f79e 100644 --- a/.gitlab/issue_templates/Bug.md +++ b/.gitlab/issue_templates/Bug.md @@ -88,6 +88,20 @@ will also determine whether the bug is fixed in a more recent version. --> +### Patch release information for backports + +If the bug fix needs to be backported in a [patch release](https://handbook.gitlab.com/handbook/engineering/releases/patch-releases) to a version +under [the maintenance policy](https://docs.gitlab.com/policy/maintenance/), please follow the steps on the +[patch release runbook for GitLab engineers](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/engineers.md). + +Refer to the [internal "Release Information" dashboard](https://dashboards.gitlab.net/d/delivery-release_info/delivery3a-release-information?orgId=1) +for information about the next patch release, including the targeted versions, expected release date, and current status. + +#### High-severity bug remediation + +To remediate high-severity issues requiring an [internal release](https://handbook.gitlab.com/handbook/engineering/releases/internal-releases/) for single-tenant SaaS instances, +refer to the [internal release process for engineers](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/internal-releases/engineers.md?ref_type=heads). + /label ~"type::bug" diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index f063bbe0275..f78734eb854 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -43,7 +43,6 @@ Capybara/VisibilityMatcher: - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/overview_spec.rb' - 'spec/features/users/user_browses_projects_on_user_page_spec.rb' - - 'spec/features/webauthn_spec.rb' - 'spec/support/helpers/features/canonical_link_helpers.rb' - 'spec/support/shared_examples/features/discussion_comments_shared_example.rb' - 'spec/support/shared_examples/features/page_description_shared_examples.rb' diff --git a/app/assets/javascripts/batch_comments/components/review_drawer.vue b/app/assets/javascripts/batch_comments/components/review_drawer.vue index e00d0b06304..07c62d80850 100644 --- a/app/assets/javascripts/batch_comments/components/review_drawer.vue +++ b/app/assets/javascripts/batch_comments/components/review_drawer.vue @@ -153,6 +153,9 @@ export default { 'discardDrafts', 'clearDrafts', ]), + isOnLatestDiff(draft) { + return draft.position?.head_sha === this.getNoteableData.diff_head_sha; + }, async onClickDraft(draft) { if (this.viewDiffsFileByFile) { await this.goToFile({ path: draft.file_path }); diff --git a/app/assets/javascripts/ci/pipeline_details/graph/components/job_group_dropdown.vue b/app/assets/javascripts/ci/pipeline_details/graph/components/job_group_dropdown.vue index 31867d5f9b3..de412cdbc54 100644 --- a/app/assets/javascripts/ci/pipeline_details/graph/components/job_group_dropdown.vue +++ b/app/assets/javascripts/ci/pipeline_details/graph/components/job_group_dropdown.vue @@ -118,16 +118,16 @@ export default {