little refactor and improvements on specs
This commit is contained in:
		
							parent
							
								
									207b7218aa
								
							
						
					
					
						commit
						1575a95b65
					
				|  | @ -118,7 +118,7 @@ module Banzai | |||
|         end | ||||
| 
 | ||||
|         if path | ||||
|           content_tag(:img, nil, src: path, class: tag_class('image')) | ||||
|           content_tag(:img, nil, src: path, class: 'gfm') | ||||
|         end | ||||
|       end | ||||
| 
 | ||||
|  | @ -155,7 +155,7 @@ module Banzai | |||
|           href = ::File.join(project_wiki_base_path, reference) | ||||
|         end | ||||
| 
 | ||||
|         content_tag(:a, name || reference, href: href, class: tag_class('page')) | ||||
|         content_tag(:a, name || reference, href: href, class: 'gfm') | ||||
|       end | ||||
| 
 | ||||
|       def project_wiki | ||||
|  | @ -172,10 +172,6 @@ module Banzai | |||
|       def validate | ||||
|         needs :project_wiki | ||||
|       end | ||||
| 
 | ||||
|       def tag_class(type) | ||||
|         "gfm gollum gollum-#{type}" | ||||
|       end | ||||
|     end | ||||
|   end | ||||
| end | ||||
|  |  | |||
|  | @ -70,7 +70,7 @@ describe Banzai::Filter::GollumTagsFilter, lib: true do | |||
|   end | ||||
| 
 | ||||
|   context 'linking internal resources' do | ||||
|     it "the created link's text will include the resource's text and project_wiki_base_path" do | ||||
|     it "the created link's text includes the resource's text and wiki base path" do | ||||
|       tag = '[[wiki-slug]]' | ||||
|       doc = filter("See #{tag}", project_wiki: project_wiki) | ||||
|       expected_path = ::File.join(project_wiki.wiki_base_path, 'wiki-slug') | ||||
|  |  | |||
|  | @ -1,9 +1,6 @@ | |||
| require 'rails_helper' | ||||
| 
 | ||||
| describe Banzai::Pipeline::WikiPipeline do | ||||
|   let(:project_wiki) { double } | ||||
|   before(:each) { allow(project_wiki).to receive(:wiki_base_path) { '/some/repo/wikis' } } | ||||
| 
 | ||||
|   describe 'TableOfContents' do | ||||
|     it 'replaces the tag with the TableOfContentsFilter result' do | ||||
|       markdown = <<-MD.strip_heredoc | ||||
|  | @ -14,7 +11,7 @@ describe Banzai::Pipeline::WikiPipeline do | |||
|           Foo | ||||
|       MD | ||||
| 
 | ||||
|       result = described_class.call(markdown, project: spy, project_wiki: project_wiki) | ||||
|       result = described_class.call(markdown, project: spy, project_wiki: spy) | ||||
| 
 | ||||
|       aggregate_failures do | ||||
|         expect(result[:output].text).not_to include '[[' | ||||
|  | @ -32,7 +29,7 @@ describe Banzai::Pipeline::WikiPipeline do | |||
|           Foo | ||||
|       MD | ||||
| 
 | ||||
|       output = described_class.to_html(markdown, project: spy, project_wiki: project_wiki) | ||||
|       output = described_class.to_html(markdown, project: spy, project_wiki: spy) | ||||
| 
 | ||||
|       expect(output).to include('[[<em>toc</em>]]') | ||||
|     end | ||||
|  | @ -45,7 +42,7 @@ describe Banzai::Pipeline::WikiPipeline do | |||
|           Foo | ||||
|       MD | ||||
| 
 | ||||
|       output = described_class.to_html(markdown, project: spy, project_wiki: project_wiki) | ||||
|       output = described_class.to_html(markdown, project: spy, project_wiki: spy) | ||||
| 
 | ||||
|       aggregate_failures do | ||||
|         expect(output).not_to include('<ul>') | ||||
|  |  | |||
		Loading…
	
		Reference in New Issue