root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Enable `Lint/EmptyWhen` cop and correct offense

This commit is contained in:
Robert Speicher 2017-02-10 15:26:23 -05:00
parent 5db56efe42
commit 17c8d15b14
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.rubocop.yml
View File

@ -572,6 +572,10 @@ Lint/ElseLayout:
Lint/EmptyEnsure: Lint/EmptyEnsure:
Enabled: true Enabled: true
# Checks for the presence of `when` branches without a body.
Lint/EmptyWhen:
Enabled: true
# Align ends correctly. # Align ends correctly.
Lint/EndAlignment: Lint/EndAlignment:
Enabled: true Enabled: true

4
.rubocop_todo.yml
View File

@ -21,10 +21,6 @@ Lint/AmbiguousRegexpLiteral:
Lint/AssignmentInCondition: Lint/AssignmentInCondition:
Enabled: false Enabled: false
# Offense count: 1
Lint/EmptyWhen:
Enabled: false
# Offense count: 20 # Offense count: 20
Lint/HandleExceptions: Lint/HandleExceptions:
Enabled: false Enabled: false

2
lib/gitlab/diff/parser.rb
View File

@ -45,7 +45,7 @@ module Gitlab
line_new += 1 line_new += 1
when "-" when "-"
line_old += 1 line_old += 1
when "\\" when "\\" # rubocop:disable Lint/EmptyWhen
# No increment # No increment
else else
line_new += 1 line_new += 1