From 181a4e02bb2f514c71abe5b088a790387c97d0fb Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 18 Jun 2024 18:23:10 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/qa.gitlab-ci.yml | 4 +- .gitlab/ci/rules.gitlab-ci.yml | 17 +- .rubocop_todo/layout/line_length.yml | 1 - Gemfile | 2 +- Gemfile.checksum | 2 +- Gemfile.lock | 4 +- .../javascripts/ci/common/pipelines_table.vue | 2 - .../ci/job_details/components/log/line.vue | 2 +- .../components/pipelines_table_wrapper.vue | 74 +++++- .../get_merge_request_pipelines.query.graphql | 2 + .../javascripts/ci/merge_requests/utils.js | 2 +- .../diffs/components/compare_versions.vue | 2 +- .../gitlab_pages/components/deployment.vue | 9 + .../gitlab_pages/components/deployments.vue | 226 ++++++++++++++++ .../gitlab_pages/components/edit.vue | 12 + .../components/load_more_deployments.vue | 36 +++ .../get_project_pages_deployments.graphql | 44 ++++ app/assets/javascripts/gitlab_pages/show.js | 11 +- .../components/related_merge_requests.vue | 98 ++++--- .../issues/related_merge_requests/index.js | 14 +- .../related_merge_requests.query.graphql | 42 +++ .../related_merge_requests/store/actions.js | 36 --- .../related_merge_requests/store/index.js | 15 -- .../store/mutation_types.js | 4 - .../related_merge_requests/store/mutations.js | 19 -- .../related_merge_requests/store/state.js | 7 - .../issues/show/components/issue_header.vue | 2 +- .../components/list/publish_method.vue | 2 +- .../shared/components/publish_message.vue | 2 +- .../components/performance_bar_app.vue | 8 +- .../dropdown_contents_create_view.vue | 2 +- .../dropdown_contents_create_view.vue | 56 ++-- .../labels_select_widget/dropdown_header.vue | 4 +- .../surveys/merge_request_experience/app.vue | 2 +- .../components/widget/utils.js | 6 +- .../issues/_details_content.html.haml | 7 +- app/views/projects/pages/show.html.haml | 31 +-- .../profiles/_email_settings.html.haml | 4 +- .../profiles/_private_profile.html.haml | 4 +- .../user_settings/profiles/show.html.haml | 4 +- config/initializers/1_settings.rb | 2 +- ...zzing-ci-configuration-create-mutation.yml | 2 +- .../14-8-graphql-project-network-policies.yml | 2 +- ...5-1-pipelinesecurityreportfinding-name.yml | 4 +- ...curityreportfinding-projectfingerprint.yml | 4 +- ...3-vulnerabilityFindingDismiss-mutation.yml | 4 +- ...5-vulnerabilityFindingDismiss-mutation.yml | 2 +- ...led-with-override-runner-setting-value.yml | 5 +- data/deprecations/15-9-Vault-integration.yml | 2 +- ...-3-runner-terminationgracepriodseconds.yml | 2 +- ...name-require_password_to_approve-field.yml | 2 +- doc/development/ai_features/duo_chat.md | 2 +- doc/development/fe_guide/style/scss.md | 6 +- doc/development/fe_guide/style/vue.md | 12 +- doc/update/deprecations.md | 133 +++++----- doc/user/gitlab_duo/index.md | 13 + .../repository/code_suggestions/index.md | 13 +- doc/user/storage_management_automation.md | 64 ++--- .../references/issue_reference_filter.rb | 2 +- locale/gitlab.pot | 29 +- spec/features/issues/form_spec.rb | 10 +- .../job_details/components/log/line_spec.js | 2 +- .../pipelines_table_wrapper_spec.js | 235 ++++++++++++++++- spec/frontend/ci/merge_requests/mock_data.js | 2 + .../diffs/components/compare_versions_spec.js | 2 +- .../components/deployments_spec.js | 248 ++++++++++++++++++ .../gitlab_pages/components/edit_spec.js | 23 ++ .../components/pages_edit_spec.js | 12 +- spec/frontend/gitlab_pages/mock_data.js | 42 +++ .../components/related_merge_requests_spec.js | 161 ++++++++---- .../store/actions_spec.js | 108 -------- .../store/mutations_spec.js | 49 ---- .../__snapshots__/publish_method_spec.js.snap | 2 +- .../dropdown_contents_create_view_spec.js | 20 +- .../components/widget/utils_spec.js | 4 +- .../references/issue_reference_filter_spec.rb | 12 +- .../work_item_reference_filter_spec.rb | 10 + .../timeline_events_spec.rb | 2 +- spec/support/rspec_order_todo.yml | 1 - .../sidebar/sidebar_labels_shared_examples.rb | 9 +- .../profiles/show.html.haml_spec.rb | 8 +- 81 files changed, 1473 insertions(+), 615 deletions(-) create mode 100644 app/assets/javascripts/gitlab_pages/components/deployment.vue create mode 100644 app/assets/javascripts/gitlab_pages/components/deployments.vue create mode 100644 app/assets/javascripts/gitlab_pages/components/edit.vue create mode 100644 app/assets/javascripts/gitlab_pages/components/load_more_deployments.vue create mode 100644 app/assets/javascripts/gitlab_pages/queries/get_project_pages_deployments.graphql create mode 100644 app/assets/javascripts/issues/related_merge_requests/queries/related_merge_requests.query.graphql delete mode 100644 app/assets/javascripts/issues/related_merge_requests/store/actions.js delete mode 100644 app/assets/javascripts/issues/related_merge_requests/store/index.js delete mode 100644 app/assets/javascripts/issues/related_merge_requests/store/mutation_types.js delete mode 100644 app/assets/javascripts/issues/related_merge_requests/store/mutations.js delete mode 100644 app/assets/javascripts/issues/related_merge_requests/store/state.js create mode 100644 spec/frontend/gitlab_pages/components/deployments_spec.js create mode 100644 spec/frontend/gitlab_pages/components/edit_spec.js create mode 100644 spec/frontend/gitlab_pages/mock_data.js delete mode 100644 spec/frontend/issues/related_merge_requests/store/actions_spec.js delete mode 100644 spec/frontend/issues/related_merge_requests/store/mutations_spec.js diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index eb1c4dc95f6..667ef8dbc48 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -110,9 +110,7 @@ e2e:post-run-e2e-message: - install_gitlab_gem script: - scripts/generate-message-to-run-e2e-pipeline.rb - needs: - - e2e-test-pipeline-generate - - build-assets-image + needs: [] artifacts: expire_in: 1 day paths: diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index a6b3ea79351..5b093553807 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -1629,12 +1629,6 @@ changes: *code-patterns - <<: *if-merge-request-and-specific-devops-stage changes: *code-patterns - - <<: *if-force-ci - when: manual - allow_failure: true - # We used to have a rule at the end here that would catch any remaining code MRs and allow the job to be run - # manually. That rule is now in ".qa:rules:code-merge-request-manual" so it can be included when needed and we can - # still use ".qa:rules:package-and-test-common" in jobs we don't want to be manual. # Like .qa:rules:package-and-test-common but not allowed to fail. # It's named `e2e` instead of `package-and-test` because it's used for e2e tests on GDK (and could be used @@ -1705,7 +1699,6 @@ rules: - !reference [".qa:rules:package-and-test-common", rules] - !reference [".qa:rules:e2e-schedule-blocking", rules] - - !reference [".qa:rules:code-merge-request-manual", rules] .qa:rules:package-and-test-ce: rules: @@ -1770,7 +1763,9 @@ # These provide a manual way to trigger follow-up:e2e:package-and-test-ee # It is fine if they're overlapping with the automatic ones. # It'll not hurt and it can simplify the rules, decoupling them. -# If any changes are made to this rule, `.qa:rules:follow-up-e2e` should also be updated. +# If any changes are made to this rule, the following should also be updated: +# 1) .qa:rules:follow-up-e2e +# 2) .qa:rules:post-run-e2e-message .qa:rules:manual-e2e: rules: - !reference [".qa:rules:package-and-test-never-run", rules] @@ -1779,7 +1774,8 @@ - !reference [".qa:rules:code-merge-request-manual", rules] # These are based on `.qa:rules:manual-e2e` but with manual jobs changed to automatic. -# If any changes are made to this rule, `.qa:rules:manual-e2e` should also be updated. +# If any changes are made to this rule, the following should also be updated: +# 1) .qa:rules:manual-e2e .qa:rules:follow-up-e2e: rules: - !reference [".qa:rules:package-and-test-never-run", rules] @@ -1824,11 +1820,10 @@ when: never - <<: *if-merge-request-and-specific-devops-stage when: never - - <<: *if-force-ci - when: never # From .qa:rules:package-and-test-schedule - <<: *if-dot-com-gitlab-org-schedule when: never + # From .qa:rules:manual-e2e - !reference [".qa:rules:code-merge-request-allowed-to-fail", rules] .qa:rules:fulfillment-e2e-quarantine-report: diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index e68fab89204..e7d750bcf3c 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -2187,7 +2187,6 @@ Layout/LineLength: - 'ee/spec/workers/repository_import_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - - 'ee/spec/workers/store_security_reports_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' diff --git a/Gemfile b/Gemfile index 87e243086df..c9ac86b51f4 100644 --- a/Gemfile +++ b/Gemfile @@ -559,7 +559,7 @@ group :test do # Moved in `test` because https://gitlab.com/gitlab-org/gitlab/-/issues/217527 gem 'derailed_benchmarks', require: false # rubocop:todo Gemfile/MissingFeatureCategory - gem 'gitlab_quality-test_tooling', '~> 1.28.0', require: false, feature_category: :tooling + gem 'gitlab_quality-test_tooling', '~> 1.29.0', require: false, feature_category: :tooling end gem 'octokit', '~> 8.1', feature_category: :importers diff --git a/Gemfile.checksum b/Gemfile.checksum index ddbc57254ef..ebb4547808f 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -229,7 +229,7 @@ {"name":"gitlab-styles","version":"12.0.1","platform":"ruby","checksum":"d8a302b0ab0e1f18e2d11501760f1b85c5e70b5e5ca628828a0786c7984ed133"}, {"name":"gitlab_chronic_duration","version":"0.12.0","platform":"ruby","checksum":"0d766944d415b5c831f176871ee8625783fc0c5bfbef2d79a3a616f207ffc16d"}, {"name":"gitlab_omniauth-ldap","version":"2.2.0","platform":"ruby","checksum":"bb4d20acb3b123ed654a8f6a47d3fac673ece7ed0b6992edb92dca14bad2838c"}, -{"name":"gitlab_quality-test_tooling","version":"1.28.0","platform":"ruby","checksum":"d0b2c6bc304b7ccf9003fae851eff330c19ed182079310356a93b30e09fe51f3"}, +{"name":"gitlab_quality-test_tooling","version":"1.29.0","platform":"ruby","checksum":"611be320785c9352b8ecdcacaefd271a19e3b76c75f5140ab544085a539eaede"}, {"name":"globalid","version":"1.1.0","platform":"ruby","checksum":"b337e1746f0c8cb0a6c918234b03a1ddeb4966206ce288fbb57779f59b2d154f"}, {"name":"gon","version":"6.4.0","platform":"ruby","checksum":"e3a618d659392890f1aa7db420f17c75fd7d35aeb5f8fe003697d02c4b88d2f0"}, {"name":"google-apis-androidpublisher_v3","version":"0.34.0","platform":"ruby","checksum":"d7e1d7dd92f79c498fe2082222a1740d788e022e660c135564b3fd299cab5425"}, diff --git a/Gemfile.lock b/Gemfile.lock index 498ffe8af94..fbade4f1aa0 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -741,7 +741,7 @@ GEM omniauth (>= 1.3, < 3) pyu-ruby-sasl (>= 0.0.3.3, < 0.1) rubyntlm (~> 0.5) - gitlab_quality-test_tooling (1.28.0) + gitlab_quality-test_tooling (1.29.0) activesupport (>= 7.0, < 7.2) amatch (~> 0.4.1) gitlab (~> 4.19) @@ -2022,7 +2022,7 @@ DEPENDENCIES gitlab-utils! gitlab_chronic_duration (~> 0.12) gitlab_omniauth-ldap (~> 2.2.0) - gitlab_quality-test_tooling (~> 1.28.0) + gitlab_quality-test_tooling (~> 1.29.0) gon (~> 6.4.0) google-apis-androidpublisher_v3 (~> 0.34.0) google-apis-cloudbilling_v1 (~> 0.21.0) diff --git a/app/assets/javascripts/ci/common/pipelines_table.vue b/app/assets/javascripts/ci/common/pipelines_table.vue index 1556825c3c5..b9e858cf857 100644 --- a/app/assets/javascripts/ci/common/pipelines_table.vue +++ b/app/assets/javascripts/ci/common/pipelines_table.vue @@ -139,11 +139,9 @@ export default { this.$emit('refresh-pipelines-table'); }, onRetryPipeline(pipeline) { - // This emit is only used by the `legacy_pipelines_table_wrapper`. this.$emit('retry-pipeline', pipeline); }, onCancelPipeline(pipeline) { - // This emit is only used by the `legacy_pipelines_table_wrapper`. this.$emit('cancel-pipeline', pipeline); }, trackPipelineMiniGraph() { diff --git a/app/assets/javascripts/ci/job_details/components/log/line.vue b/app/assets/javascripts/ci/job_details/components/log/line.vue index 6acbbff5570..f388bfaf868 100644 --- a/app/assets/javascripts/ci/job_details/components/log/line.vue +++ b/app/assets/javascripts/ci/job_details/components/log/line.vue @@ -42,7 +42,7 @@ export default { { attrs: { href: chunk, - class: '!gl-text-inherit gl-text-decoration-underline', + class: '!gl-text-inherit gl-underline', rel: 'nofollow noopener noreferrer', // eslint-disable-line @gitlab/require-i18n-strings }, }, diff --git a/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue b/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue index 471e7158a04..b96c13e5481 100644 --- a/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue +++ b/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue @@ -1,11 +1,17 @@ + + diff --git a/app/assets/javascripts/gitlab_pages/components/deployments.vue b/app/assets/javascripts/gitlab_pages/components/deployments.vue new file mode 100644 index 00000000000..d33c8fedba9 --- /dev/null +++ b/app/assets/javascripts/gitlab_pages/components/deployments.vue @@ -0,0 +1,226 @@ + + + diff --git a/app/assets/javascripts/gitlab_pages/components/edit.vue b/app/assets/javascripts/gitlab_pages/components/edit.vue new file mode 100644 index 00000000000..e235d7a6b17 --- /dev/null +++ b/app/assets/javascripts/gitlab_pages/components/edit.vue @@ -0,0 +1,12 @@ + + + diff --git a/app/assets/javascripts/gitlab_pages/components/load_more_deployments.vue b/app/assets/javascripts/gitlab_pages/components/load_more_deployments.vue new file mode 100644 index 00000000000..7db01434838 --- /dev/null +++ b/app/assets/javascripts/gitlab_pages/components/load_more_deployments.vue @@ -0,0 +1,36 @@ + + + diff --git a/app/assets/javascripts/gitlab_pages/queries/get_project_pages_deployments.graphql b/app/assets/javascripts/gitlab_pages/queries/get_project_pages_deployments.graphql new file mode 100644 index 00000000000..234d7ef15ae --- /dev/null +++ b/app/assets/javascripts/gitlab_pages/queries/get_project_pages_deployments.graphql @@ -0,0 +1,44 @@ +query GetProjectPagesDeployments( + $fullPath: ID! + $first: Int + $last: Int + $after: String + $before: String + $active: Boolean + $versioned: Boolean + $sort: Sort +) { + project(fullPath: $fullPath) { + id + pagesDeployments( + first: $first + last: $last + after: $after + before: $before + active: $active + versioned: $versioned + sort: $sort + ) { + count + pageInfo { + startCursor + endCursor + hasNextPage + hasPreviousPage + } + nodes { + id + active + rootDirectory + ciBuildId + createdAt + deletedAt + fileCount + pathPrefix + size + updatedAt + url + } + } + } +} diff --git a/app/assets/javascripts/gitlab_pages/show.js b/app/assets/javascripts/gitlab_pages/show.js index 6e664b23210..640870bfa6f 100644 --- a/app/assets/javascripts/gitlab_pages/show.js +++ b/app/assets/javascripts/gitlab_pages/show.js @@ -1,7 +1,7 @@ import Vue from 'vue'; import VueApollo from 'vue-apollo'; import createDefaultClient from '~/lib/graphql'; -import PagesEdit from './components/pages_edit.vue'; +import PagesEdit from './components/edit.vue'; Vue.use(VueApollo); @@ -20,12 +20,11 @@ export default function initPages() { el, name: 'GitlabPagesEditRoot', apolloProvider, + provide: { + projectFullPath: el.dataset.fullPath, + }, render(createElement) { - return createElement(PagesEdit, { - props: { - ...el.dataset, - }, - }); + return createElement(PagesEdit, {}); }, }); } diff --git a/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue b/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue index 2777829273d..bcea921cd46 100644 --- a/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue +++ b/app/assets/javascripts/issues/related_merge_requests/components/related_merge_requests.vue @@ -1,12 +1,56 @@