From 19db7fd1fefc4e4249d4e55f409f321fdb85aed1 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 16 Nov 2022 21:08:11 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/rspec/timecop_freeze.yml | 20 -- .../issue_board_filtered_search.vue | 12 +- .../search_tokens/paused_token_config.js | 4 +- .../search_tokens/status_token_config.js | 4 +- .../search_tokens/tag_token_config.js | 4 +- .../cycle_analytics/components/filter_bar.vue | 10 +- .../list/components/issues_list_app.vue | 14 +- .../javascripts/issues/list/constants.js | 22 +-- app/assets/javascripts/issues/list/utils.js | 4 +- .../filtered_search/jobs_filtered_search.vue | 4 +- app/assets/javascripts/members/constants.js | 6 +- .../harbor_registry/pages/details.vue | 4 +- .../components/list/package_search.vue | 4 +- .../pipelines_filtered_search.vue | 12 +- .../components/states/mr_widget_closed.vue | 64 +++++- .../vue_merge_request_widget/i18n.js | 7 + .../filtered_search_bar/constants.js | 18 +- .../filtered_search_bar/tokens/base_token.vue | 4 +- .../paginated_table_with_search_and_tabs.vue | 6 +- app/models/project.rb | 10 - ...ira_connect_oauth_self_managed_setting.yml | 2 +- doc/administration/lfs/index.md | 22 +++ doc/administration/object_storage.md | 10 + .../postgresql/replication_and_failover.md | 184 ++++++++++++++++++ doc/api/merge_trains.md | 66 +++++++ doc/api/settings.md | 10 +- doc/development/documentation/index.md | 31 ++- .../documentation/styleguide/word_list.md | 15 ++ lefthook.yml | 2 +- lib/api/settings.rb | 2 + lib/banzai/filter/syntax_highlight_filter.rb | 4 +- .../filter/timeout_html_pipeline_filter.rb | 42 ++++ .../{cross_repo_comparer.rb => cross_repo.rb} | 13 +- lib/gitlab/git/repository.rb | 11 +- lib/gitlab/workhorse.rb | 3 + lib/tasks/gitlab/usage_data.rake | 5 +- locale/gitlab.pot | 9 + spec/features/users/active_sessions_spec.rb | 26 +-- spec/frontend/boards/mock_data.js | 12 +- .../search_tokens/tag_token_spec.js | 4 +- spec/frontend/fixtures/freeze_period.rb | 9 - spec/frontend/issues/list/mock_data.js | 34 ++-- .../jobs_filtered_search_spec.js | 4 +- .../harbor_registry/pages/details_spec.js | 4 +- .../pipelines_filtered_search_spec.js | 12 +- .../states/mr_widget_closed_spec.js | 141 +++++++++++++- .../filtered_search_bar/mock_data.js | 18 +- .../tokens/base_token_spec.js | 8 +- ...ginated_table_with_search_and_tabs_spec.js | 6 +- .../filter/syntax_highlight_filter_spec.rb | 4 + .../timeout_html_pipeline_filter_spec.rb | 34 ++++ .../base_query_builder_spec.rb | 5 +- .../analytics/cycle_analytics/median_spec.rb | 8 +- .../cycle_analytics/records_fetcher_spec.rb | 2 +- .../gitlab/auth/unique_ips_limiter_spec.rb | 10 +- spec/lib/gitlab/checks/timed_logger_spec.rb | 42 ++-- .../cycle_analytics/stage_summary_spec.rb | 22 +-- .../gitlab/git/cross_repo_comparer_spec.rb | 117 ----------- spec/lib/gitlab/git/cross_repo_spec.rb | 83 ++++++++ spec/lib/gitlab/git/repository_spec.rb | 46 ++++- .../puma_logging/json_formatter_spec.rb | 4 +- spec/lib/gitlab/workhorse_spec.rb | 17 ++ spec/lib/json_web_token/hmac_token_spec.rb | 20 +- spec/lib/peek/views/active_record_spec.rb | 2 +- spec/models/project_spec.rb | 47 ----- spec/requests/api/settings_spec.rb | 8 +- spec/requests/api/usage_data_queries_spec.rb | 2 +- spec/serializers/entity_date_helper_spec.rb | 6 +- .../ci/create_pipeline_service/rules_spec.rb | 8 +- .../banzai/filter_timeout_shared_examples.rb | 37 ++++ .../test_generation.rb | 28 +-- .../helpers/features/runners_helpers.rb | 2 +- .../helpers/javascript_fixtures_helpers.rb | 4 +- .../rack_attack_shared_context.rb | 2 +- .../requests/rack_attack_shared_examples.rb | 3 + .../prune_old_annotations_worker_spec.rb | 13 +- workhorse/gitaly_test.go | 1 + workhorse/internal/api/api.go | 4 + workhorse/internal/git/info-refs.go | 3 +- workhorse/internal/git/receive-pack.go | 3 +- workhorse/internal/git/upload-pack.go | 3 +- workhorse/internal/gitaly/gitaly.go | 26 +-- workhorse/internal/gitaly/gitaly_test.go | 15 +- workhorse/main_test.go | 1 + 84 files changed, 1078 insertions(+), 496 deletions(-) create mode 100644 lib/banzai/filter/timeout_html_pipeline_filter.rb rename lib/gitlab/git/{cross_repo_comparer.rb => cross_repo.rb} (83%) create mode 100644 spec/lib/banzai/filter/timeout_html_pipeline_filter_spec.rb delete mode 100644 spec/lib/gitlab/git/cross_repo_comparer_spec.rb create mode 100644 spec/lib/gitlab/git/cross_repo_spec.rb create mode 100644 spec/support/banzai/filter_timeout_shared_examples.rb diff --git a/.rubocop_todo/rspec/timecop_freeze.yml b/.rubocop_todo/rspec/timecop_freeze.yml index 2967793e42a..2e59ce7bdda 100644 --- a/.rubocop_todo/rspec/timecop_freeze.yml +++ b/.rubocop_todo/rspec/timecop_freeze.yml @@ -1,24 +1,4 @@ --- RSpec/TimecopFreeze: Exclude: - - ee/spec/models/merge_train_spec.rb - - ee/spec/support/shared_contexts/lib/gitlab/insights/reducers/reducers_shared_contexts.rb - qa/spec/support/repeater_spec.rb - - spec/features/users/active_sessions_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/median_spec.rb - - spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb - - spec/lib/gitlab/auth/unique_ips_limiter_spec.rb - - spec/lib/gitlab/checks/timed_logger_spec.rb - - spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb - - spec/lib/gitlab/puma_logging/json_formatter_spec.rb - - spec/lib/json_web_token/hmac_token_spec.rb - - spec/models/active_session_spec.rb - - spec/serializers/entity_date_helper_spec.rb - - spec/support/cycle_analytics_helpers/test_generation.rb - - spec/support/helpers/cycle_analytics_helpers.rb - - spec/support/helpers/javascript_fixtures_helpers.rb - - spec/support/shared_contexts/rack_attack_shared_context.rb - - spec/support/shared_examples/workers/concerns/reenqueuer_shared_examples.rb - - spec/workers/concerns/reenqueuer_spec.rb - - spec/workers/metrics/dashboard/prune_old_annotations_worker_spec.rb diff --git a/app/assets/javascripts/boards/components/issue_board_filtered_search.vue b/app/assets/javascripts/boards/components/issue_board_filtered_search.vue index 605e11d1590..e2055325b7a 100644 --- a/app/assets/javascripts/boards/components/issue_board_filtered_search.vue +++ b/app/assets/javascripts/boards/components/issue_board_filtered_search.vue @@ -12,8 +12,8 @@ import { TYPE_USER } from '~/graphql_shared/constants'; import { convertToGraphQLId } from '~/graphql_shared/utils'; import { __ } from '~/locale'; import { - OPERATOR_IS_AND_IS_NOT, - OPERATOR_IS_ONLY, + OPERATORS_IS_NOT, + OPERATORS_IS, TOKEN_TITLE_ASSIGNEE, TOKEN_TITLE_AUTHOR, TOKEN_TITLE_CONFIDENTIAL, @@ -71,7 +71,7 @@ export default { icon: 'user', title: TOKEN_TITLE_ASSIGNEE, type: TOKEN_TYPE_ASSIGNEE, - operators: OPERATOR_IS_AND_IS_NOT, + operators: OPERATORS_IS_NOT, token: AuthorToken, unique: true, fetchAuthors, @@ -81,7 +81,7 @@ export default { icon: 'pencil', title: TOKEN_TITLE_AUTHOR, type: TOKEN_TYPE_AUTHOR, - operators: OPERATOR_IS_AND_IS_NOT, + operators: OPERATORS_IS_NOT, symbol: '@', token: AuthorToken, unique: true, @@ -92,7 +92,7 @@ export default { icon: 'labels', title: TOKEN_TITLE_LABEL, type: TOKEN_TYPE_LABEL, - operators: OPERATOR_IS_AND_IS_NOT, + operators: OPERATORS_IS_NOT, token: LabelToken, unique: false, symbol: '~', @@ -128,7 +128,7 @@ export default { title: TOKEN_TITLE_CONFIDENTIAL, unique: true, token: GlFilteredSearchToken, - operators: OPERATOR_IS_ONLY, + operators: OPERATORS_IS, options: [ { icon: 'eye-slash', value: 'yes', title: __('Yes') }, { icon: 'eye', value: 'no', title: __('No') }, diff --git a/app/assets/javascripts/ci/runner/components/search_tokens/paused_token_config.js b/app/assets/javascripts/ci/runner/components/search_tokens/paused_token_config.js index 97ee8ec3eef..71a145dd4a3 100644 --- a/app/assets/javascripts/ci/runner/components/search_tokens/paused_token_config.js +++ b/app/assets/javascripts/ci/runner/components/search_tokens/paused_token_config.js @@ -1,5 +1,5 @@ import { __ } from '~/locale'; -import { OPERATOR_IS_ONLY } from '~/vue_shared/components/filtered_search_bar/constants'; +import { OPERATORS_IS } from '~/vue_shared/components/filtered_search_bar/constants'; import BaseToken from '~/vue_shared/components/filtered_search_bar/tokens/base_token.vue'; import { PARAM_KEY_PAUSED, I18N_PAUSED } from '../../constants'; @@ -24,5 +24,5 @@ export const pausedTokenConfig = { // see: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1438 title: title.replace(/\s/g, '\u00a0'), })), - operators: OPERATOR_IS_ONLY, + operators: OPERATORS_IS, }; diff --git a/app/assets/javascripts/ci/runner/components/search_tokens/status_token_config.js b/app/assets/javascripts/ci/runner/components/search_tokens/status_token_config.js index 117a630719e..4bc32909777 100644 --- a/app/assets/javascripts/ci/runner/components/search_tokens/status_token_config.js +++ b/app/assets/javascripts/ci/runner/components/search_tokens/status_token_config.js @@ -1,5 +1,5 @@ import { - OPERATOR_IS_ONLY, + OPERATORS_IS, TOKEN_TITLE_STATUS, } from '~/vue_shared/components/filtered_search_bar/constants'; import BaseToken from '~/vue_shared/components/filtered_search_bar/tokens/base_token.vue'; @@ -38,5 +38,5 @@ export const statusTokenConfig = { // see: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1438 title: title.replace(/\s/g, '\u00a0'), })), - operators: OPERATOR_IS_ONLY, + operators: OPERATORS_IS, }; diff --git a/app/assets/javascripts/ci/runner/components/search_tokens/tag_token_config.js b/app/assets/javascripts/ci/runner/components/search_tokens/tag_token_config.js index fdeba714385..369b214f952 100644 --- a/app/assets/javascripts/ci/runner/components/search_tokens/tag_token_config.js +++ b/app/assets/javascripts/ci/runner/components/search_tokens/tag_token_config.js @@ -1,5 +1,5 @@ import { s__ } from '~/locale'; -import { OPERATOR_IS_ONLY } from '~/vue_shared/components/filtered_search_bar/constants'; +import { OPERATORS_IS } from '~/vue_shared/components/filtered_search_bar/constants'; import { PARAM_KEY_TAG } from '../../constants'; import TagToken from './tag_token.vue'; @@ -8,5 +8,5 @@ export const tagTokenConfig = { title: s__('Runners|Tags'), type: PARAM_KEY_TAG, token: TagToken, - operators: OPERATOR_IS_ONLY, + operators: OPERATORS_IS, }; diff --git a/app/assets/javascripts/cycle_analytics/components/filter_bar.vue b/app/assets/javascripts/cycle_analytics/components/filter_bar.vue index 0ad325a8523..bcd846940ae 100644 --- a/app/assets/javascripts/cycle_analytics/components/filter_bar.vue +++ b/app/assets/javascripts/cycle_analytics/components/filter_bar.vue @@ -1,7 +1,7 @@