Add latest changes from gitlab-org/gitlab@master

db/post_migrate/20230706011541_add_user_id_foreign_key_to_ml_experiments.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+class AddUserIdForeignKeyToMlExperiments < Gitlab::Database::Migration[2.1]
+  disable_ddl_transaction!
+
+  NEW_FK_NAME = 'fk_ml_experiments_on_user_id'
+  OLD_FK_NAME = 'fk_rails_1fbc5e001f'
+
+  def up
+    add_concurrent_foreign_key(:ml_experiments, :users, column: :user_id, on_delete: :nullify,
+      name: NEW_FK_NAME, validate: true)
+
+    with_lock_retries do
+      remove_foreign_key_if_exists(:ml_experiments, name: OLD_FK_NAME)
+    end
+  end
+
+  def down
+    unless foreign_key_exists?(:ml_experiments, :users, name: OLD_FK_NAME)
+      with_lock_retries do
+        execute(<<~SQL.squish)
+          ALTER TABLE ml_experiments ADD CONSTRAINT #{OLD_FK_NAME} FOREIGN KEY (user_id) REFERENCES users (id)
+        SQL
+      end
+    end
+
+    with_lock_retries do
+      remove_foreign_key_if_exists(:ml_experiments, name: NEW_FK_NAME)
+    end
+  end
+end

db/schema_migrations/20230706011541

@@ -0,0 +1 @@
+fad04601d706468f7e77a232e07125c152373f9fe2c443a661e0d5ee68ea6e7b

db/structure.sql

@@ -36410,6 +36410,9 @@ ALTER TABLE ONLY ml_candidate_params
 ALTER TABLE ONLY ml_candidates
     ADD CONSTRAINT fk_ml_candidates_on_user_id FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE SET NULL;
 
+ALTER TABLE ONLY ml_experiments
+    ADD CONSTRAINT fk_ml_experiments_on_user_id FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE SET NULL;
+
 ALTER TABLE ONLY path_locks
     ADD CONSTRAINT fk_path_locks_user_id FOREIGN KEY (user_id) REFERENCES users(id) ON DELETE CASCADE;
 
@@ -36632,9 +36635,6 @@ ALTER TABLE ONLY geo_repository_created_events
 ALTER TABLE ONLY external_status_checks
     ADD CONSTRAINT fk_rails_1f5a8aa809 FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE;
 
-ALTER TABLE ONLY ml_experiments
-    ADD CONSTRAINT fk_rails_1fbc5e001f FOREIGN KEY (user_id) REFERENCES users(id);
-
 ALTER TABLE ONLY dora_daily_metrics
     ADD CONSTRAINT fk_rails_1fd07aff6f FOREIGN KEY (environment_id) REFERENCES environments(id) ON DELETE CASCADE;
 

doc/ci/index.md

@@ -83,7 +83,6 @@ GitLab CI/CD features, grouped by DevOps stage, include:
 | [Connect to cloud services](cloud_services/index.md)                                         | Connect to cloud providers using OpenID Connect (OIDC) to retrieve temporary credentials to access services or secrets. |
 | **Verify**                                                                                   |             |
 | [CI services](services/index.md)                                                             | Link Docker containers with your base image. |
-| [Code Quality](testing/code_quality.md)                                                      | Analyze your source code quality. |
 | [GitLab CI/CD for external repositories](ci_cd_for_external_repos/index.md)                  | Get the benefits of GitLab CI/CD combined with repositories in GitHub and Bitbucket Cloud. |
 | [Interactive Web Terminals](interactive_web_terminal/index.md)                               | Open an interactive web terminal to debug the running jobs. |
 | [Review Apps](review_apps/index.md)                                                          | Configure GitLab CI/CD to preview code changes. |
@@ -99,6 +98,7 @@ GitLab CI/CD features, grouped by DevOps stage, include:
 | [GitLab Releases](../user/project/releases/index.md)                                         | Add release notes to Git tags. |
 | [Cloud deployment](cloud_deployment/index.md)                                                | Deploy your application to a main cloud provider. |
 | **Secure**                                                                                   |             |
+| [Code Quality](testing/code_quality.md)                                                      | Analyze your source code quality. |
 | [Container Scanning](../user/application_security/container_scanning/index.md)               | Scan your container images for known vulnerabilities. |
 | [Coverage-guided fuzz testing](../user/application_security/coverage_fuzzing/index.md)       | Test your application's behavior by providing randomized input. |
 | [Dynamic Application Security Testing](../user/application_security/dast/index.md)           | Test your application's runtime behavior for vulnerabilities. |

doc/development/testing_guide/best_practices.md

@@ -1387,6 +1387,19 @@ describe "#==" do
 end
 ```
 
+If, after creating a table-based test, you see an error that looks like this:
+
+```ruby
+NoMethodError:
+  undefined method `to_params'
+
+  param_sets = extracted.is_a?(Array) ? extracted : extracted.to_params
+                                                                       ^^^^^^^^^^
+  Did you mean?  to_param
+```
+
+That indicates that you need to include the line `using RSpec::Parameterized::TableSyntax` in the spec file.
+
 <!-- vale gitlab.Spelling = NO -->
 
 WARNING: