From 1bbd0179d7ed8fb17c0574aa74ef491e53c833a7 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 29 Jun 2023 18:10:36 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/gitlab/strong_memoize_attr.yml | 1 - .../rspec/before_all_role_assignment.yml | 1 - .../rspec/missing_feature_category.yml | 1 - CHANGELOG.md | 49 ++++ .../components/access_token_table_app.vue | 3 +- .../access_tokens/components/token.vue | 35 +-- .../access_tokens/components/tokens_app.vue | 6 +- app/assets/javascripts/emoji/index.js | 4 +- .../components/user_name_group.vue | 4 +- app/assets/stylesheets/framework/common.scss | 8 - app/assets/stylesheets/framework/layout.scss | 5 - .../framework/system_messages.scss | 10 - .../stylesheets/page_bundles/login.scss | 52 +--- app/assets/stylesheets/page_bundles/wiki.scss | 2 + .../stylesheets/startup/startup-signin.scss | 25 +- .../cycle_analytics/value_stream_actions.rb | 7 + app/controllers/import/github_controller.rb | 13 +- .../projects/compare_controller.rb | 12 +- app/graphql/types/project_type.rb | 2 + app/helpers/application_helper.rb | 6 +- app/helpers/sidebars_helper.rb | 3 +- app/helpers/users_helper.rb | 2 +- app/models/hooks/web_hook.rb | 1 + app/models/system_access.rb | 7 + app/services/import_csv/base_service.rb | 2 +- .../preprocess_milestones_service.rb | 35 +++ .../issuable/import_csv/base_service.rb | 18 ++ app/views/devise/shared/_footer.html.haml | 19 +- app/views/layouts/devise.html.haml | 18 +- app/views/layouts/devise_empty.html.haml | 16 +- app/views/layouts/signup_onboarding.html.haml | 21 +- .../notify/import_issues_csv_email.html.haml | 16 ++ .../notify/import_issues_csv_email.text.erb | 17 ++ .../personal_access_tokens/index.html.haml | 35 ++- .../shared/access_tokens/_form.html.haml | 33 +-- ...curity_dast_on_demand_api_scan_monthly.yml | 26 ++ ...ecurity_dast_on_demand_api_scan_weekly.yml | 26 ++ .../system_access_microsoft_applications.yml | 10 + ...m_access_microsoft_graph_access_tokens.yml | 10 + ...ate_system_access_microsoft_application.rb | 19 ++ ...em_access_microsoft_graph_access_tokens.rb | 15 ++ db/schema_migrations/20230616200440 | 1 + db/schema_migrations/20230616214220 | 1 + db/structure.sql | 66 +++++ .../audit_event_streaming/graphql_api.md | 2 +- doc/api/group_access_tokens.md | 2 +- doc/api/project_access_tokens.md | 2 +- doc/api/projects.md | 242 ++++++++++++++++++ .../index.md | 8 +- .../blueprints/observability_tracing/index.md | 2 +- doc/ci/caching/index.md | 2 +- doc/ci/environments/kubernetes_dashboard.md | 3 +- doc/development/code_review.md | 2 +- doc/development/database/index.md | 2 +- doc/development/database/load_balancing.md | 2 +- doc/development/gems.md | 31 ++- doc/operations/feature_flags.md | 2 +- doc/security/token_overview.md | 4 +- .../project/repository/code_suggestions.md | 12 +- lib/api/entities/group.rb | 1 + lib/api/entities/issue.rb | 9 +- lib/api/projects.rb | 22 ++ .../filter/references/reference_cache.rb | 29 +-- .../sidekiq_middleware/arguments_logger.rb | 3 +- locale/gitlab.pot | 12 +- patches/@rails+ujs+7.0.5.patch | 16 ++ .../admin/hooks_controller_spec.rb | 9 +- .../import/github_controller_spec.rb | 32 +++ .../projects/compare_controller_spec.rb | 32 ++- spec/features/admin/users/user_spec.rb | 8 +- spec/fixtures/csv_missing_milestones.csv | 5 + .../components/tokens_app_spec.js | 2 +- .../topics/components/remove_avatar_spec.js | 2 +- spec/frontend/behaviors/gl_emoji_spec.js | 4 +- spec/frontend/emoji/index_spec.js | 6 +- .../components/user_name_group_spec.js | 2 +- spec/frontend/super_sidebar/mock_data.js | 1 + .../components/diff_stats_dropdown_spec.js | 9 +- spec/graphql/types/project_type_spec.rb | 8 + spec/helpers/application_helper_spec.rb | 9 +- spec/helpers/sidebars_helper_spec.rb | 3 +- spec/lib/api/entities/issue_spec.rb | 47 ++++ spec/mailers/emails/issues_spec.rb | 9 + spec/models/hooks/web_hook_spec.rb | 7 + .../error_tracking/project_settings_spec.rb | 60 ++--- spec/requests/api/groups_spec.rb | 33 +++ spec/requests/api/projects_spec.rb | 66 +++++ .../preprocess_milestones_service_spec.rb | 83 ++++++ .../issuable/import_csv/base_service_spec.rb | 92 +++++++ ...able_import_csv_service_shared_examples.rb | 1 + .../import_issues_csv_email.html.haml_spec.rb | 29 +++ 91 files changed, 1323 insertions(+), 309 deletions(-) create mode 100644 app/models/system_access.rb create mode 100644 app/services/import_csv/preprocess_milestones_service.rb create mode 100644 config/metrics/counts_28d/20211118200530_p_ci_templates_security_dast_on_demand_api_scan_monthly.yml create mode 100644 config/metrics/counts_7d/20211118200524_p_ci_templates_security_dast_on_demand_api_scan_weekly.yml create mode 100644 db/docs/system_access_microsoft_applications.yml create mode 100644 db/docs/system_access_microsoft_graph_access_tokens.yml create mode 100644 db/migrate/20230616200440_create_system_access_microsoft_application.rb create mode 100644 db/migrate/20230616214220_create_system_access_microsoft_graph_access_tokens.rb create mode 100644 db/schema_migrations/20230616200440 create mode 100644 db/schema_migrations/20230616214220 create mode 100644 patches/@rails+ujs+7.0.5.patch create mode 100644 spec/fixtures/csv_missing_milestones.csv create mode 100644 spec/lib/api/entities/issue_spec.rb create mode 100644 spec/services/import_csv/preprocess_milestones_service_spec.rb create mode 100644 spec/services/issuable/import_csv/base_service_spec.rb diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 7ef3ae21e85..95382f51961 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -328,7 +328,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/models/vulnerabilities/finding.rb' - 'ee/app/presenters/approval_rule_presenter.rb' - 'ee/app/presenters/ci/minutes/usage_presenter.rb' - - 'ee/app/presenters/merge_request_approver_presenter.rb' - 'ee/app/serializers/dashboard_operations_project_entity.rb' - 'ee/app/serializers/ee/member_user_entity.rb' - 'ee/app/services/app_sec/dast/pipelines/find_latest_service.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index 35906845e95..05a57118861 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -1222,7 +1222,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/requests/api/draft_notes_spec.rb' - 'spec/requests/api/environments_spec.rb' - 'spec/requests/api/error_tracking/client_keys_spec.rb' - - 'spec/requests/api/error_tracking/project_settings_spec.rb' - 'spec/requests/api/files_spec.rb' - 'spec/requests/api/freeze_periods_spec.rb' - 'spec/requests/api/go_proxy_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 95a0e3f32dc..1ff8a9a09e9 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -1008,7 +1008,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/approval_merge_request_rule_spec.rb' - 'ee/spec/models/approval_state_spec.rb' - 'ee/spec/models/approval_wrapped_any_approver_rule_spec.rb' - - 'ee/spec/models/approval_wrapped_code_owner_rule_spec.rb' - 'ee/spec/models/approval_wrapped_rule_spec.rb' - 'ee/spec/models/approvals/scan_finding_wrapped_rule_set_spec.rb' - 'ee/spec/models/approvals/wrapped_rule_set_spec.rb' diff --git a/CHANGELOG.md b/CHANGELOG.md index 406f3286c33..4fbc6d82e1a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,23 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. +## 16.1.1 (2023-06-28) + +### Security (12 changes) + +- [Revert 'security-leaked-ci-job-token-permission-16-1' from '16-1'](gitlab-org/security/gitlab@d2599119b120eab983a1446fc9ed3ca801c88368) ([merge request](gitlab-org/security/gitlab!3374)) +- [Use fully qualified ref when loading code owner file](gitlab-org/security/gitlab@e8ba90bb85de376bb020350c027bb369671c83d6) ([merge request](gitlab-org/security/gitlab!3356)) +- [Maintainer can leak masked webhook secrets by manipulating URL masking](gitlab-org/security/gitlab@2cf91108544e8c30aae6d9b207385c90c299869c) ([merge request](gitlab-org/security/gitlab!3359)) +- [Remove approvals when the only commit gets amended](gitlab-org/security/gitlab@3f81f7bc4236bcc2ed887f40b7a14702d756ca9e) ([merge request](gitlab-org/security/gitlab!3366)) +- [Add authorization validation to GithubController#failures action](gitlab-org/security/gitlab@3c8c305deef9c9bd1194788b40e0d7ae1de45f3b) ([merge request](gitlab-org/security/gitlab!3335)) +- [Fix for fork permissions check in compare controller](gitlab-org/security/gitlab@5b14436f3874de7be62e0f46a25e93a1d8c99975) ([merge request](gitlab-org/security/gitlab!3342)) +- [Webhook token leaked in Sidekiq logs if log format is 'default'](gitlab-org/security/gitlab@d2d76399c880c62d7449cdae6014ee3236bffc0b) ([merge request](gitlab-org/security/gitlab!3345)) +- [Mitigate epic reference filter ReDOS](gitlab-org/security/gitlab@874d5bc2d55e2e1092bf7cc4ebb0e53fc716d850) ([merge request](gitlab-org/security/gitlab!3341)) +- [Increasing security for CI_JOB_TOKEN on public and internal projects](gitlab-org/security/gitlab@c2aa392b932af04e395d67eb06a20b5c768ec683) ([merge request](gitlab-org/security/gitlab!3337)) +- [Adjust access to value stream create, edit and destroy actions](gitlab-org/security/gitlab@8a3645e265c71886951bdc03857837aacb57e558) ([merge request](gitlab-org/security/gitlab!3349)) +- [Sanitize user email addresses in admin confirm user dialog](gitlab-org/security/gitlab@70553e6ca6b3f244df37e306466e2d3b5d54f76b) ([merge request](gitlab-org/security/gitlab!3338)) +- [Obfuscate email of service desk issue creator in issue REST API](gitlab-org/security/gitlab@d0f27b8241ab53bee11f8ce6efb20811690a2d0d) ([merge request](gitlab-org/security/gitlab!3317)) + ## 16.1.0 (2023-06-21) ### Added (224 changes) @@ -930,6 +947,23 @@ entry. - [Migrate custom CSS to utility classes](gitlab-org/gitlab@a67999317bec111d523c763fc865665d4ded0aaf) ([merge request](gitlab-org/gitlab!120745)) **GitLab Enterprise Edition** - [Remove the vsa_group_and_project_parity FF](gitlab-org/gitlab@d090818bdedb0e220928d8e456cf36c8bce81f42) ([merge request](gitlab-org/gitlab!120727)) **GitLab Enterprise Edition** +## 16.0.6 (2023-06-28) + +### Security (12 changes) + +- [Revert 'security-leaked-ci-job-token-permission-16-0' from '16-0'"](gitlab-org/security/gitlab@3c4fdbad26a123c581253fb501b5bace953a5e85) ([merge request](gitlab-org/security/gitlab!3373)) +- [Use fully qualified ref when loading code owner file](gitlab-org/security/gitlab@69c61fcbdc88873b60a217cfd3810364718417e9) ([merge request](gitlab-org/security/gitlab!3355)) +- [Maintainer can leak masked webhook secrets by manipulating URL masking](gitlab-org/security/gitlab@a3e055010523db5a1c346464e2589cc75f73629d) ([merge request](gitlab-org/security/gitlab!3360)) +- [Remove approvals when the only commit gets amended](gitlab-org/security/gitlab@01e59413e2570744dc34dd50efd2601dc91c8d2d) ([merge request](gitlab-org/security/gitlab!3367)) +- [Add authorization validation to GithubController#failures action](gitlab-org/security/gitlab@9eab0689991debab8c8a1afb9e32a3bac9978325) ([merge request](gitlab-org/security/gitlab!3334)) +- [Fix for fork permissions check in compare controller](gitlab-org/security/gitlab@da9bb4c761dfe7e8efdd910ed3fc89f348e47e90) ([merge request](gitlab-org/security/gitlab!3343)) +- [Webhook token leaked in Sidekiq logs if log format is 'default'](gitlab-org/security/gitlab@a9835cb72eddfae1748c66314618b3157a6bcb57) ([merge request](gitlab-org/security/gitlab!3346)) +- [Mitigate epic reference filter ReDOS](gitlab-org/security/gitlab@c8046028a30fe9dca7e141eec2acf3d4b49d93ee) ([merge request](gitlab-org/security/gitlab!3340)) +- [Increasing security for CI_JOB_TOKEN on public and internal projects](gitlab-org/security/gitlab@b67db0cdd9324633f4abb59bc27bca43e94e3362) ([merge request](gitlab-org/security/gitlab!3318)) +- [Adjust access to value stream create, edit and destroy actions](gitlab-org/security/gitlab@ee20f3f3a84a75c7e07e1aa6fde95761636a669f) ([merge request](gitlab-org/security/gitlab!3321)) +- [Sanitize user email addresses in admin confirm user dialog](gitlab-org/security/gitlab@545e0913336e823eb905a8bd86fe2905b321a284) ([merge request](gitlab-org/security/gitlab!3331)) +- [Obfuscate email of service desk issue creator in issue REST API](gitlab-org/security/gitlab@b921f10b565bafbd6d50d93d84d34b5f103839ea) ([merge request](gitlab-org/security/gitlab!3315)) + ## 16.0.5 (2023-06-16) ### Fixed (1 change) @@ -1765,6 +1799,21 @@ entry. - [Add index to group_group_links table](gitlab-org/gitlab@9a3f2c1a90b54074e61d0abf07101ce664198e81) ([merge request](gitlab-org/gitlab!117386)) - [Validate the projects.creator_id foregin key synchronously](gitlab-org/gitlab@ed9351984a16f20506babf6eab6706b917904ed1) ([merge request](gitlab-org/gitlab!117147)) +## 15.11.10 (2023-06-28) + +### Security (10 changes) + +- [Revert 'security-leaked-ci-job-token-permission-15-11' from '15-11'"](gitlab-org/security/gitlab@19f73bf5494d34b43eb8c807f860d545acae0c32) ([merge request](gitlab-org/security/gitlab!3375)) +- [Use fully qualified ref when loading code owner file](gitlab-org/security/gitlab@d7ffb4cca68373bff38bd05f0b8afc868cda9e04) ([merge request](gitlab-org/security/gitlab!3354)) +- [Maintainer can leak masked webhook secrets by manipulating URL masking](gitlab-org/security/gitlab@3a7ccdac5e41870fdce362c38d0a1d1437906fbd) ([merge request](gitlab-org/security/gitlab!3361)) +- [Remove approvals when the only commit gets amended](gitlab-org/security/gitlab@f8a4ad8be7e5fdf752f525ed58b94b1ce625b9a1) ([merge request](gitlab-org/security/gitlab!3368)) +- [Fix for fork permissions check in compare controller](gitlab-org/security/gitlab@8edf44b13e55ffe0c912f98134d0341a5a6bcd28) ([merge request](gitlab-org/security/gitlab!3344)) +- [Webhook token leaked in Sidekiq logs if log format is 'default'](gitlab-org/security/gitlab@02b58237085930c62ee277c9ebd89a0560f44a98) ([merge request](gitlab-org/security/gitlab!3347)) +- [Mitigate epic reference filter ReDOS](gitlab-org/security/gitlab@4c2cd6e5f7c994aca554be37d9ea9e5e114341f1) ([merge request](gitlab-org/security/gitlab!3339)) +- [Increasing security for CI_JOB_TOKEN on public and internal projects](gitlab-org/security/gitlab@4f8a00b2499e876df5b65eca921812fbb3215800) ([merge request](gitlab-org/security/gitlab!3319)) +- [Sanitize user email addresses in admin confirm user dialog](gitlab-org/security/gitlab@608c8001c349b0a62aae81850de669d3af02ab60) ([merge request](gitlab-org/security/gitlab!3332)) +- [Obfuscate email of service desk issue creator in issue REST API](gitlab-org/security/gitlab@a092ebc54cce4492f87f8ed2bf67c31793b0bd0e) ([merge request](gitlab-org/security/gitlab!3316)) + ## 15.11.9 (2023-06-15) ### Changed (1 change) diff --git a/app/assets/javascripts/access_tokens/components/access_token_table_app.vue b/app/assets/javascripts/access_tokens/components/access_token_table_app.vue index 57a237c3e84..d15c8e6e703 100644 --- a/app/assets/javascripts/access_tokens/components/access_token_table_app.vue +++ b/app/assets/javascripts/access_tokens/components/access_token_table_app.vue @@ -114,8 +114,7 @@ export default {