From 1dbd5e4a8082d0ca86a8b2dad73b34523be137db Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 4 Aug 2023 21:09:50 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../components/inbound_token_access.vue | 11 +++- .../components/outbound_token_access.vue | 13 +++- .../page_bundles/merge_requests.scss | 4 ++ ...ipeline_success_unlock_artifacts_worker.rb | 4 +- app/workers/concerns/worker_attributes.rb | 4 +- config/settings.rb | 4 +- config/sidekiq_queues.yml | 2 + .../15-9-insecure-ci-job-token.yml | 2 + .../20230727144741_add_label_lock_on_merge.rb | 7 +++ db/schema_migrations/20230727144741 | 1 + db/structure.sql | 3 +- doc/api/project_job_token_scopes.md | 4 +- doc/ci/jobs/ci_job_token.md | 12 +++- doc/ci/troubleshooting.md | 4 +- .../advanced_search_migration_styleguide.md | 21 +++++++ doc/development/sidekiq/index.md | 2 +- .../advanced_search/elasticsearch.md | 14 +++++ .../incident_management/manage_incidents.md | 2 +- doc/update/deprecations.md | 2 + doc/user/okrs.md | 56 ++++++++++++++++++ .../project/issues/confidential_issues.md | 33 ++++------- .../img/confidential_issues_search_guest.png | Bin 8593 -> 0 bytes .../img/confidential_issues_search_master.png | Bin 13228 -> 0 bytes lib/gitlab/sidekiq_middleware/skip_jobs.rb | 4 +- locale/gitlab.pot | 12 ++-- .../sidekiq_middleware/skip_jobs_spec.rb | 2 +- ...ne_success_unlock_artifacts_worker_spec.rb | 39 ++++++++++++ .../concerns/worker_attributes_spec.rb | 4 +- 28 files changed, 216 insertions(+), 50 deletions(-) create mode 100644 db/migrate/20230727144741_add_label_lock_on_merge.rb create mode 100644 db/schema_migrations/20230727144741 delete mode 100644 doc/user/project/issues/img/confidential_issues_search_guest.png delete mode 100644 doc/user/project/issues/img/confidential_issues_search_master.png diff --git a/app/assets/javascripts/token_access/components/inbound_token_access.vue b/app/assets/javascripts/token_access/components/inbound_token_access.vue index eb1222d5130..ac359b4f901 100644 --- a/app/assets/javascripts/token_access/components/inbound_token_access.vue +++ b/app/assets/javascripts/token_access/components/inbound_token_access.vue @@ -21,9 +21,9 @@ import TokenProjectsTable from './token_projects_table.vue'; export default { i18n: { - toggleLabelTitle: s__('CICD|Allow access to this project with a CI_JOB_TOKEN'), + toggleLabelTitle: s__('CICD|Limit access %{italicStart}to%{italicEnd} this project'), toggleHelpText: s__( - `CICD|Manage which projects can use their CI_JOB_TOKEN to access this project. It is a security risk to disable this feature, because unauthorized projects might attempt to retrieve an active token and access the API. %{linkStart}Learn more.%{linkEnd}`, + `CICD|Prevent access to this project from other project CI/CD job tokens, unless the other project is added to the allowlist. It is a security risk to disable this feature, because unauthorized projects might attempt to retrieve an active token and access the API. %{linkStart}Learn more.%{linkEnd}`, ), cardHeaderTitle: s__( 'CICD|Allow CI job tokens from the following projects to access this project', @@ -209,6 +209,13 @@ export default { :label="$options.i18n.toggleLabelTitle" @change="updateCIJobTokenScope" > +