diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 03af9990722..45f14dc0033 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -1128,7 +1128,7 @@ - <<: *if-not-canonical-namespace when: never - <<: *if-merge-request-targeting-stable-branch - when: on_failure + when: always ############### # Pages rules # diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index be389f5bb36..bfe30034c7c 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -583,7 +583,6 @@ Layout/ArgumentAlignment: - 'app/models/webauthn_registration.rb' - 'app/models/wiki_page.rb' - 'app/models/work_item.rb' - - 'app/policies/project_snippet_policy.rb' - 'app/services/ci/archive_trace_service.rb' - 'app/services/ci/ensure_stage_service.rb' - 'app/services/ci/list_config_variables_service.rb' @@ -1448,13 +1447,6 @@ Layout/ArgumentAlignment: - 'ee/spec/models/upload_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' - 'ee/spec/models/vulnerabilities/state_transition_spec.rb' - - 'ee/spec/policies/dast/pre_scan_verification_policy_spec.rb' - - 'ee/spec/policies/dast/pre_scan_verification_step_policy_spec.rb' - - 'ee/spec/policies/deployment_policy_spec.rb' - - 'ee/spec/policies/epic_policy_spec.rb' - - 'ee/spec/policies/merge_request_policy_spec.rb' - - 'ee/spec/policies/vulnerabilities/feedback_policy_spec.rb' - - 'ee/spec/policies/vulnerabilities/merge_request_link_policy_spec.rb' - 'ee/spec/requests/admin/impersonation_tokens_controller_spec.rb' - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' @@ -2443,11 +2435,6 @@ Layout/ArgumentAlignment: - 'spec/models/user_detail_spec.rb' - 'spec/models/user_spec.rb' - 'spec/models/wiki_page/meta_spec.rb' - - 'spec/policies/ci/build_policy_spec.rb' - - 'spec/policies/ci/pipeline_policy_spec.rb' - - 'spec/policies/ci/pipeline_schedule_policy_spec.rb' - - 'spec/policies/environment_policy_spec.rb' - - 'spec/policies/group_policy_spec.rb' - 'spec/requests/admin/applications_controller_spec.rb' - 'spec/requests/admin/impersonation_tokens_controller_spec.rb' - 'spec/requests/api/access_requests_spec.rb' diff --git a/app/assets/javascripts/lib/mermaid.js b/app/assets/javascripts/lib/mermaid.js index c72561ce69d..60b46989375 100644 --- a/app/assets/javascripts/lib/mermaid.js +++ b/app/assets/javascripts/lib/mermaid.js @@ -12,8 +12,9 @@ const drawDiagram = (source) => { // eslint-disable-next-line no-unsanitized/property element.innerHTML = svgCode; - const height = parseInt(element.firstElementChild.getAttribute('height'), 10); - const width = parseInt(element.firstElementChild.style.maxWidth, 10); + element.firstElementChild.removeAttribute('height'); + const { height, width } = element.firstElementChild.getBoundingClientRect(); + setIframeRenderedSize(height, width); }; mermaid.mermaidAPI.render('mermaid', source, insertSvg); diff --git a/app/assets/javascripts/notes/components/discussion_counter.vue b/app/assets/javascripts/notes/components/discussion_counter.vue index 37935e9c3c6..ba5ffc60917 100644 --- a/app/assets/javascripts/notes/components/discussion_counter.vue +++ b/app/assets/javascripts/notes/components/discussion_counter.vue @@ -157,7 +157,7 @@ export default { v-if="resolveAllDiscussionsIssuePath && !allResolved" :href="resolveAllDiscussionsIssuePath" > - {{ __('Create issue to resolve all threads') }} + {{ __('Resolve all with new issue') }} diff --git a/app/assets/javascripts/performance_bar/components/performance_bar_app.vue b/app/assets/javascripts/performance_bar/components/performance_bar_app.vue index 2c5f4354d38..4bd86d4982e 100644 --- a/app/assets/javascripts/performance_bar/components/performance_bar_app.vue +++ b/app/assets/javascripts/performance_bar/components/performance_bar_app.vue @@ -1,5 +1,5 @@