diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 98843e90fda..3c9a256a2f8 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -2,22 +2,6 @@ # Cop supports --autocorrect. Layout/ArgumentAlignment: Exclude: - - 'app/graphql/mutations/ci/job/base.rb' - - 'app/graphql/mutations/ci/job/cancel.rb' - - 'app/graphql/mutations/ci/job/play.rb' - - 'app/graphql/mutations/ci/job/retry.rb' - - 'app/graphql/mutations/ci/job/unschedule.rb' - - 'app/graphql/mutations/ci/job_artifact/destroy.rb' - - 'app/graphql/mutations/ci/job_token_scope/add_project.rb' - - 'app/graphql/mutations/ci/job_token_scope/remove_project.rb' - - 'app/graphql/mutations/ci/pipeline/base.rb' - - 'app/graphql/mutations/ci/pipeline/retry.rb' - - 'app/graphql/mutations/ci/pipeline_schedule/base.rb' - - 'app/graphql/mutations/ci/pipeline_schedule/create.rb' - - 'app/graphql/mutations/ci/pipeline_schedule/play.rb' - - 'app/graphql/mutations/ci/pipeline_schedule/take_ownership.rb' - - 'app/graphql/mutations/ci/pipeline_schedule/update.rb' - - 'app/graphql/mutations/ci/runner/bulk_delete.rb' - 'app/graphql/mutations/customer_relations/contacts/base.rb' - 'app/graphql/mutations/customer_relations/contacts/create.rb' - 'app/graphql/mutations/customer_relations/contacts/update.rb' @@ -173,7 +157,6 @@ Layout/ArgumentAlignment: - 'ee/app/graphql/mutations/iterations/cadences/destroy.rb' - 'ee/app/graphql/mutations/iterations/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - - 'ee/app/graphql/mutations/namespaces/base.rb' - 'ee/app/graphql/mutations/projects/initialize_product_analytics.rb' - 'ee/app/graphql/mutations/projects/set_compliance_framework.rb' - 'ee/app/graphql/mutations/quality_management/test_cases/create.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index ecce1dd8ca5..5ed87aec7e9 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -172,21 +172,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/ee/release.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/elasticsearch_indexed_namespace.rb' - - 'ee/app/models/geo_node.rb' - - 'ee/app/models/gitlab_subscription.rb' - - 'ee/app/models/incident_management/escalation_policy.rb' - - 'ee/app/models/incident_management/escalation_rule.rb' - - 'ee/app/models/incident_management/oncall_participant.rb' - - 'ee/app/models/incident_management/oncall_rotation.rb' - - 'ee/app/models/incident_management/oncall_schedule.rb' - - 'ee/app/models/incident_management/oncall_shift.rb' - - 'ee/app/models/iteration.rb' - - 'ee/app/models/iterations/cadence.rb' - - 'ee/app/models/merge_request_block.rb' - - 'ee/app/models/merge_requests/compliance_violation.rb' - - 'ee/app/models/namespaces/namespace_ban.rb' - - 'ee/app/models/requirements_management/requirement.rb' - - 'ee/app/models/resource_iteration_event.rb' - 'ee/app/models/saml_group_link.rb' - 'ee/app/models/sca/license_compliance.rb' - 'ee/app/models/security/finding.rb' diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index 63f21322716..52f15491b85 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -11,17 +11,6 @@ Lint/AmbiguousOperatorPrecedence: - 'app/helpers/timeboxes_helper.rb' - 'app/helpers/tree_helper.rb' - 'app/helpers/users_helper.rb' - - 'app/models/concerns/relative_positioning.rb' - - 'app/models/design_management/version.rb' - - 'app/models/integrations/chat_message/pipeline_message.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/namespace.rb' - - 'app/models/network/graph.rb' - - 'app/models/note.rb' - - 'app/models/notification_reason.rb' - - 'app/models/project_feature.rb' - - 'app/models/terraform/state.rb' - - 'app/models/webauthn_registration.rb' - 'app/presenters/project_presenter.rb' - 'app/services/cohorts_service.rb' - 'app/services/concerns/validates_classification_label.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index fef77e03433..23cc1a790b8 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -91,19 +91,3 @@ Lint/SymbolConversion: - 'spec/requests/api/terraform/state_spec.rb' - 'spec/requests/mailgun/webhooks_controller_spec.rb' - 'spec/requests/users_controller_spec.rb' - - 'spec/scripts/pipeline_test_report_builder_spec.rb' - - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb' - - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb' - - 'spec/services/bulk_imports/get_importable_data_service_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'spec/services/git/base_hooks_service_spec.rb' - - 'spec/services/incident_management/timeline_event_tags/create_service_spec.rb' - - 'spec/services/jira_connect/sync_service_spec.rb' - - 'spec/services/ml/experiment_tracking/candidate_repository_spec.rb' - - 'spec/support/helpers/kubernetes_helpers.rb' - - 'spec/support/helpers/prometheus_helpers.rb' - - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' - - 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb' - - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' - - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' - - 'spec/workers/gitlab/github_gists_import/import_gist_worker_spec.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index a9ff8f34001..05735c1cfa3 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -176,7 +176,6 @@ RSpec/FeatureCategory: - 'ee/spec/graphql/mutations/merge_requests/accept_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/set_assignees_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/set_reviewers_spec.rb' - - 'ee/spec/graphql/mutations/namespaces/increase_storage_temporarily_spec.rb' - 'ee/spec/graphql/mutations/projects/set_compliance_framework_spec.rb' - 'ee/spec/graphql/mutations/projects/set_locked_spec.rb' - 'ee/spec/graphql/mutations/releases/update_spec.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index c533591bf66..681ce1e55ef 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -140,7 +140,6 @@ RSpec/NamedSubject: - 'ee/spec/graphql/mutations/issues/update_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/set_reviewers_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/update_approval_rules_spec.rb' - - 'ee/spec/graphql/mutations/namespaces/increase_storage_temporarily_spec.rb' - 'ee/spec/graphql/mutations/projects/set_locked_spec.rb' - 'ee/spec/graphql/mutations/releases/update_spec.rb' - 'ee/spec/graphql/mutations/requirements_management/create_requirement_spec.rb' @@ -261,7 +260,6 @@ RSpec/NamedSubject: - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_cadences_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/code_suggestions/prompts/code_completion/vertex_ai_spec.rb' - - 'ee/spec/lib/code_suggestions/prompts/code_generation/anthropic_spec.rb' - 'ee/spec/lib/code_suggestions/task_factory_spec.rb' - 'ee/spec/lib/code_suggestions/tasks/base_spec.rb' - 'ee/spec/lib/ee/api/entities/dependency_list_export_spec.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 227a320899c..646bb46956b 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -613fa6169f5750468bdd4a15b1f453ea4f17c45c +86baea59fb2ce0379b40ee571a168cfe8b134079 diff --git a/Gemfile b/Gemfile index 1a6a9ba0dbd..c6afcacc0ab 100644 --- a/Gemfile +++ b/Gemfile @@ -83,7 +83,6 @@ gem 'omniauth-google-oauth2', '~> 1.1' # rubocop:todo Gemfile/MissingFeatureCate gem 'omniauth-oauth2-generic', '~> 0.2.2' # rubocop:todo Gemfile/MissingFeatureCategory gem 'omniauth-saml', '~> 2.1.0' # rubocop:todo Gemfile/MissingFeatureCategory gem 'omniauth-shibboleth-redux', '~> 2.0', require: 'omniauth-shibboleth' # rubocop:todo Gemfile/MissingFeatureCategory -gem 'omniauth-twitter', '~> 1.4' # rubocop:todo Gemfile/MissingFeatureCategory gem 'omniauth_crowd', '~> 2.4.0', path: 'vendor/gems/omniauth_crowd' # See vendor/gems/omniauth_crowd/README.md # rubocop:todo Gemfile/MissingFeatureCategory gem 'omniauth_openid_connect', '~> 0.6.1' # rubocop:todo Gemfile/MissingFeatureCategory # Locked until Ruby 3.0 upgrade since upgrading will pull in an updated net-smtp gem. diff --git a/Gemfile.checksum b/Gemfile.checksum index 69f0edc2f70..12837ac8c75 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -436,12 +436,10 @@ {"name":"omniauth-facebook","version":"4.0.0","platform":"ruby","checksum":"05ae3565c8fdb38df8dab04eb8ca854ea6c18e81591d3e6598ce101293a2f20f"}, {"name":"omniauth-github","version":"2.0.1","platform":"ruby","checksum":"8ff8e70ac6d6db9d52485eef52cfa894938c941496e66b52b5e2773ade3ccad4"}, {"name":"omniauth-google-oauth2","version":"1.1.1","platform":"ruby","checksum":"4496f126e84eaf760f9c6a5c69e5e7511f98092d7f25ad79fd2c0ae5e09b5039"}, -{"name":"omniauth-oauth","version":"1.2.0","platform":"ruby","checksum":"e7a78658498dc83aa3f3be1a776425c0f06a60d45d9236dbe5e98e61fadf827b"}, {"name":"omniauth-oauth2","version":"1.8.0","platform":"ruby","checksum":"b2f8e9559cc7e2d4efba57607691d6d2b634b879fc5b5b6ccfefa3da85089e78"}, {"name":"omniauth-oauth2-generic","version":"0.2.8","platform":"ruby","checksum":"ce6e8539019d5ebf2f48867072b9f248f148bb4cbe7166dee655865abfae7613"}, {"name":"omniauth-saml","version":"2.1.0","platform":"ruby","checksum":"969cb7ba271891d09dfa57b206fc274f43203c52727492517decda93decc6906"}, {"name":"omniauth-shibboleth-redux","version":"2.0.0","platform":"ruby","checksum":"e9b353fd103405fcc8549e8510b9cad857acf0b286d764fac5dba8a93ab8ffe1"}, -{"name":"omniauth-twitter","version":"1.4.0","platform":"ruby","checksum":"c5cc6c77cd767745ffa9ebbd5fbd694a3fa99d1d2d82a4d7def0bf3b6131b264"}, {"name":"omniauth_openid_connect","version":"0.6.1","platform":"ruby","checksum":"5f1318f5b19b05e339ff494def060b57a503b1e3ea83c3a0ced6cc014407d423"}, {"name":"open4","version":"1.3.4","platform":"ruby","checksum":"a1df037310624ecc1ea1d81264b11c83e96d0c3c1c6043108d37d396dcd0f4b1"}, {"name":"openid_connect","version":"1.3.0","platform":"ruby","checksum":"a796855096850cc01140e37ea6ae9fd14f2be818b9b5bc698418063dfe228770"}, diff --git a/Gemfile.lock b/Gemfile.lock index a5bc90e3fc7..10335f7938a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1195,9 +1195,6 @@ GEM oauth2 (~> 2.0.6) omniauth (~> 2.0) omniauth-oauth2 (~> 1.8.0) - omniauth-oauth (1.2.0) - oauth - omniauth (>= 1.0, < 3) omniauth-oauth2 (1.8.0) oauth2 (>= 1.4, < 3) omniauth (~> 2.0) @@ -1209,9 +1206,6 @@ GEM ruby-saml (~> 1.12) omniauth-shibboleth-redux (2.0.0) omniauth (>= 2.0.0) - omniauth-twitter (1.4.0) - omniauth-oauth (~> 1.1) - rack omniauth_openid_connect (0.6.1) omniauth (>= 1.9, < 3) openid_connect (~> 1.1) @@ -2124,7 +2118,6 @@ DEPENDENCIES omniauth-salesforce (~> 1.0.5)! omniauth-saml (~> 2.1.0) omniauth-shibboleth-redux (~> 2.0) - omniauth-twitter (~> 1.4) omniauth_crowd (~> 2.4.0)! omniauth_openid_connect (~> 0.6.1) openid_connect (= 1.3.0) diff --git a/app/assets/images/auth_buttons/twitter_64.png b/app/assets/images/auth_buttons/twitter_64.png deleted file mode 100644 index 15596b0f30a..00000000000 Binary files a/app/assets/images/auth_buttons/twitter_64.png and /dev/null differ diff --git a/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue b/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue index b85e91375d4..34e14abefc2 100644 --- a/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue +++ b/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue @@ -416,8 +416,8 @@ export default { label-for="ci-variable-type" class="gl-border-none" :class="{ - 'gl-mb-n5': !hideEnvironmentScope, - 'gl-mb-n1': hideEnvironmentScope, + '-gl-mb-5': !hideEnvironmentScope, + '-gl-mb-1': hideEnvironmentScope, }" > @@ -464,9 +464,9 @@ export default { readonly /> - +