From 20f6a17ba2d2d5f056bda38dfe85e2a7b2a82d0b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 9 Nov 2022 18:07:50 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab-ci.yml | 4 +- .gitlab/ci/pages.gitlab-ci.yml | 17 +- .gitlab/ci/rules.gitlab-ci.yml | 3 +- GITALY_SERVER_VERSION | 2 +- .../admin/users/components/actions/delete.vue | 4 + .../actions/delete_with_contributions.vue | 48 +- .../associations/associations_list.vue | 65 +++ .../associations/associations_list_item.vue | 27 + .../components/modals/delete_user_modal.vue | 17 +- .../admin/users/components/user_actions.vue | 1 + app/assets/javascripts/api/user_api.js | 6 + app/assets/javascripts/blob/openapi/index.js | 2 +- app/assets/javascripts/merge_request_tabs.js | 35 +- .../javascripts/pages/projects/init_blob.js | 3 - .../pages/projects/tree/show/index.js | 2 - .../page_bundles/merge_requests.scss | 4 + .../groups/observability_controller.rb | 17 +- .../projects/merge_requests_controller.rb | 16 +- .../mutations/ci/runner/bulk_delete.rb | 16 +- app/graphql/types/merge_request_type.rb | 2 +- app/models/application_setting.rb | 2 +- app/models/ci/bridge.rb | 24 +- app/models/commit_collection.rb | 7 +- app/models/concerns/redis_cacheable.rb | 8 +- app/models/merge_request.rb | 8 +- app/models/merge_request_diff.rb | 16 +- .../project_root_ancestor_preloader.rb | 2 +- ..._max_access_level_in_projects_preloader.rb | 2 + app/models/user.rb | 2 +- app/policies/global_policy.rb | 2 - app/policies/project_policy.rb | 1 - .../ci/runners/bulk_delete_runners_service.rb | 54 +- app/services/event_create_service.rb | 57 +- app/services/merge_requests/base_service.rb | 2 +- .../protected_branches/cache_service.rb | 8 +- app/views/projects/commits/_commits.html.haml | 7 +- .../merge_requests/_commits.html.haml | 5 +- .../gitlab_performance_bar_stats_worker.rb | 6 +- .../inactive_projects_deletion_cron_worker.rb | 10 +- .../development/duplicate_jobs_cookie.yml | 8 - .../development/observability_group_tab.yml | 2 +- doc/administration/pages/index.md | 2 +- doc/administration/pages/source.md | 2 +- doc/api/graphql/reference/index.md | 6 +- doc/api/merge_requests.md | 62 +-- .../policies/scan-execution-policies.md | 4 +- doc/user/group/saml_sso/index.md | 20 +- doc/user/permissions.md | 2 +- .../project/pages/img/remove_pages_v15_3.png | Bin 4432 -> 0 bytes doc/user/project/pages/introduction.md | 67 +-- lib/banzai/reference_parser/base_parser.rb | 10 + .../cache/ci/project_pipeline_status.rb | 12 +- lib/gitlab/cache/import/caching.rb | 28 +- lib/gitlab/container_repository/tags/cache.rb | 8 +- lib/gitlab/diff/highlight_cache.rb | 10 +- .../discussions_diff/highlight_cache.rb | 10 +- lib/gitlab/external_authorization/cache.rb | 8 +- lib/gitlab/markdown_cache/redis/store.rb | 8 +- .../mergeability/redis_interface.rb | 8 +- lib/gitlab/observability.rb | 15 + lib/gitlab/pagination_delegate.rb | 67 +++ lib/gitlab/shard_health_cache.rb | 14 +- .../duplicate_jobs/duplicate_job.rb | 282 +++------- lib/gitlab/usage/metrics/name_suggestion.rb | 30 +- .../relation_parsers/having_constraints.rb | 31 ++ .../{constraints.rb => where_constraints.rb} | 8 +- locale/gitlab.pot | 35 +- .../import/import_github_repo_spec.rb | 19 +- .../concerns/renders_commits_spec.rb | 4 +- .../explore/projects_controller_spec.rb | 25 +- .../merge_requests_controller_spec.rb | 28 +- ...e_for_discussions_in_merge_request_spec.rb | 2 +- .../features/projects/blobs/blob_show_spec.rb | 2 +- .../users/components/actions/actions_spec.js | 57 +- .../actions/delete_with_contributions_spec.js | 107 ++++ .../associations_list_item_spec.js.snap | 3 + .../associations_list_spec.js.snap | 34 ++ .../associations_list_item_spec.js | 25 + .../associations/associations_list_spec.js | 78 +++ .../modals/delete_user_modal_spec.js | 22 + .../users/components/user_actions_spec.js | 7 +- spec/frontend/admin/users/mock_data.js | 14 + spec/frontend/api/user_api_spec.js | 17 +- spec/frontend/blob/openapi/index_spec.js | 2 +- .../mutations/ci/runner/bulk_delete_spec.rb | 74 ++- spec/lib/gitlab/observability_spec.rb | 33 ++ spec/lib/gitlab/pagination_delegate_spec.rb | 157 ++++++ .../duplicate_jobs/duplicate_job_spec.rb | 490 ++---------------- .../usage/metrics/name_suggestion_spec.rb | 13 +- .../having_constraints_spec.rb | 19 + ...ints_spec.rb => where_constraints_spec.rb} | 7 +- spec/models/application_setting_spec.rb | 4 + spec/models/ci/bridge_spec.rb | 75 +++ spec/models/merge_request_diff_spec.rb | 13 + spec/models/merge_request_spec.rb | 13 + .../project_root_ancestor_preloader_spec.rb | 8 + ...access_level_in_projects_preloader_spec.rb | 52 +- spec/policies/global_policy_spec.rb | 30 -- spec/policies/project_policy_spec.rb | 2 +- spec/requests/api/release/links_spec.rb | 18 +- .../groups/observability_controller_spec.rb | 71 +-- .../create_pipeline_service/variables_spec.rb | 44 ++ .../bulk_delete_runners_service_spec.rb | 169 ++++-- spec/services/event_create_service_spec.rb | 62 ++- .../helpers/reference_parser_helpers.rb | 2 +- .../merge_requests/_commits.html.haml_spec.rb | 12 - .../creations/_new_submit.html.haml_spec.rb | 13 - 107 files changed, 1854 insertions(+), 1246 deletions(-) create mode 100644 app/assets/javascripts/admin/users/components/associations/associations_list.vue create mode 100644 app/assets/javascripts/admin/users/components/associations/associations_list_item.vue delete mode 100644 config/feature_flags/development/duplicate_jobs_cookie.yml delete mode 100644 doc/user/project/pages/img/remove_pages_v15_3.png create mode 100644 lib/gitlab/observability.rb create mode 100644 lib/gitlab/pagination_delegate.rb create mode 100644 lib/gitlab/usage/metrics/names_suggestions/relation_parsers/having_constraints.rb rename lib/gitlab/usage/metrics/names_suggestions/relation_parsers/{constraints.rb => where_constraints.rb} (81%) create mode 100644 spec/frontend/admin/users/components/actions/delete_with_contributions_spec.js create mode 100644 spec/frontend/admin/users/components/associations/__snapshots__/associations_list_item_spec.js.snap create mode 100644 spec/frontend/admin/users/components/associations/__snapshots__/associations_list_spec.js.snap create mode 100644 spec/frontend/admin/users/components/associations/associations_list_item_spec.js create mode 100644 spec/frontend/admin/users/components/associations/associations_list_spec.js create mode 100644 spec/lib/gitlab/observability_spec.rb create mode 100644 spec/lib/gitlab/pagination_delegate_spec.rb create mode 100644 spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/having_constraints_spec.rb rename spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/{constraints_spec.rb => where_constraints_spec.rb} (64%) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0c9e0391c06..bbf8265da85 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -45,8 +45,8 @@ workflow: RUBY_VERSION: "3.0" # For (detached) merge request pipelines. - if: '$CI_MERGE_REQUEST_IID' - # For the maintenance scheduled pipelines, we set specific variables. - - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "schedule" && $SCHEDULE_TYPE == "maintenance"' + # For the scheduled pipelines, we set specific variables. + - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "schedule"' variables: CRYSTALBALL: "true" CREATE_INCIDENT_FOR_PIPELINE_FAILURE: "true" diff --git a/.gitlab/ci/pages.gitlab-ci.yml b/.gitlab/ci/pages.gitlab-ci.yml index 1f9f57cfc22..ea4319809f9 100644 --- a/.gitlab/ci/pages.gitlab-ci.yml +++ b/.gitlab/ci/pages.gitlab-ci.yml @@ -10,20 +10,18 @@ pages: environment: pages resource_group: pages needs: - - job: "rspec:coverage" - - job: "coverage-frontend" - - job: "compile-production-assets" - - job: "compile-storybook" - # `update-tests-metadata` only runs on GitLab.com's EE schedules pipelines - # while `pages` runs for all the maintenance scheduled pipelines. - - job: "update-tests-metadata" - optional: true + - "rspec:coverage" + - "coverage-frontend" + - "compile-production-assets" + - "compile-storybook" + - "update-tests-metadata" + - "generate-frontend-fixtures-mapping" before_script: - apt-get update && apt-get -y install brotli gzip script: - mv public/ .public/ - mkdir public/ - - mkdir -p public/$(dirname "$KNAPSACK_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$FLAKY_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$RSPEC_PACKED_TESTS_MAPPING_PATH") + - mkdir -p public/$(dirname "$KNAPSACK_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$FLAKY_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$RSPEC_PACKED_TESTS_MAPPING_PATH") public/$(dirname "$FRONTEND_FIXTURES_MAPPING_PATH") - mv coverage/ public/coverage-ruby/ || true - mv coverage-frontend/ public/coverage-frontend/ || true - mv storybook/public public/storybook || true @@ -31,6 +29,7 @@ pages: - mv $KNAPSACK_RSPEC_SUITE_REPORT_PATH public/$KNAPSACK_RSPEC_SUITE_REPORT_PATH || true - mv $FLAKY_RSPEC_SUITE_REPORT_PATH public/$FLAKY_RSPEC_SUITE_REPORT_PATH || true - mv $RSPEC_PACKED_TESTS_MAPPING_PATH.gz public/$RSPEC_PACKED_TESTS_MAPPING_PATH.gz || true + - mv $FRONTEND_FIXTURES_MAPPING_PATH public/$FRONTEND_FIXTURES_MAPPING_PATH || true - *compress-public artifacts: paths: diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index ab98b2a0591..aa6ce356c56 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -21,7 +21,7 @@ if: '$FORCE_GITLAB_CI' .if-default-refs: &if-default-refs - if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH || $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable(-ee)?$/ || $CI_COMMIT_REF_NAME =~ /^\d+-\d+-auto-deploy-\d+$/ || $CI_COMMIT_REF_NAME =~ /^security\// || $CI_MERGE_REQUEST_IID || $CI_COMMIT_TAG || $FORCE_GITLAB_CI' + if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH || $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable(-ee)?$/ || $CI_COMMIT_REF_NAME =~ /^\d+-\d+-auto-deploy-\d+$/ || $CI_COMMIT_REF_NAME =~ /^security\// || $CI_COMMIT_REF_NAME == "ruby3" || $CI_MERGE_REQUEST_IID || $CI_COMMIT_TAG || $FORCE_GITLAB_CI' .if-default-branch-refs: &if-default-branch-refs if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $CI_MERGE_REQUEST_IID == null' @@ -868,6 +868,7 @@ - <<: *if-merge-request-targeting-stable-branch - <<: *if-merge-request-labels-run-review-app - <<: *if-auto-deploy-branches + - <<: *if-ruby3-branch - <<: *if-default-refs changes: *ci-build-images-patterns - <<: *if-default-refs diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index c33161271b9..472fc034f84 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -7a8f7c377bd013483aba14ced8eafd073c631d4a +1ba70888404fcb9719d4eb33481f57138bce7447 diff --git a/app/assets/javascripts/admin/users/components/actions/delete.vue b/app/assets/javascripts/admin/users/components/actions/delete.vue index ae0c6731271..d4f9ff4e529 100644 --- a/app/assets/javascripts/admin/users/components/actions/delete.vue +++ b/app/assets/javascripts/admin/users/components/actions/delete.vue @@ -12,6 +12,10 @@ export default { type: String, required: true, }, + userId: { + type: Number, + required: true, + }, paths: { type: Object, required: true, diff --git a/app/assets/javascripts/admin/users/components/actions/delete_with_contributions.vue b/app/assets/javascripts/admin/users/components/actions/delete_with_contributions.vue index a39df1cbfb6..413804c9a3b 100644 --- a/app/assets/javascripts/admin/users/components/actions/delete_with_contributions.vue +++ b/app/assets/javascripts/admin/users/components/actions/delete_with_contributions.vue @@ -1,17 +1,26 @@