From 21cf3e773d0527e95d761e7cc49bdbb2155183d3 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 3 Apr 2023 21:08:25 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/gitlab/strong_memoize_attr.yml | 1 - .../layout/empty_line_after_magic_comment.yml | 2 - .rubocop_todo/layout/line_length.yml | 1 - .rubocop_todo/rspec/context_wording.yml | 1 - .rubocop_todo/rspec/expect_change.yml | 2 - .rubocop_todo/style/redundant_freeze.yml | 1 - GITALY_SERVER_VERSION | 2 +- app/assets/javascripts/diffs/i18n.js | 2 +- .../details/components/import_details_app.vue | 22 ++ .../javascripts/import/details/index.js | 18 ++ app/assets/javascripts/lib/graphql.js | 1 + .../pages/import/github/details/index.js | 3 + .../components/performance_bar_app.vue | 49 ++-- .../javascripts/performance_bar/index.js | 14 +- .../services/performance_bar_service.js | 9 +- .../stores/performance_bar_store.js | 14 +- app/assets/stylesheets/framework/diffs.scss | 57 +--- app/assets/stylesheets/framework/sidebar.scss | 37 +-- .../framework/system_messages.scss | 11 +- .../page_bundles/merge_requests.scss | 12 +- app/assets/stylesheets/pages/issues.scss | 6 +- .../stylesheets/pages/merge_requests.scss | 22 +- app/assets/stylesheets/pages/notes.scss | 12 - .../stylesheets/startup/startup-dark.scss | 1 + .../stylesheets/startup/startup-general.scss | 1 + .../stylesheets/startup/startup-signin.scss | 6 + app/controllers/import/github_controller.rb | 4 + .../projects/fork_details_resolver.rb | 1 - .../application_settings/settings_helper.rb | 4 + app/models/packages/package.rb | 22 +- .../debian/find_or_create_package_service.rb | 31 ++- .../debian/process_package_file_service.rb | 25 +- app/views/import/github/details.html.haml | 4 + app/views/peek/_bar.html.haml | 3 +- app/views/projects/_files.html.haml | 3 +- app/views/projects/_home_panel.html.haml | 9 - app/views/projects/blob/_blob.html.haml | 3 +- .../_branch_names_fields.html.haml | 2 +- ...nce_counts.yml => import_details_page.yml} | 10 +- .../initializers/gettext_rails_i18n_patch.rb | 35 --- config/routes/import.rb | 1 + ...d_tmp_unique_packages_index_when_debian.rb | 23 ++ ...317080000_ensure_unique_debian_packages.rb | 48 ++++ ...7_add_unique_packages_index_when_debian.rb | 29 ++ db/schema_migrations/20230317075852 | 1 + db/schema_migrations/20230317080000 | 1 + db/schema_migrations/20230317080137 | 1 + db/structure.sql | 2 + doc/administration/docs_self_host.md | 3 - .../sec/security_report_ingestion_overview.md | 98 +++++-- doc/security/email_verification.md | 4 +- doc/security/user_email_confirmation.md | 2 +- doc/user/analytics/dora_metrics.md | 5 + doc/user/group/moderate_users.md | 2 +- doc/user/project/code_owners.md | 6 +- lib/tasks/gettext.rake | 28 +- locale/gitlab.pot | 18 +- spec/factories/packages/packages.rb | 6 +- .../components/import_details_app_spec.js | 23 ++ spec/frontend/import/details/mock_data.js | 31 +++ .../components/performance_bar_app_spec.js | 29 +- spec/frontend/performance_bar/index_spec.js | 9 +- .../services/performance_bar_service_spec.js | 2 +- .../ensure_unique_debian_packages_spec.rb | 56 ++++ spec/models/packages/package_spec.rb | 25 +- .../api/graphql/project/fork_details_spec.rb | 12 - .../requests/import/github_controller_spec.rb | 40 +++ .../projects/wikis_controller_spec.rb | 1 - .../find_or_create_package_service_spec.rb | 21 +- .../debian/process_changes_service_spec.rb | 34 ++- .../process_package_file_service_spec.rb | 40 ++- spec/spec_helper.rb | 1 + spec/support/rspec_order_todo.yml | 1 - spec/support/tmpdir.rb | 2 + spec/tasks/gettext_rake_spec.rb | 31 +-- .../lib/tooling/gettext_extractor_spec.rb | 254 ++++++++++++++++++ .../projects/_home_panel.html.haml_spec.rb | 24 -- tooling/bin/gettext_extractor | 29 ++ tooling/lib/tooling/gettext_extractor.rb | 106 ++++++++ 79 files changed, 1093 insertions(+), 419 deletions(-) create mode 100644 app/assets/javascripts/import/details/components/import_details_app.vue create mode 100644 app/assets/javascripts/import/details/index.js create mode 100644 app/assets/javascripts/pages/import/github/details/index.js create mode 100644 app/views/import/github/details.html.haml rename config/feature_flags/development/{fork_divergence_counts.yml => import_details_page.yml} (64%) create mode 100644 db/post_migrate/20230317075852_add_tmp_unique_packages_index_when_debian.rb create mode 100644 db/post_migrate/20230317080000_ensure_unique_debian_packages.rb create mode 100644 db/post_migrate/20230317080137_add_unique_packages_index_when_debian.rb create mode 100644 db/schema_migrations/20230317075852 create mode 100644 db/schema_migrations/20230317080000 create mode 100644 db/schema_migrations/20230317080137 create mode 100644 spec/frontend/import/details/components/import_details_app_spec.js create mode 100644 spec/frontend/import/details/mock_data.js create mode 100644 spec/migrations/ensure_unique_debian_packages_spec.rb create mode 100644 spec/requests/import/github_controller_spec.rb create mode 100644 spec/tooling/lib/tooling/gettext_extractor_spec.rb create mode 100755 tooling/bin/gettext_extractor create mode 100644 tooling/lib/tooling/gettext_extractor.rb diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 3ecc1ef6bfc..06efefef2f1 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -229,7 +229,6 @@ Gitlab/StrongMemoizeAttr: - 'app/services/packages/cleanup/update_policy_service.rb' - 'app/services/packages/composer/create_package_service.rb' - 'app/services/packages/debian/extract_changes_metadata_service.rb' - - 'app/services/packages/debian/find_or_create_package_service.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/packages/debian/process_changes_service.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index eec96887069..021869e6885 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -806,8 +806,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/services/packages/debian/extract_changes_metadata_service_spec.rb' - 'spec/services/packages/debian/extract_deb_metadata_service_spec.rb' - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - - 'spec/services/packages/debian/process_changes_service_spec.rb' - - 'spec/services/packages/debian/process_package_file_service_spec.rb' - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/maven/create_package_service_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index a2752712f41..86faf32e8be 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -1542,7 +1542,6 @@ Layout/LineLength: - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - - 'ee/spec/controllers/projects/dependencies_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - 'ee/spec/controllers/projects/issues_controller_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index f925b637173..9e2061049a5 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -2840,7 +2840,6 @@ RSpec/ContextWording: - 'spec/services/packages/create_package_file_service_spec.rb' - 'spec/services/packages/debian/create_distribution_service_spec.rb' - 'spec/services/packages/debian/find_or_create_incoming_service_spec.rb' - - 'spec/services/packages/debian/process_changes_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/maven/create_package_service_spec.rb' - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 9e3be798f09..154a3056635 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -398,8 +398,6 @@ RSpec/ExpectChange: - 'spec/services/milestones/find_or_create_service_spec.rb' - 'spec/services/milestones/transfer_service_spec.rb' - 'spec/services/namespaces/statistics_refresher_service_spec.rb' - - 'spec/services/packages/debian/process_changes_service_spec.rb' - - 'spec/services/packages/debian/process_package_file_service_spec.rb' - 'spec/services/pages_domains/create_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/cleanup_service_spec.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index e9ec1e101d7..07027d7dd3d 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -51,7 +51,6 @@ Style/RedundantFreeze: - 'app/services/grafana/proxy_service.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' - 'app/services/issues/base_service.rb' - - 'app/services/packages/debian/process_package_file_service.rb' - 'app/services/projects/import_error_filter.rb' - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - 'app/services/prometheus/proxy_variable_substitution_service.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 7203cc8c611..2434757116e 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -763a199d4d1425815bdb7284356f2fe549edb1c3 +d2ebb7f9a436d1476a2b750e844fe3525ae9dc8b diff --git a/app/assets/javascripts/diffs/i18n.js b/app/assets/javascripts/diffs/i18n.js index 95155181c78..e233a0cef0a 100644 --- a/app/assets/javascripts/diffs/i18n.js +++ b/app/assets/javascripts/diffs/i18n.js @@ -2,7 +2,7 @@ import { __, s__ } from '~/locale'; export const GENERIC_ERROR = __('Something went wrong on our end. Please try again!'); export const LOAD_SINGLE_DIFF_FAILED = s__( - 'MergeRequest|Encountered an issue while trying to fetch the single file diff.', + "MergeRequest|Can't fetch the diff needed to update this view. Please reload this page.", ); export const DISCUSSION_SINGLE_DIFF_FAILED = s__( "MergeRequest|Can't fetch the single file diff for the discussion. Please reload this page.", diff --git a/app/assets/javascripts/import/details/components/import_details_app.vue b/app/assets/javascripts/import/details/components/import_details_app.vue new file mode 100644 index 00000000000..ab9242b9081 --- /dev/null +++ b/app/assets/javascripts/import/details/components/import_details_app.vue @@ -0,0 +1,22 @@ + + + diff --git a/app/assets/javascripts/import/details/index.js b/app/assets/javascripts/import/details/index.js new file mode 100644 index 00000000000..70850d947e2 --- /dev/null +++ b/app/assets/javascripts/import/details/index.js @@ -0,0 +1,18 @@ +import Vue from 'vue'; +import ImportDetailsApp from './components/import_details_app.vue'; + +export default () => { + const el = document.querySelector('.js-import-details'); + + if (!el) { + return null; + } + + return new Vue({ + el, + name: 'ImportDetailsRoot', + render(createElement) { + return createElement(ImportDetailsApp); + }, + }); +}; diff --git a/app/assets/javascripts/lib/graphql.js b/app/assets/javascripts/lib/graphql.js index 150a1b16e58..dee8d11c065 100644 --- a/app/assets/javascripts/lib/graphql.js +++ b/app/assets/javascripts/lib/graphql.js @@ -170,6 +170,7 @@ function createApolloClient(resolvers = {}, config = {}) { config: { url: httpResponse.url, operationName: operation.operationName, + method: operation.getContext()?.fetchOptions?.method || 'POST', // If method is not explicitly set, we default to POST request }, headers: { 'x-request-id': httpResponse.headers.get('x-request-id'), diff --git a/app/assets/javascripts/pages/import/github/details/index.js b/app/assets/javascripts/pages/import/github/details/index.js new file mode 100644 index 00000000000..44a85589c9d --- /dev/null +++ b/app/assets/javascripts/pages/import/github/details/index.js @@ -0,0 +1,3 @@ +import initImportDetails from '~/import/details'; + +initImportDetails(); diff --git a/app/assets/javascripts/performance_bar/components/performance_bar_app.vue b/app/assets/javascripts/performance_bar/components/performance_bar_app.vue index 59a532461ab..2c5f4354d38 100644 --- a/app/assets/javascripts/performance_bar/components/performance_bar_app.vue +++ b/app/assets/javascripts/performance_bar/components/performance_bar_app.vue @@ -1,4 +1,5 @@