From 23b5f76606145a01b11d0feb7bc515ab3bef59f5 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 19 Nov 2024 15:27:48 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/gitlab/strong_memoize_attr.yml | 1 - .rubocop_todo/layout/line_length.yml | 2 - .../lint/redundant_cop_disable_directive.yml | 7 - .rubocop_todo/lint/unused_method_argument.yml | 1 - .rubocop_todo/style/redundant_self.yml | 1 - GITALY_SERVER_VERSION | 2 +- .../components/recovery_codes.vue | 24 +-- .../webauthn/components/registration.vue | 88 +++++----- .../authentication/webauthn/constants.js | 3 - app/assets/javascripts/lib/mermaid.js | 4 + .../pages/projects/blob/show/index.js | 30 ---- .../repository/components/header_area.vue | 18 +++ .../components/header_area/blob_controls.vue | 7 +- .../repository/components/last_commit.vue | 20 +-- app/assets/javascripts/repository/index.js | 10 +- .../javascripts/repository/init_header_app.js | 2 + .../components/token_access_app.vue | 27 +++- app/assets/stylesheets/pages/commits.scss | 1 - .../enforces_two_factor_authentication.rb | 2 +- app/models/integrations/emails_on_push.rb | 6 +- app/models/sent_notification.rb | 2 + app/models/subscription.rb | 1 + .../work_items/data_sync/base_service.rb | 8 +- .../data_sync/widgets/notifications.rb | 57 ++++++- .../profiles/two_factor_auths/show.html.haml | 133 ++++++++------- app/views/projects/_files.html.haml | 2 +- app/views/projects/blob/_blob.html.haml | 2 +- app/views/projects/blob/_breadcrumb.html.haml | 3 +- app/views/projects/commits/_commit.html.haml | 11 +- .../projects/tree/_tree_header.html.haml | 3 +- .../user_refresh_over_user_range_worker.rb | 2 +- app/workers/concerns/search/worker.rb | 6 + config/initializers/1_settings.rb | 3 + config/initializers/warden.rb | 2 +- config/sidekiq_queues.yml | 2 - ...lete_duplicate_issuable_resource_links.yml | 8 + .../delete_orphaned_build_records.yml | 2 +- ..._update_subscriptions_index_on_noteable.rb | 19 +++ ...te_sent_notifications_index_on_noteable.rb | 25 +++ ...elete_duplicate_issuable_resource_links.rb | 27 ++++ ..._finalize_delete_orphaned_build_records.rb | 23 +++ db/schema_migrations/20241106125601 | 1 + db/schema_migrations/20241106125627 | 1 + db/schema_migrations/20241111055711 | 1 + db/schema_migrations/20241115122644 | 1 + lib/api/helpers/integrations_helpers.rb | 27 +--- lib/atlassian/jira_connect/jwt/asymmetric.rb | 4 +- lib/gitlab/auth/current_user_mode.rb | 4 +- ...elete_duplicate_issuable_resource_links.rb | 17 ++ lib/gitlab/cleanup/personal_access_tokens.rb | 3 - lib/gitlab/lfs_token.rb | 2 +- .../sidekiq_middleware/pause_control.rb | 1 + .../strategies/advanced_search.rb | 16 ++ locale/gitlab.pot | 5 +- package.json | 2 +- rubocop/cop/search/namespaced_class.rb | 1 + scripts/lint/check_mermaid.mjs | 12 +- spec/features/projects/tree/tree_show_spec.rb | 2 +- .../webauthn/components/registration_spec.js | 4 +- spec/frontend/dompurify_verison_spec.js | 13 -- .../__snapshots__/last_commit_spec.js.snap | 18 +-- .../repository/components/header_area_spec.js | 11 +- .../repository/components/last_commit_spec.js | 8 +- .../token_access/token_access_app_spec.js | 37 +++-- .../jira_connect/jwt/asymmetric_spec.rb | 14 +- ..._duplicate_issuable_resource_links_spec.rb | 152 ++++++++++++++++++ ..._duplicate_issuable_resource_links_spec.rb | 27 ++++ .../integrations/emails_on_push_spec.rb | 5 +- .../data_sync/widgets/award_emoji_spec.rb | 2 +- .../data_sync/widgets/notifications_spec.rb | 149 +++++++++++++++++ ...eable_and_moveable_data_stared_examples.rb | 37 ++++- .../commits/_commit.html.haml_spec.rb | 41 ----- spec/workers/concerns/search/worker_spec.rb | 12 ++ yarn.lock | 8 +- 74 files changed, 838 insertions(+), 397 deletions(-) create mode 100644 db/docs/batched_background_migrations/delete_duplicate_issuable_resource_links.yml create mode 100644 db/post_migrate/20241106125601_update_subscriptions_index_on_noteable.rb create mode 100644 db/post_migrate/20241106125627_update_sent_notifications_index_on_noteable.rb create mode 100644 db/post_migrate/20241111055711_queue_delete_duplicate_issuable_resource_links.rb create mode 100644 db/post_migrate/20241115122644_finalize_delete_orphaned_build_records.rb create mode 100644 db/schema_migrations/20241106125601 create mode 100644 db/schema_migrations/20241106125627 create mode 100644 db/schema_migrations/20241111055711 create mode 100644 db/schema_migrations/20241115122644 create mode 100644 lib/gitlab/background_migration/delete_duplicate_issuable_resource_links.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/strategies/advanced_search.rb delete mode 100644 spec/frontend/dompurify_verison_spec.js create mode 100644 spec/lib/gitlab/background_migration/delete_duplicate_issuable_resource_links_spec.rb create mode 100644 spec/migrations/20241111055711_queue_delete_duplicate_issuable_resource_links_spec.rb create mode 100644 spec/services/work_items/data_sync/widgets/notifications_spec.rb diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 6ac586e52cb..ed97e112b5f 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -378,7 +378,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/lib/gitlab/code_owners/entry.rb' - 'ee/lib/gitlab/code_owners/loader.rb' - 'ee/lib/gitlab/custom_file_templates.rb' - - 'ee/lib/gitlab/elastic/document_reference.rb' - 'ee/lib/gitlab/elastic/indexer.rb' - 'ee/lib/gitlab/elastic/project_search_results.rb' - 'ee/lib/gitlab/expiring_subscription_message.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 0247e114aca..bd6600e325e 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -940,7 +940,6 @@ Layout/LineLength: - 'ee/lib/ee/sidebars/projects/menus/security_compliance_menu.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - 'ee/lib/elastic/latest/git_instance_proxy.rb' - - 'ee/lib/elastic/latest/issue_instance_proxy.rb' - 'ee/lib/elastic/latest/note_class_proxy.rb' - 'ee/lib/elastic/latest/repository_class_proxy.rb' - 'ee/lib/elastic/latest/repository_instance_proxy.rb' @@ -1434,7 +1433,6 @@ Layout/LineLength: - 'ee/spec/models/concerns/ee/noteable_spec.rb' - 'ee/spec/models/concerns/ee/project_security_scanners_information_spec.rb' - 'ee/spec/models/concerns/elastic/application_versioned_search_spec.rb' - - 'ee/spec/models/concerns/elastic/issue_spec.rb' - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' - 'ee/spec/models/concerns/elastic/repository_spec.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 40759c45ebc..dddd82cc01e 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -5,7 +5,6 @@ Lint/RedundantCopDisableDirective: # Temporarily disabled due to too many offenses Enabled: false Exclude: - - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - 'app/controllers/groups/milestones_controller.rb' - 'app/models/concerns/integrations/base/integration.rb' - 'app/models/work_items/type.rb' @@ -13,15 +12,12 @@ Lint/RedundantCopDisableDirective: - 'app/services/ci/runners/set_runner_associated_projects_service.rb' - 'app/services/work_items/data_sync/clone_service.rb' - 'app/services/work_items/data_sync/move_service.rb' - - 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb' - - 'config/initializers/warden.rb' - 'db/migrate/20241021082113_create_partitioned_ci_runners.rb' - 'db/migrate/20241024204816_create_partitioned_ci_runner_managers.rb' - 'db/post_migrate/20241021163518_drop_user_canonical_emails_table.rb' - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/models/ee/audit_events/project_audit_event.rb' - 'ee/app/services/search/zoekt/routing_service.rb' - - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb' - 'ee/spec/features/groups/settings/domain_verification_spec.rb' @@ -33,9 +29,6 @@ Lint/RedundantCopDisableDirective: - 'ee/spec/support/shared_examples/features/dashboard_saml_reauth_banner_shared_examples.rb' - 'ee/spec/views/admin/users/show.html.haml_spec.rb' - 'lib/api/submodules.rb' - - 'lib/gitlab/auth/current_user_mode.rb' - - 'lib/gitlab/cleanup/personal_access_tokens.rb' - - 'lib/gitlab/lfs_token.rb' - 'lib/gitlab/popen/runner.rb' - 'qa/qa/resource/user_runners.rb' - 'qa/qa/service/docker_run/gitlab_runner.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 0a6a0ed3381..98302efec4d 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -246,7 +246,6 @@ Lint/UnusedMethodArgument: - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' - 'ee/lib/ee/gitlab/geo_git_access.rb' - 'ee/lib/elastic/as_json.rb' - - 'ee/lib/elastic/latest/issue_instance_proxy.rb' - 'ee/lib/elastic/latest/milestone_instance_proxy.rb' - 'ee/lib/elastic/latest/note_class_proxy.rb' - 'ee/lib/elastic/latest/note_instance_proxy.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 34c6f5812be..97ed6716fcf 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -207,7 +207,6 @@ Style/RedundantSelf: - 'ee/lib/gitlab/auth/smartcard.rb' - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb' - 'ee/lib/gitlab/elastic/client.rb' - - 'ee/lib/gitlab/elastic/document_reference.rb' - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/gitlab/geo.rb' - 'ee/lib/gitlab/geo/oauth/login_state.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 4cfad176261..0be3888df42 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -85bae8b147813e5a2e79f1a96ab0c30dee8ad6a1 +48b28c1cc502cdcafb209491ce21b84c42358c03 diff --git a/app/assets/javascripts/authentication/two_factor_auth/components/recovery_codes.vue b/app/assets/javascripts/authentication/two_factor_auth/components/recovery_codes.vue index fddb1377bf9..affa200392e 100644 --- a/app/assets/javascripts/authentication/two_factor_auth/components/recovery_codes.vue +++ b/app/assets/javascripts/authentication/two_factor_auth/components/recovery_codes.vue @@ -4,6 +4,7 @@ import { Mousetrap, MOUSETRAP_COPY_KEYBOARD_SHORTCUT } from '~/lib/mousetrap'; import { __ } from '~/locale'; import Tracking from '~/tracking'; import ClipboardButton from '~/vue_shared/components/clipboard_button.vue'; +import PageHeading from '~/vue_shared/components/page_heading.vue'; import { COPY_BUTTON_ACTION, DOWNLOAD_BUTTON_ACTION, @@ -33,7 +34,7 @@ export default { recoveryCodeDownloadFilename: RECOVERY_CODE_DOWNLOAD_FILENAME, i18n, mousetrap: null, - components: { GlSprintf, GlButton, GlAlert, ClipboardButton, GlCard }, + components: { GlSprintf, GlButton, GlAlert, ClipboardButton, GlCard, PageHeading }, mixins: [Tracking.mixin()], props: { codes: { @@ -100,20 +101,19 @@ export default {