From 2a134be97dafb4743eee8fc908463136ddf23b1f Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 5 May 2023 09:12:42 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/layout/line_length.yml | 2 - .../lint/redundant_cop_disable_directive.yml | 1 - .rubocop_todo/rails/pluck.yml | 3 - .../rspec/missing_feature_category.yml | 3 - .rubocop_todo/style/guard_clause.yml | 2 - .rubocop_todo/style/if_unless_modifier.yml | 2 - Gemfile | 4 +- Gemfile.checksum | 6 +- Gemfile.lock | 15 +- .../runner/components/runner_jobs_table.vue | 6 +- .../components/table/cells/duration_cell.vue | 4 +- .../lib/utils/datetime/date_format_utility.js | 41 +-- .../components/pipelines_list/time_ago.vue | 4 +- app/controllers/application_controller.rb | 9 - app/controllers/import/gitlab_controller.rb | 92 ----- app/models/application_setting.rb | 2 +- .../projects/_import_project_pane.html.haml | 5 - config/README.md | 4 + .../counts_28d/20210216183646_gitlab.yml | 4 +- .../counts_all/20210216180639_gitlab.yml | 4 +- config/routes/import.rb | 6 - danger/ci_tables/Dangerfile | 32 ++ danger/plugins/database_dictionary.rb | 10 + doc/api/settings.md | 2 +- .../testing_guide/frontend_testing.md | 9 +- doc/integration/jira/configure.md | 2 +- .../jira/jira_server_configuration.md | 31 +- doc/user/project/import/gitlab_com.md | 23 +- lib/api/settings.rb | 2 +- lib/gitlab/gitlab_import/client.rb | 89 ----- lib/gitlab/gitlab_import/importer.rb | 65 ---- lib/gitlab/gitlab_import/project_creator.rb | 30 -- lib/gitlab/import_sources.rb | 1 - lib/gitlab/kas/client.rb | 15 +- lib/gitlab/redis/wrapper.rb | 6 +- lib/gitlab/usage_data.rb | 1 - locale/gitlab.pot | 15 +- spec/config/mail_room_spec.rb | 21 +- .../import/gitlab_controller_spec.rb | 313 ------------------ .../conflicts_controller_spec.rb | 4 +- .../merge_requests/diffs_controller_spec.rb | 2 +- .../merge_request/user_sees_versions_spec.rb | 2 +- ...activates_mattermost_slash_command_spec.rb | 2 +- spec/features/projects/new_project_spec.rb | 21 -- .../datetime/date_format_utility_spec.js | 17 - .../lib/utils/datetime_utility_spec.js | 40 ++- spec/lib/gitlab/gitlab_import/client_spec.rb | 111 ------- .../lib/gitlab/gitlab_import/importer_spec.rb | 57 ---- .../gitlab_import/project_creator_spec.rb | 37 --- spec/lib/gitlab/import_sources_spec.rb | 7 +- spec/lib/gitlab/kas/client_spec.rb | 29 ++ spec/lib/gitlab/redis/cache_spec.rb | 1 + spec/lib/gitlab/redis/queues_spec.rb | 1 + spec/lib/gitlab/redis/shared_state_spec.rb | 1 + spec/lib/gitlab/redis/sidekiq_status_spec.rb | 1 + spec/lib/gitlab/usage_data_spec.rb | 8 +- spec/models/application_setting_spec.rb | 2 +- spec/routing/import_routing_spec.rb | 26 +- spec/support/capybara.rb | 54 ++- spec/support/rspec_order_todo.yml | 4 +- .../content_editor_shared_examples.rb | 1 - .../redis_new_instance_shared_examples.rb | 27 ++ .../redis/redis_shared_examples.rb | 28 ++ .../danger/database_dictionary_spec.rb | 152 +++++++++ tooling/danger/database_dictionary.rb | 57 ++++ workhorse/.tool-versions | 2 +- 66 files changed, 512 insertions(+), 1068 deletions(-) delete mode 100644 app/controllers/import/gitlab_controller.rb create mode 100644 danger/ci_tables/Dangerfile create mode 100644 danger/plugins/database_dictionary.rb delete mode 100644 lib/gitlab/gitlab_import/client.rb delete mode 100644 lib/gitlab/gitlab_import/importer.rb delete mode 100644 lib/gitlab/gitlab_import/project_creator.rb delete mode 100644 spec/controllers/import/gitlab_controller_spec.rb delete mode 100644 spec/lib/gitlab/gitlab_import/client_spec.rb delete mode 100644 spec/lib/gitlab/gitlab_import/importer_spec.rb delete mode 100644 spec/lib/gitlab/gitlab_import/project_creator_spec.rb create mode 100644 spec/tooling/danger/database_dictionary_spec.rb create mode 100644 tooling/danger/database_dictionary.rb diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 02c57e10ec5..c98021ba329 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -2834,8 +2834,6 @@ Layout/LineLength: - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - 'lib/gitlab/github_import/parallel_scheduling.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/gl_repository.rb' - 'lib/gitlab/global_id/deprecations.rb' - 'lib/gitlab/golang.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 236e5c6a35a..2723a4e6190 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -218,7 +218,6 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/git/patches/collection.rb' - 'lib/gitlab/github_import/markdown_text.rb' - 'lib/gitlab/github_import/user_finder.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - 'lib/gitlab/health_checks/metric.rb' - 'lib/gitlab/health_checks/probes/status.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 38a8fa7487a..0f8a4d54687 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -148,14 +148,11 @@ Rails/Pluck: - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb' - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' - 'spec/controllers/projects/starrers_controller_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/features/issues/csv_spec.rb' - - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index b4700bd8a7a..4c7a30a32ee 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -3811,9 +3811,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/single_endpoint_notes_importing_spec.rb' - 'spec/lib/gitlab/github_import/user_finder_spec.rb' - 'spec/lib/gitlab/github_import_spec.rb' - - 'spec/lib/gitlab/gitlab_import/client_spec.rb' - - 'spec/lib/gitlab/gitlab_import/importer_spec.rb' - - 'spec/lib/gitlab/gitlab_import/project_creator_spec.rb' - 'spec/lib/gitlab/gl_repository/identifier_spec.rb' - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'spec/lib/gitlab/gl_repository_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 09d838267d3..50a823c9ee8 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -528,8 +528,6 @@ Style/GuardClause: - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/object_counter.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 43cfa9b269d..7baf5978326 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -850,8 +850,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/representation/issue.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/golang.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - 'lib/gitlab/graphql/queries.rb' diff --git a/Gemfile b/Gemfile index 7efbbd92a34..7e25a3bae91 100644 --- a/Gemfile +++ b/Gemfile @@ -457,7 +457,7 @@ group :test do gem 'capybara', '~> 3.39' gem 'capybara-screenshot', '~> 1.0.26' - gem 'selenium-webdriver', '~> 3.142', '>= 3.142.7' + gem 'selenium-webdriver', '~> 4.9' gem 'graphlyte', '~> 1.0.0' @@ -510,7 +510,7 @@ gem 'spamcheck', '~> 1.3.0' gem 'gitaly', '~> 15.9.0-rc3' # KAS GRPC protocol definitions -gem 'kas-grpc', '~> 0.0.2' +gem 'kas-grpc', '~> 0.1.0' gem 'grpc', '~> 1.42.0' diff --git a/Gemfile.checksum b/Gemfile.checksum index ab4ef1a2562..8b9a45e5a19 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -76,7 +76,6 @@ {"name":"charlock_holmes","version":"0.7.7","platform":"ruby","checksum":"1790eca3f661ffa6bbf5866c53c7191e4b8472626fc4997ff9dbe7c425e2cb43"}, {"name":"chef-config","version":"16.10.17","platform":"ruby","checksum":"1f4961e4d6aa4df374f739c6f62ae1d2be03dcff1bd93e56d9c963b8a156747c"}, {"name":"chef-utils","version":"16.10.17","platform":"ruby","checksum":"a74253da6aab8ff92c955549536bdecbc4d1ce8032c8201576f2a8ef4e8ed7b3"}, -{"name":"childprocess","version":"3.0.0","platform":"ruby","checksum":"4579a87cdc962de252eebf1482a4185fad383ae7dbe29a746ba2be8e261280c5"}, {"name":"chunky_png","version":"1.3.5","platform":"ruby","checksum":"b6ab1011b2e79bcc973c92deee4110d071d5cd59ed950efcd0aba49a5f57c06d"}, {"name":"circuitbox","version":"2.0.0.pre5","platform":"ruby","checksum":"033d4820a9b688f0539630b81ae0d707ce8e6ccd34756de31a79063b190ffffc"}, {"name":"citrus","version":"3.0.2","platform":"ruby","checksum":"4ec2412fc389ad186735f4baee1460f7900a8e130ffe3f216b30d4f9c684f650"}, @@ -322,7 +321,7 @@ {"name":"kaminari-actionview","version":"1.2.2","platform":"ruby","checksum":"1330f6fc8b59a4a4ef6a549ff8a224797289ebf7a3a503e8c1652535287cc909"}, {"name":"kaminari-activerecord","version":"1.2.2","platform":"ruby","checksum":"0dd3a67bab356a356f36b3b7236bcb81cef313095365befe8e98057dd2472430"}, {"name":"kaminari-core","version":"1.2.2","platform":"ruby","checksum":"3bd26fec7370645af40ca73b9426a448d09b8a8ba7afa9ba3c3e0d39cdbb83ff"}, -{"name":"kas-grpc","version":"0.0.2","platform":"ruby","checksum":"111ff7515952e939f491297ba4c69a218b72d9d0ef8e5bff80a5df6a56df9a16"}, +{"name":"kas-grpc","version":"0.1.0","platform":"ruby","checksum":"b219c79b7bddf1f3ac6a78119e25b0b52c0c29608b3a80c75929c47f32a50dda"}, {"name":"knapsack","version":"1.21.1","platform":"ruby","checksum":"82f70422adebcacec1b514f6ebff65265fc85d836e3c320718a160d8ac41cf14"}, {"name":"kramdown","version":"2.3.2","platform":"ruby","checksum":"cb4530c2e9d16481591df2c9336723683c354e5416a5dd3e447fa48215a6a71c"}, {"name":"kramdown-parser-gfm","version":"1.1.0","platform":"ruby","checksum":"fb39745516427d2988543bf01fc4cf0ab1149476382393e0e9c48592f6581729"}, @@ -562,7 +561,7 @@ {"name":"sawyer","version":"0.9.2","platform":"ruby","checksum":"fa3a72d62a4525517b18857ddb78926aab3424de0129be6772a8e2ba240e7aca"}, {"name":"sd_notify","version":"0.1.1","platform":"ruby","checksum":"cbc7ac6caa7cedd26b30a72b5eeb6f36050dc0752df263452ea24fb5a4ad3131"}, {"name":"seed-fu","version":"2.3.7","platform":"ruby","checksum":"f19673443e9af799b730e3d4eca6a89b39e5a36825015dffd00d02ea3365cf74"}, -{"name":"selenium-webdriver","version":"3.142.7","platform":"ruby","checksum":"dea0993e0e4fdb364f0453144814c0e6099a411d17396807c6cac666d0ddac29"}, +{"name":"selenium-webdriver","version":"4.9.0","platform":"ruby","checksum":"0f5fc4118ab231e5ef1895b1e14a4366eb9d73d60a8e42b0d84f69cdfdd8b6cf"}, {"name":"semver_dialects","version":"1.2.1","platform":"ruby","checksum":"60a1f67659f79c51a667e8858ec9b089c1e4ce4f6d2a0f0b4ac101916946eb23"}, {"name":"sentry-rails","version":"5.8.0","platform":"ruby","checksum":"c11b2d909de2c2bfda793c45f64180fd784d54c46886338b683ee3f8efa7731b"}, {"name":"sentry-raven","version":"3.1.2","platform":"ruby","checksum":"103d3b122958810d34898ce2e705bcf549ddb9d855a70ce9a3970ee2484f364a"}, @@ -680,6 +679,7 @@ {"name":"webfinger","version":"1.2.0","platform":"ruby","checksum":"7814ef1c85da47514f65c6e5ca14205fa9ce41ea2a70785e0c872842162852a2"}, {"name":"webmock","version":"3.18.1","platform":"ruby","checksum":"54c955df4ae4bec6181dd266eeec632a1808288c633f9551d81bafb53921d2d7"}, {"name":"webrick","version":"1.8.1","platform":"ruby","checksum":"19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f"}, +{"name":"websocket","version":"1.2.9","platform":"ruby","checksum":"884b12dee993217795bb5f58acc89c0121c88bdc99df4d1636c0505dca352b36"}, {"name":"websocket-driver","version":"0.7.5","platform":"java","checksum":"fffa83aa188e9ac90e32a385832ec9d26acdf019538e1c7d703f2c8a323b39c8"}, {"name":"websocket-driver","version":"0.7.5","platform":"ruby","checksum":"a280c3f44dcbb0323d58bc78dc49350c05d589ab7d13267fcff08d9d5ae76b28"}, {"name":"websocket-extensions","version":"0.1.5","platform":"ruby","checksum":"1c6ba63092cda343eb53fc657110c71c754c56484aad42578495227d717a8241"}, diff --git a/Gemfile.lock b/Gemfile.lock index 4e0e15bd01a..f074a37cc8e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -303,7 +303,6 @@ GEM mixlib-shellout (>= 2.0, < 4.0) tomlrb (~> 1.2) chef-utils (16.10.17) - childprocess (3.0.0) chunky_png (1.3.5) circuitbox (2.0.0.pre5) citrus (3.0.2) @@ -871,7 +870,7 @@ GEM activerecord kaminari-core (= 1.2.2) kaminari-core (1.2.2) - kas-grpc (0.0.2) + kas-grpc (0.1.0) grpc (~> 1.0) knapsack (1.21.1) rake @@ -1404,9 +1403,10 @@ GEM seed-fu (2.3.7) activerecord (>= 3.1) activesupport (>= 3.1) - selenium-webdriver (3.142.7) - childprocess (>= 0.5, < 4.0) - rubyzip (>= 1.2.2) + selenium-webdriver (4.9.0) + rexml (~> 3.2, >= 3.2.5) + rubyzip (>= 1.2.2, < 3.0) + websocket (~> 1.0) semver_dialects (1.2.1) pastel (~> 0.8.0) thor (~> 1.2.0) @@ -1638,6 +1638,7 @@ GEM crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) webrick (1.8.1) + websocket (1.2.9) websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) @@ -1809,7 +1810,7 @@ DEPENDENCIES json_schemer (~> 0.2.18) jwt (~> 2.5) kaminari (~> 1.2.2) - kas-grpc (~> 0.0.2) + kas-grpc (~> 0.1.0) knapsack (~> 1.21.1) kramdown (~> 2.3.1) kubeclient (~> 4.11.0) @@ -1918,7 +1919,7 @@ DEPENDENCIES sassc-rails (~> 2.1.0) sd_notify (~> 0.1.0) seed-fu (~> 2.3.7) - selenium-webdriver (~> 3.142, >= 3.142.7) + selenium-webdriver (~> 4.9) semver_dialects (~> 1.2.1) sentry-rails (~> 5.8.0) sentry-raven (~> 3.1) diff --git a/app/assets/javascripts/ci/runner/components/runner_jobs_table.vue b/app/assets/javascripts/ci/runner/components/runner_jobs_table.vue index ebcda4f0ac3..5d8e9dcdee2 100644 --- a/app/assets/javascripts/ci/runner/components/runner_jobs_table.vue +++ b/app/assets/javascripts/ci/runner/components/runner_jobs_table.vue @@ -2,7 +2,7 @@ import { GlTableLite } from '@gitlab/ui'; import { __, s__ } from '~/locale'; import { getIdFromGraphQLId } from '~/graphql_shared/utils'; -import { durationTimeFormatted } from '~/lib/utils/datetime_utility'; +import { formatTime } from '~/lib/utils/datetime_utility'; import CiBadgeLink from '~/vue_shared/components/ci_badge_link.vue'; import RunnerTags from '~/ci/runner/components/runner_tags.vue'; import TimeAgo from '~/vue_shared/components/time_ago_tooltip.vue'; @@ -50,11 +50,11 @@ export default { }, duration(job) { const { duration } = job; - return duration ? durationTimeFormatted(duration) : ''; + return duration ? formatTime(duration * 1000) : ''; }, queued(job) { const { queuedDuration } = job; - return queuedDuration ? durationTimeFormatted(queuedDuration) : ''; + return queuedDuration ? formatTime(queuedDuration * 1000) : ''; }, }, fields: [ diff --git a/app/assets/javascripts/jobs/components/table/cells/duration_cell.vue b/app/assets/javascripts/jobs/components/table/cells/duration_cell.vue index d1b2da4d115..11593fa355a 100644 --- a/app/assets/javascripts/jobs/components/table/cells/duration_cell.vue +++ b/app/assets/javascripts/jobs/components/table/cells/duration_cell.vue @@ -1,6 +1,6 @@