From 2b9f6cfb3fc31259e923ca929d585b7fa643f39a Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 21 Jun 2023 06:08:36 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/layout/argument_alignment.yml | 39 ----- .../components/delete_merged_branches.vue | 7 +- .../components/details/package_files.vue | 30 ++-- app/views/projects/branches/_branch.html.haml | 6 +- ...nd_id_desc_on_merged_action_for_removal.rb | 17 ++ ...ability_reads_on_common_project_filters.rb | 18 ++ db/schema_migrations/20230619072744 | 1 + db/schema_migrations/20230619134106 | 1 + db/structure.sql | 2 +- doc/administration/integration/plantuml.md | 7 +- doc/api/settings.md | 21 ++- doc/development/migration_style_guide.md | 33 ++-- doc/development/software_design.md | 162 ++++++++++++++++++ doc/topics/offline/quick_start_guide.md | 2 +- doc/update/index.md | 9 + doc/user/admin_area/moderate_users.md | 27 +++ doc/user/group/compliance_frameworks.md | 31 +++- doc/user/project/settings/index.md | 19 +- locale/gitlab.pot | 9 + qa/qa/git/repository.rb | 2 +- qa/qa/page/project/branches/show.rb | 22 --- qa/qa/resource/repository/branch.rb | 52 ++++++ .../add_list_delete_branches_spec.rb | 77 +++++++++ .../add_list_delete_branches_spec.rb | 99 ----------- spec/features/admin/admin_mode/login_spec.rb | 6 +- ...activates_mattermost_slash_command_spec.rb | 2 +- spec/features/atom/issues_spec.rb | 14 +- spec/features/atom/merge_requests_spec.rb | 14 +- spec/features/atom/users_spec.rb | 36 ++-- spec/features/boards/issue_ordering_spec.rb | 16 +- spec/features/boards/multi_select_spec.rb | 16 +- spec/features/boards/sidebar_assignee_spec.rb | 5 +- spec/features/commits_spec.rb | 28 +-- spec/features/dashboard/activity_spec.rb | 14 +- .../dashboard/datetime_on_tooltips_spec.rb | 9 +- .../features/dashboard/merge_requests_spec.rb | 55 +++--- .../dashboard/todos/todos_sorting_spec.rb | 5 +- spec/features/dashboard/todos/todos_spec.rb | 25 +-- spec/features/projects/blobs/blame_spec.rb | 2 +- .../environments/environments_spec.rb | 2 +- .../projects/pipelines/pipelines_spec.rb | 2 +- .../delete_merged_branches_spec.js.snap | 5 +- .../components/delete_merged_branches_spec.js | 2 +- .../components/delete_issue_modal_spec.js | 9 +- .../components/details/package_files_spec.js | 12 +- 45 files changed, 637 insertions(+), 335 deletions(-) create mode 100644 db/post_migrate/20230619072744_schedule_index_events_on_project_id_and_id_desc_on_merged_action_for_removal.rb create mode 100644 db/post_migrate/20230619134106_prepare_index_for_vulnerability_reads_on_common_project_filters.rb create mode 100644 db/schema_migrations/20230619072744 create mode 100644 db/schema_migrations/20230619134106 create mode 100644 qa/qa/resource/repository/branch.rb create mode 100644 qa/qa/specs/features/api/3_create/repository/add_list_delete_branches_spec.rb delete mode 100644 qa/qa/specs/features/browser_ui/3_create/repository/add_list_delete_branches_spec.rb diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index ca7dba5c8db..5a145708439 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -1058,29 +1058,6 @@ Layout/ArgumentAlignment: - 'ee/spec/features/projects/merge_requests/user_edits_merge_request_spec.rb' - 'ee/spec/features/projects/milestones/milestone_spec.rb' - 'ee/spec/features/projects/security/user_views_security_configuration_spec.rb' - - 'ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_approval_settings_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_merge_pipelines_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_merge_requests_template_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_merge_trains_spec.rb' - - 'ee/spec/features/projects/settings/user_manages_approval_settings_spec.rb' - - 'ee/spec/features/projects/settings/user_manages_merge_requests_template_spec.rb' - - 'ee/spec/features/registrations/email_confirmation_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_company_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_company_joining_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_just_me_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_just_me_importing_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_just_me_joining_project_spec.rb' - - 'ee/spec/features/registrations/saas/subscription_flow_paid_plan_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_company_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_company_importing_project_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_just_me_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_just_me_importing_project_spec.rb' - - 'ee/spec/features/registrations/sign_up_with_trial_from_external_site_without_confirmation_spec.rb' - - 'ee/spec/features/search/elastic/global_search_spec.rb' - - 'ee/spec/features/search/elastic/group_search_spec.rb' - - 'ee/spec/features/security/project/discover_spec.rb' - - 'ee/spec/features/users/identity_verification_spec.rb' - 'ee/spec/frontend/fixtures/dora/metrics.rb' - 'ee/spec/frontend/fixtures/oncall_schedule.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' @@ -1570,22 +1547,6 @@ Layout/ArgumentAlignment: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' - 'spec/components/previews/pajamas/button_component_preview.rb' - - 'spec/features/admin/admin_mode/login_spec.rb' - - 'spec/features/admin/integrations/user_activates_mattermost_slash_command_spec.rb' - - 'spec/features/atom/issues_spec.rb' - - 'spec/features/atom/merge_requests_spec.rb' - - 'spec/features/atom/users_spec.rb' - - 'spec/features/boards/issue_ordering_spec.rb' - - 'spec/features/boards/multi_select_spec.rb' - - 'spec/features/boards/sidebar_assignee_spec.rb' - - 'spec/features/calendar_spec.rb' - - 'spec/features/clusters/cluster_health_dashboard_spec.rb' - - 'spec/features/commits_spec.rb' - - 'spec/features/dashboard/activity_spec.rb' - - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - - 'spec/features/dashboard/merge_requests_spec.rb' - - 'spec/features/dashboard/todos/todos_sorting_spec.rb' - - 'spec/features/dashboard/todos/todos_spec.rb' - 'spec/features/error_tracking/user_filters_errors_by_status_spec.rb' - 'spec/features/error_tracking/user_searches_sentry_errors_spec.rb' - 'spec/features/error_tracking/user_sees_error_details_spec.rb' diff --git a/app/assets/javascripts/branches/components/delete_merged_branches.vue b/app/assets/javascripts/branches/components/delete_merged_branches.vue index 117c15be907..50fe610d335 100644 --- a/app/assets/javascripts/branches/components/delete_merged_branches.vue +++ b/app/assets/javascripts/branches/components/delete_merged_branches.vue @@ -69,7 +69,7 @@ export default { this.openModal(); }, extraAttrs: { - 'data-qa-selector': 'delete_merged_branches_button', + 'data-testid': 'delete-merged-branches-button', class: 'gl-text-red-500!', }, }, @@ -102,12 +102,11 @@ export default { category="tertiary" no-caret placement="right" - data-qa-selector="delete_merged_branches_dropdown_button" class="gl-display-none gl-md-display-block!" :items="dropdownItems" /> {{ $options.i18n.deleteButtonText }} - - - {{ $options.i18n.deleteFile }} - - + + + +