From 2f2a542b6c45f925affeaa47d62c49dd450078b5 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 2 Aug 2024 03:08:59 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/rspec/context_wording.yml | 1 - .rubocop_todo/rspec/expect_change.yml | 1 - .rubocop_todo/rspec/feature_category.yml | 1 - .rubocop_todo/rspec/named_subject.yml | 1 - .../custom_emoji/components/list.vue | 4 +- app/helpers/emails_helper.rb | 5 +- .../admin/gitaly_servers/index.html.haml | 14 +- app/views/notify/closed_issue_email.text.haml | 2 +- .../created_flux_git_push_notifications.yml | 14 ++ config/events/request_api_proxy_access.yml | 14 ++ .../request_api_proxy_access_via_ci.yml | 14 ++ .../request_api_proxy_access_via_pat.yml | 14 ++ .../request_api_proxy_access_via_user.yml | 14 ++ config/gitlab_loose_foreign_keys.yml | 4 + ...kubernetes_agent_k8s_api_proxy_request.yml | 8 +- ...gent_flux_git_push_notifications_total.yml | 8 +- ...t_k8s_api_proxy_requests_via_ci_access.yml | 8 +- ...k8s_api_proxy_requests_via_user_access.yml | 8 +- ..._k8s_api_proxy_requests_via_pat_access.yml | 8 +- .../17-0-deprecate-support-for-OWASP-2017.yml | 2 +- data/deprecations/17-3-codeclimate.yml | 22 +++ ...error_tracking_error_events_project_id.yml | 9 + .../make_security_policy_bots_private.yml | 9 + db/docs/dast_site_tokens.yml | 2 +- db/docs/error_tracking_error_events.yml | 1 + ...oject_id_to_error_tracking_error_events.rb | 9 + ...projects_dast_site_tokens_project_id_fk.rb | 21 ++ ...queue_make_security_policy_bots_private.rb | 27 +++ ...ror_tracking_error_events_on_project_id.rb | 16 ++ ...ror_tracking_error_events_project_id_fk.rb | 16 ++ ...racking_error_events_project_id_trigger.rb | 25 +++ ..._error_tracking_error_events_project_id.rb | 40 ++++ db/schema_migrations/20240722075838 | 1 + db/schema_migrations/20240729124632 | 1 + db/schema_migrations/20240731160140 | 1 + db/schema_migrations/20240731160141 | 1 + db/schema_migrations/20240731160142 | 1 + db/schema_migrations/20240731160143 | 1 + db/schema_migrations/20240731160144 | 1 + db/structure.sql | 27 ++- doc/update/deprecations.md | 63 ++++-- .../iac_scanning/index.md | 55 ++++++ .../policies/scan-result-policies.md | 31 ++- .../policies/scan_execution_policies.md | 28 ++- .../vulnerability_report/index.md | 2 +- doc/user/compliance/audit_event_types.md | 62 +++--- .../index.md | 18 ++ doc/user/group/compliance_frameworks.md | 3 +- lib/api/helpers/kubernetes/agent_helpers.rb | 23 ++- ..._error_tracking_error_events_project_id.rb | 10 + .../make_security_policy_bots_private.rb | 13 ++ lib/gitlab/usage_data_counters.rb | 1 - .../kubernetes_agent_counter.rb | 40 ---- .../total_counter_redis_key_overrides.yml | 5 + locale/gitlab.pot | 6 +- .../custom_emoji/components/list_spec.js | 8 +- spec/helpers/emails_helper_spec.rb | 9 +- ...r_tracking_error_events_project_id_spec.rb | 15 ++ .../database/no_cross_db_foreign_keys_spec.rb | 3 +- .../kubernetes_agent_counter_spec.rb | 74 ------- ..._make_security_policy_bots_private_spec.rb | 26 +++ ...r_tracking_error_events_project_id_spec.rb | 33 ++++ spec/requests/api/internal/kubernetes_spec.rb | 183 ++++++++++++------ spec/support/rspec_order_todo.yml | 1 - ...ll_desired_sharding_key_shared_examples.rb | 47 +++-- 65 files changed, 812 insertions(+), 323 deletions(-) create mode 100644 config/events/created_flux_git_push_notifications.yml create mode 100644 config/events/request_api_proxy_access.yml create mode 100644 config/events/request_api_proxy_access_via_ci.yml create mode 100644 config/events/request_api_proxy_access_via_pat.yml create mode 100644 config/events/request_api_proxy_access_via_user.yml create mode 100644 data/deprecations/17-3-codeclimate.yml create mode 100644 db/docs/batched_background_migrations/backfill_error_tracking_error_events_project_id.yml create mode 100644 db/docs/batched_background_migrations/make_security_policy_bots_private.yml create mode 100644 db/migrate/20240731160140_add_project_id_to_error_tracking_error_events.rb create mode 100644 db/post_migrate/20240722075838_remove_projects_dast_site_tokens_project_id_fk.rb create mode 100644 db/post_migrate/20240729124632_queue_make_security_policy_bots_private.rb create mode 100644 db/post_migrate/20240731160141_index_error_tracking_error_events_on_project_id.rb create mode 100644 db/post_migrate/20240731160142_add_error_tracking_error_events_project_id_fk.rb create mode 100644 db/post_migrate/20240731160143_add_error_tracking_error_events_project_id_trigger.rb create mode 100644 db/post_migrate/20240731160144_queue_backfill_error_tracking_error_events_project_id.rb create mode 100644 db/schema_migrations/20240722075838 create mode 100644 db/schema_migrations/20240729124632 create mode 100644 db/schema_migrations/20240731160140 create mode 100644 db/schema_migrations/20240731160141 create mode 100644 db/schema_migrations/20240731160142 create mode 100644 db/schema_migrations/20240731160143 create mode 100644 db/schema_migrations/20240731160144 create mode 100644 lib/gitlab/background_migration/backfill_error_tracking_error_events_project_id.rb create mode 100644 lib/gitlab/background_migration/make_security_policy_bots_private.rb delete mode 100644 lib/gitlab/usage_data_counters/kubernetes_agent_counter.rb create mode 100644 spec/lib/gitlab/background_migration/backfill_error_tracking_error_events_project_id_spec.rb delete mode 100644 spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb create mode 100644 spec/migrations/20240729124632_queue_make_security_policy_bots_private_spec.rb create mode 100644 spec/migrations/20240731160144_queue_backfill_error_tracking_error_events_project_id_spec.rb diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 348ea807a4c..1198ba51c62 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1883,7 +1883,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - 'spec/lib/gitlab/usage_data_counters/ipynb_diff_activity_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' - 'spec/lib/gitlab/utils/mime_type_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 14326180862..aacfada6625 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -224,7 +224,6 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - 'spec/lib/gitlab/query_limiting/transaction_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index 083c7380fe4..26ca97386bf 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -3290,7 +3290,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/usage_data_counters/ipynb_diff_activity_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/package_event_counter_spec.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index b3846110664..1658e45f290 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -2305,7 +2305,6 @@ RSpec/NamedSubject: - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_metric_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/redis_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' diff --git a/app/assets/javascripts/custom_emoji/components/list.vue b/app/assets/javascripts/custom_emoji/components/list.vue index db3c2dc85ec..1267e0d4441 100644 --- a/app/assets/javascripts/custom_emoji/components/list.vue +++ b/app/assets/javascripts/custom_emoji/components/list.vue @@ -2,7 +2,7 @@