From 313ce461cafef54a87c1943b941dc1327246e1e2 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 6 Dec 2023 03:14:51 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../rspec/before_all_role_assignment.yml | 1 + .rubocop_todo/rspec/named_subject.yml | 1 + Gemfile.lock | 2 + .../notes/abuse_report_add_note.vue | 4 +- .../components/sidebar/sidebar.vue | 2 +- .../emoji/queries/custom_emoji.query.graphql | 2 +- .../work_items/components/item_title.vue | 21 +- .../components/notes/work_item_add_note.vue | 4 +- .../notes/work_item_notes_activity_header.vue | 14 +- .../components/work_item_detail.vue | 2 + .../work_items/components/work_item_notes.vue | 6 + .../work_items/components/work_item_title.vue | 12 +- .../framework/contextual_sidebar.scss | 4 - .../stylesheets/framework/variables.scss | 3 - .../stylesheets/page_bundles/build.scss | 5 +- app/assets/stylesheets/pages/note_form.scss | 1 - app/assets/stylesheets/themes/_dark.scss | 15 - .../protection/rule/delete.rb | 41 +++ app/graphql/types/mutation_type.rb | 1 + app/helpers/notes_helper.rb | 2 +- .../protection/delete_rule_service.rb | 45 +++ .../shared/_create_protected_branch.html.haml | 2 +- config/application.rb | 1 - ...et_server_importer_exponential_backoff.yml | 8 + config/initializers/7_redis.rb | 2 + ...o_bulk_imports_on_updated_at_and_status.rb | 17 + db/schema_migrations/20231124213241 | 1 + db/structure.sql | 2 + doc/.vale/gitlab/SubstitutionWarning.yml | 1 + .../monitoring/prometheus/gitlab_metrics.md | 2 + doc/administration/server_hooks.md | 4 +- doc/api/graphql/reference/index.md | 25 ++ doc/ci/environments/deployment_approvals.md | 15 +- doc/development/ai_features/index.md | 1 + .../documentation/styleguide/word_list.md | 5 + doc/gitlab-basics/start-using-git.md | 2 +- doc/topics/git/git_rebase.md | 318 ++++++++++-------- doc/user/project/git_attributes.md | 70 ++++ doc/user/project/merge_requests/conflicts.md | 4 +- .../project/merge_requests/methods/index.md | 2 +- doc/user/project/protected_branches.md | 2 +- .../settings/import_export_troubleshooting.md | 2 +- gems/gitlab-secret_detection/Gemfile.lock | 30 +- .../gitlab-secret_detection.gemspec | 7 +- .../lib/gitlab/secret_detection.rb | 6 +- .../lib/gitlab/secret_detection/finding.rb | 28 ++ .../lib/gitlab/secret_detection/response.rb | 28 ++ .../lib/gitlab/secret_detection/scan.rb | 193 +++++++++++ .../lib/gitlab/secret_detection/status.rb | 16 + .../gitlab-secret_detection/lib/gitleaks.toml | 49 +++ .../spec/gitlab/secret_detection_spec.rb | 7 - .../lib/gitlab/secret_detection/scan_spec.rb | 199 +++++++++++ lib/bitbucket_server/connection.rb | 38 ++- lib/bitbucket_server/retry_with_delay.rb | 32 ++ lib/gitlab/instrumentation/connection_pool.rb | 40 +++ lib/gitlab/redis/wrapper.rb | 2 +- locale/gitlab.pot | 6 +- package.json | 2 +- .../notes/abuse_report_add_note_spec.js | 2 +- .../work_items/components/item_title_spec.js | 9 +- .../work_item_notes_activity_header_spec.js | 18 +- spec/lib/bitbucket_server/client_spec.rb | 2 +- spec/lib/bitbucket_server/connection_spec.rb | 149 ++++++-- .../bitbucket_server/retry_with_delay_spec.rb | 60 ++++ .../instrumentation/connection_pool_spec.rb | 69 ++++ .../protection/rule/delete_spec.rb | 102 ++++++ .../protection/delete_rule_service_spec.rb | 106 ++++++ .../redis/redis_shared_examples.rb | 6 +- yarn.lock | 8 +- 69 files changed, 1603 insertions(+), 285 deletions(-) create mode 100644 app/graphql/mutations/container_registry/protection/rule/delete.rb create mode 100644 app/services/container_registry/protection/delete_rule_service.rb create mode 100644 config/feature_flags/development/bitbucket_server_importer_exponential_backoff.yml create mode 100644 db/post_migrate/20231124213241_add_index_to_bulk_imports_on_updated_at_and_status.rb create mode 100644 db/schema_migrations/20231124213241 create mode 100644 gems/gitlab-secret_detection/lib/gitlab/secret_detection/finding.rb create mode 100644 gems/gitlab-secret_detection/lib/gitlab/secret_detection/response.rb create mode 100644 gems/gitlab-secret_detection/lib/gitlab/secret_detection/scan.rb create mode 100644 gems/gitlab-secret_detection/lib/gitlab/secret_detection/status.rb create mode 100644 gems/gitlab-secret_detection/lib/gitleaks.toml delete mode 100644 gems/gitlab-secret_detection/spec/gitlab/secret_detection_spec.rb create mode 100644 gems/gitlab-secret_detection/spec/lib/gitlab/secret_detection/scan_spec.rb create mode 100644 lib/bitbucket_server/retry_with_delay.rb create mode 100644 lib/gitlab/instrumentation/connection_pool.rb create mode 100644 spec/lib/bitbucket_server/retry_with_delay_spec.rb create mode 100644 spec/lib/gitlab/instrumentation/connection_pool_spec.rb create mode 100644 spec/requests/api/graphql/mutations/container_registry/protection/rule/delete_spec.rb create mode 100644 spec/services/container_registry/protection/delete_rule_service_spec.rb diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index 5ab492b4a29..7f4eeeb3d00 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -1098,6 +1098,7 @@ RSpec/BeforeAllRoleAssignment: - 'spec/lib/bulk_imports/projects/pipelines/ci_pipelines_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/commit_notes_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/legacy_references_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/merge_requests_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/pipeline_schedules_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index dd4928d9c8a..bcb59ffbcb7 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -1770,6 +1770,7 @@ RSpec/NamedSubject: - 'spec/lib/bulk_imports/projects/graphql/get_project_query_spec.rb' - 'spec/lib/bulk_imports/projects/graphql/get_repository_query_spec.rb' - 'spec/lib/bulk_imports/projects/graphql/get_snippet_repository_query_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/legacy_references_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/references_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/stage_spec.rb' - 'spec/lib/bulk_imports/source_url_builder_spec.rb' diff --git a/Gemfile.lock b/Gemfile.lock index 6ef11ee6a13..bce114b23e8 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -65,6 +65,8 @@ PATH remote: gems/gitlab-secret_detection specs: gitlab-secret_detection (0.1.0) + re2 (~> 2.4) + toml-rb (~> 2.2) PATH remote: gems/gitlab-utils diff --git a/app/assets/javascripts/admin/abuse_report/components/notes/abuse_report_add_note.vue b/app/assets/javascripts/admin/abuse_report/components/notes/abuse_report_add_note.vue index d13d7611143..a1e2c3f3c7a 100644 --- a/app/assets/javascripts/admin/abuse_report/components/notes/abuse_report_add_note.vue +++ b/app/assets/javascripts/admin/abuse_report/components/notes/abuse_report_add_note.vue @@ -8,7 +8,7 @@ import AbuseReportCommentForm from './abuse_report_comment_form.vue'; export default { name: 'AbuseReportAddNote', i18n: { - reply: __('Reply'), + reply: __('Reply…'), replyToComment: __('Reply to comment'), commentError: __('Your comment could not be submitted because %{reason}.'), genericError: __( @@ -139,7 +139,7 @@ export default { v-else ref="textarea" rows="1" - class="reply-placeholder-text-field gl-font-regular!" + class="reply-placeholder-text-field" data-testid="abuse-report-note-reply-textarea" :placeholder="$options.i18n.reply" :aria-label="$options.i18n.replyToComment" diff --git a/app/assets/javascripts/ci/job_details/components/sidebar/sidebar.vue b/app/assets/javascripts/ci/job_details/components/sidebar/sidebar.vue index 231f45d7ae6..08eaa7c8ecd 100644 --- a/app/assets/javascripts/ci/job_details/components/sidebar/sidebar.vue +++ b/app/assets/javascripts/ci/job_details/components/sidebar/sidebar.vue @@ -85,7 +85,7 @@ export default { };