From 374f3dee7dc0fae10a34daf503b8bf3078008f4b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 2 Mar 2023 09:08:22 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../rspec/missing_feature_category.yml | 37 -- GITALY_SERVER_VERSION | 2 +- .../notes/components/note_header.vue | 2 +- .../components/toggle_replies_widget.vue | 4 +- .../components/notes/work_item_add_note.vue | 14 +- .../notes/work_item_comment_locked.vue | 2 +- .../components/notes/work_item_discussion.vue | 14 +- .../components/notes/work_item_note.vue | 75 +-- .../components/notes/work_item_note_body.vue | 15 +- .../notes/work_item_note_signed_out.vue | 2 +- .../components/work_item_detail.vue | 455 +++++++++--------- .../stylesheets/page_bundles/work_items.scss | 10 +- .../groups/accepting_project_shares_finder.rb | 2 +- db/fixtures/development/24_forks.rb | 2 +- ...rability_reads_trigger_to_set_has_issue.rb | 185 +++++++ ...0208125736_schedule_migration_for_links.rb | 25 + db/schema_migrations/20230208125736 | 1 + db/schema_migrations/20230216142836 | 1 + db/structure.sql | 22 +- doc/administration/get_started.md | 3 +- .../postgresql/multiple_databases.md | 89 +++- doc/development/bulk_import.md | 9 +- doc/development/import_project.md | 31 +- .../exploratory_testing.md | 1 + doc/raketasks/restore_gitlab.md | 4 +- doc/user/analytics/value_streams_dashboard.md | 3 +- .../compliance/compliance_report/index.md | 150 +++--- doc/user/group/import/index.md | 3 +- doc/user/project/settings/import_export.md | 4 +- doc/user/project/wiki/group.md | 8 +- ...igrate_links_for_vulnerability_findings.rb | 79 +++ .../migrations/constraints_helpers.rb | 40 +- locale/gitlab.pot | 6 +- .../user_creates_image_diff_notes_spec.rb | 2 +- .../notes/work_item_discussion_spec.js | 8 +- ...e_links_for_vulnerability_findings_spec.rb | 141 ++++++ .../migrations/constraints_helpers_spec.rb | 35 +- ...25736_schedule_migration_for_links_spec.rb | 31 ++ spec/requests/api/projects_spec.rb | 24 +- .../agent_tokens/track_usage_service_spec.rb | 2 +- .../clusters/agents/create_service_spec.rb | 2 +- .../delete_expired_events_service_spec.rb | 2 +- .../clusters/agents/delete_service_spec.rb | 2 +- ...build_kubernetes_namespace_service_spec.rb | 2 +- spec/services/clusters/build_service_spec.rb | 2 +- .../cleanup/project_namespace_service_spec.rb | 2 +- .../cleanup/service_account_service_spec.rb | 2 +- spec/services/clusters/create_service_spec.rb | 2 +- .../services/clusters/destroy_service_spec.rb | 2 +- .../integrations/create_service_spec.rb | 2 +- .../prometheus_health_check_service_spec.rb | 2 +- ...create_or_update_namespace_service_spec.rb | 2 +- ..._or_update_service_account_service_spec.rb | 2 +- .../fetch_kubernetes_token_service_spec.rb | 2 +- spec/services/clusters/kubernetes_spec.rb | 2 +- ...gement_project_permissions_service_spec.rb | 2 +- spec/services/clusters/update_service_spec.rb | 2 +- .../commits/cherry_pick_service_spec.rb | 2 +- .../commits/commit_patch_service_spec.rb | 2 +- spec/services/commits/tag_service_spec.rb | 2 +- .../concerns/audit_event_save_type_spec.rb | 2 +- .../concerns/exclusive_lease_guard_spec.rb | 2 +- .../assigns_merge_params_spec.rb | 2 +- .../concerns/rate_limited_service_spec.rb | 2 +- .../features/work_items_shared_examples.rb | 2 +- 65 files changed, 1097 insertions(+), 496 deletions(-) create mode 100644 db/migrate/20230216142836_update_vulnerability_reads_trigger_to_set_has_issue.rb create mode 100644 db/post_migrate/20230208125736_schedule_migration_for_links.rb create mode 100644 db/schema_migrations/20230208125736 create mode 100644 db/schema_migrations/20230216142836 create mode 100644 lib/gitlab/background_migration/migrate_links_for_vulnerability_findings.rb create mode 100644 spec/lib/gitlab/background_migration/migrate_links_for_vulnerability_findings_spec.rb create mode 100644 spec/migrations/20230208125736_schedule_migration_for_links_spec.rb diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index f7f8de0f90b..8817e8039d4 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -1775,11 +1775,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/ci_cd/github_integration_setup_service_spec.rb' - 'ee/spec/services/ci_cd/github_setup_service_spec.rb' - 'ee/spec/services/ci_cd/setup_project_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' - - 'ee/spec/services/compliance_management/merge_requests/create_compliance_violations_service_spec.rb' - - 'ee/spec/services/concerns/epics/related_epic_links/usage_data_helper_spec.rb' - 'ee/spec/services/dashboard/environments/list_service_spec.rb' - 'ee/spec/services/dashboard/operations/list_service_spec.rb' - 'ee/spec/services/dashboard/projects/create_service_spec.rb' @@ -1793,7 +1788,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb' - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - 'ee/spec/services/ee/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'ee/spec/services/ee/commits/create_service_spec.rb' - 'ee/spec/services/ee/deployments/update_environment_service_spec.rb' - 'ee/spec/services/ee/design_management/delete_designs_service_spec.rb' - 'ee/spec/services/ee/design_management/save_designs_service_spec.rb' @@ -3775,7 +3769,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/feature/gitaly_spec.rb' - 'spec/lib/file_size_validator_spec.rb' - 'spec/lib/forever_spec.rb' - - 'spec/lib/generators/gitlab/snowplow_event_definition_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_definition/redis_hll_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_definition_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_generator_spec.rb' @@ -6153,7 +6146,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/protectable_dropdown_spec.rb' - 'spec/models/protected_branch/merge_access_level_spec.rb' - 'spec/models/protected_branch/push_access_level_spec.rb' - - 'spec/models/protected_branch_spec.rb' - 'spec/models/protected_tag_spec.rb' - 'spec/models/push_event_payload_spec.rb' - 'spec/models/push_event_spec.rb' @@ -6827,34 +6819,8 @@ RSpec/MissingFeatureCategory: - 'spec/services/ci/update_build_queue_service_spec.rb' - 'spec/services/ci/update_instance_variables_service_spec.rb' - 'spec/services/ci/update_pending_build_service_spec.rb' - - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' - - 'spec/services/clusters/agents/create_activity_event_service_spec.rb' - - 'spec/services/clusters/agents/create_service_spec.rb' - - 'spec/services/clusters/agents/delete_expired_events_service_spec.rb' - - 'spec/services/clusters/agents/delete_service_spec.rb' - - 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb' - - 'spec/services/clusters/build_service_spec.rb' - - 'spec/services/clusters/cleanup/project_namespace_service_spec.rb' - - 'spec/services/clusters/cleanup/service_account_service_spec.rb' - - 'spec/services/clusters/create_service_spec.rb' - - 'spec/services/clusters/destroy_service_spec.rb' - - 'spec/services/clusters/integrations/create_service_spec.rb' - - 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - - 'spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb' - - 'spec/services/clusters/kubernetes_spec.rb' - - 'spec/services/clusters/management/validate_management_project_permissions_service_spec.rb' - - 'spec/services/clusters/update_service_spec.rb' - 'spec/services/cohorts_service_spec.rb' - - 'spec/services/commits/cherry_pick_service_spec.rb' - - 'spec/services/commits/commit_patch_service_spec.rb' - - 'spec/services/commits/tag_service_spec.rb' - 'spec/services/compare_service_spec.rb' - - 'spec/services/concerns/audit_event_save_type_spec.rb' - - 'spec/services/concerns/exclusive_lease_guard_spec.rb' - - 'spec/services/concerns/merge_requests/assigns_merge_params_spec.rb' - - 'spec/services/concerns/rate_limited_service_spec.rb' - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - 'spec/services/container_expiration_policies/update_service_spec.rb' - 'spec/services/customer_relations/contacts/create_service_spec.rb' @@ -7238,7 +7204,6 @@ RSpec/MissingFeatureCategory: - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_import_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_link_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' - 'spec/services/projects/move_access_service_spec.rb' - 'spec/services/projects/move_deploy_keys_projects_service_spec.rb' @@ -7871,7 +7836,6 @@ RSpec/MissingFeatureCategory: - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/gitlab_shell_worker_spec.rb' - 'spec/workers/google_cloud/create_cloudsql_instance_worker_spec.rb' - - 'spec/workers/group_destroy_worker_spec.rb' - 'spec/workers/group_export_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/groups/update_statistics_worker_spec.rb' @@ -7968,7 +7932,6 @@ RSpec/MissingFeatureCategory: - 'spec/workers/post_receive_spec.rb' - 'spec/workers/process_commit_worker_spec.rb' - 'spec/workers/project_cache_worker_spec.rb' - - 'spec/workers/project_destroy_worker_spec.rb' - 'spec/workers/project_export_worker_spec.rb' - 'spec/workers/projects/after_import_worker_spec.rb' - 'spec/workers/projects/finalize_project_statistics_refresh_worker_spec.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 40b9cacdd09..45f6226a5e1 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -212f0e3545668faeb671dac213eaf25be5840bc0 +c7695bd902060be80b3499ffd2bd9e86d89c4f4f diff --git a/app/assets/javascripts/notes/components/note_header.vue b/app/assets/javascripts/notes/components/note_header.vue index c83b3d870d7..4af8cf1ded3 100644 --- a/app/assets/javascripts/notes/components/note_header.vue +++ b/app/assets/javascripts/notes/components/note_header.vue @@ -167,7 +167,7 @@ export default { @{{ author.username }} diff --git a/app/assets/javascripts/notes/components/toggle_replies_widget.vue b/app/assets/javascripts/notes/components/toggle_replies_widget.vue index 4437d461308..cf8fe8f2b33 100644 --- a/app/assets/javascripts/notes/components/toggle_replies_widget.vue +++ b/app/assets/javascripts/notes/components/toggle_replies_widget.vue @@ -76,7 +76,7 @@ export default { v-for="author in uniqueAuthors" :key="author.username" class="gl-mr-3 reply-author-avatar" - :link-href="author.path" + :link-href="author.path || author.webUrl" :img-alt="author.name" img-css-classes="gl-mr-0!" :img-src="author.avatar_url || author.avatarUrl" @@ -95,7 +95,7 @@ export default {