From 3c5195204b69df0bc69a0c98c7d61d258dc39866 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 15 Dec 2022 06:07:50 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .eslintrc.yml | 2 +- .../admin/users/components/actions/ban.vue | 4 +- .../components/issuable_header_warnings.vue | 6 +- .../components/notes/system_note.vue | 229 ++++++++++++++ .../components/work_item_detail.vue | 19 +- .../components/work_item_detail_modal.vue | 1 + .../work_items/components/work_item_notes.vue | 109 +++++++ .../javascripts/work_items/constants.js | 2 + .../graphql/discussion.fragment.graphql | 12 + .../graphql/work_item_notes.query.graphql | 27 ++ .../work_item_notes_by_iid.query.graphql | 32 ++ .../work_item_widgets.fragment.graphql | 3 + app/assets/javascripts/work_items/utils.js | 6 + .../merge_requests/application_controller.rb | 4 - app/finders/issuable_finder.rb | 5 +- app/finders/issuable_finder/params.rb | 5 - app/finders/issues_finder.rb | 2 +- app/finders/issues_finder/params.rb | 8 +- .../concerns/resolves_merge_requests.rb | 2 +- app/helpers/issuables_helper.rb | 16 +- app/helpers/issues_helper.rb | 12 + app/models/bulk_imports/tracker.rb | 2 +- app/models/concerns/issuable.rb | 12 - app/models/issue.rb | 12 + app/policies/issuable_policy.rb | 3 - app/policies/issue_policy.rb | 3 + app/policies/merge_request_policy.rb | 4 - app/views/projects/issues/_issue.html.haml | 2 +- .../merge_requests/_merge_request.html.haml | 1 - .../merge_requests/_mr_title.html.haml | 2 +- .../issue_type/_details_header.html.haml | 2 +- app/workers/bulk_imports/entity_worker.rb | 2 + .../bulk_imports/export_request_worker.rb | 66 ++-- app/workers/bulk_imports/pipeline_worker.rb | 120 +++----- .../testing_guide/contract/index.md | 2 + doc/user/admin_area/moderate_users.md | 2 +- doc/user/project/import/bitbucket_server.md | 4 + doc/user/project/import/github.md | 7 +- jest.config.base.js | 2 +- jest.config.contract.js | 6 + locale/gitlab.pot | 8 +- package.json | 1 + qa/Gemfile | 2 +- qa/Gemfile.lock | 4 +- qa/README.md | 37 +++ qa/qa/support/page/logging.rb | 5 +- qa/spec/page/logging_spec.rb | 9 + spec/contracts/consumer/.node-version | 1 - spec/contracts/consumer/package.json | 3 + spec/contracts/provider/spec_helper.rb | 9 + spec/factories/bulk_import/trackers.rb | 9 +- .../admin_views_hidden_merge_request_spec.rb | 26 -- .../admin_views_hidden_merge_requests_spec.rb | 26 -- .../issuable_header_warnings_spec.js | 3 +- .../components/notes/system_note_spec.js | 111 +++++++ .../components/work_item_notes_spec.js | 107 +++++++ spec/frontend/work_items/mock_data.js | 285 ++++++++++++++++++ spec/helpers/issuables_helper_spec.rb | 62 ---- spec/helpers/issues_helper_spec.rb | 51 ++++ spec/models/bulk_imports/tracker_spec.rb | 5 +- spec/models/concerns/issuable_spec.rb | 47 --- spec/models/issue_spec.rb | 20 ++ spec/policies/merge_request_policy_spec.rb | 16 - .../merge_requests_controller_spec.rb | 26 +- .../bulk_imports/entity_worker_spec.rb | 2 + .../export_request_worker_spec.rb | 90 ++---- .../bulk_imports/pipeline_worker_spec.rb | 175 ++++++++--- spec/workers/every_sidekiq_worker_spec.rb | 1 + 68 files changed, 1389 insertions(+), 512 deletions(-) create mode 100644 app/assets/javascripts/work_items/components/notes/system_note.vue create mode 100644 app/assets/javascripts/work_items/components/work_item_notes.vue create mode 100644 app/assets/javascripts/work_items/graphql/discussion.fragment.graphql create mode 100644 app/assets/javascripts/work_items/graphql/work_item_notes.query.graphql create mode 100644 app/assets/javascripts/work_items/graphql/work_item_notes_by_iid.query.graphql create mode 100644 jest.config.contract.js delete mode 100644 spec/contracts/consumer/.node-version delete mode 100644 spec/features/merge_request/admin_views_hidden_merge_request_spec.rb delete mode 100644 spec/features/merge_requests/admin_views_hidden_merge_requests_spec.rb create mode 100644 spec/frontend/work_items/components/notes/system_note_spec.js create mode 100644 spec/frontend/work_items/components/work_item_notes_spec.js diff --git a/.eslintrc.yml b/.eslintrc.yml index d2bae1b21b3..4a7197e3bd5 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -193,6 +193,6 @@ overrides: '@graphql-eslint/no-unused-fragments': error '@graphql-eslint/no-duplicate-fields': error - files: - - 'spec/contracts/consumer/**/*' + - '{,ee/}spec/contracts/consumer/**/*' rules: '@gitlab/require-i18n-strings': off diff --git a/app/assets/javascripts/admin/users/components/actions/ban.vue b/app/assets/javascripts/admin/users/components/actions/ban.vue index 898a688c203..55938832dce 100644 --- a/app/assets/javascripts/admin/users/components/actions/ban.vue +++ b/app/assets/javascripts/admin/users/components/actions/ban.vue @@ -11,9 +11,7 @@ const messageHtml = `

${s__('AdminUsers|You can unban their account in the future. Their data remains intact.')}

${sprintf( diff --git a/app/assets/javascripts/issuable/components/issuable_header_warnings.vue b/app/assets/javascripts/issuable/components/issuable_header_warnings.vue index a84187ab86b..543dca0afe1 100644 --- a/app/assets/javascripts/issuable/components/issuable_header_warnings.vue +++ b/app/assets/javascripts/issuable/components/issuable_header_warnings.vue @@ -1,7 +1,7 @@ + + diff --git a/app/assets/javascripts/work_items/components/work_item_detail.vue b/app/assets/javascripts/work_items/components/work_item_detail.vue index e0ebc714dbb..4c5c5eb9de9 100644 --- a/app/assets/javascripts/work_items/components/work_item_detail.vue +++ b/app/assets/javascripts/work_items/components/work_item_detail.vue @@ -30,6 +30,7 @@ import { WIDGET_TYPE_ITERATION, WORK_ITEM_TYPE_VALUE_ISSUE, WORK_ITEM_TYPE_VALUE_OBJECTIVE, + WIDGET_TYPE_NOTES, } from '../constants'; import workItemDatesSubscription from '../graphql/work_item_dates.subscription.graphql'; @@ -49,6 +50,7 @@ import WorkItemDueDate from './work_item_due_date.vue'; import WorkItemAssignees from './work_item_assignees.vue'; import WorkItemLabels from './work_item_labels.vue'; import WorkItemMilestone from './work_item_milestone.vue'; +import WorkItemNotes from './work_item_notes.vue'; export default { i18n, @@ -75,6 +77,7 @@ export default { WorkItemIteration: () => import('ee_component/work_items/components/work_item_iteration.vue'), WorkItemMilestone, WorkItemTree, + WorkItemNotes, }, mixins: [glFeatureFlagMixin()], inject: ['fullPath'], @@ -258,6 +261,9 @@ export default { workItemMilestone() { return this.isWidgetPresent(WIDGET_TYPE_MILESTONE); }, + workItemNotes() { + return this.isWidgetPresent(WIDGET_TYPE_NOTES); + }, fetchByIid() { return this.glFeatures.useIidInWorkItemsPath && parseBoolean(getParameterByName('iid_path')); }, @@ -428,7 +434,7 @@ export default {