From 3d42e098d9658853984534c9dfc2bf76284a8ac0 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 8 Feb 2023 21:11:09 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../components/toolbar_more_dropdown.vue | 113 ++++--- .../security_patch_upgrade_alert.vue | 76 ----- .../javascripts/gitlab_version_check/index.js | 25 -- .../components/inbound_token_access.vue | 258 +++++++++++++++ ...n_access.vue => outbound_token_access.vue} | 30 +- .../components/token_access_app.vue | 27 ++ .../components/token_projects_table.vue | 29 +- ...roject_ci_job_token_scope.mutation.graphql | 7 + ...roject_ci_job_token_scope.mutation.graphql | 7 + ...update_ci_job_token_scope.mutation.graphql | 8 + ...bound_get_ci_job_token_scope.query.graphql | 8 + ...ects_with_ci_job_token_scope.query.graphql | 18 + app/assets/javascripts/token_access/index.js | 4 +- app/controllers/explore/groups_controller.rb | 4 +- .../projects/settings/ci_cd_controller.rb | 1 + app/helpers/version_check_helper.rb | 6 +- app/models/repository.rb | 14 +- .../_security_patch_upgrade_alert.html.haml | 1 - .../development/critical_security_alert.yml | 8 - .../development/optimized_head_tree.yml | 8 - .../experiment/generic_explore_groups.yml | 8 + .../15-9-praefect-metrics-config-variable.yml | 25 +- db/docs/ar_internal_metadata.yml | 7 +- db/docs/dast_profiles_tags.yml | 4 +- db/docs/dast_scanner_profiles_tags.yml | 5 +- doc/ci/runners/configure_runners.md | 4 +- doc/ci/runners/runners_scope.md | 21 +- doc/update/deprecations.md | 11 +- doc/update/index.md | 24 +- doc/user/ssh.md | 15 + lib/tasks/gitlab/db.rake | 9 +- locale/gitlab.pot | 36 +- package.json | 4 +- .../explore/groups_controller_spec.rb | 8 + .../components/toolbar_more_dropdown_spec.js | 15 +- .../security_patch_upgrade_alert_spec.js | 84 ----- .../gitlab_version_check/index_spec.js | 19 +- .../gitlab_version_check/mock_data.js | 6 - .../token_access/inbound_token_access_spec.js | 311 ++++++++++++++++++ spec/frontend/token_access/mock_data.js | 96 ++++++ ..._spec.js => outbound_token_access_spec.js} | 25 +- .../token_access/token_access_app_spec.js | 47 +++ .../token_access/token_projects_table_spec.js | 7 +- spec/helpers/version_check_helper_spec.rb | 31 +- spec/models/repository_spec.rb | 51 +-- ...rity_patch_upgrade_alert.html.haml_spec.rb | 4 - yarn.lock | 16 +- 47 files changed, 1053 insertions(+), 492 deletions(-) delete mode 100644 app/assets/javascripts/gitlab_version_check/components/security_patch_upgrade_alert.vue create mode 100644 app/assets/javascripts/token_access/components/inbound_token_access.vue rename app/assets/javascripts/token_access/components/{token_access.vue => outbound_token_access.vue} (91%) create mode 100644 app/assets/javascripts/token_access/components/token_access_app.vue create mode 100644 app/assets/javascripts/token_access/graphql/mutations/inbound_add_project_ci_job_token_scope.mutation.graphql create mode 100644 app/assets/javascripts/token_access/graphql/mutations/inbound_remove_project_ci_job_token_scope.mutation.graphql create mode 100644 app/assets/javascripts/token_access/graphql/mutations/inbound_update_ci_job_token_scope.mutation.graphql create mode 100644 app/assets/javascripts/token_access/graphql/queries/inbound_get_ci_job_token_scope.query.graphql create mode 100644 app/assets/javascripts/token_access/graphql/queries/inbound_get_projects_with_ci_job_token_scope.query.graphql delete mode 100644 config/feature_flags/development/critical_security_alert.yml delete mode 100644 config/feature_flags/development/optimized_head_tree.yml create mode 100644 config/feature_flags/experiment/generic_explore_groups.yml delete mode 100644 spec/frontend/gitlab_version_check/components/security_patch_upgrade_alert_spec.js create mode 100644 spec/frontend/token_access/inbound_token_access_spec.js rename spec/frontend/token_access/{token_access_spec.js => outbound_token_access_spec.js} (92%) create mode 100644 spec/frontend/token_access/token_access_app_spec.js diff --git a/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue b/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue index 93b31ea7d20..ca17443081c 100644 --- a/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue +++ b/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue @@ -1,18 +1,63 @@ diff --git a/app/assets/javascripts/gitlab_version_check/components/security_patch_upgrade_alert.vue b/app/assets/javascripts/gitlab_version_check/components/security_patch_upgrade_alert.vue deleted file mode 100644 index 89dc68ec73e..00000000000 --- a/app/assets/javascripts/gitlab_version_check/components/security_patch_upgrade_alert.vue +++ /dev/null @@ -1,76 +0,0 @@ - - - diff --git a/app/assets/javascripts/gitlab_version_check/index.js b/app/assets/javascripts/gitlab_version_check/index.js index edb7e9abe49..dff09d2cb51 100644 --- a/app/assets/javascripts/gitlab_version_check/index.js +++ b/app/assets/javascripts/gitlab_version_check/index.js @@ -1,7 +1,6 @@ import Vue from 'vue'; import { parseBoolean, convertObjectPropsToCamelCase } from '~/lib/utils/common_utils'; import GitlabVersionCheckBadge from './components/gitlab_version_check_badge.vue'; -import SecurityPatchUpgradeAlert from './components/security_patch_upgrade_alert.vue'; import SecurityPatchUpgradeAlertModal from './components/security_patch_upgrade_alert_modal.vue'; const mountGitlabVersionCheckBadge = (el) => { @@ -33,25 +32,6 @@ const mountGitlabVersionCheckBadge = (el) => { } }; -const mountSecurityPatchUpgradeAlert = (el) => { - const { currentVersion } = el.dataset; - - try { - return new Vue({ - el, - render(createElement) { - return createElement(SecurityPatchUpgradeAlert, { - props: { - currentVersion, - }, - }); - }, - }); - } catch { - return null; - } -}; - const mountSecurityPatchUpgradeAlertModal = (el) => { const { currentVersion, version } = el.dataset; @@ -78,16 +58,11 @@ const mountSecurityPatchUpgradeAlertModal = (el) => { export default () => { const renderedApps = []; - const securityPatchUpgradeAlert = document.getElementById('js-security-patch-upgrade-alert'); const securityPatchUpgradeAlertModal = document.getElementById( 'js-security-patch-upgrade-alert-modal', ); const versionCheckBadges = [...document.querySelectorAll('.js-gitlab-version-check-badge')]; - if (securityPatchUpgradeAlert) { - renderedApps.push(mountSecurityPatchUpgradeAlert(securityPatchUpgradeAlert)); - } - if (securityPatchUpgradeAlertModal) { renderedApps.push(mountSecurityPatchUpgradeAlertModal(securityPatchUpgradeAlertModal)); } diff --git a/app/assets/javascripts/token_access/components/inbound_token_access.vue b/app/assets/javascripts/token_access/components/inbound_token_access.vue new file mode 100644 index 00000000000..1a225550c95 --- /dev/null +++ b/app/assets/javascripts/token_access/components/inbound_token_access.vue @@ -0,0 +1,258 @@ + + diff --git a/app/assets/javascripts/token_access/components/token_access.vue b/app/assets/javascripts/token_access/components/outbound_token_access.vue similarity index 91% rename from app/assets/javascripts/token_access/components/token_access.vue rename to app/assets/javascripts/token_access/components/outbound_token_access.vue index 527f01f0a6f..47ec0910a7b 100644 --- a/app/assets/javascripts/token_access/components/token_access.vue +++ b/app/assets/javascripts/token_access/components/outbound_token_access.vue @@ -17,7 +17,6 @@ import removeProjectCIJobTokenScopeMutation from '../graphql/mutations/remove_pr import updateCIJobTokenScopeMutation from '../graphql/mutations/update_ci_job_token_scope.mutation.graphql'; import getCIJobTokenScopeQuery from '../graphql/queries/get_ci_job_token_scope.query.graphql'; import getProjectsWithCIJobTokenScopeQuery from '../graphql/queries/get_projects_with_ci_job_token_scope.query.graphql'; -import OptInJwt from './opt_in_jwt.vue'; import TokenProjectsTable from './token_projects_table.vue'; export default { @@ -36,6 +35,27 @@ export default { projectsFetchError: __('There was a problem fetching the projects'), scopeFetchError: __('There was a problem fetching the job token scope value'), }, + fields: [ + { + key: 'project', + label: __('Project that can be accessed'), + thClass: 'gl-border-t-none!', + columnClass: 'gl-w-40p', + }, + { + key: 'namespace', + label: __('Namespace'), + thClass: 'gl-border-t-none!', + columnClass: 'gl-w-40p', + }, + { + key: 'actions', + label: '', + tdClass: 'gl-text-right', + thClass: 'gl-border-t-none!', + columnClass: 'gl-w-10p', + }, + ], components: { GlAlert, GlButton, @@ -45,7 +65,6 @@ export default { GlLoadingIcon, GlSprintf, GlToggle, - OptInJwt, TokenProjectsTable, }, inject: { @@ -230,9 +249,12 @@ export default { > {{ $options.i18n.settingDisabledMessage }} - + - diff --git a/app/assets/javascripts/token_access/components/token_access_app.vue b/app/assets/javascripts/token_access/components/token_access_app.vue new file mode 100644 index 00000000000..410a6267dc8 --- /dev/null +++ b/app/assets/javascripts/token_access/components/token_access_app.vue @@ -0,0 +1,27 @@ + + diff --git a/app/assets/javascripts/token_access/components/token_projects_table.vue b/app/assets/javascripts/token_access/components/token_projects_table.vue index ce33478cbee..c00dd882895 100644 --- a/app/assets/javascripts/token_access/components/token_projects_table.vue +++ b/app/assets/javascripts/token_access/components/token_projects_table.vue @@ -1,32 +1,11 @@