From 3f11364a27599c5c8002affd68054fdfb4774b0f Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 11 Jun 2024 00:24:51 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/database.gitlab-ci.yml | 2 +- .gitlab/ci/global.gitlab-ci.yml | 2 +- .rubocop_todo/gitlab/bounded_contexts.yml | 30 --- Gemfile.checksum | 2 +- Gemfile.lock | 2 +- .../get_linked_pipelines.query.graphql | 2 + .../downstream_pipelines.vue | 84 ++++++++ .../get_pipeline_mini_graph.query.graphql | 7 +- .../legacy_linked_pipelines_mini_list.vue | 7 +- .../linked_pipelines_mini_list.vue | 118 ----------- .../pipeline_mini_graph.vue | 29 ++- .../ci/pipeline_mini_graph/pipeline_stage.vue | 7 +- app/models/concerns/protected_ref_access.rb | 1 + .../protected_branch/merge_access_level.rb | 1 - .../protected_branch/push_access_level.rb | 1 - .../protected_tag/create_access_level.rb | 1 - config/bounded_contexts.yml | 5 + .../backup_restore/backup_gitlab.md | 5 +- doc/administration/logs/index.md | 2 +- .../pipeline/detected_secrets.md | 145 +++++++++++++ .../detected_secrets.md | 53 +++++ .../secret_push_protection/index.md | 44 +++- lib/backup/manager.rb | 3 +- lib/backup/options.rb | 7 +- lib/backup/tasks/external_diffs.rb | 23 +++ lib/gitlab/utils/sanitize_node_link.rb | 7 +- lib/tasks/gitlab/backup.rake | 10 + locale/gitlab.pot | 24 ++- qa/lib/gitlab/page/group/settings/billing.rb | 19 -- .../page/group/settings/billing.stub.rb | 192 ------------------ .../product_analytics/browser_sdk_app.rb | 2 +- .../product_analytics/dotnet_sdk_app.rb | 2 +- .../product_analytics/node_sdk_app.rb | 67 ++++++ .../product_analytics/ruby_sdk_app.rb | 2 +- .../ci/pipeline_schedules_finder_spec.rb | 26 +-- spec/frontend/ci/pipeline_editor/mock_data.js | 4 + .../downstream_pipelines_spec.js | 89 ++++++++ ...s => legacy_linked_pipelines_mock_data.js} | 0 .../legacy_linked_pipelines_mini_list_spec.js | 16 +- .../legacy_pipeline_mini_graph_spec.js | 2 +- .../linked_pipelines_mini_list_spec.js | 140 ------------- .../ci/pipeline_mini_graph/mock_data.js | 98 +++++++-- .../pipeline_mini_graph_spec.js | 95 +++++++-- spec/frontend/commit/mock_data.js | 4 + ...roject_pipeline_schedules_resolver_spec.rb | 38 ++-- spec/helpers/preferences_helper_spec.rb | 2 +- .../gitlab/utils/sanitize_node_link_spec.rb | 42 +++- spec/support/helpers/test_env.rb | 5 + spec/tasks/gitlab/backup_rake_spec.rb | 16 +- 49 files changed, 824 insertions(+), 661 deletions(-) create mode 100644 app/assets/javascripts/ci/pipeline_mini_graph/downstream_pipelines.vue delete mode 100644 app/assets/javascripts/ci/pipeline_mini_graph/linked_pipelines_mini_list.vue create mode 100644 doc/user/application_security/secret_detection/pipeline/detected_secrets.md create mode 100644 doc/user/application_security/secret_detection/secret_push_protection/detected_secrets.md create mode 100644 lib/backup/tasks/external_diffs.rb create mode 100644 qa/qa/service/docker_run/product_analytics/node_sdk_app.rb create mode 100644 spec/frontend/ci/pipeline_mini_graph/downstream_pipelines_spec.js rename spec/frontend/ci/pipeline_mini_graph/{linked_pipelines_mock_data.js => legacy_linked_pipelines_mock_data.js} (100%) delete mode 100644 spec/frontend/ci/pipeline_mini_graph/linked_pipelines_mini_list_spec.js diff --git a/.gitlab/ci/database.gitlab-ci.yml b/.gitlab/ci/database.gitlab-ci.yml index 0a86a8888a5..2fe80de47f9 100644 --- a/.gitlab/ci/database.gitlab-ci.yml +++ b/.gitlab/ci/database.gitlab-ci.yml @@ -147,7 +147,7 @@ db:backup_and_restore: script: - . scripts/prepare_build.sh - bundle exec rake db:drop db:create db:schema:load db:seed_fu - - mkdir -p tmp/tests/public/uploads tmp/tests/{artifacts,pages,lfs-objects,terraform_state,registry,packages,ci_secure_files} + - mkdir -p tmp/tests/public/uploads tmp/tests/{artifacts,pages,lfs-objects,terraform_state,registry,packages,ci_secure_files,external-diffs} - bundle exec rake gitlab:backup:create - date - bundle exec rake gitlab:backup:restore diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 78c4cedea12..926e6521d9a 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -321,7 +321,7 @@ .ai-gateway-services: services: - - name: registry.gitlab.com/gitlab-org/modelops/applied-ml/code-suggestions/ai-assist/model-gateway:v1.6.0 + - name: registry.gitlab.com/gitlab-org/modelops/applied-ml/code-suggestions/ai-assist/model-gateway:v1.6.1 alias: ai-gateway .use-pg13: diff --git a/.rubocop_todo/gitlab/bounded_contexts.yml b/.rubocop_todo/gitlab/bounded_contexts.yml index 1bfd6c0e54b..318b5dec371 100644 --- a/.rubocop_todo/gitlab/bounded_contexts.yml +++ b/.rubocop_todo/gitlab/bounded_contexts.yml @@ -3923,7 +3923,6 @@ Gitlab/BoundedContexts: - 'ee/lib/compliance_management/standards_adherence_checks_tracker.rb' - 'ee/lib/delay.rb' - 'ee/lib/duo_pro/bulk_user_assignment.rb' - - 'ee/lib/ee/backup/targets/repositories.rb' - 'ee/lib/ee/bulk_imports/groups/stage.rb' - 'ee/lib/ee/bulk_imports/projects/pipelines/issues_pipeline.rb' - 'ee/lib/ee/bulk_imports/projects/stage.rb' @@ -4103,35 +4102,6 @@ Gitlab/BoundedContexts: - 'lib/atlassian/jira_issue_key_extractor.rb' - 'lib/atlassian/jira_issue_key_extractors/branch.rb' - 'lib/aws/s3_client.rb' - - 'lib/backup.rb' - - 'lib/backup/database_configuration.rb' - - 'lib/backup/database_connection.rb' - - 'lib/backup/dump/postgres.rb' - - 'lib/backup/gitaly_backup.rb' - - 'lib/backup/helper.rb' - - 'lib/backup/manager.rb' - - 'lib/backup/metadata.rb' - - 'lib/backup/options.rb' - - 'lib/backup/remote_storage.rb' - - 'lib/backup/restore/preconditions.rb' - - 'lib/backup/restore/process.rb' - - 'lib/backup/restore/unpack.rb' - - 'lib/backup/targets/database.rb' - - 'lib/backup/targets/files.rb' - - 'lib/backup/targets/repositories.rb' - - 'lib/backup/targets/target.rb' - - 'lib/backup/tasks/artifacts.rb' - - 'lib/backup/tasks/builds.rb' - - 'lib/backup/tasks/ci_secure_files.rb' - - 'lib/backup/tasks/database.rb' - - 'lib/backup/tasks/lfs.rb' - - 'lib/backup/tasks/packages.rb' - - 'lib/backup/tasks/pages.rb' - - 'lib/backup/tasks/registry.rb' - - 'lib/backup/tasks/repositories.rb' - - 'lib/backup/tasks/task.rb' - - 'lib/backup/tasks/terraform_state.rb' - - 'lib/backup/tasks/uploads.rb' - 'lib/bitbucket/app_password_connection.rb' - 'lib/bitbucket/client.rb' - 'lib/bitbucket/collection.rb' diff --git a/Gemfile.checksum b/Gemfile.checksum index 1acbfa16efc..df217a86fc6 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -446,7 +446,7 @@ {"name":"openssl-signature_algorithm","version":"1.3.0","platform":"ruby","checksum":"a3b40b5e8276162d4a6e50c7c97cdaf1446f9b2c3946a6fa2c14628e0c957e80"}, {"name":"opentelemetry-api","version":"1.2.5","platform":"ruby","checksum":"ab3d9a0566cd2ee068ade40e840bc973383ab8568e693c0c5712f0c789122cc9"}, {"name":"opentelemetry-common","version":"0.21.0","platform":"ruby","checksum":"fe891a44583a20bc3217b324aec76d066504494951682d391cfd57d40cd01c98"}, -{"name":"opentelemetry-exporter-otlp","version":"0.26.3","platform":"ruby","checksum":"fc1deea7924c74e3536983b02684d1bc7e9737baa5c38f3aff9809a7fd330399"}, +{"name":"opentelemetry-exporter-otlp","version":"0.27.0","platform":"ruby","checksum":"0050cf6ade97186ee3176cd8c44087b70cb739c3c624dbfc7c33097a3a189e4c"}, {"name":"opentelemetry-helpers-sql-obfuscation","version":"0.1.0","platform":"ruby","checksum":"bc6ef1373dbcf979647091b3bfc99d7b6fb9669f74c3ae184f58b48adfc8d432"}, {"name":"opentelemetry-instrumentation-action_pack","version":"0.9.0","platform":"ruby","checksum":"c5df8472afc9cdbfc1425d9af7816b9cfc1a1a69b86621f1fc624974bd9acb9a"}, {"name":"opentelemetry-instrumentation-action_view","version":"0.7.0","platform":"ruby","checksum":"bc7c714be0b4bb76843085c29ecc9465e65cb7fe6722e34c71629e44f8c3cb75"}, diff --git a/Gemfile.lock b/Gemfile.lock index 122f32efec2..88348e790f1 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1226,7 +1226,7 @@ GEM opentelemetry-api (1.2.5) opentelemetry-common (0.21.0) opentelemetry-api (~> 1.0) - opentelemetry-exporter-otlp (0.26.3) + opentelemetry-exporter-otlp (0.27.0) google-protobuf (~> 3.14) googleapis-common-protos-types (~> 1.3) opentelemetry-api (~> 1.1) diff --git a/app/assets/javascripts/ci/pipeline_details/graphql/queries/get_linked_pipelines.query.graphql b/app/assets/javascripts/ci/pipeline_details/graphql/queries/get_linked_pipelines.query.graphql index 9257cc7de7b..ba623db5c76 100644 --- a/app/assets/javascripts/ci/pipeline_details/graphql/queries/get_linked_pipelines.query.graphql +++ b/app/assets/javascripts/ci/pipeline_details/graphql/queries/get_linked_pipelines.query.graphql @@ -14,6 +14,7 @@ query getLinkedPipelines($fullPath: ID!, $iid: ID!) { } detailedStatus { id + detailsPath group icon label @@ -33,6 +34,7 @@ query getLinkedPipelines($fullPath: ID!, $iid: ID!) { } detailedStatus { id + detailsPath group icon label diff --git a/app/assets/javascripts/ci/pipeline_mini_graph/downstream_pipelines.vue b/app/assets/javascripts/ci/pipeline_mini_graph/downstream_pipelines.vue new file mode 100644 index 00000000000..f73665056b1 --- /dev/null +++ b/app/assets/javascripts/ci/pipeline_mini_graph/downstream_pipelines.vue @@ -0,0 +1,84 @@ + + + diff --git a/app/assets/javascripts/ci/pipeline_mini_graph/graphql/queries/get_pipeline_mini_graph.query.graphql b/app/assets/javascripts/ci/pipeline_mini_graph/graphql/queries/get_pipeline_mini_graph.query.graphql index b77c21dab51..24b4414f598 100644 --- a/app/assets/javascripts/ci/pipeline_mini_graph/graphql/queries/get_pipeline_mini_graph.query.graphql +++ b/app/assets/javascripts/ci/pipeline_mini_graph/graphql/queries/get_pipeline_mini_graph.query.graphql @@ -11,20 +11,19 @@ query getPipelineMiniGraph($fullPath: ID!, $iid: ID!) { detailedStatus { id icon - group + label } } } upstream { id - path project { id name } detailedStatus { id - group + detailsPath icon label } @@ -39,7 +38,7 @@ query getPipelineMiniGraph($fullPath: ID!, $iid: ID!) { } detailedStatus { id - group + detailsPath icon label } diff --git a/app/assets/javascripts/ci/pipeline_mini_graph/legacy_pipeline_mini_graph/legacy_linked_pipelines_mini_list.vue b/app/assets/javascripts/ci/pipeline_mini_graph/legacy_pipeline_mini_graph/legacy_linked_pipelines_mini_list.vue index 09a432e1b47..014a31fb706 100644 --- a/app/assets/javascripts/ci/pipeline_mini_graph/legacy_pipeline_mini_graph/legacy_linked_pipelines_mini_list.vue +++ b/app/assets/javascripts/ci/pipeline_mini_graph/legacy_pipeline_mini_graph/legacy_linked_pipelines_mini_list.vue @@ -66,7 +66,7 @@ export default { return `+${this.linkedPipelines.length - this.maxRenderedPipelines}`; }, counterTooltipText() { - return sprintf(s__('LinkedPipelines|%{counterLabel} more downstream pipelines'), { + return sprintf(s__('Pipelines|%{counterLabel} more downstream pipelines'), { counterLabel: this.counterLabel, }); }, @@ -76,6 +76,7 @@ export default { const { label } = accessValue(pipeline, this.dataMethod, 'detailedStatus'); return `${pipeline.project.name} - ${label}`; + // return `${pipeline?.project?.name} - ${pipeline?.details?.status?.label}`; }, pipelineStatus(pipeline) { // detailedStatus is graphQL, details.status is REST @@ -88,10 +89,6 @@ export default {