From 40ea82e97ab5ef5aace6bfa53272632e049cb29e Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 20 Nov 2024 18:23:23 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/rules.gitlab-ci.yml | 4 + .../rspec/example_without_description.yml | 2 - .../pipeline_failed_jobs_widget.vue | 10 ++ .../components/stop_environment_modal.vue | 2 +- app/assets/javascripts/gfm_auto_complete.js | 1 + .../components/merge_requests_list_app.vue | 1 + .../todo_toggle/sidebar_todo_widget.vue | 1 + .../markdown/comment_templates_modal.vue | 2 +- .../stylesheets/page_bundles/issuable.scss | 4 + app/models/integrations/unify_circuit.rb | 7 +- app/models/packages/nuget/symbol.rb | 11 ++- .../packages/maven/cached_response.rb | 8 +- ...assign_placeholder_user_records_service.rb | 11 ++- app/services/notes/create_service.rb | 6 +- .../create_or_update_service.rb | 1 - .../maven/handle_file_request_service.rb | 7 +- ...e_unique_index_on_packages_nuget_symbol.rb | 33 +++++++ db/schema_migrations/20241111220006 | 1 + db/structure.sql | 4 +- doc/administration/configure.md | 1 + doc/administration/index.md | 5 +- doc/administration/monitoring/index.md | 1 + doc/api/graphql/reference/index.md | 43 +++++++++ .../visual_studio_code/cicd.md | 22 +++-- .../visual_studio_code/index.md | 52 ++++++++++- .../visual_studio_code/troubleshooting.md | 14 ++- .../reduce_dependency_proxy_storage.md | 8 +- doc/user/packages/npm_registry/index.md | 12 +-- doc/user/project/quick_actions.md | 6 +- doc/user/workspace/configuration.md | 3 +- .../packages/maven/cached_response.rb | 1 - lib/api/helpers/integrations_helpers.rb | 9 +- lib/gitlab/asciidoc.rb | 2 + lib/gitlab/git/commit.rb | 4 +- .../importer/diff_note_importer.rb | 8 +- .../quick_actions/merge_request_actions.rb | 50 +++++++++- locale/gitlab.pot | 21 ++++- spec/factories/packages/nuget/symbol.rb | 3 +- .../pipeline_failed_jobs_widget_spec.js | 13 ++- .../merge_requests_list_app_spec.js | 1 + .../packages/maven/cached_response_spec.rb | 4 +- spec/lib/gitlab/asciidoc_spec.rb | 4 +- .../importer/diff_note_importer_spec.rb | 12 +++ spec/models/packages/nuget/symbol_spec.rb | 41 +++++++-- .../packages/maven/cached_response_spec.rb | 45 +++------ .../virtual_registries/packages/maven_spec.rb | 1 - ...n_placeholder_user_records_service_spec.rb | 28 +++++- spec/services/notes/create_service_spec.rb | 8 ++ .../quick_actions/interpret_service_spec.rb | 91 +++++++++++++++++-- .../create_or_update_service_spec.rb | 2 - .../maven/handle_file_request_service_spec.rb | 10 +- .../cleanup_package_registry_worker_spec.rb | 2 +- .../cleanup_stale_symbols_worker_spec.rb | 8 +- 53 files changed, 500 insertions(+), 151 deletions(-) create mode 100644 db/post_migrate/20241111220006_update_unique_index_on_packages_nuget_symbol.rb create mode 100644 db/schema_migrations/20241111220006 diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 0a9265d2e60..d05d0e32263 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -2699,6 +2699,8 @@ when: never - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /gemnasium([^-]|$)/' when: never + # Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved + - <<: *if-default-branch-refs - <<: *if-default-refs changes: *dependency-patterns @@ -2708,6 +2710,8 @@ when: never - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /gemnasium-python/' when: never + # Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved + - <<: *if-default-branch-refs - <<: *if-default-refs changes: *python-patterns diff --git a/.rubocop_todo/rspec/example_without_description.yml b/.rubocop_todo/rspec/example_without_description.yml index 44ae7dc6868..04e9e33117b 100644 --- a/.rubocop_todo/rspec/example_without_description.yml +++ b/.rubocop_todo/rspec/example_without_description.yml @@ -290,7 +290,6 @@ RSpec/ExampleWithoutDescription: - 'spec/initializers/gitlab_http_spec.rb' - 'spec/initializers/google_cloud_profiler_spec.rb' - 'spec/keeps/helpers/postgres_ai_spec.rb' - - 'spec/lib/api/entities/virtual_registries/packages/maven/cached_response_spec.rb' - 'spec/lib/banzai/filter/commit_trailers_filter_spec.rb' - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/banzai/pipeline_spec.rb' @@ -477,7 +476,6 @@ RSpec/ExampleWithoutDescription: - 'spec/models/users/banned_user_spec.rb' - 'spec/models/users/phone_number_validation_spec.rb' - 'spec/models/users/project_callout_spec.rb' - - 'spec/models/virtual_registries/packages/maven/cached_response_spec.rb' - 'spec/models/virtual_registries/packages/maven/registry_spec.rb' - 'spec/models/virtual_registries/packages/maven/registry_upstream_spec.rb' - 'spec/models/virtual_registries/packages/maven/upstream_spec.rb' diff --git a/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue b/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue index a57dcfb1e22..158b8796195 100644 --- a/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue +++ b/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue @@ -113,6 +113,7 @@ export default { class="!gl-text-subtle" :aria-expanded="isExpanded.toString()" :aria-controls="$options.ariaControlsId" + data-testid="toggle-button" @click="toggleWidget" > @@ -126,6 +127,15 @@ export default { {{ failedJobsCountBadge }} +