From 4315ea0bc498a7705b9f7e6ed66a4e27910ab381 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 12 Jun 2024 21:16:42 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/qa-common/main.gitlab-ci.yml | 4 +- .gitlab/ci/qa-common/variables.gitlab-ci.yml | 2 +- .gitlab/issue_templates/rca_upgrade_stop.md | 119 +++++ .../javascripts/diffs/components/app.vue | 13 +- .../diffs/components/diff_file_header.vue | 2 + .../issues/create_merge_request_dropdown.js | 269 ++++-------- .../repository/maintenance/remove_blobs.vue | 2 +- .../javascripts/search/store/actions.js | 41 +- .../javascripts/search/store/constants.js | 6 +- .../javascripts/search/store/getters.js | 10 +- app/assets/javascripts/search/store/utils.js | 19 +- .../search/topbar/components/app.vue | 16 +- .../components/global_search.vue | 4 +- .../components/global_search_scoped_items.vue | 2 + .../components/global_search/store/getters.js | 13 +- .../components/inbound_token_access.vue | 112 ++--- .../components/outbound_token_access.vue | 35 +- .../components/token_access_table.vue | 66 ++- ...ects_with_ci_job_token_scope.query.graphql | 2 + .../components/approvals/approvals.vue | 6 +- .../stylesheets/framework/new_card.scss | 8 +- app/controllers/concerns/renders_notes.rb | 5 + app/helpers/projects/issues_helper.rb | 49 --- app/models/issue.rb | 7 +- app/models/note.rb | 5 +- app/services/merge_requests/build_service.rb | 5 +- .../projects/issues/_new_branch.html.haml | 19 +- .../maintenance/_remove_blobs.html.haml | 2 +- .../graphql_minimal_auth_methods.yml | 4 +- doc/administration/postgresql/upgrading_os.md | 4 + .../sec/security_report_ingestion_overview.md | 4 +- .../reducing_the_repo_size_using_git.md | 61 +++ lib/banzai/pipeline/single_line_pipeline.rb | 1 + locale/gitlab.pot | 19 +- spec/factories/notes.rb | 5 + ...r_creates_branch_and_merge_request_spec.rb | 408 ++++++++---------- .../__helpers__/vuex_action_helper.js | 1 - spec/frontend/diffs/components/app_spec.js | 26 +- .../diffs/components/diff_file_header_spec.js | 3 + .../create_merge_request_dropdown_spec.js | 7 +- spec/frontend/search/mock_data.js | 14 + spec/frontend/search/store/actions_spec.js | 53 ++- spec/frontend/search/store/getters_spec.js | 8 +- spec/frontend/search/store/utils_spec.js | 55 ++- .../search/topbar/components/app_spec.js | 3 +- .../components/global_search_spec.js | 13 + .../components/global_search/mock_data.js | 26 +- .../token_access/inbound_token_access_spec.js | 74 +++- spec/frontend/token_access/mock_data.js | 53 ++- .../token_access/token_access_table_spec.js | 12 +- spec/helpers/projects/issues_helper_spec.rb | 29 -- spec/models/issue_spec.rb | 98 ++++- spec/models/note_spec.rb | 49 +++ .../merge_requests/build_service_spec.rb | 15 +- spec/support/rspec_order_todo.yml | 2 - spec/workers/every_sidekiq_worker_spec.rb | 1 + 56 files changed, 1145 insertions(+), 746 deletions(-) create mode 100644 .gitlab/issue_templates/rca_upgrade_stop.md rename config/feature_flags/{gitlab_com_derisk => ops}/graphql_minimal_auth_methods.yml (86%) diff --git a/.gitlab/ci/qa-common/main.gitlab-ci.yml b/.gitlab/ci/qa-common/main.gitlab-ci.yml index 7d8f87335af..11949282e74 100644 --- a/.gitlab/ci/qa-common/main.gitlab-ci.yml +++ b/.gitlab/ci/qa-common/main.gitlab-ci.yml @@ -5,7 +5,7 @@ workflow: name: $PIPELINE_NAME include: - - component: "gitlab.com/gitlab-org/quality/pipeline-common/allure-report@8.15.1" + - component: "gitlab.com/gitlab-org/quality/pipeline-common/allure-report@8.16.0" inputs: job_name: "e2e-test-report" job_stage: "report" @@ -15,7 +15,7 @@ include: gitlab_auth_token_variable_name: "PROJECT_TOKEN_FOR_CI_SCRIPTS_API_USAGE" allure_job_name: "${QA_RUN_TYPE}" - project: gitlab-org/quality/pipeline-common - ref: 8.15.1 + ref: 8.16.0 file: - /ci/base.gitlab-ci.yml - /ci/knapsack-report.yml diff --git a/.gitlab/ci/qa-common/variables.gitlab-ci.yml b/.gitlab/ci/qa-common/variables.gitlab-ci.yml index bd99a455f40..8a417bf1400 100644 --- a/.gitlab/ci/qa-common/variables.gitlab-ci.yml +++ b/.gitlab/ci/qa-common/variables.gitlab-ci.yml @@ -16,4 +16,4 @@ variables: QA_OMNIBUS_MR_TESTS: "only-smoke" # Retry failed specs in separate process QA_RETRY_FAILED_SPECS: "true" - GITLAB_HELM_CHART_REF: "c7532b6e1ba98d5663b58012a879a781689db916" # helm chart ref used by test-on-cng pipeline + GITLAB_HELM_CHART_REF: "4c21d49231b948fa31f502feee136f688e3abf76" # helm chart ref used by test-on-cng pipeline diff --git a/.gitlab/issue_templates/rca_upgrade_stop.md b/.gitlab/issue_templates/rca_upgrade_stop.md new file mode 100644 index 00000000000..8702f9ebefc --- /dev/null +++ b/.gitlab/issue_templates/rca_upgrade_stop.md @@ -0,0 +1,119 @@ + + +## Summary + +A brief summary of what happened. Try to make it as executive-friendly as possible. + +- Upgrade path(s) affected: +- Upgrade type: downtime / zero downtime upgrade +- [Type of degradation](https://handbook.gitlab.com/handbook/engineering/unplanned-upgrade-stop/#unplanned-upgrade-types): Database migration error / Configuration changes / Breaking functionality changes +- Relevant bug issue: +- Team attribution: ~group:: + +## Impact & Metrics + +Start with the following: + +| Question | Answer | +| ----- | ----- | +| Who was impacted? | (i.e. customers with specific environment configurations or data ...) | +| How many customers affected? | | + +Include any additional metrics that are of relevance. + +## Detection & Response + +Start with the following: + +| Question | Answer | +| ----- | ----- | +| When was the issue detected? | YYYY-MM-DD | +| How was the issue detected? | (i.e. Support request, Bug raised, ...) | +| How long did it take from the start of the issue to its detection? | | +| How long did it take from detection to remediation? | | +| What steps were taken to remediate? | | +| Was patch release created? | | +| Was patch backported to older versions? | | + +## Timeline + +YYYY-MM-DD + +- something happened +- something else happened +- ... + +YYYY-MM-DD+1 + +- and then this happened +- and more happened +- ... + +## Root Cause Analysis + +The purpose of this document is to understand the reasons that caused an issue, and to create mechanisms to prevent it from recurring in the future. A root cause can **never be a person**, the way of writing has to refer to the system and the context rather than the specific actors. + +### What is causing upgrade error + +Start with the following: + +- What is the cause of the upgrade error? +- What steps could be done to reproduce the upgrade error? + +### What can be improved + +DRI: Corresponding Engineering team + +- Using the root cause analysis, explain what can be improved to prevent this from happening again. +- What changes to our tooling or review process would have prevented this issue? +- Is there an existing issue that would have either prevented this issue or reduced the impact? +- Did we have any indication or beforehand knowledge that this issue might take place? + +DRI: Test Platform + +- What is the cause of the test gap on integration and system level testing? +- What can be done to increase test coverage? +- Did relevant tests pass for this upgrade path? + +## Corrective actions + +- Link issues that have been created as corrective actions from this issue. +- For each issue, include the following: + - `` - Issue labeled as ~"corrective action" ~upgrades. + - An estimated date of completion of the corrective action. Priority of the issue should correspond with RCA severity. + +## Guidelines + +- [Blameless RCA Guideline](https://about.gitlab.com/handbook/customer-success/professional-services-engineering/workflows/internal/root-cause-analysis.html) +- [5 whys](https://en.wikipedia.org/wiki/5_Whys) + +/confidential +/label ~RCA ~upgrades ~"type::ignore" + + +/label ~severity:: + + +/label ~group:: + + +/relate diff --git a/app/assets/javascripts/diffs/components/app.vue b/app/assets/javascripts/diffs/components/app.vue index 70b8684f988..b856ab236da 100644 --- a/app/assets/javascripts/diffs/components/app.vue +++ b/app/assets/javascripts/diffs/components/app.vue @@ -1,7 +1,7 @@