diff --git a/.eslint_todo/vue-no-unused-properties.mjs b/.eslint_todo/vue-no-unused-properties.mjs index d999d37afd4..1d23a58f263 100644 --- a/.eslint_todo/vue-no-unused-properties.mjs +++ b/.eslint_todo/vue-no-unused-properties.mjs @@ -58,9 +58,6 @@ export default { 'app/assets/javascripts/ci/pipelines_page/components/pipelines_artifacts.vue', 'app/assets/javascripts/ci/pipelines_page/pipelines.vue', 'app/assets/javascripts/ci/reports/components/report_section.vue', - 'app/assets/javascripts/clusters_list/components/agents.vue', - 'app/assets/javascripts/clusters_list/components/delete_agent_button.vue', - 'app/assets/javascripts/clusters_list/components/install_agent_modal.vue', 'app/assets/javascripts/commit/pipelines/legacy_pipelines_table_wrapper.vue', 'app/assets/javascripts/content_editor/components/bubble_menus/media_bubble_menu.vue', 'app/assets/javascripts/content_editor/components/content_editor.vue', @@ -76,7 +73,6 @@ export default { 'app/assets/javascripts/custom_emoji/pages/index.vue', 'app/assets/javascripts/deploy_freeze/components/deploy_freeze_modal.vue', 'app/assets/javascripts/deploy_freeze/components/deploy_freeze_table.vue', - 'app/assets/javascripts/deployments/components/deployment_header.vue', 'app/assets/javascripts/design_management/components/design_description/description_form.vue', 'app/assets/javascripts/design_management/components/design_notes/design_discussion.vue', 'app/assets/javascripts/design_management/components/design_notes/design_note.vue', @@ -92,15 +88,6 @@ export default { 'app/assets/javascripts/diffs/components/diff_view.vue', 'app/assets/javascripts/diffs/components/image_diff_overlay.vue', 'app/assets/javascripts/emoji/components/picker.vue', - 'app/assets/javascripts/environments/components/canary_update_modal.vue', - 'app/assets/javascripts/environments/components/deployment.vue', - 'app/assets/javascripts/environments/components/empty_state.vue', - 'app/assets/javascripts/environments/components/enable_review_app_modal.vue', - 'app/assets/javascripts/environments/components/environment_flux_resource_selector.vue', - 'app/assets/javascripts/environments/components/environment_form.vue', - 'app/assets/javascripts/environments/environment_details/components/deployment_actions.vue', - 'app/assets/javascripts/environments/environment_details/components/deployment_history.vue', - 'app/assets/javascripts/environments/environment_details/components/kubernetes/kubernetes_overview.vue', 'app/assets/javascripts/error_tracking/components/error_details.vue', 'app/assets/javascripts/error_tracking/components/error_tracking_list.vue', 'app/assets/javascripts/error_tracking_settings/components/project_dropdown.vue', @@ -144,8 +131,6 @@ export default { 'app/assets/javascripts/invite_members/components/user_limit_notification.vue', 'app/assets/javascripts/jira_connect/branches/components/new_branch_form.vue', 'app/assets/javascripts/jira_import/components/jira_import_form.vue', - 'app/assets/javascripts/kubernetes_dashboard/components/workload_details.vue', - 'app/assets/javascripts/kubernetes_dashboard/components/workload_details_drawer.vue', 'app/assets/javascripts/members/components/filter_sort/sort_dropdown.vue', 'app/assets/javascripts/merge_request_dashboard/components/status_badge.vue', 'app/assets/javascripts/merge_requests/components/reviewers/reviewer_drawer.vue', @@ -448,9 +433,6 @@ export default { 'ee/app/assets/javascripts/projects/components/move_personal_project_to_group_modal.vue', 'ee/app/assets/javascripts/projects/merge_requests/blocking_mr_input_root.vue', 'ee/app/assets/javascripts/projects/settings/branch_rules/components/view/index.vue', - 'ee/app/assets/javascripts/protected_environments/create_protected_environment.vue', - 'ee/app/assets/javascripts/protected_environments/edit_protected_environment_rules_card.vue', - 'ee/app/assets/javascripts/protected_environments/protected_environments.vue', 'ee/app/assets/javascripts/related_items_tree/components/create_epic_form.vue', 'ee/app/assets/javascripts/related_items_tree/components/related_items_tree_app.vue', 'ee/app/assets/javascripts/related_items_tree/components/related_items_tree_header_actions.vue', diff --git a/.markdownlint-cli2.yaml b/.markdownlint-cli2.yaml index 753dcc1c24b..bfee1c7b066 100644 --- a/.markdownlint-cli2.yaml +++ b/.markdownlint-cli2.yaml @@ -162,3 +162,5 @@ config: ] ignores: - "doc/architecture" +customRules: + - "./doc/.markdownlint/rules/unnecessary_traversal.js" diff --git a/app/assets/javascripts/clusters_list/components/agent_table.vue b/app/assets/javascripts/clusters_list/components/agent_table.vue index 77839fee099..976d1d65a18 100644 --- a/app/assets/javascripts/clusters_list/components/agent_table.vue +++ b/app/assets/javascripts/clusters_list/components/agent_table.vue @@ -69,11 +69,6 @@ export default { required: true, type: Array, }, - defaultBranchName: { - default: '.noBranch', - required: false, - type: String, - }, maxAgents: { default: null, required: false, @@ -423,7 +418,6 @@ export default { v-if="action.name === 'delete-agent'" :key="action.name" :agent="item" - :default-branch-name="defaultBranchName" /> - + diff --git a/app/assets/javascripts/clusters_list/components/delete_agent_button.vue b/app/assets/javascripts/clusters_list/components/delete_agent_button.vue index 54dea312e4e..1e9ecf4236d 100644 --- a/app/assets/javascripts/clusters_list/components/delete_agent_button.vue +++ b/app/assets/javascripts/clusters_list/components/delete_agent_button.vue @@ -36,11 +36,6 @@ export default { type: Object, validator: (value) => ['id', 'name'].every((prop) => value[prop]), }, - defaultBranchName: { - default: '.noBranch', - required: false, - type: String, - }, }, data() { return { diff --git a/app/assets/javascripts/clusters_list/components/install_agent_modal.vue b/app/assets/javascripts/clusters_list/components/install_agent_modal.vue index f9e0038c3f3..cf6e1f6e451 100644 --- a/app/assets/javascripts/clusters_list/components/install_agent_modal.vue +++ b/app/assets/javascripts/clusters_list/components/install_agent_modal.vue @@ -194,6 +194,8 @@ export default { } this.registerAgent(); }, + // This method is triggered from outside of the component + // eslint-disable-next-line vue/no-unused-properties showModalForAgent(name) { this.agentName = name; this.$refs.modal?.show(); diff --git a/app/assets/javascripts/deployments/components/deployment_header.vue b/app/assets/javascripts/deployments/components/deployment_header.vue index 3119deb11a6..0353ed4090d 100644 --- a/app/assets/javascripts/deployments/components/deployment_header.vue +++ b/app/assets/javascripts/deployments/components/deployment_header.vue @@ -55,9 +55,6 @@ export default { }, }, computed: { - iid() { - return this.deployment.iid; - }, status() { return this.deployment.status?.toLowerCase() ?? ''; }, diff --git a/app/assets/javascripts/environments/components/canary_update_modal.vue b/app/assets/javascripts/environments/components/canary_update_modal.vue index d656b3bf5d5..6a58e788b29 100644 --- a/app/assets/javascripts/environments/components/canary_update_modal.vue +++ b/app/assets/javascripts/environments/components/canary_update_modal.vue @@ -48,7 +48,7 @@ export default { static: true, }, data() { - return { error: '', dismissed: true }; + return { error: '' }; }, computed: { stableWeight() { diff --git a/app/assets/javascripts/environments/components/deployment.vue b/app/assets/javascripts/environments/components/deployment.vue index bf782480d53..ac4abc17fab 100644 --- a/app/assets/javascripts/environments/components/deployment.vue +++ b/app/assets/javascripts/environments/components/deployment.vue @@ -71,9 +71,6 @@ export default { const dateTime = new Date(this.deploymentTime); return localeDateFormat.asDateTimeFull.format(dateTime); }, - createdAt() { - return this.deployment?.createdAt; - }, commit() { return this.deployment?.commit; }, diff --git a/app/assets/javascripts/environments/components/empty_state.vue b/app/assets/javascripts/environments/components/empty_state.vue index 92b29b691ab..6bde3638fca 100644 --- a/app/assets/javascripts/environments/components/empty_state.vue +++ b/app/assets/javascripts/environments/components/empty_state.vue @@ -24,14 +24,6 @@ export default { default: false, }, }, - computed: { - title() { - return this.hasTerm ? this.$options.i18n.searchingTitle : this.$options.i18n.title; - }, - content() { - return this.hasTerm ? this.$options.i18n.searchingContent : this.$options.i18n.content; - }, - }, i18n: { title: s__('Environments|Get started with environments'), content: s__( diff --git a/app/assets/javascripts/environments/components/enable_review_app_modal.vue b/app/assets/javascripts/environments/components/enable_review_app_modal.vue index 67682121e89..e9c14aed302 100644 --- a/app/assets/javascripts/environments/components/enable_review_app_modal.vue +++ b/app/assets/javascripts/environments/components/enable_review_app_modal.vue @@ -47,11 +47,6 @@ export default { - if: $CI_PIPELINE_SOURCE == "merge_request_event"`; }, }, - methods: { - commaOrPeriod(index, length) { - return index + 1 === length ? '.' : ','; - }, - }, i18n, configuringReviewAppsPath: helpPagePath('ci/review_apps/_index.md', { anchor: 'configure-review-apps', diff --git a/app/assets/javascripts/environments/components/environment_flux_resource_selector.vue b/app/assets/javascripts/environments/components/environment_flux_resource_selector.vue index ec794481889..08d1dd0fd69 100644 --- a/app/assets/javascripts/environments/components/environment_flux_resource_selector.vue +++ b/app/assets/javascripts/environments/components/environment_flux_resource_selector.vue @@ -61,10 +61,7 @@ export default { fluxKustomizations: { query: fluxKustomizationsQuery, variables() { - return { - configuration: this.configuration, - namespace: this.namespace, - }; + return this.variables; }, skip() { return !this.namespace; @@ -85,10 +82,7 @@ export default { fluxHelmReleases: { query: fluxHelmReleasesQuery, variables() { - return { - configuration: this.configuration, - namespace: this.namespace, - }; + return this.variables; }, skip() { return !this.namespace; diff --git a/app/assets/javascripts/environments/components/environment_form.vue b/app/assets/javascripts/environments/components/environment_form.vue index 764b7d0f25b..d11ed144265 100644 --- a/app/assets/javascripts/environments/components/environment_form.vue +++ b/app/assets/javascripts/environments/components/environment_form.vue @@ -103,13 +103,9 @@ export default { selectedAgentId: this.environment.clusterAgentId, agentSearchTerm: '', selectedNamespace: this.environment.kubernetesNamespace, - kubernetesError: '', }; }, computed: { - loadingNamespacesList() { - return this.$apollo.queries.k8sNamespaces.loading; - }, isNameDisabled() { return Boolean(this.environment.id); }, diff --git a/app/assets/javascripts/environments/environment_details/components/deployment_actions.vue b/app/assets/javascripts/environments/environment_details/components/deployment_actions.vue index 1ef317f7b05..2248d1e565d 100644 --- a/app/assets/javascripts/environments/environment_details/components/deployment_actions.vue +++ b/app/assets/javascripts/environments/environment_details/components/deployment_actions.vue @@ -80,9 +80,6 @@ export default { isActionsShown() { return this.actions.length > 0; }, - deploymentIid() { - return this.approvalEnvironment.deploymentIid; - }, environment() { return this.approvalEnvironment.environment; }, diff --git a/app/assets/javascripts/environments/environment_details/components/deployment_history.vue b/app/assets/javascripts/environments/environment_details/components/deployment_history.vue index f1cf7ea7dc3..6eeece16b96 100644 --- a/app/assets/javascripts/environments/environment_details/components/deployment_history.vue +++ b/app/assets/javascripts/environments/environment_details/components/deployment_history.vue @@ -104,9 +104,6 @@ export default { isPaginationDisabled() { return this.isLoading || this.isPrefetchingPages; }, - pollingInterval() { - return this.graphqlEtagKey ? ENVIRONMENT_DETAILS_QUERY_POLLING_INTERVAL : null; - }, isDirectionAscending() { return this.sortDirection === DIRECTION_ASCENDING; }, diff --git a/app/assets/javascripts/environments/environment_details/components/kubernetes/kubernetes_overview.vue b/app/assets/javascripts/environments/environment_details/components/kubernetes/kubernetes_overview.vue index e04170bc125..1211cea3948 100644 --- a/app/assets/javascripts/environments/environment_details/components/kubernetes/kubernetes_overview.vue +++ b/app/assets/javascripts/environments/environment_details/components/kubernetes/kubernetes_overview.vue @@ -132,7 +132,6 @@ export default { podsLoading: false, activeTab: k8sResourceType.k8sPods, fluxApiError: '', - focusedElement: null, podToDelete: {}, fluxHelmRelease: {}, fluxKustomization: {}, diff --git a/app/assets/javascripts/kubernetes_dashboard/components/workload_details.vue b/app/assets/javascripts/kubernetes_dashboard/components/workload_details.vue index 741db1c110f..3221d300d26 100644 --- a/app/assets/javascripts/kubernetes_dashboard/components/workload_details.vue +++ b/app/assets/javascripts/kubernetes_dashboard/components/workload_details.vue @@ -179,13 +179,13 @@ export default { - + {{ $options.STATUS_LABELS[item.status] }}