Do not implicitly authenticate user during session creation

This commit is contained in:
Grzegorz Bizon 2018-08-01 16:57:59 +02:00
parent 2b05562c5b
commit 4eb9d6a96f
2 changed files with 6 additions and 2 deletions

View File

@ -131,7 +131,11 @@ class ApplicationController < ActionController::Base
# that is going to invoke warden callbacks, so we use Warden directly here.
#
def auth_user
if warden.authenticated?(:user)
# TODO improve that
#
return if controller_name == 'sessions' && action_name == 'create'
if user_signed_in?
current_user
else
try(:authenticated_user)

View File

@ -34,7 +34,7 @@ Rails.application.configure do |config|
if user.blocked?
Gitlab::Auth::Activity.new(opts).user_blocked!
BlockedUserTracker.new(user, auth).log_blocked_user_activity!
Gitlab::Auth::BlockedUserTracker.new(user, auth).log_blocked_user_activity!
end
Gitlab::Auth::Activity.new(opts).user_session_destroyed!