From 4f27fd0e82418afdff0fa0d068aa07dc22338c09 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 22 Oct 2024 09:22:04 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/rspec/be_eq.yml | 1 + .rubocop_todo/rspec/change_by_zero.yml | 1 + .rubocop_todo/rspec/contain_exactly.yml | 1 + .../ml/model_registry/apps/edit_ml_model.vue | 61 ++ .../ml/model_registry/apps/index.js | 10 +- .../ml/model_registry/apps/show_ml_model.vue | 16 +- .../model_registry/components/model_edit.vue | 175 ++--- .../ml/model_registry/constants.js | 1 - .../pages/projects/ml/models/edit/index.js | 8 + .../states/mr_widget_auto_merge_enabled.vue | 6 +- .../stylesheets/components/code_flow.scss | 4 + .../projects/build_artifacts_controller.rb | 1 - .../projects/ml/models_controller.rb | 6 +- .../projects/ml/model_registry_helper.rb | 17 + app/models/ci/processable.rb | 7 +- app/views/projects/ml/models/edit.html.haml | 5 + ..._resource_from_resource_group_worker_v2.rb | 20 +- ...rce_worker_deduplicate_until_executing.yml | 9 - ...r_deduplicate_until_executing_override.yml | 9 - config/routes/project.rb | 2 +- db/docs/keys.yml | 1 - .../packages/container_registry.md | 54 ++ doc/ci/environments/deployment_safety.md | 2 +- .../environments/external_deployment_tools.md | 2 +- doc/ci/environments/index.md | 707 +++++++++--------- ...eason.png => job_failure_reason_v10_7.png} | Bin doc/ci/jobs/index.md | 2 +- ...n.png => maven-freestyle-plugin_v16_4.png} | Bin ...ll.png => maven-freestyle-shell_v16_4.png} | Bin doc/ci/migration/examples/jenkins-maven.md | 4 +- ...continuous-delivery-review-apps_v11_4.svg} | 0 ...widget.png => view_on_mr_widget_v11_5.png} | Bin doc/ci/review_apps/index.md | 4 +- ...solation.png => build_isolation_v16_1.png} | Bin ...lab-hosted_runners_architecture_v17_0.png} | Bin ...ng => project_runner_ip_address_v10_7.png} | Bin ...> runner_fleet_dashboard_groups_v17_1.png} | Bin ...d.png => runner_fleet_dashboard_v17_1.png} | Bin doc/ci/runners/index.md | 4 +- doc/ci/runners/runner_fleet_dashboard.md | 2 +- .../runners/runner_fleet_dashboard_groups.md | 2 +- doc/ci/runners/runners_scope.md | 2 +- doc/development/observability/index.md | 6 +- .../end_to_end/running_tests/index.md | 5 +- doc/integration/jira/connect-app.md | 2 + .../img/ssh_keys_restricted_key_icon.png | Bin 4887 -> 0 bytes .../img/ssh_keys_restrictions_settings.png | Bin 11733 -> 0 bytes doc/security/ssh_keys_restrictions.md | 18 +- doc/update/background_migrations.md | 6 +- .../dast/browser/configuration/variables.md | 4 +- doc/user/project/import/bitbucket.md | 2 - doc/user/storage_management_automation.md | 140 +++- doc/user/workspace/set_up_workspaces_proxy.md | 7 + lib/gitlab/observability.rb | 11 +- qa/qa/runtime/namespace.rb | 24 +- qa/spec/runtime/namespace_spec.rb | 32 +- .../model_registry/apps/edit_ml_model_spec.js | 41 + .../model_registry/apps/show_ml_model_spec.js | 14 +- .../components/model_edit_spec.js | 41 +- .../projects/ml/model_registry_helper_spec.rb | 37 + spec/lib/gitlab/observability_spec.rb | 47 +- spec/models/ci/pipeline_spec.rb | 1 - spec/models/ci/processable_spec.rb | 37 - .../build_artifacts_controller_spec.rb | 28 +- .../projects/ml/models_controller_spec.rb | 48 +- ...source_from_resource_group_service_spec.rb | 14 - ...urce_from_resource_group_worker_v2_spec.rb | 10 +- workhorse/go.mod | 2 +- workhorse/go.sum | 4 +- 69 files changed, 1070 insertions(+), 657 deletions(-) create mode 100644 app/assets/javascripts/ml/model_registry/apps/edit_ml_model.vue create mode 100644 app/assets/javascripts/pages/projects/ml/models/edit/index.js create mode 100644 app/views/projects/ml/models/edit.html.haml delete mode 100644 config/feature_flags/beta/assign_resource_worker_deduplicate_until_executing.yml delete mode 100644 config/feature_flags/beta/assign_resource_worker_deduplicate_until_executing_override.yml rename doc/ci/jobs/img/{job_failure_reason.png => job_failure_reason_v10_7.png} (100%) rename doc/ci/migration/examples/img/{maven-freestyle-plugin.png => maven-freestyle-plugin_v16_4.png} (100%) rename doc/ci/migration/examples/img/{maven-freestyle-shell.png => maven-freestyle-shell_v16_4.png} (100%) rename doc/ci/review_apps/img/{continuous-delivery-review-apps.svg => continuous-delivery-review-apps_v11_4.svg} (100%) rename doc/ci/review_apps/img/{view_on_mr_widget.png => view_on_mr_widget_v11_5.png} (100%) rename doc/ci/runners/img/{build_isolation.png => build_isolation_v16_1.png} (100%) rename doc/ci/runners/img/{gitlab-hosted_runners_architecture.png => gitlab-hosted_runners_architecture_v17_0.png} (100%) rename doc/ci/runners/img/{project_runner_ip_address.png => project_runner_ip_address_v10_7.png} (100%) rename doc/ci/runners/img/{runner_fleet_dashboard_groups.png => runner_fleet_dashboard_groups_v17_1.png} (100%) rename doc/ci/runners/img/{runner_fleet_dashboard.png => runner_fleet_dashboard_v17_1.png} (100%) delete mode 100644 doc/security/img/ssh_keys_restricted_key_icon.png delete mode 100644 doc/security/img/ssh_keys_restrictions_settings.png create mode 100644 spec/frontend/ml/model_registry/apps/edit_ml_model_spec.js diff --git a/.rubocop_todo/rspec/be_eq.yml b/.rubocop_todo/rspec/be_eq.yml index 598a8e9db97..f047efc82af 100644 --- a/.rubocop_todo/rspec/be_eq.yml +++ b/.rubocop_todo/rspec/be_eq.yml @@ -32,6 +32,7 @@ RSpec/BeEq: - 'ee/spec/elastic/migrate/20240130144625_reindex_epics_to_update_analyzer_spec.rb' - 'ee/spec/elastic/migrate/20240814231502_remove_work_item_access_level_from_work_item_spec.rb' - 'ee/spec/elastic/migrate/20241002103536_reindex_merge_requests_for_title_completion_spec.rb' + - 'ee/spec/elastic/migrate/20241017094601_add_embedding_to_work_items_opensearch_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/admin/users/users_spec.rb' diff --git a/.rubocop_todo/rspec/change_by_zero.yml b/.rubocop_todo/rspec/change_by_zero.yml index 45868ce908d..d770acd8cdb 100644 --- a/.rubocop_todo/rspec/change_by_zero.yml +++ b/.rubocop_todo/rspec/change_by_zero.yml @@ -47,6 +47,7 @@ RSpec/ChangeByZero: - 'ee/spec/services/software_license_policies/bulk_create_scan_result_policy_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerabilities/security_finding/create_merge_request_service_spec.rb' + - 'ee/spec/services/work_items/legacy_epics/related_epic_links/create_service_spec.rb' - 'ee/spec/support/shared_examples/models/concerns/replicable_model_with_separate_table_shared_examples.rb' - 'ee/spec/workers/observability/alert_query_worker_spec.rb' - 'ee/spec/workers/security/store_security_reports_by_project_worker_spec.rb' diff --git a/.rubocop_todo/rspec/contain_exactly.yml b/.rubocop_todo/rspec/contain_exactly.yml index 955e223195a..793d9e39773 100644 --- a/.rubocop_todo/rspec/contain_exactly.yml +++ b/.rubocop_todo/rspec/contain_exactly.yml @@ -139,6 +139,7 @@ RSpec/ContainExactly: - 'spec/lib/gitlab/database/load_balancing/host_list_spec.rb' - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' + - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/feature_categories_spec.rb' - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' diff --git a/app/assets/javascripts/ml/model_registry/apps/edit_ml_model.vue b/app/assets/javascripts/ml/model_registry/apps/edit_ml_model.vue new file mode 100644 index 00000000000..928a56dac1f --- /dev/null +++ b/app/assets/javascripts/ml/model_registry/apps/edit_ml_model.vue @@ -0,0 +1,61 @@ + + + diff --git a/app/assets/javascripts/ml/model_registry/apps/index.js b/app/assets/javascripts/ml/model_registry/apps/index.js index ac593a7390f..37187c1bb25 100644 --- a/app/assets/javascripts/ml/model_registry/apps/index.js +++ b/app/assets/javascripts/ml/model_registry/apps/index.js @@ -3,5 +3,13 @@ import ShowMlModelVersion from './show_ml_model_version.vue'; import NewMlModelVersion from './new_ml_model_version.vue'; import IndexMlModels from './index_ml_models.vue'; import NewMlModel from './new_ml_model.vue'; +import EditMlModel from './edit_ml_model.vue'; -export { ShowMlModel, ShowMlModelVersion, IndexMlModels, NewMlModel, NewMlModelVersion }; +export { + EditMlModel, + IndexMlModels, + NewMlModel, + NewMlModelVersion, + ShowMlModel, + ShowMlModelVersion, +}; diff --git a/app/assets/javascripts/ml/model_registry/apps/show_ml_model.vue b/app/assets/javascripts/ml/model_registry/apps/show_ml_model.vue index 36f6b42c65d..65463b32075 100644 --- a/app/assets/javascripts/ml/model_registry/apps/show_ml_model.vue +++ b/app/assets/javascripts/ml/model_registry/apps/show_ml_model.vue @@ -15,7 +15,6 @@ import * as Sentry from '~/sentry/sentry_browser_wrapper'; import DeleteDisclosureDropdownItem from '../components/delete_disclosure_dropdown_item.vue'; import LoadOrErrorOrShow from '../components/load_or_error_or_show.vue'; import DeleteModel from '../components/functional/delete_model.vue'; -import ModelEdit from '../components/model_edit.vue'; const ROUTE_DETAILS = 'details'; const ROUTE_VERSIONS = 'versions'; @@ -53,7 +52,6 @@ export default { MetadataItem, LoadOrErrorOrShow, DeleteModel, - ModelEdit, }, router: new VueRouter({ routes, @@ -66,6 +64,7 @@ export default { maxAllowedFileSize: this.maxAllowedFileSize, latestVersion: this.latestVersion, markdownPreviewPath: this.markdownPreviewPath, + editModelPath: this.editModelPath, createModelVersionPath: this.createModelVersionPath, modelGid: this.modelGid, }; @@ -87,6 +86,10 @@ export default { type: String, required: true, }, + editModelPath: { + type: String, + required: true, + }, createModelVersionPath: { type: String, required: true, @@ -179,6 +182,7 @@ export default { }, i18n: { createModelVersionLinkTitle: s__('MlModelRegistry|Create model version'), + editModelButtonLabel: s__('MlModelRegistry|Edit model'), }, modelVersionEntity: MODEL_ENTITIES.modelVersion, ROUTE_DETAILS, @@ -196,7 +200,13 @@ export default {