From 5460c19548d3d3d2ff764ceff05c2b72aa2d3a32 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 5 Oct 2020 12:08:47 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/review.gitlab-ci.yml | 2 +- .../components/design_note_pin.vue | 14 +- .../components/design_overlay.vue | 4 +- app/assets/javascripts/lib/utils/css_utils.js | 19 + .../javascripts/packages/list/constants.js | 2 +- .../javascripts/packages/shared/utils.js | 2 +- app/assets/javascripts/profile/gl_crop.js | 4 + app/assets/stylesheets/application.scss | 1 - .../components/design_management/design.scss | 74 +++- .../stylesheets/lazy_bundles/cropper.css | 378 ++++++++++++++++++ app/controllers/help_controller.rb | 1 + app/controllers/ide_controller.rb | 2 + .../import/available_namespaces_controller.rb | 2 + app/controllers/import/base_controller.rb | 1 + .../import/bulk_imports_controller.rb | 2 + .../import/gitlab_groups_controller.rb | 2 + app/controllers/invites_controller.rb | 2 + .../jira_connect/application_controller.rb | 2 + app/controllers/jwt_controller.rb | 2 + .../notification_settings_controller.rb | 2 + .../oauth/jira/authorizations_controller.rb | 2 + .../omniauth_callbacks_controller.rb | 2 + .../experience_levels_controller.rb | 2 + app/controllers/registrations_controller.rb | 2 + .../git_http_client_controller.rb | 2 + app/controllers/runner_setup_controller.rb | 2 + app/controllers/search_controller.rb | 2 + .../sent_notifications_controller.rb | 2 + app/controllers/sessions_controller.rb | 2 + .../snippets/application_controller.rb | 2 + app/controllers/snippets/notes_controller.rb | 2 + app/controllers/uploads_controller.rb | 2 + app/controllers/user_callouts_controller.rb | 2 + app/controllers/users/terms_controller.rb | 2 + app/controllers/users_controller.rb | 2 + app/graphql/types/merge_request_type.rb | 7 + app/graphql/types/package_type_enum.rb | 2 +- app/models/ci/build.rb | 5 + app/models/ci/pipeline.rb | 7 + app/models/packages/event.rb | 2 +- app/models/packages/package.rb | 2 +- .../packages/pypi/package_presenter.rb | 4 +- app/serializers/build_details_entity.rb | 2 +- app/serializers/pipeline_entity.rb | 4 +- .../ci/build_report_result_service.rb | 29 +- .../system_notes/issuables_service.rb | 21 + app/views/profiles/show.html.haml | 2 +- .../219951-improve-styling-of-design-pins.yml | 5 + ...8-track-additional-issue-change-events.yml | 5 + ...educe-cached-query-jobscontroller-show.yml | 5 + .../unreleased/242285-approve-graphql-ce.yml | 5 + .../251113-create_framework_model.yml | 5 + ...ame-column-to-namespace_settings-table.yml | 5 + .../eb-unit-tests-parsed-usage-ping.yml | 5 + .../unreleased/fix-spelling-of-pypi.yml | 5 + ...feature-fix-keep-path-artifact-locking.yml | 5 + .../mc-feature-project-ci-lint-api.yml | 5 + .../unreleased/tz-lazy-load-cropper.yml | 5 + config/application.rb | 1 + .../track_unique_test_cases_parsed.yml | 7 + .../usage_data_i_testing_test_case_parsed.yml | 7 + ...fault_branch_name_to_namespace_settings.rb | 15 + ..._namespace_settings_default_branch_name.rb | 19 + ...22075244_add_compliance_framework_model.rb | 32 ++ db/schema_migrations/20200919200318 | 1 + db/schema_migrations/20200919204155 | 1 + db/schema_migrations/20200922075244 | 1 + db/structure.sql | 36 +- .../geo/replication/datatypes.md | 2 +- doc/administration/gitaly/index.md | 13 +- doc/administration/gitaly/praefect.md | 4 +- doc/administration/packages/index.md | 2 +- .../reference_architectures/10k_users.md | 2 +- .../reference_architectures/25k_users.md | 2 +- .../reference_architectures/2k_users.md | 2 +- .../reference_architectures/3k_users.md | 2 +- .../reference_architectures/50k_users.md | 2 +- .../reference_architectures/5k_users.md | 2 +- .../graphql/reference/gitlab_schema.graphql | 67 +++- doc/api/graphql/reference/gitlab_schema.json | 179 ++++++++- doc/api/graphql/reference/index.md | 27 +- doc/api/lint.md | 48 +++ doc/development/internal_api.md | 1 + doc/integration/elasticsearch.md | 2 +- doc/raketasks/backup_restore.md | 2 +- doc/user/packages/pypi_repository/index.md | 20 +- lib/api/entities/ci/lint/result.rb | 16 + lib/api/lint.rb | 19 + lib/gitlab/ci/lint.rb | 7 +- .../ci/pipeline/chain/config/process.rb | 2 + lib/gitlab/ci/reports/test_case.rb | 6 +- lib/gitlab/ci/reports/test_suite.rb | 16 +- lib/gitlab/redis/hll.rb | 16 +- .../issue_activity_unique_counter.rb | 35 ++ .../usage_data_counters/known_events.yml | 33 ++ locale/gitlab.pot | 4 +- scripts/review_apps/review-apps.sh | 4 +- spec/controllers/every_controller_spec.rb | 14 +- .../projects/jobs_controller_spec.rb | 42 +- spec/factories/packages.rb | 4 + .../design_note_pin_spec.js.snap | 18 +- .../components/design_note_pin_spec.js | 17 - .../components/design_overlay_spec.js | 6 +- .../packages/details/store/getters_spec.js | 2 +- .../packages_list_app_spec.js.snap | 6 +- spec/frontend/packages/shared/utils_spec.js | 2 +- spec/graphql/types/merge_request_type_spec.rb | 3 +- spec/graphql/types/package_type_enum_spec.rb | 2 +- spec/lib/gitlab/ci/lint_spec.rb | 43 +- spec/lib/gitlab/ci/reports/test_suite_spec.rb | 14 + .../gitlab/closing_issue_extractor_spec.rb | 19 +- spec/lib/gitlab/redis/hll_spec.rb | 30 +- .../hll_redis_counter_spec.rb | 2 +- .../issue_activity_unique_counter_spec.rb | 70 ++++ spec/lib/gitlab/usage_data_spec.rb | 4 +- spec/models/ci/build_spec.rb | 48 +++ .../graphql/project/merge_requests_spec.rb | 22 + spec/requests/api/lint_spec.rb | 111 +++++ spec/requests/api/pypi_packages_spec.rb | 146 +++---- .../ci/build_report_result_service_spec.rb | 21 +- .../api/pypi_packages_shared_examples.rb | 12 +- .../services/packages_shared_examples.rb | 1 + 122 files changed, 1725 insertions(+), 281 deletions(-) create mode 100644 app/assets/javascripts/lib/utils/css_utils.js create mode 100644 app/assets/stylesheets/lazy_bundles/cropper.css create mode 100644 changelogs/unreleased/219951-improve-styling-of-design-pins.yml create mode 100644 changelogs/unreleased/229918-track-additional-issue-change-events.yml create mode 100644 changelogs/unreleased/231467-reduce-cached-query-jobscontroller-show.yml create mode 100644 changelogs/unreleased/242285-approve-graphql-ce.yml create mode 100644 changelogs/unreleased/251113-create_framework_model.yml create mode 100644 changelogs/unreleased/251935-add-default_branch_name-column-to-namespace_settings-table.yml create mode 100644 changelogs/unreleased/eb-unit-tests-parsed-usage-ping.yml create mode 100644 changelogs/unreleased/fix-spelling-of-pypi.yml create mode 100644 changelogs/unreleased/mc-feature-fix-keep-path-artifact-locking.yml create mode 100644 changelogs/unreleased/mc-feature-project-ci-lint-api.yml create mode 100644 changelogs/unreleased/tz-lazy-load-cropper.yml create mode 100644 config/feature_flags/development/track_unique_test_cases_parsed.yml create mode 100644 config/feature_flags/development/usage_data_i_testing_test_case_parsed.yml create mode 100644 db/migrate/20200919200318_add_default_branch_name_to_namespace_settings.rb create mode 100644 db/migrate/20200919204155_add_text_limit_to_namespace_settings_default_branch_name.rb create mode 100644 db/migrate/20200922075244_add_compliance_framework_model.rb create mode 100644 db/schema_migrations/20200919200318 create mode 100644 db/schema_migrations/20200919204155 create mode 100644 db/schema_migrations/20200922075244 create mode 100644 lib/api/entities/ci/lint/result.rb diff --git a/.gitlab/ci/review.gitlab-ci.yml b/.gitlab/ci/review.gitlab-ci.yml index fab33dd3c07..0fd2c01bb04 100644 --- a/.gitlab/ci/review.gitlab-ci.yml +++ b/.gitlab/ci/review.gitlab-ci.yml @@ -72,7 +72,7 @@ review-deploy: - download_chart - date - deploy || (display_deployment_debug && exit 1) - - disable_sign_ups + - disable_sign_ups || (delete_release && exit 1) # When the job is manual, review-qa-smoke is also manual and we don't want people # to have to manually start the jobs in sequence, so we do it for them. - '[ -z $CI_JOB_MANUAL ] || play_job "review-qa-smoke"' diff --git a/app/assets/javascripts/design_management/components/design_note_pin.vue b/app/assets/javascripts/design_management/components/design_note_pin.vue index 2b5e62c2870..320e0654aab 100644 --- a/app/assets/javascripts/design_management/components/design_note_pin.vue +++ b/app/assets/javascripts/design_management/components/design_note_pin.vue @@ -17,19 +17,11 @@ export default { required: false, default: null, }, - repositioning: { - type: Boolean, - required: false, - default: false, - }, }, computed: { isNewNote() { return this.label === null; }, - pinStyle() { - return this.repositioning ? { ...this.position, cursor: 'move' } : this.position; - }, pinLabel() { return this.isNewNote ? __('Comment form position') @@ -41,13 +33,13 @@ export default {