From 55a8c39b971ce3acef77daebfe0d23befd802fd7 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 26 Feb 2025 18:12:12 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 6 +- .rubocop_todo/style/symbol_proc.yml | 12 - CHANGELOG.md | 35 +++ GITLAB_KAS_VERSION | 2 +- .../ci_environments_dropdown.vue | 6 + .../components/ci_variable_drawer.vue | 11 +- .../services/serialization_helpers.js | 14 +- .../services/serializer/image.js | 7 +- .../services/serializer/link.js | 16 +- .../notes/components/note_body.vue | 14 +- .../projects/commit/rapid_diffs/index.js | 14 +- .../pages/projects/commit/show/index.js | 2 + app/assets/javascripts/popovers/index.js | 18 +- .../javascripts/rapid_diffs/diff_file.js | 2 +- .../rapid_diffs/expand_lines/adapter.js | 51 ++-- .../rapid_diffs/expand_lines/diff_line_row.js | 20 ++ .../rapid_diffs/expand_lines/get_lines.js | 85 ++++-- .../components/states/ready_to_merge.vue | 2 +- .../states/ready_to_merge.fragment.graphql | 2 +- .../entity_select/init_project_selects.js | 2 + .../entity_select/project_select.vue | 6 + .../shared/work_item_token_input.vue | 16 +- .../rapid_diffs/text_file_viewers.scss | 25 +- .../rapid_diffs/diff_file_component.rb | 2 +- .../text/expand_lines_component.html.haml | 7 +- .../text/inline_hunk_component.html.haml | 2 +- .../viewers/text/inline_hunk_component.rb | 4 - .../text/line_number_component.html.haml | 2 +- .../text/parallel_hunk_component.html.haml | 2 +- .../viewers/text/parallel_hunk_component.rb | 4 - .../clusters/clusters_controller.rb | 5 +- .../event_forward/event_forward_controller.rb | 28 ++ app/controllers/event_forward/logger.rb | 9 + app/controllers/profiles_controller.rb | 8 +- app/controllers/projects/commit_controller.rb | 1 + .../resolvers/repositories/commit_resolver.rb | 22 ++ app/graphql/types/repository_type.rb | 4 + app/helpers/clusters_helper.rb | 30 +++ app/models/clusters/agent_migration.rb | 2 + app/models/commit.rb | 2 +- app/models/concerns/cached_commit.rb | 2 +- app/models/container_repository.rb | 2 +- app/models/discussion.rb | 2 +- app/models/integrations/prometheus.rb | 4 +- app/models/members/project_member.rb | 4 +- app/models/packages/conan/package_revision.rb | 6 +- app/models/packages/conan/recipe_revision.rb | 6 +- .../merge_request_diff_preloader.rb | 2 +- app/models/release.rb | 2 +- app/presenters/clusters/cluster_presenter.rb | 4 + .../clusters/migration/create_service.rb | 18 +- .../clusters/clusters/_migrate.html.haml | 80 +++++- .../clusters/clusters/_migrate_tab.html.haml | 1 + .../commit/_signature_badge.html.haml | 2 +- .../projects/commit/rapid_diffs.html.haml | 6 +- .../inactive_tokens_deletion_cron_worker.rb | 7 +- config/routes.rb | 2 + ...t-da-deprecate-cov-guided-fuzz-testing.yml | 24 ++ ...em_type_custom_fields_work_item_type_id.rb | 24 ++ ...em_type_custom_fields_work_item_type_id.rb | 26 ++ ...type_user_preferences_work_item_type_id.rb | 24 ++ ...type_user_preferences_work_item_type_id.rb | 26 ++ db/schema_migrations/20250220004946 | 1 + db/schema_migrations/20250220005723 | 1 + db/schema_migrations/20250225001149 | 1 + db/schema_migrations/20250225001333 | 1 + db/structure.sql | 12 +- doc/.vale/gitlab_base/spelling-exceptions.txt | 20 +- .../monitoring/prometheus/gitlab_metrics.md | 2 +- doc/api/graphql/reference/_index.md | 12 + doc/ci/variables/predefined_variables.md | 250 +++++++++--------- doc/topics/git/img/revert_v14_0.png | Bin 11230 -> 0 bytes doc/topics/git/undo.md | 17 +- doc/update/deprecations.md | 22 ++ .../application_security/policies/_index.md | 1 + doc/user/glql/fields.md | 193 +++++++++++++- doc/user/profile/account/create_accounts.md | 16 +- lib/bulk_imports/ndjson_pipeline.rb | 2 +- lib/container_registry/client.rb | 8 +- lib/container_registry/gitlab_api_client.rb | 4 +- .../analytics/cycle_analytics/stage_events.rb | 2 +- lib/gitlab/diff/viewer_hunk.rb | 5 +- lib/gitlab/tracking/destinations/snowplow.rb | 24 +- locale/gitlab.pot | 55 +++- scripts/database/query_analyzers.rb | 2 +- scripts/database/query_analyzers.yml | 2 + scripts/database/query_analyzers/base.rb | 2 +- .../query_analyzers/jsonb_scan_detector.rb | 46 ++++ .../multiple_partition_scan_detector.rb | 2 +- .../rapid_diffs/diff_file_component_spec.rb | 4 +- .../text/expand_lines_component_spec.rb | 6 + .../text/inline_hunk_component_spec.rb | 15 +- .../text/line_number_component_spec.rb | 2 + .../text/parallel_hunk_component_spec.rb | 15 +- .../admin/clusters_controller_spec.rb | 6 +- spec/controllers/event_forward/logger_spec.rb | 15 ++ .../groups/clusters_controller_spec.rb | 7 +- .../projects/clusters_controller_spec.rb | 7 +- spec/factories/clusters/agent_migrations.rb | 1 + .../clusters/cluster_detail_page_spec.rb | 85 ++++++ .../services/serializer/image_spec.js | 8 + .../services/serializer/link_spec.js | 11 + spec/frontend/popovers/index_spec.js | 21 ++ spec/frontend/rapid_diffs/diff_file_spec.js | 5 +- .../rapid_diffs/expand_lines/adapter_spec.js | 81 ++++++ .../expand_lines/diff_line_row_spec.js | 33 +++ .../expand_lines/get_lines_spec.js | 81 ++++++ .../entity_select/project_select_spec.js | 3 + .../shared/work_item_token_input_spec.js | 33 ++- .../repositories/commit_resolver_spec.rb | 33 +++ spec/graphql/types/repository_type_spec.rb | 4 +- spec/helpers/clusters_helper_spec.rb | 56 ++++ spec/lib/gitlab/diff/viewer_hunk_spec.rb | 6 + .../tracking/destinations/snowplow_spec.rb | 13 + .../packages/conan/package_revision_spec.rb | 34 ++- .../packages/conan/recipe_revision_spec.rb | 34 ++- .../clusters/cluster_presenter_spec.rb | 29 ++ .../api/graphql/project/repository_spec.rb | 28 ++ .../event_forward_controller_spec.rb | 48 ++++ .../jsonb_scan_detector_spec.rb | 54 ++++ .../clusters/migration/create_service_spec.rb | 10 +- .../lib/api/access_token_shared_examples.rb | 136 ++++++++++ ...active_tokens_deletion_cron_worker_spec.rb | 22 ++ tooling/lib/tooling/test_map_generator.rb | 2 +- 124 files changed, 2011 insertions(+), 416 deletions(-) create mode 100644 app/assets/javascripts/rapid_diffs/expand_lines/diff_line_row.js create mode 100644 app/controllers/event_forward/event_forward_controller.rb create mode 100644 app/controllers/event_forward/logger.rb create mode 100644 app/graphql/resolvers/repositories/commit_resolver.rb create mode 100644 data/deprecations/17-9-ast-da-deprecate-cov-guided-fuzz-testing.yml create mode 100644 db/post_migrate/20250220004946_new_fk_for_work_item_type_custom_fields_work_item_type_id.rb create mode 100644 db/post_migrate/20250220005723_drop_old_fk_for_work_item_type_custom_fields_work_item_type_id.rb create mode 100644 db/post_migrate/20250225001149_new_fk_for_work_item_type_user_preferences_work_item_type_id.rb create mode 100644 db/post_migrate/20250225001333_drop_old_fk_for_work_item_type_user_preferences_work_item_type_id.rb create mode 100644 db/schema_migrations/20250220004946 create mode 100644 db/schema_migrations/20250220005723 create mode 100644 db/schema_migrations/20250225001149 create mode 100644 db/schema_migrations/20250225001333 delete mode 100644 doc/topics/git/img/revert_v14_0.png create mode 100644 scripts/database/query_analyzers/jsonb_scan_detector.rb create mode 100644 spec/controllers/event_forward/logger_spec.rb create mode 100644 spec/frontend/rapid_diffs/expand_lines/adapter_spec.js create mode 100644 spec/frontend/rapid_diffs/expand_lines/diff_line_row_spec.js create mode 100644 spec/frontend/rapid_diffs/expand_lines/get_lines_spec.js create mode 100644 spec/graphql/resolvers/repositories/commit_resolver_spec.rb create mode 100644 spec/requests/event_forward/event_forward_controller_spec.rb create mode 100644 spec/scripts/database/query_analyzers/jsonb_scan_detector_spec.rb create mode 100644 spec/support/shared_examples/lib/api/access_token_shared_examples.rb diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 5e8fd72fab5..e78c91baee0 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -795,7 +795,6 @@ lib/gitlab/checks/** /doc/api/import.md @ashrafkhamis /doc/api/instance_clusters.md @z_painter /doc/api/instance_level_ci_variables.md @marcel.amirault -/doc/api/integrations.md @ashrafkhamis /doc/api/invitations.md @emily.sahlani /doc/api/issue_links.md @msedlakjakubowski /doc/api/issues.md @msedlakjakubowski @@ -840,6 +839,7 @@ lib/gitlab/checks/** /doc/api/project_clusters.md @z_painter /doc/api/project_forks.md @emily.sahlani /doc/api/project_import_export.md @ashrafkhamis +/doc/api/project_integrations.md @ashrafkhamis /doc/api/project_job_token_scopes.md @marcel.amirault /doc/api/project_level_variables.md @marcel.amirault /doc/api/project_markdown_uploads.md @msedlakjakubowski @@ -1027,7 +1027,7 @@ lib/gitlab/checks/** /doc/raketasks/x509_signatures.md @brendan777 /doc/security/ @idurham /doc/security/hardening_nist_800_53.md @emily.sahlani -/doc/solutions/ @jfullam @brianwald @Darwinjs +/doc/solutions/ @jfullam @Darwinjs @sbrightwell /doc/solutions/integrations/servicenow.md @ashrafkhamis /doc/subscriptions/ @lciutacu /doc/subscriptions/gitlab_com/ @lyspin @@ -1111,8 +1111,6 @@ lib/gitlab/checks/** /doc/user/group/_index.md @emily.sahlani /doc/user/group/access_and_permissions.md @emily.sahlani /doc/user/group/clusters/ @z_painter -/doc/user/group/compliance_frameworks.md @eread -/doc/user/group/compliance_pipelines.md @eread /doc/user/group/contribution_analytics/ @lciutacu /doc/user/group/credentials_inventory.md @idurham /doc/user/group/custom_project_templates.md @brendan777 diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index 27e3107eb85..b0ebcbd4b84 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -2,15 +2,8 @@ # Cop supports --autocorrect. Style/SymbolProc: Exclude: - - 'app/controllers/profiles_controller.rb' - 'app/models/ci/pipeline.rb' - - 'app/models/container_repository.rb' - - 'app/models/discussion.rb' - 'app/models/environment.rb' - - 'app/models/integrations/prometheus.rb' - - 'app/models/members/project_member.rb' - - 'app/models/preloaders/merge_request_diff_preloader.rb' - - 'app/models/release.rb' - 'app/models/remote_mirror.rb' - 'app/models/snippet_input_action_collection.rb' - 'app/policies/group_policy.rb' @@ -95,10 +88,6 @@ Style/SymbolProc: - 'lib/api/helpers/internal_helpers.rb' - 'lib/atlassian/jira_connect/serializers/base_entity.rb' - 'lib/bulk_imports/common/pipelines/entity_finisher.rb' - - 'lib/bulk_imports/ndjson_pipeline.rb' - - 'lib/container_registry/client.rb' - - 'lib/container_registry/gitlab_api_client.rb' - - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' - 'lib/gitlab/auth/o_auth/auth_hash.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' @@ -188,4 +177,3 @@ Style/SymbolProc: - 'spec/support/shared_examples/models/label_note_shared_examples.rb' - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - 'spec/workers/snippets/schedule_bulk_repository_shard_moves_worker_spec.rb' - - 'tooling/lib/tooling/test_map_generator.rb' diff --git a/CHANGELOG.md b/CHANGELOG.md index 35be130f23f..0989e16c57e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,19 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. +## 17.9.1 (2025-02-26) + +### Fixed (1 change) + +- [Fix instance level dashboard by default severity override](https://gitlab.com/gitlab-org/security/gitlab/-/commit/56d2f940bb6e87b34e4f26ba9a298f28360dd23a) **GitLab Enterprise Edition** + +### Security (4 changes) + +- [Increase minimum role in SPP to read policy yaml](https://gitlab.com/gitlab-org/security/gitlab/-/commit/593c0a6f70564e9570fb16b25a37298eacf6c644) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4718)) +- [Fix access to read code review analytics in private projects](https://gitlab.com/gitlab-org/security/gitlab/-/commit/0faa526c76e3c523ff6486057c5b5b07e8e4e5d9) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4794)) +- [Escape work item dropdown items and restrict HTML tags](https://gitlab.com/gitlab-org/security/gitlab/-/commit/fc777a98ebd45b30ab95bc0d94a418479d15f09c) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4788)) +- [Use stricter CSP values in the packages dependency proxy](https://gitlab.com/gitlab-org/security/gitlab/-/commit/922d3ad17cf7493a10f8dbf90c0cae8d9d4b063d) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4787)) + ## 17.9.0 (2025-02-19) ### Added (202 changes) @@ -1083,6 +1096,15 @@ entry. - [Quarantine a flaky test](https://gitlab.com/gitlab-org/gitlab/-/commit/c932e35efdc0e3c6f316a3c2d37045e115ce8cd5) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/176452)) - [Finalize migration BackfillRemoteDevelopmentAgentConfigsProjectId](https://gitlab.com/gitlab-org/gitlab/-/commit/da4c63d7aab3685c3fbe9d1e48f68ba2162a0b5e) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/172769)) +## 17.8.4 (2025-02-26) + +### Security (4 changes) + +- [Increase minimum role in SPP to read policy yaml](https://gitlab.com/gitlab-org/security/gitlab/-/commit/9bfcf4a596b965ce73426d68861cec83ee70f19e) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4716)) +- [Fix access to read code review analytics in private projects](https://gitlab.com/gitlab-org/security/gitlab/-/commit/537159f505cad7d23cded01140fbdfd84e9cdfa2) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4758)) +- [Escape work item dropdown items and restrict HTML tags](https://gitlab.com/gitlab-org/security/gitlab/-/commit/5548168c3d4e0ba660ed934f23c332045a640799) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4784)) +- [Use stricter CSP values in the packages dependency proxy](https://gitlab.com/gitlab-org/security/gitlab/-/commit/d491abd511c9c1cb00c928e28dc84cb7ef8e4cd3) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4764)) + ## 17.8.3 (2025-02-21) ### Fixed (2 changes) @@ -1574,6 +1596,19 @@ entry. - [Remove default on `group_saved_replies_flag feature flag](https://gitlab.com/gitlab-org/gitlab/-/commit/75d49fe13646e1e0d3b68233ac4a965c86853917) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/175647)) - [Remove use_actual_plan_in_license_check flag](https://gitlab.com/gitlab-org/gitlab/-/commit/b8c3fe16aedb69c82ff52d1c695d72e933c4b946) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/175649)) +## 17.7.6 (2025-02-26) + +### Fixed (1 change) + +- [Fix failed jobs widget polling issue](https://gitlab.com/gitlab-org/security/gitlab/-/commit/e2154d3d886d82e1f5fe62fb9d234d00e257e784) + +### Security (4 changes) + +- [Increase minimum role in SPP to read policy yaml](https://gitlab.com/gitlab-org/security/gitlab/-/commit/6d5c2ea1feb6097cb5720650f39b3808554b6a29) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4717)) +- [Fix access to read code review analytics in private projects](https://gitlab.com/gitlab-org/security/gitlab/-/commit/4454c18d19d2d8df92520f4c0fafa24ddbf9fbe4) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4757)) +- [Escape work item dropdown items and restrict HTML tags](https://gitlab.com/gitlab-org/security/gitlab/-/commit/a834b94cf4e967065590f6b78b15c8733d67df30) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4785)) +- [Use stricter CSP values in the packages dependency proxy](https://gitlab.com/gitlab-org/security/gitlab/-/commit/d975b402434b9e17ff2963d9c4c6f438f52545ed) ([merge request](https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/4765)) + ## 17.7.5 (2025-02-21) ### Fixed (1 change) diff --git a/GITLAB_KAS_VERSION b/GITLAB_KAS_VERSION index 79614cfc4af..5af311270d3 100644 --- a/GITLAB_KAS_VERSION +++ b/GITLAB_KAS_VERSION @@ -1 +1 @@ -afc35fcc49db7d999d74b4f2fcccc2625567bd75 +efced52dc4e4f9f202e32dc6239573d4aceb4d4e diff --git a/app/assets/javascripts/ci/ci_environments_dropdown/ci_environments_dropdown.vue b/app/assets/javascripts/ci/ci_environments_dropdown/ci_environments_dropdown.vue index 3ef23f6e5f7..dc6cefb537f 100644 --- a/app/assets/javascripts/ci/ci_environments_dropdown/ci_environments_dropdown.vue +++ b/app/assets/javascripts/ci/ci_environments_dropdown/ci_environments_dropdown.vue @@ -58,6 +58,11 @@ export default { required: false, default: '', }, + ariaLabelledBy: { + type: String, + required: false, + default: '', + }, }, data() { return { @@ -158,6 +163,7 @@ export default { :loading="isDropdownLoading" :searching="isDropdownSearching" :toggle-text="toggleText" + :toggle-aria-labelled-by="ariaLabelledBy" @search="debouncedSearch" @select="selectEnvironment" @shown="toggleDropdownShown(true)" diff --git a/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue b/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue index 79fbb25269f..e3ea7c56312 100644 --- a/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue +++ b/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_drawer.vue @@ -482,16 +482,18 @@ export default { + {{ $options.i18n.type }} @@ -499,12 +501,12 @@ export default {