From 57e2488085b623e4b48a6b8518e844fa842b6f4a Mon Sep 17 00:00:00 2001 From: Alexis Reigel Date: Thu, 23 Nov 2017 13:51:15 +0100 Subject: [PATCH] we only need a test for the happy path the failure case is already covered by the test in spec/services/test_hooks/system_service_spec.rb --- spec/features/admin/admin_hooks_spec.rb | 8 -------- 1 file changed, 8 deletions(-) diff --git a/spec/features/admin/admin_hooks_spec.rb b/spec/features/admin/admin_hooks_spec.rb index 197e6cd07c4..725e603d1e3 100644 --- a/spec/features/admin/admin_hooks_spec.rb +++ b/spec/features/admin/admin_hooks_spec.rb @@ -119,14 +119,6 @@ describe 'Admin::Hooks' do WebMock.stub_request(:post, system_hook.url) end - it 'fails if the user does not have any repository with a merge request' do - visit admin_hooks_path - find('.hook-test-button.dropdown').click - click_link 'Merge requests events' - - expect(page).to have_content 'Ensure one of your projects has merge requests.' - end - it 'succeeds if the user has a repository with a merge request' do project = create(:project, :repository) create(:project_member, user: user, project: project)