diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index b9d73d7770d..29887881da5 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -134,7 +134,7 @@ rubocop: unset CI_SLACK_WEBHOOK_URL run_timed_command "fail_on_warnings bundle exec rake rubocop:check:graceful" else - cat "${RSPEC_CHANGED_FILES_PATH}" | ruby -e 'print $stdin.read.split(" ").select { |f| File.exist?(f) }.join(" ")' > "$RUBOCOP_TARGET_FILES" + select_existing_files < "${RSPEC_CHANGED_FILES_PATH}" > "${RUBOCOP_TARGET_FILES}" # Skip running RuboCop if there's no target files if [ -s "${RUBOCOP_TARGET_FILES}" ]; then run_timed_command "fail_on_warnings bundle exec rubocop --parallel --force-exclusion $(cat ${RUBOCOP_TARGET_FILES})" diff --git a/.rubocop_todo/naming/inclusive_language.yml b/.rubocop_todo/naming/inclusive_language.yml index 9d1e98f87d3..271286d4752 100644 --- a/.rubocop_todo/naming/inclusive_language.yml +++ b/.rubocop_todo/naming/inclusive_language.yml @@ -1,26 +1,19 @@ --- Naming/InclusiveLanguage: Exclude: - - 'app/controllers/admin/application_settings/appearances_controller.rb' - - 'app/controllers/concerns/requires_whitelisted_monitoring_client.rb' - - 'app/controllers/health_check_controller.rb' - - 'app/controllers/health_controller.rb' - - 'app/controllers/metrics_controller.rb' + - 'app/controllers/concerns/requires_allowlisted_monitoring_client.rb' - 'app/helpers/application_settings_helper.rb' - - 'app/helpers/blob_helper.rb' - 'app/helpers/markup_helper.rb' - 'app/models/application_setting.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/services/application_settings/update_service.rb' - - 'app/services/projects/download_service.rb' - 'app/uploaders/avatar_uploader.rb' - 'app/uploaders/content_type_whitelist.rb' - 'app/uploaders/design_management/design_v432x230_uploader.rb' - 'app/uploaders/favicon_uploader.rb' - 'app/uploaders/gitlab_uploader.rb' - 'app/uploaders/import_export_uploader.rb' - - 'app/validators/cron_validator.rb' - 'app/validators/qualified_domain_array_validator.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/doorkeeper.rb' @@ -28,14 +21,12 @@ Naming/InclusiveLanguage: - 'ee/app/controllers/projects/push_rules_controller.rb' - 'ee/lib/arkose/verify_response.rb' - 'ee/lib/system_check/geo/http_connection_check.rb' - - 'ee/spec/models/dora/lead_time_for_changes_metric_spec.rb' - 'lib/api/entities/application_setting.rb' - 'lib/api/settings.rb' - 'lib/banzai/filter/asset_proxy_filter.rb' - 'lib/gitlab/asset_proxy.rb' - 'lib/gitlab/auth/ip_rate_limiter.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - - 'lib/gitlab/git/hook_env.rb' - 'lib/gitlab/github_import/markdown/attachment.rb' - 'lib/gitlab/markdown_cache/active_record/extension.rb' - 'lib/gitlab/markdown_cache/field_data.rb' @@ -44,9 +35,6 @@ Naming/InclusiveLanguage: - 'lib/gitlab/sanitizers/svg.rb' - 'lib/gitlab/sanitizers/svg/whitelist.rb' - 'lib/system_check/app/git_user_default_ssh_config_check.rb' - - 'rubocop/cop/avoid_return_from_blocks.rb' - - 'rubocop/cop/graphql/id_type.rb' - - 'spec/controllers/concerns/issuable_collections_spec.rb' - 'spec/controllers/health_check_controller_spec.rb' - 'spec/controllers/metrics_controller_spec.rb' - 'spec/helpers/markup_helper_spec.rb' @@ -61,17 +49,7 @@ Naming/InclusiveLanguage: - 'spec/models/application_setting_spec.rb' - 'spec/requests/api/settings_spec.rb' - 'spec/requests/health_controller_spec.rb' - - 'spec/rubocop/cop/avoid_return_from_blocks_spec.rb' - - 'spec/rubocop/cop/graphql/id_type_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - - 'spec/services/design_management/generate_image_versions_service_spec.rb' - - 'spec/services/projects/download_service_spec.rb' - - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/shared_contexts/upload_type_check_shared_context.rb' - - 'spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - - 'spec/uploaders/avatar_uploader_spec.rb' - 'spec/uploaders/content_type_whitelist_spec.rb' - - 'spec/uploaders/design_management/design_v432x230_uploader_spec.rb' - - 'spec/uploaders/favicon_uploader_spec.rb' - - 'spec/validators/cron_validator_spec.rb' diff --git a/app/assets/javascripts/content_editor/components/content_editor.vue b/app/assets/javascripts/content_editor/components/content_editor.vue index 344df7a35c3..c6b605cd92f 100644 --- a/app/assets/javascripts/content_editor/components/content_editor.vue +++ b/app/assets/javascripts/content_editor/components/content_editor.vue @@ -227,7 +227,7 @@ export default {