From 5842aa35563dacaabf9a80307966fabe366a1321 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 11 Jul 2023 18:10:34 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 +- .rubocop_todo/naming/inclusive_language.yml | 24 +- .../components/content_editor.vue | 6 +- .../components/formatting_toolbar.vue | 236 +++++++++--------- .../services/create_content_editor.js | 5 - .../components/related_merge_requests.vue | 6 +- .../incidents/timeline_events_form.vue | 2 +- .../notes/components/comment_field_layout.vue | 20 +- .../notes/components/noteable_discussion.vue | 2 +- .../components/related_issues_block.vue | 14 +- .../components/entity_select/group_select.vue | 1 + .../entity_select/project_select.vue | 1 + .../markdown/editor_mode_switcher.vue | 2 +- .../vue_shared/components/markdown/field.vue | 5 +- .../vue_shared/components/markdown/header.vue | 4 +- .../components/markdown/markdown_editor.vue | 2 +- .../components/markdown/toolbar.vue | 36 ++- .../work_item_links/work_item_links.vue | 5 +- .../components/content_editor.scss | 5 + .../stylesheets/framework/markdown_area.scss | 3 +- .../stylesheets/framework/new_card.scss | 6 +- app/assets/stylesheets/pages/note_form.scss | 51 ++-- .../appearances_controller.rb | 2 +- .../observability/content_security_policy.rb | 21 +- ...requires_allowlisted_monitoring_client.rb} | 16 +- app/controllers/health_check_controller.rb | 2 +- app/controllers/health_controller.rb | 2 +- app/controllers/metrics_controller.rb | 2 +- .../projects/tracing_controller.rb | 22 ++ app/helpers/blob_helper.rb | 4 +- app/services/projects/download_service.rb | 4 +- app/validators/cron_validator.rb | 8 +- app/views/shared/_md_preview.html.haml | 4 +- app/views/shared/notes/_hints.html.haml | 6 +- .../development/observability_tracing.yml | 8 + .../packages_dependency_proxy_maven.yml | 8 + config/routes/project.rb | 2 + .../dependency_proxy_packages_settings.yml | 2 +- doc/development/pipelines/internals.md | 1 + doc/subscriptions/gitlab_com/index.md | 5 + doc/update/index.md | 2 + .../settings/sign_in_restrictions.md | 8 +- .../dependency_scanning/index.md | 9 +- .../iac_scanning/index.md | 11 +- doc/user/application_security/index.md | 36 ++- doc/user/application_security/sast/index.md | 25 +- .../secret_detection/index.md | 21 +- doc/user/search/command_palette.md | 28 +++ lib/api/helpers/packages/maven.rb | 22 ++ lib/api/maven_packages.rb | 6 +- lib/gitlab/git/hook_env.rb | 8 +- lib/gitlab/observability.rb | 13 +- lib/sidebars/projects/menus/monitor_menu.rb | 15 ++ .../super_sidebar_menus/monitor_menu.rb | 1 + locale/gitlab.pot | 3 + rubocop/cop/avoid_return_from_blocks.rb | 8 +- rubocop/cop/graphql/id_type.rb | 4 +- scripts/rspec_helpers.sh | 2 +- scripts/utils.sh | 4 + .../concerns/issuable_collections_spec.rb | 4 +- .../services/create_content_editor_spec.js | 8 - .../components/related_issues_block_spec.js | 47 ++-- .../snippet_description_edit_spec.js.snap | 2 +- .../entity_select/group_select_spec.js | 12 + .../entity_select/project_select_spec.js | 12 + spec/lib/gitlab/observability_spec.rb | 27 ++ .../projects/menus/monitor_menu_spec.rb | 18 +- .../super_sidebar_menus/monitor_menu_spec.rb | 1 + .../groups/observability_controller_spec.rb | 4 + .../projects/issues_controller_spec.rb | 7 + .../projects/merge_requests/creations_spec.rb | 20 +- .../merge_requests_controller_spec.rb | 1 + .../projects/tracing_controller_spec.rb | 56 +++++ .../cop/avoid_return_from_blocks_spec.rb | 10 +- spec/rubocop/cop/graphql/id_type_spec.rb | 4 +- .../generate_image_versions_service_spec.rb | 2 +- .../projects/download_service_spec.rb | 4 +- .../import_export/export_file_helper.rb | 2 +- .../navbar_structure_context.rb | 1 + .../sanitization_filter_shared_examples.rb | 2 +- .../observability/csp_shared_examples.rb | 190 ++++++++------ spec/uploaders/avatar_uploader_spec.rb | 6 +- .../design_v432x230_uploader_spec.rb | 6 +- spec/uploaders/favicon_uploader_spec.rb | 6 +- spec/validators/cron_validator_spec.rb | 4 +- 85 files changed, 753 insertions(+), 486 deletions(-) rename app/controllers/concerns/{requires_whitelisted_monitoring_client.rb => requires_allowlisted_monitoring_client.rb} (63%) create mode 100644 app/controllers/projects/tracing_controller.rb create mode 100644 config/feature_flags/development/observability_tracing.yml create mode 100644 config/feature_flags/development/packages_dependency_proxy_maven.yml create mode 100644 doc/user/search/command_palette.md create mode 100644 lib/api/helpers/packages/maven.rb create mode 100644 spec/requests/projects/tracing_controller_spec.rb diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index b9d73d7770d..29887881da5 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -134,7 +134,7 @@ rubocop: unset CI_SLACK_WEBHOOK_URL run_timed_command "fail_on_warnings bundle exec rake rubocop:check:graceful" else - cat "${RSPEC_CHANGED_FILES_PATH}" | ruby -e 'print $stdin.read.split(" ").select { |f| File.exist?(f) }.join(" ")' > "$RUBOCOP_TARGET_FILES" + select_existing_files < "${RSPEC_CHANGED_FILES_PATH}" > "${RUBOCOP_TARGET_FILES}" # Skip running RuboCop if there's no target files if [ -s "${RUBOCOP_TARGET_FILES}" ]; then run_timed_command "fail_on_warnings bundle exec rubocop --parallel --force-exclusion $(cat ${RUBOCOP_TARGET_FILES})" diff --git a/.rubocop_todo/naming/inclusive_language.yml b/.rubocop_todo/naming/inclusive_language.yml index 9d1e98f87d3..271286d4752 100644 --- a/.rubocop_todo/naming/inclusive_language.yml +++ b/.rubocop_todo/naming/inclusive_language.yml @@ -1,26 +1,19 @@ --- Naming/InclusiveLanguage: Exclude: - - 'app/controllers/admin/application_settings/appearances_controller.rb' - - 'app/controllers/concerns/requires_whitelisted_monitoring_client.rb' - - 'app/controllers/health_check_controller.rb' - - 'app/controllers/health_controller.rb' - - 'app/controllers/metrics_controller.rb' + - 'app/controllers/concerns/requires_allowlisted_monitoring_client.rb' - 'app/helpers/application_settings_helper.rb' - - 'app/helpers/blob_helper.rb' - 'app/helpers/markup_helper.rb' - 'app/models/application_setting.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/services/application_settings/update_service.rb' - - 'app/services/projects/download_service.rb' - 'app/uploaders/avatar_uploader.rb' - 'app/uploaders/content_type_whitelist.rb' - 'app/uploaders/design_management/design_v432x230_uploader.rb' - 'app/uploaders/favicon_uploader.rb' - 'app/uploaders/gitlab_uploader.rb' - 'app/uploaders/import_export_uploader.rb' - - 'app/validators/cron_validator.rb' - 'app/validators/qualified_domain_array_validator.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/doorkeeper.rb' @@ -28,14 +21,12 @@ Naming/InclusiveLanguage: - 'ee/app/controllers/projects/push_rules_controller.rb' - 'ee/lib/arkose/verify_response.rb' - 'ee/lib/system_check/geo/http_connection_check.rb' - - 'ee/spec/models/dora/lead_time_for_changes_metric_spec.rb' - 'lib/api/entities/application_setting.rb' - 'lib/api/settings.rb' - 'lib/banzai/filter/asset_proxy_filter.rb' - 'lib/gitlab/asset_proxy.rb' - 'lib/gitlab/auth/ip_rate_limiter.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - - 'lib/gitlab/git/hook_env.rb' - 'lib/gitlab/github_import/markdown/attachment.rb' - 'lib/gitlab/markdown_cache/active_record/extension.rb' - 'lib/gitlab/markdown_cache/field_data.rb' @@ -44,9 +35,6 @@ Naming/InclusiveLanguage: - 'lib/gitlab/sanitizers/svg.rb' - 'lib/gitlab/sanitizers/svg/whitelist.rb' - 'lib/system_check/app/git_user_default_ssh_config_check.rb' - - 'rubocop/cop/avoid_return_from_blocks.rb' - - 'rubocop/cop/graphql/id_type.rb' - - 'spec/controllers/concerns/issuable_collections_spec.rb' - 'spec/controllers/health_check_controller_spec.rb' - 'spec/controllers/metrics_controller_spec.rb' - 'spec/helpers/markup_helper_spec.rb' @@ -61,17 +49,7 @@ Naming/InclusiveLanguage: - 'spec/models/application_setting_spec.rb' - 'spec/requests/api/settings_spec.rb' - 'spec/requests/health_controller_spec.rb' - - 'spec/rubocop/cop/avoid_return_from_blocks_spec.rb' - - 'spec/rubocop/cop/graphql/id_type_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - - 'spec/services/design_management/generate_image_versions_service_spec.rb' - - 'spec/services/projects/download_service_spec.rb' - - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/shared_contexts/upload_type_check_shared_context.rb' - - 'spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - - 'spec/uploaders/avatar_uploader_spec.rb' - 'spec/uploaders/content_type_whitelist_spec.rb' - - 'spec/uploaders/design_management/design_v432x230_uploader_spec.rb' - - 'spec/uploaders/favicon_uploader_spec.rb' - - 'spec/validators/cron_validator_spec.rb' diff --git a/app/assets/javascripts/content_editor/components/content_editor.vue b/app/assets/javascripts/content_editor/components/content_editor.vue index 344df7a35c3..c6b605cd92f 100644 --- a/app/assets/javascripts/content_editor/components/content_editor.vue +++ b/app/assets/javascripts/content_editor/components/content_editor.vue @@ -227,7 +227,7 @@ export default {