From 5e7fac8adf1a69cd690cf37e14b714a7c588d77d Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 26 Apr 2024 09:14:30 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/static-analysis.gitlab-ci.yml | 2 +- ...google_cloud_registration_instructions.vue | 97 +++++++++----- .../lib/utils/bootstrap_linked_tabs.js | 121 ------------------ .../javascripts/lib/utils/favicon_ci.js | 16 --- .../javascripts/observability/constants.js | 5 + app/assets/javascripts/observability/utils.js | 80 ++++++++++++ .../components/list/package_search.vue | 76 ++++++----- .../components/list/packages_list.vue | 1 + .../list/tokens/package_type_token.vue | 26 ---- .../package_registry/constants.js | 35 +++-- .../queries/get_packages.query.graphql | 3 + .../package_registry/pages/list.vue | 26 +++- .../packages_and_registries/shared/utils.js | 5 +- .../general/components/signup_form.vue | 4 +- .../projects/pipelines/init_pipelines.js | 33 ----- .../pages/projects/pipelines/show/index.js | 2 - app/assets/javascripts/pipelines.js | 15 --- app/services/issuable/callbacks/base.rb | 5 + .../callbacks/time_tracking.rb | 10 +- app/services/issuable_base_service.rb | 3 +- app/services/work_items/create_service.rb | 2 +- app/services/work_items/update_service.rb | 2 +- .../backup_restore/backup_gitlab.md | 46 ++----- .../backup_restore/restore_gitlab.md | 4 +- .../troubleshooting_backup_gitlab.md | 80 ++---------- .../geo/disaster_recovery/index.md | 19 --- .../runbooks/planned_failover_multi_node.md | 68 +--------- .../runbooks/planned_failover_single_node.md | 71 +--------- doc/administration/geo/index.md | 4 +- .../geo/replication/configuration.md | 2 - .../geo/replication/location_aware_git_url.md | 1 - .../geo/replication/troubleshooting/common.md | 2 - .../replication/troubleshooting/failover.md | 8 +- .../troubleshooting/replication.md | 28 ---- .../troubleshooting/synchronization.md | 83 ------------ .../geo/secondary_proxy/index.md | 3 - doc/administration/geo/setup/database.md | 8 +- doc/administration/geo_sites.md | 8 -- doc/administration/instance_limits.md | 2 +- doc/administration/maintenance_mode/index.md | 2 - doc/api/settings.md | 2 +- .../blueprints/remote_development/index.md | 2 +- doc/development/geo.md | 38 ------ doc/drawers/advanced_search_syntax.md | 2 +- doc/drawers/exact_code_search_syntax.md | 2 +- doc/update/versions/gitlab_14_changes.md | 12 +- doc/user/product_analytics/index.md | 8 ++ doc/user/workspace/configuration.md | 8 +- .../workspace/gitlab_agent_configuration.md | 4 +- lib/api/settings.rb | 4 +- locale/gitlab.pot | 46 +++++-- scripts/process_custom_semgrep_results.rb | 87 +++++++++---- spec/frontend/bootstrap_linked_tabs_spec.js | 71 ---------- ...le_cloud_registration_instructions_spec.js | 14 +- .../frontend/fixtures/static/linked_tabs.html | 20 --- spec/frontend/lib/utils/favicon_ci_spec.js | 51 -------- spec/frontend/observability/utils_spec.js | 77 ++++++++++- .../components/list/packages_search_spec.js | 27 ++-- .../list/tokens/package_type_token_spec.js | 46 ------- .../package_registry/pages/list_spec.js | 7 +- .../shared/utils_spec.js | 17 +-- spec/graphql/mutations/issues/update_spec.rb | 16 ++- .../callbacks/time_tracking_spec.rb | 10 +- .../notes/quick_actions_service_spec.rb | 5 +- workhorse/internal/transport/transport.go | 11 +- 65 files changed, 568 insertions(+), 1027 deletions(-) delete mode 100644 app/assets/javascripts/lib/utils/bootstrap_linked_tabs.js delete mode 100644 app/assets/javascripts/lib/utils/favicon_ci.js delete mode 100644 app/assets/javascripts/packages_and_registries/package_registry/components/list/tokens/package_type_token.vue delete mode 100644 app/assets/javascripts/pages/projects/pipelines/init_pipelines.js delete mode 100644 app/assets/javascripts/pipelines.js rename app/services/{work_items => issuable}/callbacks/time_tracking.rb (85%) delete mode 100644 spec/frontend/bootstrap_linked_tabs_spec.js delete mode 100644 spec/frontend/fixtures/static/linked_tabs.html delete mode 100644 spec/frontend/lib/utils/favicon_ci_spec.js delete mode 100644 spec/frontend/packages_and_registries/package_registry/components/list/tokens/package_type_token_spec.js rename spec/services/{work_items => issuable}/callbacks/time_tracking_spec.rb (95%) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 0ccda31a296..98073c7ad7b 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -234,7 +234,7 @@ ping-appsec-for-sast-findings: - .ping-appsec-for-sast-findings:rules variables: # Project Access Token bot ID for /gitlab-com/gl-security/appsec/sast-custom-rules - BOT_USER_ID: 14406065 + BOT_USER_ID: 19650678 needs: - semgrep-appsec-custom-rules script: diff --git a/app/assets/javascripts/ci/runner/components/registration/google_cloud_registration_instructions.vue b/app/assets/javascripts/ci/runner/components/registration/google_cloud_registration_instructions.vue index e5da1b2eb57..95ea8b0c144 100644 --- a/app/assets/javascripts/ci/runner/components/registration/google_cloud_registration_instructions.vue +++ b/app/assets/javascripts/ci/runner/components/registration/google_cloud_registration_instructions.vue @@ -46,14 +46,6 @@ export default { stepTwoDescription: s__( 'Runners|To view the setup instructions, complete the previous form. The instructions help you set up an autoscaling fleet of runners to execute your CI/CD jobs in Google Cloud.', ), - projectIdLabel: s__('Runners|Google Cloud project ID'), - projectIdDescription: s__( - 'Runners|To improve security, use a dedicated project for CI/CD, separate from resources and identity management projects. %{linkStart}Where’s my project ID in Google Cloud?%{linkEnd}', - ), - zonesLinkText: s__('Runners|View available zones'), - machineTypeDescription: s__( - 'Runners|For most CI/CD jobs, use a %{linkStart}N2D standard machine type%{linkEnd}.', - ), runnerSetupBtnText: s__('Runners|Setup instructions'), copyCommands: __('Copy commands'), emptyFieldsAlertMessage: s__( @@ -329,18 +321,20 @@ export default { ref="cloudProjectId" v-model="cloudProjectId" name="cloudProjectId" - :label="$options.i18n.projectIdLabel" + :label="s__('Runners|Google Cloud project ID')" :invalid-feedback-if-empty="s__('Runners|Project ID is required.')" - :invalid-feedback-if-malformed=" - s__( - 'Runners|Project ID must be 6 to 30 lowercase letters, digits, or hyphens. It needs to start with a lowercase letter and end with a letter or number.', - ) - " + :invalid-feedback-if-malformed="s__('Runners|Project ID must have the right format.')" :regexp="$options.GC_PROJECT_PATTERN" data-testid="project-id-input" > @@ -360,9 +359,7 @@ export default { v-model="region" name="region" :invalid-feedback-if-empty="s__('Runners|Region is required.')" - :invalid-feedback-if-malformed=" - s__('Runners|Region must have the correct format. Example: us-central1') - " + :invalid-feedback-if-malformed="s__('Runners|Region must have the right format.')" :regexp="$options.GC_REGION_PATTERN" data-testid="region-input" > @@ -377,6 +374,18 @@ export default { + @@ -406,10 +413,28 @@ export default { @@ -418,11 +443,7 @@ export default { v-model="machineType" name="machineType" :invalid-feedback-if-empty="s__('Runners|Machine type is required.')" - :invalid-feedback-if-malformed=" - s__( - 'Runners|Machine type must have the format `family-series-size`. Example: n2d-standard-2', - ) - " + :invalid-feedback-if-malformed="s__('Runners|Machine type must have the right format.')" :regexp="$options.GC_MACHINE_TYPE_PATTERN" data-testid="machine-type-input" > @@ -442,7 +463,13 @@ export default { diff --git a/app/assets/javascripts/lib/utils/bootstrap_linked_tabs.js b/app/assets/javascripts/lib/utils/bootstrap_linked_tabs.js deleted file mode 100644 index 286fc2568b2..00000000000 --- a/app/assets/javascripts/lib/utils/bootstrap_linked_tabs.js +++ /dev/null @@ -1,121 +0,0 @@ -import $ from 'jquery'; - -/** - * Linked Tabs - * - * Handles persisting and restores the current tab selection and content. - * Reusable component for static content. - * - * ### Example Markup - * - *