From 60028378dd5e5e7844810e4a2aa2934a58f738ca Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 8 Mar 2022 09:17:44 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- Gemfile | 2 +- Gemfile.lock | 4 +- app/assets/javascripts/boards/boards_util.js | 14 +- .../boards/components/board_form.vue | 30 +--- .../boards/components/boards_selector.vue | 3 +- app/assets/javascripts/boards/index.js | 17 +- .../javascripts/boards/stores/actions.js | 36 +++++ .../boards/stores/mutation_types.js | 3 + .../javascripts/boards/stores/mutations.js | 17 +- app/assets/javascripts/boards/stores/state.js | 1 + app/assets/javascripts/gfm_auto_complete.js | 10 +- .../javascripts/graphql_shared/constants.js | 2 + .../javascripts/lib/utils/text_markdown.js | 52 +++++- app/assets/javascripts/single_file_diff.js | 3 +- .../source_viewer/source_viewer.vue | 12 +- .../components/source_viewer/utils.js | 10 +- app/models/application_record.rb | 1 + .../concerns/sensitive_serializable_hash.rb | 46 ++++++ app/models/concerns/token_authenticatable.rb | 10 +- .../token_authenticatable_strategies/base.rb | 8 + .../digest.rb | 4 + .../encrypted.rb | 4 + app/models/wiki.rb | 4 +- ...ensitive_fields_from_serializable_hash.yml | 8 + danger/documentation/Dangerfile | 4 +- doc/administration/encrypted_configuration.md | 2 +- .../package_information/index.md | 2 +- .../package_information/licensing.md | 2 +- .../package_information/omnibus_packages.md | 2 +- .../postgresql_versions.md | 2 +- .../package_information/signed_packages.md | 2 +- doc/api/graphql/reference/index.md | 2 +- doc/api/oauth2.md | 2 +- .../index.md | 2 +- .../index.md | 2 +- doc/ci/yaml/gitlab_ci_yaml.md | 2 +- doc/development/bulk_import.md | 2 +- doc/development/contributing/design.md | 2 +- doc/development/export_csv.md | 2 +- doc/install/aws/manual_install_aws.md | 2 +- doc/integration/security_partners/index.md | 2 +- doc/update/package/convert_to_ee.md | 2 +- doc/update/package/downgrade.md | 2 +- doc/update/package/index.md | 2 +- doc/user/admin_area/reporting/spamcheck.md | 2 +- .../api_fuzzing/create_har_files.md | 2 +- doc/user/clusters/agent/gitops.md | 2 +- .../agent/gitops/secrets_management.md | 2 +- doc/user/clusters/agent/repository.md | 2 +- doc/user/clusters/agent/vulnerabilities.md | 2 +- .../group/value_stream_analytics/index.md | 2 +- .../protect/container_host_security/index.md | 2 +- .../quick_start_guide.md | 2 +- .../container_network_security/index.md | 2 +- .../quick_start_guide.md | 2 +- doc/user/project/clusters/protect/index.md | 2 +- doc/user/usage_quotas.md | 2 +- lib/gitlab/git/wiki.rb | 8 +- lib/gitlab/gitaly_client/wiki_service.rb | 5 +- lib/gitlab/json_cache.rb | 4 +- locale/gitlab.pot | 3 + .../gitlab_migration_pipeline_spec.rb | 59 +++++++ .../gitlab_project_migration_common.rb | 6 +- spec/features/markdown/copy_as_gfm_spec.rb | 9 +- ...triggers_manual_job_with_variables_spec.rb | 2 +- .../boards/components/boards_selector_spec.js | 1 + spec/frontend/boards/mock_data.js | 31 ++++ spec/frontend/boards/stores/actions_spec.js | 72 ++++++++- spec/frontend/boards/stores/mutations_spec.js | 40 ++++- spec/frontend/lib/utils/text_markdown_spec.js | 108 +++++++++++-- .../source_viewer/source_viewer_spec.js | 6 + .../components/source_viewer/utils_spec.js | 27 +++- spec/lib/gitlab/git/wiki_spec.rb | 16 +- .../sensitive_serializable_hash_spec.rb | 150 ++++++++++++++++++ .../concerns/token_authenticatable_spec.rb | 6 + .../base_spec.rb | 18 +++ .../digest_spec.rb | 18 +++ .../encrypted_spec.rb | 10 +- .../ci/job_artifacts/create_service_spec.rb | 2 +- .../ci/parse_dotenv_artifact_service_spec.rb | 24 +-- tooling/graphql/docs/helper.rb | 2 +- 81 files changed, 820 insertions(+), 176 deletions(-) create mode 100644 app/models/concerns/sensitive_serializable_hash.rb create mode 100644 config/feature_flags/development/prevent_sensitive_fields_from_serializable_hash.yml create mode 100644 qa/qa/specs/features/api/1_manage/migration/gitlab_migration_pipeline_spec.rb create mode 100644 spec/models/concerns/sensitive_serializable_hash_spec.rb create mode 100644 spec/models/concerns/token_authenticatable_strategies/digest_spec.rb diff --git a/Gemfile b/Gemfile index 40cf9bcf465..b7fd39b3617 100644 --- a/Gemfile +++ b/Gemfile @@ -476,7 +476,7 @@ gem 'ssh_data', '~> 1.2' gem 'spamcheck', '~> 0.1.0' # Gitaly GRPC protocol definitions -gem 'gitaly', '~> 14.8.0.pre.rc1' +gem 'gitaly', '~> 14.9.0.pre.rc2' # KAS GRPC protocol definitions gem 'kas-grpc', '~> 0.0.2' diff --git a/Gemfile.lock b/Gemfile.lock index a66a2fff1bd..eb64191b6e6 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -455,7 +455,7 @@ GEM rails (>= 3.2.0) git (1.7.0) rchardet (~> 1.8) - gitaly (14.8.0.pre.rc1) + gitaly (14.9.0.pre.rc2) grpc (~> 1.0) github-markup (1.7.0) gitlab (4.16.1) @@ -1475,7 +1475,7 @@ DEPENDENCIES gettext (~> 3.3) gettext_i18n_rails (~> 1.8.0) gettext_i18n_rails_js (~> 1.3) - gitaly (~> 14.8.0.pre.rc1) + gitaly (~> 14.9.0.pre.rc2) github-markup (~> 1.7.0) gitlab-chronic (~> 0.10.5) gitlab-dangerfiles (~> 2.10.2) diff --git a/app/assets/javascripts/boards/boards_util.js b/app/assets/javascripts/boards/boards_util.js index 7e4d3ebb686..96cc774a280 100644 --- a/app/assets/javascripts/boards/boards_util.js +++ b/app/assets/javascripts/boards/boards_util.js @@ -1,5 +1,6 @@ import { sortBy, cloneDeep } from 'lodash'; -import { isGid } from '~/graphql_shared/utils'; +import { TYPE_BOARD, TYPE_ITERATION, TYPE_MILESTONE, TYPE_USER } from '~/graphql_shared/constants'; +import { isGid, convertToGraphQLId } from '~/graphql_shared/utils'; import { ListType, MilestoneIDs, AssigneeFilterType, MilestoneFilterType } from './constants'; export function getMilestone() { @@ -80,19 +81,22 @@ export function formatListsPageInfo(lists) { } export function fullBoardId(boardId) { - return `gid://gitlab/Board/${boardId}`; + if (!boardId) { + return null; + } + return convertToGraphQLId(TYPE_BOARD, boardId); } export function fullIterationId(id) { - return `gid://gitlab/Iteration/${id}`; + return convertToGraphQLId(TYPE_ITERATION, id); } export function fullUserId(id) { - return `gid://gitlab/User/${id}`; + return convertToGraphQLId(TYPE_USER, id); } export function fullMilestoneId(id) { - return `gid://gitlab/Milestone/${id}`; + return convertToGraphQLId(TYPE_MILESTONE, id); } export function fullLabelId(label) { diff --git a/app/assets/javascripts/boards/components/board_form.vue b/app/assets/javascripts/boards/components/board_form.vue index cc048e2af1a..f39f9751c83 100644 --- a/app/assets/javascripts/boards/components/board_form.vue +++ b/app/assets/javascripts/boards/components/board_form.vue @@ -1,11 +1,8 @@