From 60e7627c998b74d48df10b9a7759d6038a1f139c Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 12 Apr 2023 09:14:57 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 10 +- GITALY_SERVER_VERSION | 2 +- .../issues/show/components/description.vue | 8 +- .../components/constants.js | 45 ++++++++ .../components/feature_card.vue | 58 +++++++--- .../labels/labels_select_widget/constants.js | 1 + .../dropdown_contents_create_view.vue | 10 +- .../vue_shared/security_reports/constants.js | 1 + app/finders/security/security_jobs_finder.rb | 2 +- .../types/permission_types/work_item.rb | 3 +- app/models/ci/catalog/resource.rb | 8 ++ config/initializers/net_http_patch.rb | 4 + config/routes.rb | 1 + ...ns_note_id_to_bigint_for_gitlab_dot_com.rb | 83 ++++++++++++++ ...1_async_validate_fk_projects_creator_id.rb | 15 +++ db/schema_migrations/20230403041917 | 1 + db/schema_migrations/20230410111251 | 1 + db/structure.sql | 9 +- doc/administration/audit_events.md | 2 + doc/api/graphql/reference/index.md | 3 + .../blueprints/runner_scaling/index.md | 6 +- doc/ci/jobs/job_artifacts.md | 43 +++++--- doc/ci/runners/configure_runners.md | 2 +- doc/ci/runners/index.md | 4 +- doc/ci/yaml/index.md | 2 +- .../database/loose_foreign_keys.md | 2 +- doc/integration/jira/connect-app.md | 33 ++++++ doc/integration/kerberos.md | 10 ++ .../secret_detection/index.md | 21 ++++ .../secret_detection/post_processing.md | 70 ++++++------ doc/user/workspace/quick_start/index.md | 18 ++++ lib/gitlab/ci/components/instance_path.rb | 10 +- locale/gitlab.pot | 33 ++++++ .../feature-branch/gl-sast-report.json | 22 +++- .../gl-secret-detection-report.json | 36 ++++++- .../master/gl-sast-missing-scanner.json | 52 ++++++++- .../master/gl-sast-report-bandit.json | 13 ++- .../master/gl-sast-report-gosec.json | 13 ++- .../master/gl-sast-report-minimal.json | 18 +++- .../gl-sast-report-semgrep-for-bandit.json | 13 ++- .../gl-sast-report-semgrep-for-gosec.json | 13 ++- ...-report-semgrep-for-multiple-findings.json | 13 ++- .../master/gl-sast-report.json | 22 +++- .../master/gl-secret-detection-report.json | 35 +++++- .../show/components/description_spec.js | 19 +++- .../issues/show/mock_data/mock_data.js | 13 +++ .../components/feature_card_spec.js | 101 +++++++++++++++++- .../dropdown_contents_create_view_spec.js | 30 +++++- .../labels/labels_select_widget/mock_data.js | 11 ++ .../types/permission_types/work_item_spec.rb | 3 +- spec/initializers/net_http_patch_spec.rb | 6 ++ .../ci/components/instance_path_spec.rb | 31 ++++++ .../gitlab/ci/parsers/security/sast_spec.rb | 4 +- .../parsers/security/secret_detection_spec.rb | 2 +- ...te_id_to_bigint_for_gitlab_dot_com_spec.rb | 66 ++++++++++++ spec/models/ci/catalog/resource_spec.rb | 26 ++++- spec/requests/api/graphql/work_item_spec.rb | 3 +- 57 files changed, 950 insertions(+), 136 deletions(-) create mode 100644 db/post_migrate/20230403041917_swap_issue_user_mentions_note_id_to_bigint_for_gitlab_dot_com.rb create mode 100644 db/post_migrate/20230410111251_async_validate_fk_projects_creator_id.rb create mode 100644 db/schema_migrations/20230403041917 create mode 100644 db/schema_migrations/20230410111251 create mode 100644 doc/user/workspace/quick_start/index.md create mode 100644 spec/migrations/swap_issue_user_mentions_note_id_to_bigint_for_gitlab_dot_com_spec.rb diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index ffdd0ef10e3..012fafb3c3e 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1228,7 +1228,7 @@ lib/gitlab/checks/** @proglottis @toon [Verify] @gitlab-org/maintainers/cicd-verify # Verify Backend -/**/app/**/ci/ +/**/app/**/ci/ /**/lib/**/ci/ /**/spec/**/ci/ /**/app/**/merge_trains/ @@ -1347,7 +1347,7 @@ lib/gitlab/checks/** @proglottis @toon /**/javascripts/jobs/ @gitlab-org/ci-cd/verify/frontend /**/javascripts/token_access/ @gitlab-org/ci-cd/verify/frontend /**/javascripts/admin/application_settings/runner_token_expiration/ @gitlab-org/ci-cd/verify/frontend -/**/javascripts/usage_quotas/pipelines/ @gitlab-org/ci-cd/verify/frontend @fulfillment-group/utilization-group/fe +/**/javascripts/usage_quotas/pipelines/ @gitlab-org/ci-cd/verify/frontend @sheldonled @aalakkad @kpalchyk [Manage::Workspace] lib/api/entities/basic_project_details.rb @gitlab-org/manage/manage-workspace/backend-approvers @@ -1419,9 +1419,9 @@ ee/lib/ee/api/entities/project.rb @gitlab-org/manage/manage-workspace/backend-ap /lib/gitlab/audit_json_logger.rb @gitlab-org/govern/compliance [Fulfillment::Utilization] -/ee/app/assets/javascripts/usage_quotas/components/ @fulfillment-group/utilization-group/fe -/ee/app/assets/javascripts/usage_quotas/seats/ @fulfillment-group/utilization-group/fe -/ee/app/assets/javascripts/usage_quotas/storage/ @fulfillment-group/utilization-group/fe +/ee/app/assets/javascripts/usage_quotas/components/ @sheldonled @aalakkad @kpalchyk +/ee/app/assets/javascripts/usage_quotas/seats/ @sheldonled @aalakkad @kpalchyk +/ee/app/assets/javascripts/usage_quotas/storage/ @sheldonled @aalakkad @kpalchyk [Manage::Foundations] /lib/sidebars/ @gitlab-org/manage/foundations/engineering diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 5c9981a0449..58b425aa464 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -a5d056f2e268a775f6742046e284f33bae43078b +b8190668d147784e8be4a379b33f691363e08a0f diff --git a/app/assets/javascripts/issues/show/components/description.vue b/app/assets/javascripts/issues/show/components/description.vue index 6412a13e3e6..3721f224d5e 100644 --- a/app/assets/javascripts/issues/show/components/description.vue +++ b/app/assets/javascripts/issues/show/components/description.vue @@ -132,7 +132,10 @@ export default { }, watch: { descriptionHtml(newDescription, oldDescription) { - if (!this.initialUpdate && newDescription !== oldDescription) { + if ( + !this.initialUpdate && + this.stripClientState(newDescription) !== this.stripClientState(oldDescription) + ) { this.animateChange(); } else { this.initialUpdate = false; @@ -321,6 +324,9 @@ export default { listItem.append(element); } }, + stripClientState(description) { + return description.replaceAll('
', '
'); + }, async createTask({ taskTitle, taskDescription, oldDescription }) { try { const { title, description } = extractTaskTitleAndDescription(taskTitle, taskDescription); diff --git a/app/assets/javascripts/security_configuration/components/constants.js b/app/assets/javascripts/security_configuration/components/constants.js index 6beb6cd4d34..1d5ff5eb16f 100644 --- a/app/assets/javascripts/security_configuration/components/constants.js +++ b/app/assets/javascripts/security_configuration/components/constants.js @@ -6,6 +6,7 @@ import { REPORT_TYPE_SAST_IAC, REPORT_TYPE_DAST, REPORT_TYPE_DAST_PROFILES, + REPORT_TYPE_BREACH_AND_ATTACK_SIMULATION, REPORT_TYPE_SECRET_DETECTION, REPORT_TYPE_DEPENDENCY_SCANNING, REPORT_TYPE_CONTAINER_SCANNING, @@ -67,6 +68,30 @@ export const DAST_PROFILES_DESCRIPTION = s__( ); export const DAST_PROFILES_CONFIG_TEXT = s__('SecurityConfiguration|Manage profiles'); +export const BAS_BADGE_TEXT = s__('SecurityConfiguration|Incubating feature'); +export const BAS_BADGE_TOOLTIP = s__( + 'SecurityConfiguration|Breach and Attack Simulation is an incubating feature extending existing security testing by simulating adversary activity.', +); +export const BAS_DESCRIPTION = s__( + 'SecurityConfiguration|Simulate breach and attack scenarios against your running application by attempting to detect and exploit known vulnerabilities.', +); +export const BAS_HELP_PATH = helpPagePath( + 'user/application_security/breach_and_attack_simulation/index', +); +export const BAS_NAME = s__('SecurityConfiguration|Breach and Attack Simulation (BAS)'); +export const BAS_SHORT_NAME = s__('SecurityConfiguration|BAS'); + +export const BAS_DAST_FEATURE_FLAG_DESCRIPTION = s__( + 'SecurityConfiguration|Enable incubating Breach and Attack Simulation focused features such as callback attacks in your DAST scans.', +); +export const BAS_DAST_FEATURE_FLAG_HELP_PATH = helpPagePath( + 'user/application_security/breach_and_attack_simulation/index', + { anchor: 'extend-dynamic-application-security-testing-dast' }, +); +export const BAS_DAST_FEATURE_FLAG_NAME = s__( + 'SecurityConfiguration|Out-of-Band Application Security Testing (OAST)', +); + export const SECRET_DETECTION_NAME = __('Secret Detection'); export const SECRET_DETECTION_DESCRIPTION = __( 'Analyze your source code and git history for secrets.', @@ -142,6 +167,7 @@ export const SCANNER_NAMES_MAP = { COVERAGE_FUZZING: COVERAGE_FUZZING_NAME, SECRET_DETECTION: SECRET_DETECTION_NAME, DEPENDENCY_SCANNING: DEPENDENCY_SCANNING_NAME, + BAS: BAS_SHORT_NAME, GENERIC: s__('ciReport|Manually added'), }; @@ -223,6 +249,25 @@ export const securityFeatures = [ configurationText: CORPUS_MANAGEMENT_CONFIG_TEXT, }, }, + { + anchor: 'bas', + badge: { + alwaysDisplay: true, + text: BAS_BADGE_TEXT, + tooltipText: BAS_BADGE_TOOLTIP, + variant: 'info', + }, + description: BAS_DESCRIPTION, + name: BAS_NAME, + helpPath: BAS_HELP_PATH, + secondary: { + configurationHelpPath: BAS_DAST_FEATURE_FLAG_HELP_PATH, + description: BAS_DAST_FEATURE_FLAG_DESCRIPTION, + name: BAS_DAST_FEATURE_FLAG_NAME, + }, + shortName: BAS_SHORT_NAME, + type: REPORT_TYPE_BREACH_AND_ATTACK_SIMULATION, + }, ]; export const complianceFeatures = [ diff --git a/app/assets/javascripts/security_configuration/components/feature_card.vue b/app/assets/javascripts/security_configuration/components/feature_card.vue index 19b412d66ca..d1b705fe2fc 100644 --- a/app/assets/javascripts/security_configuration/components/feature_card.vue +++ b/app/assets/javascripts/security_configuration/components/feature_card.vue @@ -1,7 +1,10 @@