Better control flow.

2016-04-11 17:26:01 -05:00 · 2016-04-11 17:26:01 -05:00 · 61fc9aa87e
parent 31bcd9f879
commit 61fc9aa87e
1 changed files with 4 additions and 6 deletions
--- a/lib/gitlab/o_auth/user.rb
+++ b/lib/gitlab/o_auth/user.rb
@ -54,12 +54,10 @@ module Gitlab
          @user ||= build_new_user
        end

-        unless @user.nil?
-          if external_provider?
-            @user.external = true
-          else
-            @user.external = false
-          end
+        if external_provider? && @user
+          @user.external = true
+        elsif @user
+          @user.external = false
        end

        @user