diff --git a/app/assets/javascripts/diff_notes/components/jump_to_discussion.js b/app/assets/javascripts/diff_notes/components/jump_to_discussion.js index 092c69a01d3..fa5f8ea4005 100644 --- a/app/assets/javascripts/diff_notes/components/jump_to_discussion.js +++ b/app/assets/javascripts/diff_notes/components/jump_to_discussion.js @@ -24,9 +24,9 @@ const JumpToDiscussion = Vue.extend({ computed: { buttonText() { if (this.discussionId) { - return __('Jump to next unresolved discussion'); + return __('Jump to next unresolved thread'); } else { - return __('Jump to first unresolved discussion'); + return __('Jump to first unresolved thread'); } }, allResolved() { diff --git a/app/assets/javascripts/mr_notes/init_notes.js b/app/assets/javascripts/mr_notes/init_notes.js index a942bcc13da..2580f8e86b1 100644 --- a/app/assets/javascripts/mr_notes/init_notes.js +++ b/app/assets/javascripts/mr_notes/init_notes.js @@ -69,13 +69,11 @@ export default () => { }, }, render(createElement) { - const isDiffView = this.activeTab === 'diffs'; - // NOTE: Even though `discussionKeyboardNavigator` is added to the `notes-app`, // it adds a global key listener so it works on the diffs tab as well. // If we create a single Vue app for all of the MR tabs, we should move this // up the tree, to the root. - return createElement(discussionKeyboardNavigator, { props: { isDiffView } }, [ + return createElement(discussionKeyboardNavigator, [ createElement('notes-app', { props: { noteableData: this.noteableData, diff --git a/app/assets/javascripts/notes/components/discussion_actions.vue b/app/assets/javascripts/notes/components/discussion_actions.vue index fad1bc67be7..8ab31ef3448 100644 --- a/app/assets/javascripts/notes/components/discussion_actions.vue +++ b/app/assets/javascripts/notes/components/discussion_actions.vue @@ -73,7 +73,7 @@ export default { v-if="discussion.resolvable && shouldShowJumpToNextDiscussion" class="btn-group discussion-actions ml-sm-2" > - + diff --git a/app/assets/javascripts/notes/components/discussion_counter.vue b/app/assets/javascripts/notes/components/discussion_counter.vue index 98f1f385e9b..70e22db364b 100644 --- a/app/assets/javascripts/notes/components/discussion_counter.vue +++ b/app/assets/javascripts/notes/components/discussion_counter.vue @@ -1,5 +1,5 @@ @@ -83,9 +71,9 @@ export default {
diff --git a/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue b/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue index f87ca097b40..630d4fd89b1 100644 --- a/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue +++ b/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue @@ -1,6 +1,7 @@ @@ -19,8 +21,8 @@ export default { ref="button" v-gl-tooltip class="btn btn-default discussion-next-btn" - :title="s__('MergeRequests|Jump to next unresolved discussion')" - @click="$emit('onClick')" + :title="s__('MergeRequests|Jump to next unresolved thread')" + @click="jumpToNextDiscussion" > diff --git a/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue b/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue index 7d742fbfeee..2dc222d08f9 100644 --- a/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue +++ b/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue @@ -1,53 +1,18 @@