root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Remove unnecessary hash

This commit is contained in:
Shinya Maeda 2017-03-27 19:15:21 +09:00
parent f65cd3289c
commit 673693888a
1 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
spec/requests/api/pipelines_spec.rb
View File

@ -46,7 +46,7 @@ describe API::Pipelines do
%w[running pending].each do |target|
context "when scope is #{target}" do
it "returns matched pipelines" do
get api("/projects/#{project.id}/pipelines", user), { scope: target }
get api("/projects/#{project.id}/pipelines", user), scope: target
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -58,7 +58,7 @@ describe API::Pipelines do
context 'when scope is finished' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { scope: 'finished' }
get api("/projects/#{project.id}/pipelines", user), scope: 'finished'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -69,7 +69,7 @@ describe API::Pipelines do
context 'when scope is branches' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { scope: 'branches' }
get api("/projects/#{project.id}/pipelines", user), scope: 'branches'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -80,7 +80,7 @@ describe API::Pipelines do
context 'when scope is tags' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { scope: 'tags' }
get api("/projects/#{project.id}/pipelines", user), scope: 'tags'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -91,7 +91,7 @@ describe API::Pipelines do
context 'when scope is invalid' do
it 'returns 400' do
get api("/projects/#{project.id}/pipelines", user), { scope: 'invalid-scope' }
get api("/projects/#{project.id}/pipelines", user), scope: 'invalid-scope'
expect(response).to have_http_status(400)
end
@ -102,7 +102,7 @@ describe API::Pipelines do
%w[running pending success failed canceled skipped].each do |target|
context "when status is #{target}" do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { status: target }
get api("/projects/#{project.id}/pipelines", user), status: target
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -114,7 +114,7 @@ describe API::Pipelines do
context 'when status is invalid' do
it 'returns 400' do
get api("/projects/#{project.id}/pipelines", user), { status: 'invalid-status' }
get api("/projects/#{project.id}/pipelines", user), status: 'invalid-status'
expect(response).to have_http_status(400)
end
@ -124,7 +124,7 @@ describe API::Pipelines do
context 'when ref is passed' do
context 'when ref exists' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { ref: 'master' }
get api("/projects/#{project.id}/pipelines", user), ref: 'master'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -135,7 +135,7 @@ describe API::Pipelines do
context 'when ref does not exist' do
it 'returns empty' do
get api("/projects/#{project.id}/pipelines", user), { ref: 'invalid-ref' }
get api("/projects/#{project.id}/pipelines", user), ref: 'invalid-ref'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -147,7 +147,7 @@ describe API::Pipelines do
context 'when name is passed' do
context 'when name exists' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { name: user1.name }
get api("/projects/#{project.id}/pipelines", user), name: user1.name
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -157,7 +157,7 @@ describe API::Pipelines do
context 'when name does not exist' do
it 'returns empty' do
get api("/projects/#{project.id}/pipelines", user), { name: 'invalid-name' }
get api("/projects/#{project.id}/pipelines", user), name: 'invalid-name'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -169,7 +169,7 @@ describe API::Pipelines do
context 'when username is passed' do
context 'when username exists' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { username: user1.username }
get api("/projects/#{project.id}/pipelines", user), username: user1.username
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -179,7 +179,7 @@ describe API::Pipelines do
context 'when username does not exist' do
it 'returns empty' do
get api("/projects/#{project.id}/pipelines", user), { username: 'invalid-username' }
get api("/projects/#{project.id}/pipelines", user), username: 'invalid-username'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -191,7 +191,7 @@ describe API::Pipelines do
context 'when yaml_errors is passed' do
context 'when yaml_errors is true' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { yaml_errors: true }
get api("/projects/#{project.id}/pipelines", user), yaml_errors: true
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -201,7 +201,7 @@ describe API::Pipelines do
context 'when yaml_errors is false' do
it 'returns matched pipelines' do
get api("/projects/#{project.id}/pipelines", user), { yaml_errors: false }
get api("/projects/#{project.id}/pipelines", user), yaml_errors: false
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -211,7 +211,7 @@ describe API::Pipelines do
context 'when yaml_errors is invalid' do
it 'returns 400' do
get api("/projects/#{project.id}/pipelines", user), { yaml_errors: 'invalid-yaml_errors' }
get api("/projects/#{project.id}/pipelines", user), yaml_errors: 'invalid-yaml_errors'
expect(response).to have_http_status(400)
end
@ -221,7 +221,7 @@ describe API::Pipelines do
context 'when order_by and sort are passed' do
context 'when order_by and sort are valid' do
it 'sorts pipelines' do
get api("/projects/#{project.id}/pipelines", user), { order_by: 'user_id', sort: 'asc' }
get api("/projects/#{project.id}/pipelines", user), order_by: 'user_id', sort: 'asc'
expect(response).to have_http_status(200)
expect(response).to include_pagination_headers
@ -235,7 +235,7 @@ describe API::Pipelines do
context 'when order_by is invalid' do
it 'returns 400' do
get api("/projects/#{project.id}/pipelines", user), { order_by: 'lock_version', sort: 'asc' }
get api("/projects/#{project.id}/pipelines", user), order_by: 'lock_version', sort: 'asc'
expect(response).to have_http_status(400)
end
@ -243,7 +243,7 @@ describe API::Pipelines do
context 'when sort is invalid' do
it 'returns 400' do
get api("/projects/#{project.id}/pipelines", user), { order_by: 'id', sort: 'hack' }
get api("/projects/#{project.id}/pipelines", user), order_by: 'id', sort: 'hack'
expect(response).to have_http_status(400)
end