From 69d28d313c2a65ead87229841a50bfc130e8c952 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 30 Apr 2021 15:09:50 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../runner_instructions_modal.vue | 41 ++- app/finders/deploy_tokens/tokens_finder.rb | 43 +++ app/helpers/projects_helper.rb | 42 --- app/helpers/sidebars_helper.rb | 3 +- .../nav/sidebar/_project_menus.html.haml | 95 ------ .../nav/sidebar/_tracing_link.html.haml | 7 - ...06-remove-ff-search-track-unique-users.yml | 5 + ...433-add-filtering-to-deploy-tokens-api.yml | 5 + ...n-modal-should-support-smaller-screens.yml | 6 + .../development/search_track_unique_users.yml | 8 - ...alize_conversion_of_events_id_to_bigint.rb | 2 +- ..._push_event_payloads_event_id_to_bigint.rb | 2 +- ..._conversion_of_ci_build_needs_to_bigint.rb | 2 +- ...onversion_of_ci_job_artifacts_to_bigint.rb | 2 +- ...urces_pipelines_source_job_id_to_bigint.rb | 2 +- doc/api/deploy_tokens.md | 84 +++-- doc/development/code_review.md | 2 +- .../configuration/index.md | 3 + .../secret_detection/index.md | 44 +++ .../merge_requests/approvals/img/approve.png | Bin 6655 -> 0 bytes .../approvals/img/approve_additionally.png | Bin 7803 -> 0 bytes .../approvals/img/remove_approval.png | Bin 7533 -> 0 bytes .../project/merge_requests/approvals/index.md | 187 ++++++----- lib/api/deploy_tokens.rb | 31 +- lib/api/entities/deploy_token.rb | 3 +- lib/gitlab/database/migration_helpers.rb | 36 +- .../sidekiq_logging/structured_logger.rb | 2 + .../known_events/common.yml | 3 - .../projects/menus/operations_menu.rb | 217 ++++++++++++ lib/sidebars/projects/panel.rb | 1 + locale/gitlab.pot | 8 +- qa/qa/page/project/sub_menus/operations.rb | 17 +- .../settings/repository_controller_spec.rb | 2 + .../settings/repository_controller_spec.rb | 2 + spec/features/issues/issue_sidebar_spec.rb | 1 + spec/features/operations_sidebar_link_spec.rb | 91 ++--- .../deploy_tokens/tokens_finder_spec.rb | 135 ++++++++ .../runner_instructions_modal_spec.js | 40 ++- spec/helpers/projects_helper_spec.rb | 37 -- .../gitlab/database/migration_helpers_spec.rb | 24 +- .../projects/menus/operations_menu_spec.rb | 205 ++++++++++++ spec/requests/api/deploy_tokens_spec.rb | 57 +++- .../nav/sidebar/_project.html.haml_spec.rb | 316 ++++++++++++++---- 43 files changed, 1333 insertions(+), 480 deletions(-) create mode 100644 app/finders/deploy_tokens/tokens_finder.rb delete mode 100644 app/views/layouts/nav/sidebar/_tracing_link.html.haml create mode 100644 changelogs/unreleased/240906-remove-ff-search-track-unique-users.yml create mode 100644 changelogs/unreleased/292433-add-filtering-to-deploy-tokens-api.yml create mode 100644 changelogs/unreleased/327124-runner-installation-modal-should-support-smaller-screens.yml delete mode 100644 config/feature_flags/development/search_track_unique_users.yml delete mode 100644 doc/user/project/merge_requests/approvals/img/approve.png delete mode 100644 doc/user/project/merge_requests/approvals/img/approve_additionally.png delete mode 100644 doc/user/project/merge_requests/approvals/img/remove_approval.png create mode 100644 lib/sidebars/projects/menus/operations_menu.rb create mode 100644 spec/finders/deploy_tokens/tokens_finder_spec.rb create mode 100644 spec/lib/sidebars/projects/menus/operations_menu_spec.rb diff --git a/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue b/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue index 795b4f58ac5..1f70644eb2c 100644 --- a/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue +++ b/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue @@ -9,7 +9,9 @@ import { GlIcon, GlLoadingIcon, GlSkeletonLoader, + GlResizeObserverDirective, } from '@gitlab/ui'; +import { GlBreakpointInstance as bp } from '@gitlab/ui/dist/utils'; import { isEmpty } from 'lodash'; import { __, s__ } from '~/locale'; import ModalCopyButton from '~/vue_shared/components/modal_copy_button.vue'; @@ -33,6 +35,9 @@ export default { GlSkeletonLoader, ModalCopyButton, }, + directives: { + GlResizeObserver: GlResizeObserverDirective, + }, props: { modalId: { type: String, @@ -87,6 +92,7 @@ export default { selectedArchitecture: null, showAlert: false, instructions: {}, + platformsButtonGroupVertical: false, }; }, computed: { @@ -127,6 +133,13 @@ export default { toggleAlert(state) { this.showAlert = state; }, + onPlatformsButtonResize() { + if (bp.getBreakpointSize() === 'xs') { + this.platformsButtonGroupVertical = true; + } else { + this.platformsButtonGroupVertical = false; + } + }, }, i18n: { installARunner: s__('Runners|Install a runner'), @@ -159,17 +172,23 @@ export default {
{{ __('Environment') }}
- - + - {{ platform.humanReadableName }} - - + + {{ platform.humanReadableName }} + + +