From 71c85847eb6645f6cca91febd70668d544a4125d Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 19 Nov 2020 18:09:13 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../javascripts/diffs/components/app.vue | 3 - .../diffs/components/diff_content.vue | 10 +- .../diffs/components/diff_expansion_cell.vue | 18 +- .../diffs/components/diff_line_note_form.vue | 12 +- app/assets/javascripts/diffs/store/actions.js | 90 +--- app/assets/javascripts/diffs/store/getters.js | 48 +- .../javascripts/diffs/store/mutation_types.js | 1 - .../javascripts/diffs/store/mutations.js | 80 +--- app/assets/javascripts/diffs/store/utils.js | 186 +------- .../notes/components/noteable_note.vue | 9 +- .../test_reports/test_suite_table.vue | 26 +- .../pipelines/stores/test_reports/actions.js | 1 + .../pipelines/stores/test_reports/getters.js | 7 +- .../stores/test_reports/mutation_types.js | 1 + .../stores/test_reports/mutations.js | 8 + .../pipelines/stores/test_reports/state.js | 4 + .../merge_requests/diffs_controller.rb | 2 +- .../projects/merge_requests_controller.rb | 3 +- app/helpers/diff_helper.rb | 8 - app/helpers/storage_helper.rb | 6 +- .../analytics/devops_adoption/segment.rb | 2 +- .../devops_adoption/segment_selection.rb | 8 +- ...-even-if-group-disable-2fa-enforce-mig.yml | 5 + .../262395-devops-adoption-mutations.yml | 5 + .../280512-paginate-test-report.yml | 5 + .../development/unified_diff_lines.yml | 8 - ...ting_users_that_require_two_factor_auth.rb | 35 ++ db/schema_migrations/20201030121314 | 1 + db/structure.sql | 2 + doc/administration/audit_events.md | 6 - doc/api/appearance.md | 35 +- .../graphql/reference/gitlab_schema.graphql | 123 +++++ doc/api/graphql/reference/gitlab_schema.json | 433 ++++++++++++++++++ doc/api/graphql/reference/index.md | 29 ++ doc/api/vulnerabilities.md | 10 +- doc/api/vulnerability_exports.md | 2 +- doc/api/vulnerability_findings.md | 4 +- doc/ci/docker/using_docker_build.md | 69 ++- doc/development/cached_queries.md | 144 +++--- doc/development/feature_flags/development.md | 6 + .../secure_partner_integration.md | 8 +- .../merge_request_performance_guidelines.md | 2 +- doc/integration/README.md | 2 +- doc/integration/facebook.md | 4 +- doc/integration/github.md | 14 +- doc/integration/gitlab.md | 6 +- .../gmail_action_buttons_for_gitlab.md | 7 +- doc/integration/google.md | 10 +- doc/integration/jenkins_deprecated.md | 9 +- doc/integration/oauth2_generic.md | 8 +- doc/integration/oauth_provider.md | 6 +- doc/integration/omniauth.md | 24 +- doc/integration/salesforce.md | 6 +- doc/integration/shibboleth.md | 8 +- doc/integration/slash_commands.md | 8 +- doc/integration/trello_power_up.md | 8 +- doc/integration/twitter.md | 4 +- .../analytics/instance_statistics.md | 2 +- doc/user/admin_area/settings/help_page.md | 4 +- .../settings/rate_limits_on_raw_endpoints.md | 2 +- .../settings/sign_in_restrictions.md | 14 +- .../admin_area/settings/usage_statistics.md | 12 +- .../settings/user_and_ip_rate_limits.md | 2 +- doc/user/analytics/code_review_analytics.md | 2 +- doc/user/analytics/index.md | 2 +- doc/user/analytics/merge_request_analytics.md | 2 +- doc/user/analytics/productivity_analytics.md | 2 +- doc/user/analytics/repository_analytics.md | 2 +- doc/user/analytics/value_stream_analytics.md | 2 +- doc/user/application_security/dast/index.md | 15 +- .../dependency_list/index.md | 2 +- .../dependency_scanning/index.md | 4 +- .../offline_deployments/index.md | 8 +- doc/user/application_security/sast/index.md | 10 +- .../security_dashboard/index.md | 6 +- .../vulnerabilities/index.md | 2 +- .../compliance/license_compliance/index.md | 20 +- .../group/contribution_analytics/index.md | 2 +- doc/user/group/insights/index.md | 2 +- doc/user/group/issues_analytics/index.md | 2 +- ...ting_users_that_require_two_factor_auth.rb | 110 +++++ .../postgres_hll_batch_distinct_counter.rb | 156 +++++++ locale/gitlab.pot | 5 +- qa/qa/page/component/note.rb | 8 +- .../collapse_comments_in_discussions_spec.rb | 14 +- .../admin_sees_project_statistics_spec.rb | 2 +- .../user_resolves_conflicts_spec.rb | 5 - .../user_sees_merge_request_pipelines_spec.rb | 1 - .../features/projects/diffs/diff_show_spec.rb | 4 - spec/finders/fork_projects_finder_spec.rb | 2 - spec/frontend/diffs/components/app_spec.js | 105 ----- .../diffs/components/diff_content_spec.js | 7 +- .../components/diff_expansion_cell_spec.js | 5 +- spec/frontend/diffs/store/actions_spec.js | 8 - spec/frontend/diffs/store/mutations_spec.js | 288 +++--------- spec/frontend/diffs/store/utils_spec.js | 215 +++------ .../test_reports/stores/getters_spec.js | 33 +- .../test_reports/stores/mutations_spec.js | 13 + .../test_reports/test_suite_table_spec.js | 24 +- spec/helpers/diff_helper_spec.rb | 26 -- spec/helpers/storage_helper_spec.rb | 6 +- ...users_that_require_two_factor_auth_spec.rb | 74 +++ ...ostgres_hll_batch_distinct_counter_spec.rb | 132 ++++++ ...users_that_require_two_factor_auth_spec.rb | 29 ++ .../devops_adoption/segment_selection_spec.rb | 4 +- spec/services/projects/fork_service_spec.rb | 4 - spec/spec_helper.rb | 6 +- 107 files changed, 1818 insertions(+), 1178 deletions(-) create mode 100644 changelogs/unreleased/220433-user-stuck-in-2fa-setup-page-even-if-group-disable-2fa-enforce-mig.yml create mode 100644 changelogs/unreleased/262395-devops-adoption-mutations.yml create mode 100644 changelogs/unreleased/280512-paginate-test-report.yml delete mode 100644 config/feature_flags/development/unified_diff_lines.yml create mode 100644 db/post_migrate/20201030121314_schedule_update_existing_users_that_require_two_factor_auth.rb create mode 100644 db/schema_migrations/20201030121314 create mode 100644 lib/gitlab/background_migration/update_existing_users_that_require_two_factor_auth.rb create mode 100644 lib/gitlab/database/postgres_hll_batch_distinct_counter.rb create mode 100644 spec/lib/gitlab/background_migration/update_existing_users_that_require_two_factor_auth_spec.rb create mode 100644 spec/lib/gitlab/database/postgres_hll_batch_distinct_counter_spec.rb create mode 100644 spec/migrations/schedule_update_existing_users_that_require_two_factor_auth_spec.rb diff --git a/app/assets/javascripts/diffs/components/app.vue b/app/assets/javascripts/diffs/components/app.vue index 9d8d184a3f6..09baf16ade9 100644 --- a/app/assets/javascripts/diffs/components/app.vue +++ b/app/assets/javascripts/diffs/components/app.vue @@ -230,9 +230,6 @@ export default { } }, diffViewType() { - if (!this.glFeatures.unifiedDiffLines && (this.needsReload() || this.needsFirstLoad())) { - this.refetchDiffData(); - } this.adjustView(); }, shouldShow() { diff --git a/app/assets/javascripts/diffs/components/diff_content.vue b/app/assets/javascripts/diffs/components/diff_content.vue index 401064fb18f..1454728288e 100644 --- a/app/assets/javascripts/diffs/components/diff_content.vue +++ b/app/assets/javascripts/diffs/components/diff_content.vue @@ -87,7 +87,7 @@ export default { return this.getUserData; }, mappedLines() { - if (this.glFeatures.unifiedDiffLines && this.glFeatures.unifiedDiffComponents) { + if (this.glFeatures.unifiedDiffComponents) { return this.diffLines(this.diffFile, true).map(mapParallel(this)) || []; } @@ -95,9 +95,7 @@ export default { if (this.isInlineView) { return this.diffFile.highlighted_diff_lines.map(mapInline(this)); } - return this.glFeatures.unifiedDiffLines - ? this.diffLines(this.diffFile).map(mapParallel(this)) - : this.diffFile.parallel_diff_lines.map(mapParallel(this)) || []; + return this.diffLines(this.diffFile).map(mapParallel(this)); }, }, updated() { @@ -129,9 +127,7 @@ export default {