diff --git a/app/assets/javascripts/ide/components/activity_bar.vue b/app/assets/javascripts/ide/components/activity_bar.vue index c625976621f..3e3a70085f3 100644 --- a/app/assets/javascripts/ide/components/activity_bar.vue +++ b/app/assets/javascripts/ide/components/activity_bar.vue @@ -1,7 +1,7 @@ @@ -41,9 +41,10 @@ export default { type="button" class="ide-sidebar-link js-ide-edit-mode" :class="{ - active: currentActivityView === $options.ActivityBarViews.edit + active: currentActivityView === $options.activityBarViews.edit }" - @click.prevent="updateActivityBarView($options.ActivityBarViews.edit)" + @click.prevent="updateActivityBarView($options.activityBarViews.edit)" + :aria-label="s__('IDE|Edit mode')" > ({ currentProjectId: '', @@ -20,6 +20,6 @@ export default () => ({ entries: {}, viewer: 'editor', delayViewerUpdated: false, - currentActivityView: ActivityBarViews.edit, + currentActivityView: activityBarViews.edit, fileFindVisible: false, }); diff --git a/spec/javascripts/ide/components/activity_bar_spec.js b/spec/javascripts/ide/components/activity_bar_spec.js index 5c7b4909fc7..68277ed15eb 100644 --- a/spec/javascripts/ide/components/activity_bar_spec.js +++ b/spec/javascripts/ide/components/activity_bar_spec.js @@ -1,6 +1,6 @@ import Vue from 'vue'; import store from '~/ide/stores'; -import { ActivityBarViews } from '~/ide/constants'; +import { activityBarViews } from '~/ide/constants'; import ActivityBar from '~/ide/components/activity_bar.vue'; import { createComponentWithStore } from '../../helpers/vue_mount_component_helper'; import { resetStore } from '../helpers'; @@ -54,13 +54,13 @@ describe('IDE activity bar', () => { it('calls updateActivityBarView with edit value on click', () => { vm.$el.querySelector('.js-ide-edit-mode').click(); - expect(vm.updateActivityBarView).toHaveBeenCalledWith(ActivityBarViews.edit); + expect(vm.updateActivityBarView).toHaveBeenCalledWith(activityBarViews.edit); }); it('calls updateActivityBarView with commit value on click', () => { vm.$el.querySelector('.js-ide-commit-mode').click(); - expect(vm.updateActivityBarView).toHaveBeenCalledWith(ActivityBarViews.commit); + expect(vm.updateActivityBarView).toHaveBeenCalledWith(activityBarViews.commit); }); }); @@ -74,7 +74,7 @@ describe('IDE activity bar', () => { }); it('sets commit item active', done => { - vm.$store.state.currentActivityView = ActivityBarViews.commit; + vm.$store.state.currentActivityView = activityBarViews.commit; vm.$nextTick(() => { expect(vm.$el.querySelector('.js-ide-commit-mode').classList).toContain('active'); diff --git a/spec/javascripts/ide/components/ide_side_bar_spec.js b/spec/javascripts/ide/components/ide_side_bar_spec.js index 8784f2f965d..20ee20bc1d7 100644 --- a/spec/javascripts/ide/components/ide_side_bar_spec.js +++ b/spec/javascripts/ide/components/ide_side_bar_spec.js @@ -1,7 +1,7 @@ import Vue from 'vue'; import store from '~/ide/stores'; import ideSidebar from '~/ide/components/ide_side_bar.vue'; -import { ActivityBarViews } from '~/ide/constants'; +import { activityBarViews } from '~/ide/constants'; import { createComponentWithStore } from 'spec/helpers/vue_mount_component_helper'; import { resetStore } from '../helpers'; import { projectData } from '../mock_data'; @@ -45,7 +45,7 @@ describe('IdeSidebar', () => { }); it('renders commit component', done => { - vm.$store.state.currentActivityView = ActivityBarViews.commit; + vm.$store.state.currentActivityView = activityBarViews.commit; vm.$nextTick(() => { expect(vm.$el.querySelector('.multi-file-commit-panel-section')).not.toBeNull();