From 733befe96ad19f5a02e442c4a9cc8059d3aabbda Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 14 Feb 2020 09:08:43 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- app/assets/javascripts/api.js | 17 ++ .../ci_variable_list/ajax_variable_list.js | 4 +- app/assets/javascripts/commons/jquery.js | 2 +- .../contributors/components/contributors.vue | 6 +- app/assets/javascripts/gfm_auto_complete.js | 2 +- .../jobs/components/environments_block.vue | 192 +++++++++++++----- .../javascripts/jobs/components/job_app.vue | 1 + app/assets/javascripts/notes.js | 2 +- .../usage_ping_payload.js | 6 +- app/assets/stylesheets/application.scss | 2 +- app/assets/stylesheets/framework/selects.scss | 3 +- app/assets/stylesheets/framework/spinner.scss | 6 + app/models/deployment.rb | 1 + app/serializers/build_details_entity.rb | 6 + app/serializers/cluster_basic_entity.rb | 10 - app/serializers/deployment_cluster_entity.rb | 20 ++ app/serializers/deployment_entity.rb | 6 +- .../application_settings/_usage.html.haml | 2 +- .../milestones/_delete_button.html.haml | 2 +- .../shared/milestones/_sidebar.html.haml | 4 - .../shared/milestones/_tab_loading.html.haml | 2 +- .../196678-replace-_-with-lodash.yml | 5 + changelogs/unreleased/an-sidekiq-query.yml | 5 + .../unreleased/leipert-fix-user-label-bug.yml | 5 + .../refactoring-entities-file-31.yml | 5 + ...-kubernetes-namespace-on-job-show-page.yml | 5 + config/webpack.vendor.config.js | 2 +- .../operations/extra_sidekiq_processes.md | 87 ++++++++ doc/user/gitlab_com/index.md | 25 ++- doc/user/project/issues/design_management.md | 5 +- lib/api/entities.rb | 33 --- .../entities/internal_post_receive/message.rb | 12 ++ .../internal_post_receive/response.rb | 12 ++ lib/api/entities/platform/kubernetes.rb | 14 ++ lib/api/entities/provider/gcp.rb | 17 ++ lib/gitlab/sidekiq_config/cli_methods.rb | 84 +++++++- locale/gitlab.pot | 30 +++ package.json | 4 +- spec/factories/deployment_clusters.rb | 9 + spec/fixtures/api/schemas/deployment.json | 2 +- ...ter_basic.json => deployment_cluster.json} | 6 + .../fixtures/api/schemas/job/job_details.json | 6 + spec/frontend/gfm_auto_complete_spec.js | 2 +- spec/javascripts/badges/dummy_badge.js | 4 +- .../components/environments_block_spec.js | 134 ++++++++---- .../gitlab/sidekiq_config/cli_methods_spec.rb | 111 +++++++++- spec/models/deployment_spec.rb | 1 + ...c.rb => deployment_cluster_entity_spec.rb} | 14 +- yarn.lock | 18 +- 49 files changed, 753 insertions(+), 200 deletions(-) delete mode 100644 app/serializers/cluster_basic_entity.rb create mode 100644 app/serializers/deployment_cluster_entity.rb create mode 100644 changelogs/unreleased/196678-replace-_-with-lodash.yml create mode 100644 changelogs/unreleased/an-sidekiq-query.yml create mode 100644 changelogs/unreleased/leipert-fix-user-label-bug.yml create mode 100644 changelogs/unreleased/refactoring-entities-file-31.yml create mode 100644 changelogs/unreleased/show-kubernetes-namespace-on-job-show-page.yml create mode 100644 lib/api/entities/internal_post_receive/message.rb create mode 100644 lib/api/entities/internal_post_receive/response.rb create mode 100644 lib/api/entities/platform/kubernetes.rb create mode 100644 lib/api/entities/provider/gcp.rb create mode 100644 spec/factories/deployment_clusters.rb rename spec/fixtures/api/schemas/{cluster_basic.json => deployment_cluster.json} (67%) rename spec/serializers/{cluster_basic_entity_spec.rb => deployment_cluster_entity_spec.rb} (58%) diff --git a/app/assets/javascripts/api.js b/app/assets/javascripts/api.js index 76f3020c5c2..4dc4ce543e9 100644 --- a/app/assets/javascripts/api.js +++ b/app/assets/javascripts/api.js @@ -24,6 +24,7 @@ const Api = { projectMergeRequestChangesPath: '/api/:version/projects/:id/merge_requests/:mrid/changes', projectMergeRequestVersionsPath: '/api/:version/projects/:id/merge_requests/:mrid/versions', projectRunnersPath: '/api/:version/projects/:id/runners', + projectProtectedBranchesPath: '/api/:version/projects/:id/protected_branches', mergeRequestsPath: '/api/:version/merge_requests', groupLabelsPath: '/groups/:namespace_path/-/labels', issuableTemplatePath: '/:namespace_path/:project_path/templates/:type/:key', @@ -220,6 +221,22 @@ const Api = { return axios.get(url, config); }, + projectProtectedBranches(id, query = '') { + const url = Api.buildUrl(Api.projectProtectedBranchesPath).replace( + ':id', + encodeURIComponent(id), + ); + + return axios + .get(url, { + params: { + search: query, + per_page: DEFAULT_PER_PAGE, + }, + }) + .then(({ data }) => data); + }, + mergeRequests(params = {}) { const url = Api.buildUrl(Api.mergeRequestsPath); diff --git a/app/assets/javascripts/ci_variable_list/ajax_variable_list.js b/app/assets/javascripts/ci_variable_list/ajax_variable_list.js index 0bba2a2e160..da33e092086 100644 --- a/app/assets/javascripts/ci_variable_list/ajax_variable_list.js +++ b/app/assets/javascripts/ci_variable_list/ajax_variable_list.js @@ -1,4 +1,4 @@ -import _ from 'underscore'; +import { escape as esc } from 'lodash'; import axios from '../lib/utils/axios_utils'; import { s__ } from '../locale'; import Flash from '../flash'; @@ -10,7 +10,7 @@ function generateErrorBoxContent(errors) { const errorList = [].concat(errors).map( errorString => `
  • - ${_.escape(errorString)} + ${esc(errorString)}
  • `, ); diff --git a/app/assets/javascripts/commons/jquery.js b/app/assets/javascripts/commons/jquery.js index 2f268419bff..25640f71af2 100644 --- a/app/assets/javascripts/commons/jquery.js +++ b/app/assets/javascripts/commons/jquery.js @@ -4,6 +4,6 @@ import 'jquery'; import 'jquery-ujs'; import 'vendor/jquery.endless-scroll'; import 'jquery.caret'; // must be imported before at.js -import 'at.js'; +import '@gitlab/at.js'; import 'vendor/jquery.scrollTo'; import 'jquery.waitforimages'; diff --git a/app/assets/javascripts/contributors/components/contributors.vue b/app/assets/javascripts/contributors/components/contributors.vue index caad2a835fa..8dbf0a68c43 100644 --- a/app/assets/javascripts/contributors/components/contributors.vue +++ b/app/assets/javascripts/contributors/components/contributors.vue @@ -1,5 +1,5 @@