From 78ea62d0cf2a680785eea4d7873d658da9fdf632 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 28 Feb 2024 21:09:33 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/docs.gitlab-ci.yml | 2 +- .../layout/first_hash_element_indentation.yml | 1 - .rubocop_todo/rspec/context_wording.yml | 1 - .../graphql_shared/possible_types.json | 4 +- .../components/advanced_settings.vue | 43 ++++- .../pages/import/github/status/index.js | 2 + .../components/registry/title_area.vue | 2 +- app/controllers/groups_controller.rb | 4 +- app/controllers/import/github_controller.rb | 18 +- app/graphql/types/ci/catalog/resource_type.rb | 8 + app/models/ci/runner.rb | 4 +- app/policies/group_policy.rb | 4 + app/serializers/project_import_entity.rb | 4 + app/services/import/base_service.rb | 4 +- app/services/import/github_service.rb | 33 +++- app/views/groups/edit.html.haml | 103 ++++++------ app/views/import/_githubish_status.html.haml | 2 + .../import/bitbucket_server/status.html.haml | 6 +- app/views/import/github/new.html.haml | 2 +- app/views/import/github/status.html.haml | 1 + ...cate-based-integration-with-kubernetes.yml | 4 +- db/docs/namespace_root_storage_statistics.yml | 4 +- db/docs/namespace_statistics.yml | 4 +- ...ipeline_id_to_vulnerability_occurrences.rb | 11 ++ ...143045_add_remove_group_to_member_roles.rb | 15 ++ ...ipeline_id_to_vulnerability_occurrences.rb | 20 +++ db/schema_migrations/20240214035028 | 1 + db/schema_migrations/20240219143045 | 1 + db/schema_migrations/20240226072310 | 1 + db/structure.sql | 5 +- doc/administration/appearance.md | 2 +- .../backup_restore/backup_gitlab.md | 2 +- .../disaster_recovery/bring_primary_back.md | 2 +- doc/administration/gitaly/configure_gitaly.md | 2 +- doc/administration/pages/index.md | 6 +- .../settings/account_and_limit_settings.md | 4 +- doc/api/code_suggestions.md | 2 +- doc/api/graphql/reference/index.md | 88 +++++----- doc/api/group_protected_branches.md | 4 +- doc/api/group_ssh_certificates.md | 2 +- doc/api/import.md | 11 +- doc/api/integrations.md | 6 +- doc/api/markdown.md | 2 +- doc/api/merge_request_approvals.md | 2 +- doc/api/product_analytics.md | 4 +- doc/api/project_import_export.md | 2 +- doc/ci/environments/index.md | 2 +- doc/ci/environments/kubernetes_dashboard.md | 3 +- doc/ci/yaml/index.md | 8 +- doc/development/activitypub/actors/index.md | 2 +- .../activitypub/actors/releases.md | 2 +- doc/development/activitypub/index.md | 2 +- .../documentation/experiment_beta.md | 2 +- .../documentation/feature_flags.md | 6 +- .../advanced_search/elasticsearch.md | 2 +- doc/integration/oauth_provider.md | 2 +- .../incident_timeline_events.md | 2 +- doc/operations/incident_management/slack.md | 2 +- doc/operations/metrics.md | 4 +- doc/security/email_verification.md | 4 +- doc/security/two_factor_authentication.md | 4 +- doc/update/background_migrations.md | 2 +- doc/update/deprecations.md | 52 +++--- doc/user/analytics/analytics_dashboards.md | 10 +- doc/user/analytics/dora_metrics.md | 4 +- .../policies/scan-execution-policies.md | 4 +- .../policies/scan-result-policies.md | 2 +- .../vulnerability_report/pipeline.md | 2 +- .../compliance/compliance_center/index.md | 2 +- doc/user/custom_roles/abilities.md | 1 + doc/user/group/epics/manage_epics.md | 2 +- doc/user/group/issues_analytics/index.md | 4 +- .../group/reporting/git_abuse_rate_limit.md | 4 +- doc/user/group/ssh_certificates.md | 4 +- .../group/value_stream_analytics/index.md | 2 +- doc/user/okrs.md | 8 +- doc/user/organization/index.md | 2 +- .../packages/composer_repository/index.md | 2 +- doc/user/permissions.md | 2 +- doc/user/profile/account/delete_account.md | 2 +- .../account/two_factor_authentication.md | 2 +- doc/user/project/import/bitbucket_server.md | 2 +- .../project/integrations/beyond_identity.md | 2 +- doc/user/project/integrations/git_guardian.md | 4 +- .../project/integrations/webhook_events.md | 2 +- doc/user/project/integrations/webhooks.md | 4 +- doc/user/project/issue_board.md | 2 +- doc/user/project/issues/managing_issues.md | 2 +- .../merge_requests/approvals/settings.md | 2 +- doc/user/project/merge_requests/changes.md | 4 +- doc/user/project/merge_requests/index.md | 4 +- .../merge_when_pipeline_succeeds.md | 4 +- doc/user/project/pages/index.md | 2 +- doc/user/project/pages/redirects.md | 2 +- doc/user/project/protected_branches.md | 4 +- .../remote_development/connect_machine.md | 4 +- doc/user/project/remote_development/index.md | 4 +- doc/user/project/repository/branches/index.md | 2 +- .../service_desk/using_service_desk.md | 2 +- doc/user/project/time_tracking.md | 2 +- doc/user/project/web_ide/index.md | 4 +- doc/user/search/exact_code_search.md | 6 +- doc/user/tasks.md | 14 +- doc/user/todos.md | 4 +- lib/api/groups.rb | 2 +- lib/api/import_github.rb | 3 +- lib/gitlab/github_import.rb | 4 + locale/gitlab.pot | 46 ++++- qa/Gemfile.lock | 3 +- qa/qa/tools/long_running_spec_reporter.rb | 14 +- .../tools/long_running_spec_reporter_spec.rb | 8 +- .../import/github_controller_spec.rb | 45 +++++ spec/db/schema_spec.rb | 1 + .../components/advanced_settings_spec.js | 44 +++-- .../types/ci/catalog/resource_type_spec.rb | 1 + spec/lib/gitlab/github_import_spec.rb | 7 + .../api/graphql/ci/catalog/resources_spec.rb | 8 +- spec/requests/api/import_github_spec.rb | 70 ++++++++ spec/services/import/github_service_spec.rb | 157 +++++++++++++++++- .../policies/group_policy_shared_context.rb | 2 + 120 files changed, 807 insertions(+), 305 deletions(-) create mode 100644 db/migrate/20240214035028_add_first_and_latest_pipeline_id_to_vulnerability_occurrences.rb create mode 100644 db/migrate/20240219143045_add_remove_group_to_member_roles.rb create mode 100644 db/post_migrate/20240226072310_prepare_index_for_initial_and_latest_pipeline_id_to_vulnerability_occurrences.rb create mode 100644 db/schema_migrations/20240214035028 create mode 100644 db/schema_migrations/20240219143045 create mode 100644 db/schema_migrations/20240226072310 diff --git a/.gitlab/ci/docs.gitlab-ci.yml b/.gitlab/ci/docs.gitlab-ci.yml index 98c7b9e3231..98f30dfba17 100644 --- a/.gitlab/ci/docs.gitlab-ci.yml +++ b/.gitlab/ci/docs.gitlab-ci.yml @@ -58,7 +58,7 @@ docs-lint links: .docs-markdown-lint-image: # When updating the image version here, update it in /scripts/lint-doc.sh too. - image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-docs/lint-markdown:alpine-3.18-vale-2.29.6-markdownlint-0.37.0-markdownlint2-0.10.0 + image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-docs/lint-markdown:alpine-3.19-vale-3.0.7-markdownlint-0.39.0-markdownlint2-0.12.1 docs-lint markdown: extends: diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index d43547a82fd..2a96ea2cc9a 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -221,7 +221,6 @@ Layout/FirstHashElementIndentation: - 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb' - 'spec/services/clusters/update_service_spec.rb' - 'spec/services/google_cloud/get_cloudsql_instances_service_spec.rb' - - 'spec/services/import/github_service_spec.rb' - 'spec/services/notes/render_service_spec.rb' - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - 'spec/services/projects/container_repository/delete_tags_service_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 1e31d9570fd..b4fb5d0ef6a 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -2562,7 +2562,6 @@ RSpec/ContextWording: - 'spec/services/ide/terminal_config_service_spec.rb' - 'spec/services/import/bitbucket_server_service_spec.rb' - 'spec/services/import/fogbugz_service_spec.rb' - - 'spec/services/import/github_service_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' - 'spec/services/incident_management/incidents/create_service_spec.rb' diff --git a/app/assets/javascripts/graphql_shared/possible_types.json b/app/assets/javascripts/graphql_shared/possible_types.json index c721e9e3a77..63ea8830cae 100644 --- a/app/assets/javascripts/graphql_shared/possible_types.json +++ b/app/assets/javascripts/graphql_shared/possible_types.json @@ -11,8 +11,8 @@ "AuditEventStreamingHeader", "AuditEventsStreamingInstanceHeader" ], - "CiRunnerCloudProvisioningOptions": [ - "CiRunnerGoogleCloudProvisioningOptions" + "CiRunnerCloudProvisioning": [ + "CiRunnerGoogleCloudProvisioning" ], "CiVariable": [ "CiGroupVariable", diff --git a/app/assets/javascripts/import_entities/import_projects/components/advanced_settings.vue b/app/assets/javascripts/import_entities/import_projects/components/advanced_settings.vue index d22a52df326..a3f8b8a885f 100644 --- a/app/assets/javascripts/import_entities/import_projects/components/advanced_settings.vue +++ b/app/assets/javascripts/import_entities/import_projects/components/advanced_settings.vue @@ -1,14 +1,30 @@