From 84b4743475246e91dc78c3f25f9b335c40be84cd Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 21 Mar 2022 15:08:37 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../javascripts/blob/line_highlighter.js | 2 + .../components/group_select.vue | 23 ++- .../components/invite_groups_modal.vue | 1 - .../vue_shared/components/line_numbers.vue | 31 ---- .../source_viewer/components/chunk.vue | 103 +++++++++++ .../source_viewer/components/chunk_line.vue | 44 +++++ .../components/source_viewer/constants.js | 2 + .../source_viewer/source_viewer.vue | 167 ++++++++++++------ .../components/source_viewer/utils.js | 28 --- ...ex_on_id_from_vulnerability_occurrences.rb | 15 ++ db/schema_migrations/20220120160625 | 1 + db/structure.sql | 2 - doc/administration/gitaly/index.md | 57 +++--- .../reference_architectures/10k_users.md | 8 +- .../reference_architectures/25k_users.md | 8 +- .../reference_architectures/3k_users.md | 8 +- .../reference_architectures/50k_users.md | 8 +- .../reference_architectures/5k_users.md | 8 +- doc/development/database/database_lab.md | 101 +++++++++++ doc/development/event_store.md | 40 +++++ doc/user/discussions/index.md | 19 +- doc/user/profile/notifications.md | 5 +- lib/backup/manager.rb | 136 +++++++------- .../groups/members/manage_groups_spec.rb | 146 +++++++++++---- .../blobs/blob_line_permalink_updater_spec.rb | 8 +- .../projects/members/invite_group_spec.rb | 116 +++++++++--- .../components/group_select_spec.js | 5 +- .../components/line_numbers_spec.js | 37 ---- .../components/chunk_line_spec.js | 47 +++++ .../source_viewer/components/chunk_spec.js | 82 +++++++++ .../source_viewer/source_viewer_spec.js | 103 +++++------ .../components/source_viewer/utils_spec.js | 26 --- spec/lib/backup/manager_spec.rb | 80 ++++++--- .../features/invite_members_modal_helper.rb | 12 ++ .../lib/gitlab/event_store_shared_examples.rb | 18 ++ spec/tasks/gitlab/backup_rake_spec.rb | 13 +- .../update_head_pipeline_worker_spec.rb | 6 +- .../update_root_statistics_worker_spec.rb | 6 +- 38 files changed, 1055 insertions(+), 467 deletions(-) delete mode 100644 app/assets/javascripts/vue_shared/components/line_numbers.vue create mode 100644 app/assets/javascripts/vue_shared/components/source_viewer/components/chunk.vue create mode 100644 app/assets/javascripts/vue_shared/components/source_viewer/components/chunk_line.vue delete mode 100644 app/assets/javascripts/vue_shared/components/source_viewer/utils.js create mode 100644 db/migrate/20220120160625_remove_temp_index_on_id_from_vulnerability_occurrences.rb create mode 100644 db/schema_migrations/20220120160625 create mode 100644 doc/development/database/database_lab.md delete mode 100644 spec/frontend/vue_shared/components/line_numbers_spec.js create mode 100644 spec/frontend/vue_shared/components/source_viewer/components/chunk_line_spec.js create mode 100644 spec/frontend/vue_shared/components/source_viewer/components/chunk_spec.js delete mode 100644 spec/frontend/vue_shared/components/source_viewer/utils_spec.js create mode 100644 spec/support/shared_examples/lib/gitlab/event_store_shared_examples.rb diff --git a/app/assets/javascripts/blob/line_highlighter.js b/app/assets/javascripts/blob/line_highlighter.js index a1f59aa1b54..a8932f8c73b 100644 --- a/app/assets/javascripts/blob/line_highlighter.js +++ b/app/assets/javascripts/blob/line_highlighter.js @@ -37,6 +37,7 @@ const LineHighlighter = function (options = {}) { options.fileHolderSelector = options.fileHolderSelector || '.file-holder'; options.scrollFileHolder = options.scrollFileHolder || false; options.hash = options.hash || window.location.hash; + options.scrollBehavior = options.scrollBehavior || 'smooth'; this.options = options; this._hash = options.hash; @@ -74,6 +75,7 @@ LineHighlighter.prototype.highlightHash = function (newHash) { // Scroll to the first highlighted line on initial load // Add an offset of -100 for some context offset: -100, + behavior: this.options.scrollBehavior, }); } } diff --git a/app/assets/javascripts/invite_members/components/group_select.vue b/app/assets/javascripts/invite_members/components/group_select.vue index 04a8ec3400f..fc14b2eba6a 100644 --- a/app/assets/javascripts/invite_members/components/group_select.vue +++ b/app/assets/javascripts/invite_members/components/group_select.vue @@ -24,10 +24,6 @@ export default { prop: 'selectedGroup', }, props: { - accessLevels: { - type: Object, - required: true, - }, groupsFilter: { type: String, required: false, @@ -58,13 +54,6 @@ export default { isFetchResultEmpty() { return this.groups.length === 0; }, - defaultFetchOptions() { - return { - exclude_internal: true, - active: true, - min_access_level: this.accessLevels.Guest, - }; - }, }, watch: { searchTerm() { @@ -107,9 +96,13 @@ export default { fetchGroups() { switch (this.groupsFilter) { case GROUP_FILTERS.DESCENDANT_GROUPS: - return getDescendentGroups(this.parentGroupId, this.searchTerm, this.defaultFetchOptions); + return getDescendentGroups( + this.parentGroupId, + this.searchTerm, + this.$options.defaultFetchOptions, + ); default: - return getGroups(this.searchTerm, this.defaultFetchOptions); + return getGroups(this.searchTerm, this.$options.defaultFetchOptions); } }, }, @@ -118,6 +111,10 @@ export default { searchPlaceholder: s__('GroupSelect|Search groups'), emptySearchResult: s__('GroupSelect|No matching results'), }, + defaultFetchOptions: { + exclude_internal: true, + active: true, + }, };