From 8b88def0da0dec7db3520d445ea405bdae7a7a3f Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 7 May 2025 12:14:55 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/rails/enum_syntax.yml | 110 ------- GITALY_SERVER_VERSION | 2 +- .../diffs/components/diffs_file_tree.vue | 2 +- .../pipelines/charts/components/app.vue | 3 +- .../components/clickhouse_help_popover.vue | 2 +- .../components/edit/branch_dropdown.vue | 2 +- .../settings/components/branch_rule_modal.vue | 2 +- app/controllers/groups_controller.rb | 34 +-- .../merge_requests/creations_controller.rb | 3 +- .../projects/pipelines_controller.rb | 4 - app/models/abuse_report.rb | 4 +- app/models/alert_management/alert.rb | 4 +- .../alert_management/http_integration.rb | 2 +- .../cycle_analytics/issue_stage_event.rb | 2 +- .../merge_request_stage_event.rb | 2 +- .../analytics/usage_trends/measurement.rb | 2 +- app/models/anti_abuse/event.rb | 4 +- app/models/anti_abuse/trust_score.rb | 2 +- app/models/application_record.rb | 2 +- app/models/authentication_event.rb | 2 +- .../batched_git_ref_updates/deletion.rb | 2 +- app/models/bulk_import.rb | 2 +- app/models/bulk_imports/entity.rb | 2 +- app/models/ci/build_metadata.rb | 2 +- app/models/ci/build_pending_state.rb | 4 +- app/models/ci/build_source.rb | 2 +- app/models/ci/build_trace_chunk.rb | 2 +- app/models/ci/catalog/resource.rb | 4 +- app/models/ci/catalog/resources/component.rb | 2 +- app/models/ci/catalog/resources/sync_event.rb | 2 +- app/models/ci/catalog/verified_namespace.rb | 2 +- app/models/ci/external_pull_request.rb | 2 +- app/models/ci/job_artifact.rb | 6 +- app/models/ci/job_token/project_scope_link.rb | 2 +- app/models/ci/job_variable.rb | 2 +- app/models/ci/pipeline.rb | 8 +- app/models/ci/pipeline_artifact.rb | 2 +- app/models/ci/pipeline_message.rb | 2 +- app/models/ci/pipeline_metadata.rb | 8 +- app/models/ci/resource_group.rb | 2 +- app/models/ci/runner.rb | 12 +- app/models/ci/runner_manager.rb | 6 +- app/models/ci/runner_version.rb | 2 +- app/models/ci/running_build.rb | 2 +- app/models/ci/stage.rb | 2 +- app/models/clusters/agent_token.rb | 2 +- app/models/clusters/agents/activity_event.rb | 8 +- app/models/clusters/cluster.rb | 6 +- .../clusters/integrations/prometheus.rb | 2 +- app/models/clusters/platforms/kubernetes.rb | 4 +- app/models/commit_status.rb | 4 +- .../analytics/cycle_analytics/stageable.rb | 8 +- app/models/concerns/ci/artifactable.rb | 4 +- app/models/concerns/ci/has_runner_executor.rb | 4 +- app/models/concerns/ci/has_variable.rb | 2 +- app/models/concerns/ci/lockable.rb | 4 +- app/models/concerns/commit_signature.rb | 2 +- app/models/concerns/has_user_type.rb | 2 +- .../concerns/import/has_import_source.rb | 2 +- app/models/concerns/issuable_link.rb | 2 +- .../concerns/merge_request_reviewer_state.rb | 2 +- .../packages/debian/component_file.rb | 4 +- app/models/concerns/ttl_expirable.rb | 2 +- ...se_sql_function_for_primary_key_lookups.rb | 4 +- .../container_registry/data_repair_detail.rb | 2 +- .../container_registry/protection/rule.rb | 10 +- app/models/container_repository.rb | 4 +- app/models/customer_relations/contact.rb | 2 +- app/models/customer_relations/organization.rb | 2 +- app/models/deploy_token.rb | 2 +- app/models/deployment.rb | 2 +- app/models/design_management/action.rb | 2 +- app/models/diff_note_position.rb | 4 +- app/models/draft_note.rb | 2 +- app/models/environment.rb | 6 +- app/models/error_tracking/error.rb | 2 +- app/models/event.rb | 2 +- app/models/group_deploy_key.rb | 10 - app/models/integrations/jira.rb | 2 +- app/models/integrations/jira_tracker_data.rb | 2 +- app/models/internal_id.rb | 2 +- app/models/issuable_severity.rb | 2 +- app/models/jira_import_state.rb | 2 +- app/models/key.rb | 3 +- app/models/list.rb | 2 +- .../loose_foreign_keys/deleted_record.rb | 2 +- app/models/merge_request_diff.rb | 2 +- app/models/ml/candidate.rb | 2 +- .../namespace/root_storage_statistics.rb | 4 +- app/models/namespace_setting.rb | 8 +- app/models/namespaces/project_namespace.rb | 2 +- app/models/notification_setting.rb | 2 +- app/models/operations/feature_flag.rb | 2 +- app/models/organizations/organization_user.rb | 2 +- app/models/packages/conan/file_metadatum.rb | 2 +- app/models/packages/debian/file_metadatum.rb | 2 +- app/models/packages/dependency_link.rb | 2 +- app/models/packages/npm/metadata_cache.rb | 2 +- app/models/packages/package.rb | 4 +- app/models/packages/package_file.rb | 2 +- app/models/packages/protection/rule.rb | 12 +- app/models/packages/rpm/repository_file.rb | 2 +- app/models/pages_domain.rb | 6 +- app/models/project.rb | 2 +- app/models/project_auto_devops.rb | 2 +- app/models/project_ci_cd_setting.rb | 2 +- app/models/project_repository.rb | 2 +- app/models/projects/ci_feature_usage.rb | 2 +- app/models/push_event_payload.rb | 4 +- app/models/releases/link.rb | 2 +- .../resource_events/abuse_report_event.rb | 4 +- .../resource_events/issue_assignment_event.rb | 2 +- .../merge_request_assignment_event.rb | 2 +- app/models/resource_label_event.rb | 2 +- app/models/resource_milestone_event.rb | 2 +- app/models/resource_state_event.rb | 2 +- app/models/resource_timebox_event.rb | 2 +- .../service_desk/custom_email_credential.rb | 2 +- .../service_desk/custom_email_verification.rb | 4 +- app/models/user.rb | 1 - .../shared/_create_protected_branch.html.haml | 2 +- .../shared/_index.html.haml | 2 +- config/application.rb | 2 + .../collect_product_usage_events.yml | 6 +- .../disable_widget_responses.yml | 4 +- ...ci_improved_project_pipeline_analytics.yml | 9 - .../initializers/active_record_lifecycle.rb | 2 +- config/initializers/postgresql_cte.rb | 2 +- config/initializers/sidekiq.rb | 2 +- db/docs/deleted_tables/taggings.yml | 8 + db/docs/taggings.yml | 12 - ...nique_contraints_ci_job_artifact_states.rb | 37 +++ .../20250505150842_drop_taggings.rb | 29 ++ db/schema_migrations/20250428232147 | 1 + db/schema_migrations/20250505150842 | 1 + db/structure.sql | 35 +-- doc/administration/analytics.md | 2 +- doc/administration/logs/_index.md | 65 +++- .../postgresql/replication_and_failover.md | 10 +- .../self_hosted_models/related_topics.md | 29 -- doc/api/protected_branches.md | 4 +- doc/ci/components/_index.md | 2 +- doc/ci/pipelines/schedules.md | 2 +- .../database/pagination_guidelines.md | 24 +- doc/development/value_stream_analytics.md | 28 +- ...lue_stream_analytics_aggregated_backend.md | 40 +-- doc/integration/jira/_index.md | 24 +- doc/topics/git/git_rebase.md | 2 +- doc/user/analytics/ci_cd_analytics.md | 6 + .../merge_request_approval_policies.md | 2 +- doc/user/compliance/_index.md | 2 +- .../group/value_stream_analytics/_index.md | 28 +- doc/user/permissions.md | 2 +- doc/user/project/codeowners/_index.md | 6 +- .../project/codeowners/troubleshooting.md | 2 +- doc/user/project/deploy_keys/_index.md | 2 +- doc/user/project/import/github.md | 8 +- .../google_artifact_management.md | 10 +- .../project/merge_requests/approvals/rules.md | 4 +- .../project/repository/branches/protected.md | 280 +++++++----------- .../repository/branches/protection_rules.md | 221 ++++++++++++++ .../repository/mirror/troubleshooting.md | 2 +- .../databases/concerns/elastic_executor.rb | 24 +- .../databases/concerns/executor.rb | 14 +- .../databases/postgresql/executor.rb | 18 +- .../lib/active_context/reference.rb | 17 +- .../lib/active_context/bulk_processor_spec.rb | 2 +- .../databases/concerns/executor_spec.rb | 19 +- .../preprocessors/chunking_spec.rb | 2 +- .../preprocessors/embeddings_spec.rb | 2 +- .../preprocessors/preload_spec.rb | 2 +- .../spec/lib/active_context/reference_spec.rb | 87 +++++- keeps/initialize_big_int_conversion.rb | 2 +- keeps/remove_duplicated_indexes.rb | 2 +- lib/gitlab/database/reindexing.rb | 3 - lib/gitlab/database/truncate_taggings.rb | 34 --- lib/gitlab/tracking/destinations/snowplow.rb | 16 +- lib/gitlab/tracking/snowplow_event_logger.rb | 15 + .../tracking/snowplow_logging_emitter.rb | 24 ++ lib/tasks/dev.rake | 2 +- lib/tasks/gitlab/db.rake | 4 +- locale/gitlab.pot | 3 + package.json | 2 +- qa/gdk/entrypoint | 2 +- qa/gdk/gdk.yml | 3 +- scripts/product_usage_data_event_formatter.rb | 48 +++ spec/controllers/groups_controller_spec.rb | 20 -- spec/db/schema_spec.rb | 1 - spec/features/projects/graph_spec.rb | 28 +- .../pipelines/charts/components/app_spec.js | 19 -- .../clickhouse_help_popover_spec.js | 20 +- .../components/branch_rule_modal_spec.js | 2 +- .../copy_taggings_to_p_ci_build_tags_spec.rb | 2 +- .../gitlab/database/truncate_taggings_spec.rb | 53 ---- .../tracking/destinations/snowplow_spec.rb | 52 ++++ .../tracking/snowplow_logging_emitter_spec.rb | 28 ++ spec/models/group_deploy_key_spec.rb | 6 - .../creations_controller_spec.rb | 9 + spec/support/db_cleaner.rb | 7 +- spec/tasks/dev_rake_spec.rb | 6 +- yarn.lock | 70 ++--- 201 files changed, 1174 insertions(+), 965 deletions(-) delete mode 100644 .rubocop_todo/rails/enum_syntax.yml rename config/feature_flags/{wip => beta}/collect_product_usage_events.yml (70%) rename config/feature_flags/{gitlab_com_derisk => beta}/disable_widget_responses.yml (86%) delete mode 100644 config/feature_flags/wip/ci_improved_project_pipeline_analytics.yml create mode 100644 db/docs/deleted_tables/taggings.yml delete mode 100644 db/docs/taggings.yml create mode 100644 db/migrate/20250428232147_change_unique_contraints_ci_job_artifact_states.rb create mode 100644 db/post_migrate/20250505150842_drop_taggings.rb create mode 100644 db/schema_migrations/20250428232147 create mode 100644 db/schema_migrations/20250505150842 delete mode 100644 doc/administration/self_hosted_models/related_topics.md create mode 100644 doc/user/project/repository/branches/protection_rules.md delete mode 100644 lib/gitlab/database/truncate_taggings.rb create mode 100644 lib/gitlab/tracking/snowplow_event_logger.rb create mode 100644 lib/gitlab/tracking/snowplow_logging_emitter.rb create mode 100755 scripts/product_usage_data_event_formatter.rb delete mode 100644 spec/lib/gitlab/database/truncate_taggings_spec.rb create mode 100644 spec/lib/gitlab/tracking/snowplow_logging_emitter_spec.rb diff --git a/.rubocop_todo/rails/enum_syntax.yml b/.rubocop_todo/rails/enum_syntax.yml deleted file mode 100644 index 700635c4e9d..00000000000 --- a/.rubocop_todo/rails/enum_syntax.yml +++ /dev/null @@ -1,110 +0,0 @@ ---- -# Cop supports --autocorrect. -Rails/EnumSyntax: - Exclude: - - 'app/models/abuse_report.rb' - - 'app/models/alert_management/alert.rb' - - 'app/models/alert_management/http_integration.rb' - - 'app/models/analytics/cycle_analytics/issue_stage_event.rb' - - 'app/models/analytics/cycle_analytics/merge_request_stage_event.rb' - - 'app/models/analytics/usage_trends/measurement.rb' - - 'app/models/anti_abuse/event.rb' - - 'app/models/anti_abuse/trust_score.rb' - - 'app/models/application_record.rb' - - 'app/models/authentication_event.rb' - - 'app/models/batched_git_ref_updates/deletion.rb' - - 'app/models/bulk_import.rb' - - 'app/models/bulk_imports/entity.rb' - - 'app/models/ci/build_metadata.rb' - - 'app/models/ci/build_pending_state.rb' - - 'app/models/ci/build_source.rb' - - 'app/models/ci/build_trace_chunk.rb' - - 'app/models/ci/catalog/resource.rb' - - 'app/models/ci/catalog/resources/component.rb' - - 'app/models/ci/catalog/resources/sync_event.rb' - - 'app/models/ci/catalog/verified_namespace.rb' - - 'app/models/ci/external_pull_request.rb' - - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/job_token/project_scope_link.rb' - - 'app/models/ci/job_variable.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/ci/pipeline_artifact.rb' - - 'app/models/ci/pipeline_message.rb' - - 'app/models/ci/pipeline_metadata.rb' - - 'app/models/ci/resource_group.rb' - - 'app/models/ci/runner.rb' - - 'app/models/ci/runner_manager.rb' - - 'app/models/ci/runner_version.rb' - - 'app/models/ci/running_build.rb' - - 'app/models/ci/stage.rb' - - 'app/models/clusters/agent_token.rb' - - 'app/models/clusters/agents/activity_event.rb' - - 'app/models/clusters/cluster.rb' - - 'app/models/clusters/integrations/prometheus.rb' - - 'app/models/clusters/platforms/kubernetes.rb' - - 'app/models/commit_status.rb' - - 'app/models/concerns/analytics/cycle_analytics/stageable.rb' - - 'app/models/concerns/ci/artifactable.rb' - - 'app/models/concerns/ci/has_runner_executor.rb' - - 'app/models/concerns/ci/has_variable.rb' - - 'app/models/concerns/ci/lockable.rb' - - 'app/models/concerns/commit_signature.rb' - - 'app/models/concerns/has_user_type.rb' - - 'app/models/concerns/import/has_import_source.rb' - - 'app/models/concerns/issuable_link.rb' - - 'app/models/concerns/merge_request_reviewer_state.rb' - - 'app/models/concerns/packages/debian/component_file.rb' - - 'app/models/concerns/ttl_expirable.rb' - - 'app/models/container_registry/data_repair_detail.rb' - - 'app/models/container_registry/protection/rule.rb' - - 'app/models/container_repository.rb' - - 'app/models/customer_relations/contact.rb' - - 'app/models/customer_relations/organization.rb' - - 'app/models/deploy_token.rb' - - 'app/models/deployment.rb' - - 'app/models/design_management/action.rb' - - 'app/models/diff_note_position.rb' - - 'app/models/draft_note.rb' - - 'app/models/environment.rb' - - 'app/models/error_tracking/error.rb' - - 'app/models/event.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/integrations/jira_tracker_data.rb' - - 'app/models/internal_id.rb' - - 'app/models/issuable_severity.rb' - - 'app/models/jira_import_state.rb' - - 'app/models/key.rb' - - 'app/models/list.rb' - - 'app/models/loose_foreign_keys/deleted_record.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/ml/candidate.rb' - - 'app/models/namespace/root_storage_statistics.rb' - - 'app/models/namespace_setting.rb' - - 'app/models/notification_setting.rb' - - 'app/models/operations/feature_flag.rb' - - 'app/models/organizations/organization_user.rb' - - 'app/models/packages/conan/file_metadatum.rb' - - 'app/models/packages/debian/file_metadatum.rb' - - 'app/models/packages/dependency_link.rb' - - 'app/models/packages/npm/metadata_cache.rb' - - 'app/models/packages/package.rb' - - 'app/models/packages/package_file.rb' - - 'app/models/packages/protection/rule.rb' - - 'app/models/packages/rpm/repository_file.rb' - - 'app/models/pages_domain.rb' - - 'app/models/project.rb' - - 'app/models/project_auto_devops.rb' - - 'app/models/project_ci_cd_setting.rb' - - 'app/models/project_repository.rb' - - 'app/models/projects/ci_feature_usage.rb' - - 'app/models/push_event_payload.rb' - - 'app/models/releases/link.rb' - - 'app/models/resource_events/abuse_report_event.rb' - - 'app/models/resource_events/issue_assignment_event.rb' - - 'app/models/resource_events/merge_request_assignment_event.rb' - - 'app/models/resource_label_event.rb' - - 'app/models/resource_milestone_event.rb' - - 'app/models/resource_state_event.rb' - - 'app/models/resource_timebox_event.rb' - - 'app/models/service_desk/custom_email_credential.rb' - - 'app/models/service_desk/custom_email_verification.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 6f22fcc3a5d..36f134e057b 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -124a10130bac885023b44616e773ffd4229ee592 +c46abdc81b87926a9cc99e13fdcbfb8ec516cb17 diff --git a/app/assets/javascripts/diffs/components/diffs_file_tree.vue b/app/assets/javascripts/diffs/components/diffs_file_tree.vue index 9fef8d68460..16f9d8b7420 100644 --- a/app/assets/javascripts/diffs/components/diffs_file_tree.vue +++ b/app/assets/javascripts/diffs/components/diffs_file_tree.vue @@ -140,7 +140,7 @@ export default { :style="floatingWrapperStyles" >