From 9186354c5c1da6262bbcd2c0331b0d59e2f4c72b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 6 May 2024 15:16:24 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../merge_request_templates/Security Fix.md | 3 +- .rubocop_todo/layout/argument_alignment.yml | 16 ---- .../terraform/components/states_table.vue | 13 ++- .../components/states_table_actions.vue | 5 +- .../terraform/components/terraform_list.vue | 57 ++++++------ .../types/commit_signature_interface.rb | 16 ++-- .../commit_signatures/gpg_signature_type.rb | 16 ++-- .../commit_signatures/x509_signature_type.rb | 10 +- app/graphql/types/commit_type.rb | 52 +++++------ .../container_repository_details_type.rb | 30 +++--- .../types/countable_connection_type.rb | 2 +- app/graphql/types/current_user_todos.rb | 12 +-- app/graphql/types/custom_emoji_type.rb | 20 ++-- .../contact_state_counts_type.rb | 6 +- .../customer_relations/contact_state_enum.rb | 12 +-- .../types/customer_relations/contact_type.rb | 58 ++++++------ .../organization_state_counts_type.rb | 6 +- .../organization_state_enum.rb | 12 +-- .../customer_relations/organization_type.rb | 42 ++++----- .../types/dependency_proxy/manifest_type.rb | 6 +- app/helpers/application_settings_helper.rb | 13 +-- app/models/application_setting.rb | 28 +++--- .../application_setting_implementation.rb | 10 +- app/services/gpg_keys/create_service.rb | 2 + .../gpg_keys/validate_integrations_service.rb | 9 +- app/services/issuable/callbacks/base.rb | 1 + app/services/issuable_base_service.rb | 1 + .../application_setting_importers.json | 11 +++ .../i_quickactions_add_email_multiple.yml | 20 ++++ .../i_quickactions_add_email_single.yml | 20 ++++ config/initializers/1_settings.rb | 2 +- ...uickactions_add_email_multiple_monthly.yml | 23 +++++ ..._quickactions_add_email_single_monthly.yml | 23 +++++ ...quickactions_add_email_multiple_weekly.yml | 23 +++++ ...i_quickactions_add_email_single_weekly.yml | 23 +++++ db/docs/ci_builds_runner_session.yml | 1 + db/docs/ci_cost_settings.yml | 1 + db/docs/ci_runner_machines.yml | 1 + db/docs/ci_runner_projects.yml | 1 + db/docs/ci_runner_versions.yml | 1 + db/docs/ci_runners.yml | 1 + .../p_ci_finished_build_ch_sync_events.yml | 1 + db/docs/p_ci_runner_machine_builds.yml | 1 + ...9_add_importers_to_application_settings.rb | 10 ++ ...hash_constraint_to_application_settings.rb | 20 ++++ db/schema_migrations/20240409013009 | 1 + db/schema_migrations/20240409014016 | 1 + db/structure.sql | 2 + doc/api/settings.md | 8 +- doc/development/ai_features/local_models.md | 2 +- doc/development/packages/settings.md | 16 ++-- .../testing_guide/end_to_end/index.md | 2 +- doc/development/work_items_widgets.md | 2 + doc/user/project/clusters/runbooks/index.md | 91 ++++++++----------- doc/user/project/quick_actions.md | 2 +- .../service_desk/external_participants.md | 8 +- lib/api/entities/application_setting.rb | 16 ++++ lib/gitlab/beyond_identity/client.rb | 25 ++++- .../integrations/beyond_identity_check.rb | 12 ++- lib/gitlab/i18n.rb | 22 ++--- lib/gitlab/quick_actions/issue_actions.rb | 8 +- .../quick_action_activity_unique_counter.rb | 16 +++- locale/gitlab.pot | 10 +- .../user_scrolls_to_deeplinked_note_spec.rb | 2 +- .../components/terraform_list_spec.js | 20 ++-- .../application_settings_helper_spec.rb | 24 ----- .../api/entities/application_setting_spec.rb | 18 ++++ .../lib/gitlab/beyond_identity/client_spec.rb | 35 +++++-- .../beyond_identity_check_spec.rb | 14 +-- ...ick_action_activity_unique_counter_spec.rb | 12 +-- spec/models/application_setting_spec.rb | 16 +--- spec/services/gpg_keys/create_service_spec.rb | 4 +- .../validate_integrations_service_spec.rb | 49 ++++++---- .../quick_actions/interpret_service_spec.rb | 26 +++--- workhorse/internal/zipartifacts/metadata.go | 6 +- .../internal/zipartifacts/metadata_test.go | 5 + 76 files changed, 672 insertions(+), 444 deletions(-) create mode 100644 app/validators/json_schemas/application_setting_importers.json create mode 100644 config/events/i_quickactions_add_email_multiple.yml create mode 100644 config/events/i_quickactions_add_email_single.yml create mode 100644 config/metrics/counts_28d/count_total_i_quickactions_add_email_multiple_monthly.yml create mode 100644 config/metrics/counts_28d/count_total_i_quickactions_add_email_single_monthly.yml create mode 100644 config/metrics/counts_7d/count_total_i_quickactions_add_email_multiple_weekly.yml create mode 100644 config/metrics/counts_7d/count_total_i_quickactions_add_email_single_weekly.yml create mode 100644 db/migrate/20240409013009_add_importers_to_application_settings.rb create mode 100644 db/migrate/20240409014016_add_importers_hash_constraint_to_application_settings.rb create mode 100644 db/schema_migrations/20240409013009 create mode 100644 db/schema_migrations/20240409014016 diff --git a/.gitlab/merge_request_templates/Security Fix.md b/.gitlab/merge_request_templates/Security Fix.md index 88ef950742d..7fe7d7fb426 100644 --- a/.gitlab/merge_request_templates/Security Fix.md +++ b/.gitlab/merge_request_templates/Security Fix.md @@ -37,10 +37,9 @@ See [the general developer security guidelines](https://gitlab.com/gitlab-org/re /label ~security [GitLab Security]: https://gitlab.com/gitlab-org/security/gitlab -[quick actions]: https://docs.gitlab.com/ee/user/project/quick_actions.html#quick-actions-for-issues-merge-requests-and-epics [CHANGELOG entry]: https://docs.gitlab.com/ee/development/changelog.html#overview [Code Review process]: https://docs.gitlab.com/ee/development/code_review.html -[Code reviews and Approvals]: (https://gitlab.com/gitlab-org/release/docs/blob/master/general/security/developer.md#code-reviews-and-approvals) +[Code reviews and Approvals]: (https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/security/engineer.md#code-reviews-and-approvals) [Approval Guidelines]: https://docs.gitlab.com/ee/development/code_review.html#approval-guidelines [Canonical repository]: https://gitlab.com/gitlab-org/gitlab [`e2e:package-and-test` job]: https://docs.gitlab.com/ee/development/testing_guide/end_to_end/#using-the-package-and-test-job diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 57a9d6a15bf..f0d0e89008f 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -85,22 +85,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/board_type.rb' - 'app/graphql/types/boards/board_issuable_input_base_type.rb' - 'app/graphql/types/boards/board_issue_input_base_type.rb' - - 'app/graphql/types/commit_signature_interface.rb' - - 'app/graphql/types/commit_signatures/gpg_signature_type.rb' - - 'app/graphql/types/commit_signatures/ssh_signature_type.rb' - - 'app/graphql/types/commit_signatures/x509_signature_type.rb' - - 'app/graphql/types/commit_type.rb' - - 'app/graphql/types/container_repository_details_type.rb' - - 'app/graphql/types/countable_connection_type.rb' - - 'app/graphql/types/current_user_todos.rb' - - 'app/graphql/types/custom_emoji_type.rb' - - 'app/graphql/types/customer_relations/contact_state_counts_type.rb' - - 'app/graphql/types/customer_relations/contact_state_enum.rb' - - 'app/graphql/types/customer_relations/contact_type.rb' - - 'app/graphql/types/customer_relations/organization_state_counts_type.rb' - - 'app/graphql/types/customer_relations/organization_state_enum.rb' - - 'app/graphql/types/customer_relations/organization_type.rb' - - 'app/graphql/types/dependency_proxy/manifest_type.rb' - 'app/graphql/types/error_tracking/sentry_detailed_error_type.rb' - 'app/graphql/types/error_tracking/sentry_error_collection_type.rb' - 'app/graphql/types/error_tracking/sentry_error_stack_trace_context_type.rb' diff --git a/app/assets/javascripts/terraform/components/states_table.vue b/app/assets/javascripts/terraform/components/states_table.vue index 8b6edbf0514..e1f00bfdaa5 100644 --- a/app/assets/javascripts/terraform/components/states_table.vue +++ b/app/assets/javascripts/terraform/components/states_table.vue @@ -141,7 +141,7 @@ export default { class="gl-display-flex gl-align-items-center gl-justify-content-end gl-md-justify-content-start" data-testid="terraform-states-table-name" > -

+

{{ item.name }}

@@ -188,16 +188,15 @@ export default {