root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Merge branch 'winh-lint-console-tests' into 'master' 

Enable no-console ESLint rule for tests

See merge request gitlab-org/gitlab-ce!20812
This commit is contained in:
Mike Greiling 2018-07-31 19:03:19 +00:00
parent 400925c480 7a870e4045
commit 93c7b6c51a
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
spec/javascripts/.eslintrc.yml
View File

@ -30,7 +30,6 @@ rules:
jasmine/no-spec-dupes: jasmine/no-spec-dupes:
- warn - warn
- branch - branch
no-console: off
prefer-arrow-callback: off prefer-arrow-callback: off
import/no-unresolved: import/no-unresolved:
- error - error

1
spec/javascripts/datetime_utility_spec.js
View File

@ -162,7 +162,6 @@ describe('getTimeframeWindowFrom', () => {
const timeframe = datetimeUtility.getTimeframeWindowFrom(startDate, 5); const timeframe = datetimeUtility.getTimeframeWindowFrom(startDate, 5);
expect(timeframe.length).toBe(5); expect(timeframe.length).toBe(5);
timeframe.forEach((timeframeItem, index) => { timeframe.forEach((timeframeItem, index) => {
console.log(timeframeItem);
expect(timeframeItem.getFullYear() === mockTimeframe[index].getFullYear()).toBe(true); expect(timeframeItem.getFullYear() === mockTimeframe[index].getFullYear()).toBe(true);
expect(timeframeItem.getMonth() === mockTimeframe[index].getMonth()).toBe(true); expect(timeframeItem.getMonth() === mockTimeframe[index].getMonth()).toBe(true);
expect(timeframeItem.getDate() === mockTimeframe[index].getDate()).toBeTruthy(); expect(timeframeItem.getDate() === mockTimeframe[index].getDate()).toBeTruthy();

2
spec/javascripts/pdf/page_spec.js
View File

@ -30,7 +30,7 @@ describe('Page component', () => {
done(); done();
}) })
.catch((error) => { .catch((error) => {
console.error(error); done.fail(error);
}); });
}); });

4
spec/javascripts/test_bundle.js
View File

@ -1,4 +1,6 @@
/* eslint-disable jasmine/no-global-setup, jasmine/no-unsafe-spy, no-underscore-dangle */ /* eslint-disable
jasmine/no-global-setup, jasmine/no-unsafe-spy, no-underscore-dangle, no-console
*/
import $ from 'jquery'; import $ from 'jquery';
import 'vendor/jasmine-jquery'; import 'vendor/jasmine-jquery';