From 93fdeb5a619e45cb64ff346c127ff4d68c619ffe Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 2 Aug 2023 18:10:41 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab-ci.yml | 2 +- .gitlab/CODEOWNERS | 1 + .rubocop.yml | 1 + GITALY_SERVER_VERSION | 2 +- Gemfile | 4 +- Gemfile.checksum | 4 +- Gemfile.lock | 8 +- .../registration_instructions.vue | 2 +- .../ci/runner/components/runner_details.vue | 5 +- .../comment_templates/components/form.vue | 9 +- .../comment_templates/components/list.vue | 47 ++--- .../components/list_item.vue | 8 +- .../comment_templates/pages/index.vue | 47 ++++- .../components/global_search.vue | 8 +- .../components/global_search/constants.js | 2 +- .../organizations/application_controller.rb | 6 +- app/controllers/projects/pages_controller.rb | 10 +- app/models/work_items/type.rb | 8 +- app/services/projects/update_service.rb | 6 - .../projects/pages/_pages_settings.html.haml | 17 +- app/workers/all_queues.yml | 9 + app/workers/concerns/worker_attributes.rb | 4 + app/workers/pause_control/resume_worker.rb | 50 +++++ .../zoekt_pause_indexing.yml} | 14 +- config/initializers/1_settings.rb | 3 + config/initializers/zz_metrics.rb | 1 + danger/roulette/Dangerfile | 4 - .../20230728174927_add_epic_work_item_type.rb | 82 ++++++++ db/schema_migrations/20230728174927 | 1 + doc/administration/geo/index.md | 1 + .../geo/secondary_proxy/index.md | 7 +- doc/api/code_suggestions.md | 7 +- doc/api/merge_requests.md | 6 +- doc/api/milestones.md | 8 +- doc/api/projects.md | 9 +- doc/api/repository_files.md | 4 +- doc/api/users.md | 16 +- doc/development/cicd/index.md | 47 ++++- doc/development/ruby_upgrade.md | 3 +- doc/development/sidekiq/worker_attributes.md | 39 ++++ doc/user/ai_features.md | 37 +++- doc/user/group/saml_sso/group_sync.md | 88 +++++++-- doc/user/profile/notifications.md | 6 + .../import_issues_from_jira_button_v12_10.png | Bin 8422 -> 0 bytes .../import_issues_from_jira_button_v16_3.png | Bin 0 -> 9369 bytes doc/user/project/import/jira.md | 18 +- doc/user/project/pages/introduction.md | 1 + .../work_items/base_type_importer.rb | 12 ++ .../hierarchy_restrictions_importer.rb | 5 +- lib/gitlab/pages/url_builder.rb | 3 +- lib/gitlab/pages/virtual_host_finder.rb | 1 - .../sidekiq_logging/pause_control_logger.rb | 31 +++ lib/gitlab/sidekiq_middleware.rb | 2 + .../sidekiq_middleware/pause_control.rb | 20 ++ .../pause_control/client.rb | 13 ++ .../pause_control/pause_control_service.rb | 118 ++++++++++++ .../pause_control/server.rb | 13 ++ .../pause_control/strategies/base.rb | 64 +++++++ .../pause_control/strategies/none.rb | 17 ++ .../pause_control/strategies/zoekt.rb | 16 ++ .../pause_control/strategy_handler.rb | 35 ++++ .../pause_control/workers_map.rb | 26 +++ lib/system_check/app/ruby_version_check.rb | 2 +- locale/gitlab.pot | 38 +++- package.json | 8 +- .../projects/issues_controller_spec.rb | 8 + .../projects/pages_controller_spec.rb | 51 ++--- spec/factories/issues.rb | 4 + spec/factories/work_items.rb | 4 + .../list_users_comment_template_spec.rb | 2 +- .../user_creates_comment_template_spec.rb | 3 +- .../__snapshots__/list_item_spec.js.snap | 8 +- .../comment_templates/components/list_spec.js | 6 - .../comment_templates/pages/index_spec.js | 9 + .../components/global_search_spec.js | 154 ++++++++++++--- spec/graphql/types/issue_type_enum_spec.rb | 2 +- spec/helpers/integrations_helper_spec.rb | 2 +- spec/lib/gitlab/pages/url_builder_spec.rb | 72 ++----- .../pause_control/client_spec.rb | 53 ++++++ .../pause_control_service_spec.rb | 178 ++++++++++++++++++ .../pause_control/server_spec.rb | 76 ++++++++ .../pause_control/strategy_handler_spec.rb | 68 +++++++ .../sidekiq_middleware/pause_control_spec.rb | 19 ++ ...0728174927_add_epic_work_item_type_spec.rb | 91 +++++++++ spec/models/issue_spec.rb | 2 +- spec/models/work_items/type_spec.rb | 4 +- spec/requests/api/internal/pages_spec.rb | 14 -- .../organizations_controller_spec.rb | 30 +-- spec/services/projects/update_service_spec.rb | 131 +++++-------- ...rk_item_hierarchy_restrictions_importer.rb | 4 +- .../danger/bulk_database_actions_spec.rb | 135 +++++++------ .../pages/_pages_settings.html.haml_spec.rb | 10 - tooling/danger/bulk_database_actions.rb | 2 +- 93 files changed, 1727 insertions(+), 501 deletions(-) create mode 100644 app/workers/pause_control/resume_worker.rb rename config/feature_flags/{development/pages_unique_domain.yml => ops/zoekt_pause_indexing.yml} (50%) create mode 100644 db/post_migrate/20230728174927_add_epic_work_item_type.rb create mode 100644 db/schema_migrations/20230728174927 delete mode 100644 doc/user/project/import/img/jira/import_issues_from_jira_button_v12_10.png create mode 100644 doc/user/project/import/img/jira/import_issues_from_jira_button_v16_3.png create mode 100644 lib/gitlab/sidekiq_logging/pause_control_logger.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/client.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/pause_control_service.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/server.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/strategies/base.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/strategies/none.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/strategies/zoekt.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/strategy_handler.rb create mode 100644 lib/gitlab/sidekiq_middleware/pause_control/workers_map.rb create mode 100644 spec/lib/gitlab/sidekiq_middleware/pause_control/client_spec.rb create mode 100644 spec/lib/gitlab/sidekiq_middleware/pause_control/pause_control_service_spec.rb create mode 100644 spec/lib/gitlab/sidekiq_middleware/pause_control/server_spec.rb create mode 100644 spec/lib/gitlab/sidekiq_middleware/pause_control/strategy_handler_spec.rb create mode 100644 spec/lib/gitlab/sidekiq_middleware/pause_control_spec.rb create mode 100644 spec/migrations/20230728174927_add_epic_work_item_type_spec.rb diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7184bdc1bbc..bcca822fc0b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -143,7 +143,7 @@ variables: BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3" BUNDLE_FROZEN: "true" # we override the max_old_space_size to prevent OOM errors - NODE_OPTIONS: --max_old_space_size=4096 + NODE_OPTIONS: --max_old_space_size=5120 GIT_DEPTH: "20" # 'GIT_STRATEGY: clone' optimizes the pack-objects cache hit ratio GIT_STRATEGY: "clone" diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index f0b549766ed..9e49144e11e 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1333,6 +1333,7 @@ lib/gitlab/checks/** /app/policies/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers /app/presenters/ci/runner_*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers /app/serializers/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/services/groups/update_shared_runners_service.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers /app/services/ci/runners/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers /app/workers/ci/runners/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers /db/docs/ci_runner*.yml @gitlab-org/ci-cd/runner-fleet-team/backend-approvers diff --git a/.rubocop.yml b/.rubocop.yml index 48e7a92d05f..25e65fe6b8d 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1013,6 +1013,7 @@ Search/NamespacedClass: - 'lib/gitlab/instrumentation/**/*.rb' - 'lib/gitlab/usage/metrics/instrumentations/**/*.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/**/*.rb' + - 'lib/gitlab/sidekiq_middleware/pause_control/strategies/zoekt.rb' SidekiqLoadBalancing/WorkerDataConsistency: Enabled: true diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 80d9ad4a8eb..863894c2f39 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -26f9b86f5d59e643b719b5ff15bb8e57d8ba599f +4dd176cbbace0b22872fd82e94ea56713f8304ea diff --git a/Gemfile b/Gemfile index 5ae0197cadf..3cd606d36e8 100644 --- a/Gemfile +++ b/Gemfile @@ -404,7 +404,7 @@ group :development, :test do gem 'parser', '~> 3.2', '>= 3.2.2.3' gem 'pry-byebug' gem 'pry-rails', '~> 0.3.9' - gem 'pry-shell', '~> 0.6.1' + gem 'pry-shell', '~> 0.6.3' gem 'awesome_print', require: false @@ -447,7 +447,7 @@ group :development, :test do end group :development, :test, :danger do - gem 'gitlab-dangerfiles', '~> 3.12.0', require: false + gem 'gitlab-dangerfiles', '~> 3.13.0', require: false end group :development, :test, :coverage do diff --git a/Gemfile.checksum b/Gemfile.checksum index d45dd85fc68..7e2af4a079b 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -206,7 +206,7 @@ {"name":"gitaly","version":"16.2.0.pre.rc4","platform":"ruby","checksum":"08756662fb1537b7d481bbd377c20648f3e0c50fff7d1fd25c6e6034cea2517c"}, {"name":"gitlab","version":"4.19.0","platform":"ruby","checksum":"3f645e3e195dbc24f0834fbf83e8ccfb2056d8e9712b01a640aad418a6949679"}, {"name":"gitlab-chronic","version":"0.10.5","platform":"ruby","checksum":"f80f18dc699b708870a80685243331290bc10cfeedb6b99c92219722f729c875"}, -{"name":"gitlab-dangerfiles","version":"3.12.0","platform":"ruby","checksum":"0b260c84530664b5ae9d8cf21658c4658d4c319a0c9cbc4d56ecb6591b097d7d"}, +{"name":"gitlab-dangerfiles","version":"3.13.0","platform":"ruby","checksum":"2081eac7fe1f538427f8ebec1e8cd7c143a30d50e1470348cdec4f2d273ea1ad"}, {"name":"gitlab-experiment","version":"0.7.1","platform":"ruby","checksum":"166dddb3aa83428bcaa93c35684ed01dc4d61f321fd2ae40b020806dc54a7824"}, {"name":"gitlab-fog-azure-rm","version":"1.8.0","platform":"ruby","checksum":"e4f24b174b273b88849d12fbcfecb79ae1c09f56cbd614998714c7f0a81e6c28"}, {"name":"gitlab-labkit","version":"0.33.0","platform":"ruby","checksum":"d1fba8d30fde314a3f5dee1921ac31860bed4fecd8aa98ac6671f2627479e05b"}, @@ -461,7 +461,7 @@ {"name":"pry","version":"0.14.2","platform":"ruby","checksum":"c4fe54efedaca1d351280b45b8849af363184696fcac1c72e0415f9bdac4334d"}, {"name":"pry-byebug","version":"3.10.1","platform":"ruby","checksum":"c8f975c32255bfdb29e151f5532130be64ff3d0042dc858d0907e849125581f8"}, {"name":"pry-rails","version":"0.3.9","platform":"ruby","checksum":"468662575abb6b67f4a9831219f99290d5eae7bf186e64dd810d0a3e4a8cc4b1"}, -{"name":"pry-shell","version":"0.6.1","platform":"ruby","checksum":"a99a6b3dffe4df274ea1751866816906861a23851f13346e10a8e8f61b53360c"}, +{"name":"pry-shell","version":"0.6.3","platform":"ruby","checksum":"17b9cdf0e318ab50dc12698da3e1b8f532518cbceb0353c42a9ce2dd066676c2"}, {"name":"public_suffix","version":"5.0.0","platform":"ruby","checksum":"26ee4fbce33ada25eb117ac71f2c24bf4d8b3414ab6b34f05b4708a3e90f1c6b"}, {"name":"puma","version":"6.3.0","platform":"java","checksum":"5e2ff95953608d1ba0350b80a3961a43e9bbb78ec60ebd5e4db1940c2921d5d8"}, {"name":"puma","version":"6.3.0","platform":"ruby","checksum":"b0e35b4fe7ae440237a9ff1647c6bb252a1c0951ff356020670d2e62c1aeeeec"}, diff --git a/Gemfile.lock b/Gemfile.lock index 2a1900005a6..334b819fa1f 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -641,7 +641,7 @@ GEM terminal-table (>= 1.5.1) gitlab-chronic (0.10.5) numerizer (~> 0.2) - gitlab-dangerfiles (3.12.0) + gitlab-dangerfiles (3.13.0) danger (>= 8.4.5) danger-gitlab (>= 8.0.0) rake @@ -1217,7 +1217,7 @@ GEM pry (>= 0.13, < 0.15) pry-rails (0.3.9) pry (>= 0.10.4) - pry-shell (0.6.1) + pry-shell (0.6.3) pry (>= 0.13.0) tty-markdown tty-prompt @@ -1810,7 +1810,7 @@ DEPENDENCIES gettext_i18n_rails_js (~> 1.3) gitaly (~> 16.2.0.pre.rc4) gitlab-chronic (~> 0.10.5) - gitlab-dangerfiles (~> 3.12.0) + gitlab-dangerfiles (~> 3.13.0) gitlab-experiment (~> 0.7.1) gitlab-fog-azure-rm (~> 1.8.0) gitlab-labkit (~> 0.33.0) @@ -1941,7 +1941,7 @@ DEPENDENCIES prometheus-client-mmap (~> 0.27) pry-byebug pry-rails (~> 0.3.9) - pry-shell (~> 0.6.1) + pry-shell (~> 0.6.3) puma (~> 6.3) rack (~> 2.2.7) rack-attack (~> 6.6.1) diff --git a/app/assets/javascripts/ci/runner/components/registration/registration_instructions.vue b/app/assets/javascripts/ci/runner/components/registration/registration_instructions.vue index 69021dde0e9..771ecb1a0d4 100644 --- a/app/assets/javascripts/ci/runner/components/registration/registration_instructions.vue +++ b/app/assets/javascripts/ci/runner/components/registration/registration_instructions.vue @@ -163,7 +163,7 @@ export default { " >

diff --git a/app/assets/javascripts/ci/runner/components/runner_details.vue b/app/assets/javascripts/ci/runner/components/runner_details.vue index 8c1280cffb9..fac90fb0370 100644 --- a/app/assets/javascripts/ci/runner/components/runner_details.vue +++ b/app/assets/javascripts/ci/runner/components/runner_details.vue @@ -94,10 +94,7 @@ export default {
-
+
{{ __('Save') }} - {{ __('Cancel') }} + {{ __('Cancel') }} diff --git a/app/assets/javascripts/comment_templates/components/list.vue b/app/assets/javascripts/comment_templates/components/list.vue index 76a5b231d81..9c460297335 100644 --- a/app/assets/javascripts/comment_templates/components/list.vue +++ b/app/assets/javascripts/comment_templates/components/list.vue @@ -1,21 +1,14 @@ diff --git a/app/assets/javascripts/comment_templates/components/list_item.vue b/app/assets/javascripts/comment_templates/components/list_item.vue index 70ba449113b..0619201e346 100644 --- a/app/assets/javascripts/comment_templates/components/list_item.vue +++ b/app/assets/javascripts/comment_templates/components/list_item.vue @@ -74,8 +74,8 @@ export default {