From 953180403c1798ba42d396742e0691d5772da3a5 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 28 Nov 2022 18:09:29 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 1 - .gitlab/ci/rules.gitlab-ci.yml | 3 + .../javascripts/issues/list/constants.js | 2 +- .../components/states/ready_to_merge.vue | 3 +- .../javascripts/work_items/constants.js | 2 +- app/controllers/concerns/lfs_request.rb | 7 +- app/finders/users_finder.rb | 6 +- app/helpers/search_helper.rb | 20 ++++++ app/models/work_items/type.rb | 27 ++++++-- ...create_work_item_hierarchy_restrictions.rb | 5 ++ ...create_work_item_hierarchy_restrictions.rb | 5 ++ ...16143854_add_okr_hierarchy_restrictions.rb | 48 +++++++++++++ db/schema_migrations/20221116143854 | 1 + doc/administration/feature_flags.md | 3 +- doc/api/graphql/reference/index.md | 2 +- doc/api/merge_request_approvals.md | 2 + doc/api/packages/pypi.md | 6 +- doc/user/search/index.md | 1 + lib/gitlab/ci/config/entry/default.rb | 26 ++++--- lib/gitlab/ci/config/entry/hooks.rb | 2 + lib/gitlab/ci/config/entry/job.rb | 2 +- lib/gitlab/ci/pipeline/logger.rb | 8 +-- .../hierarchy_restrictions_importer.rb | 37 ++++++++++ lib/gitlab/slash_commands/application_help.rb | 11 +-- lib/gitlab/slash_commands/command.rb | 6 +- scripts/api/create_issue_discussion.rb | 32 +++++++++ scripts/create-pipeline-failure-incident.rb | 20 +++++- .../review_apps/k8s-resources-count-checks.sh | 3 - scripts/used-feature-flags | 3 + spec/controllers/search_controller_spec.rb | 6 ++ ...e_work_item_hierarchy_restrictions_spec.rb | 9 +++ ...e_work_item_hierarchy_restrictions_spec.rb | 9 +++ spec/finders/users_finder_spec.rb | 52 +++++++++----- spec/helpers/search_helper_spec.rb | 28 ++++++++ .../lib/gitlab/ci/config/entry/bridge_spec.rb | 2 +- .../gitlab/ci/config/entry/default_spec.rb | 5 +- spec/lib/gitlab/ci/pipeline/logger_spec.rb | 15 ++++ spec/lib/gitlab/ci/yaml_processor_spec.rb | 31 +++++++++ .../hierarchy_restrictions_importer_spec.rb | 10 +++ .../slash_commands/application_help_spec.rb | 4 +- .../add_okr_hierarchy_restrictions_spec.rb | 35 ++++++++++ spec/models/work_items/type_spec.rb | 26 +++++++ spec/requests/lfs_http_spec.rb | 52 +++++++++++++- .../create_pipeline_service/scripts_spec.rb | 68 ++++++++++++++++--- ...rk_item_hierarchy_restrictions_importer.rb | 53 +++++++++++++++ tooling/config/CODEOWNERS.yml | 1 + 46 files changed, 616 insertions(+), 84 deletions(-) create mode 100644 db/fixtures/development/50_create_work_item_hierarchy_restrictions.rb create mode 100644 db/fixtures/production/020_create_work_item_hierarchy_restrictions.rb create mode 100644 db/post_migrate/20221116143854_add_okr_hierarchy_restrictions.rb create mode 100644 db/schema_migrations/20221116143854 create mode 100644 lib/gitlab/database_importers/work_items/hierarchy_restrictions_importer.rb create mode 100644 scripts/api/create_issue_discussion.rb create mode 100644 spec/db/development/create_work_item_hierarchy_restrictions_spec.rb create mode 100644 spec/db/production/create_work_item_hierarchy_restrictions_spec.rb create mode 100644 spec/lib/gitlab/database_importers/work_items/hierarchy_restrictions_importer_spec.rb create mode 100644 spec/migrations/add_okr_hierarchy_restrictions_spec.rb create mode 100644 spec/support/shared_examples/work_item_hierarchy_restrictions_importer.rb diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 8587312bb08..3199739a33f 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1043,7 +1043,6 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab /app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql @gitlab-org/manage/authentication-and-authorization/approvers /app/assets/javascripts/authentication/ @gitlab-org/manage/authentication-and-authorization/approvers /app/assets/javascripts/ide/components/shared/tokened_input.vue @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/invite_members/components/members_token_select.vue @gitlab-org/manage/authentication-and-authorization/approvers /app/assets/javascripts/packages_and_registries/package_registry/components/list/tokens/ @gitlab-org/manage/authentication-and-authorization/approvers /app/assets/javascripts/pages/admin/impersonation_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers /app/assets/javascripts/pages/groups/settings/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 830fbf64d38..c40f5744686 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -1903,14 +1903,17 @@ - <<: *if-dot-com-gitlab-org-merge-request changes: *controllers-patterns variables: *review-change-pattern + when: manual allow_failure: true - <<: *if-dot-com-gitlab-org-merge-request changes: *models-patterns variables: *review-change-pattern + when: manual allow_failure: true - <<: *if-dot-com-gitlab-org-merge-request changes: *lib-gitlab-patterns variables: *review-change-pattern + when: manual allow_failure: true - <<: *if-dot-com-gitlab-org-merge-request changes: *qa-patterns diff --git a/app/assets/javascripts/issues/list/constants.js b/app/assets/javascripts/issues/list/constants.js index fd7d53e7a36..16d28e8404c 100644 --- a/app/assets/javascripts/issues/list/constants.js +++ b/app/assets/javascripts/issues/list/constants.js @@ -147,7 +147,7 @@ export const specialFilterValues = [ export const TYPE_TOKEN_TASK_OPTION = { icon: 'issue-type-task', title: 'task', value: 'task' }; export const TYPE_TOKEN_OBJECTIVE_OPTION = { - icon: 'issue-type-issue', + icon: 'issue-type-objective', title: 'objective', value: 'objective', }; diff --git a/app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue b/app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue index a15bf6fadd8..6b9a8f59aa8 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue @@ -467,8 +467,9 @@ export default {