diff --git a/.haml-lint.yml b/.haml-lint.yml index 24e671eee87..3231627862d 100644 --- a/.haml-lint.yml +++ b/.haml-lint.yml @@ -109,7 +109,6 @@ linters: # These cops should eventually get enabled - Cop/LineBreakAfterGuardClauses - Cop/ProjectPathHelper - - Gitlab/FeatureAvailableUsage - Gitlab/Json - GitlabSecurity/PublicSend - Layout/EmptyLineAfterGuardClause diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index d7eec700a9d..a0c71dec923 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -38,7 +38,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/models/approval_state.rb' - 'ee/app/models/concerns/ee/approvable.rb' - 'ee/app/models/concerns/ee/project_security_scanners_information.rb' - - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/insights_feature.rb' - 'ee/app/models/ee/board.rb' - 'ee/app/models/ee/ci/build.rb' @@ -68,7 +67,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/ci/audit_variable_change_service.rb' - 'ee/app/services/dashboard/projects/create_service.rb' - 'ee/app/services/dashboard/projects/list_service.rb' - - 'ee/app/services/ee/alert_management/http_integrations/create_service.rb' - 'ee/app/services/ee/audit_event_service.rb' - 'ee/app/services/ee/boards/issues/list_service.rb' - 'ee/app/services/ee/boards/lists/create_service.rb' @@ -91,6 +89,31 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/projects/mark_for_deletion_service.rb' - 'ee/app/services/requirements_management/process_test_reports_service.rb' - 'ee/app/services/security/store_scans_service.rb' + - 'ee/app/views/compliance_management/compliance_framework/_project_settings.html.haml.rb' + - 'ee/app/views/groups/epics/index.html.haml.rb' + - 'ee/app/views/product_analytics/_project_settings.html.haml.rb' + - 'ee/app/views/projects/_merge_request_settings.html.haml.rb' + - 'ee/app/views/projects/_merge_request_settings_description_text.html.haml.rb' + - 'ee/app/views/projects/_remove.html.haml.rb' + - 'ee/app/views/projects/audit_events/index.html.haml.rb' + - 'ee/app/views/projects/blob/_header_file_locks.html.haml.rb' + - 'ee/app/views/projects/branch_defaults/_branch_names_help.html.haml.rb' + - 'ee/app/views/projects/merge_requests/show.html.haml.rb' + - 'ee/app/views/projects/push_rules/_index.html.haml.rb' + - 'ee/app/views/projects/quality/test_cases/index.html.haml.rb' + - 'ee/app/views/projects/settings/_default_issue_template.html.haml.rb' + - 'ee/app/views/projects/settings/_restore.html.haml.rb' + - 'ee/app/views/projects/settings/ci_cd/_auto_rollback.html.haml.rb' + - 'ee/app/views/projects/settings/ci_cd/_pipeline_subscriptions.html.haml.rb' + - 'ee/app/views/projects/settings/merge_requests/_merge_request_approvals_settings.html.haml.rb' + - 'ee/app/views/projects/settings/operations/_status_page.html.haml.rb' + - 'ee/app/views/projects/settings/repository/_protected_branches.html.haml.rb' + - 'ee/app/views/protected_branches/ee/_code_owner_approval_form.html.haml.rb' + - 'ee/app/views/protected_branches/ee/_code_owner_approval_table.html.haml.rb' + - 'ee/app/views/protected_branches/ee/_code_owner_approval_table_head.html.haml.rb' + - 'ee/app/views/shared/labels/_create_label_help_text.html.haml.rb' + - 'ee/app/views/shared/promotions/_promote_mr_features.html.haml.rb' + - 'ee/app/views/shared/promotions/_promote_repository_features.html.haml.rb' - 'ee/app/workers/analytics/code_review_metrics_worker.rb' - 'ee/app/workers/group_saml_group_sync_worker.rb' - 'ee/lib/ee/api/entities/approval_state.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 435efc1c5b3..ba364327e4a 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -687,7 +687,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/requests/lfs_http_spec.rb' - 'spec/rubocop/cop/migration/complex_indexes_require_name_spec.rb' - 'spec/rubocop/cop/migration/refer_to_index_by_name_spec.rb' - - 'spec/rubocop/formatter/todo_formatter_spec.rb' - 'spec/scripts/lib/glfm/parse_examples_spec.rb' - 'spec/scripts/lib/glfm/shared_spec.rb' - 'spec/scripts/lib/glfm/update_example_snapshots_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 0835191b8f4..4d635a3071c 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -5370,9 +5370,7 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/usage_data/instrumentation_superclass_spec.rb' - 'spec/rubocop/cop/usage_data/large_table_spec.rb' - 'spec/rubocop/cop/user_admin_spec.rb' - - 'spec/rubocop/cop_todo_spec.rb' - 'spec/rubocop/formatter/graceful_formatter_spec.rb' - - 'spec/rubocop/formatter/todo_formatter_spec.rb' - 'spec/rubocop/migration_helpers_spec.rb' - 'spec/rubocop/qa_helpers_spec.rb' - 'spec/rubocop/todo_dir_spec.rb' diff --git a/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue b/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue index 9f4ce14f704..cc31afea88c 100644 --- a/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue +++ b/app/assets/javascripts/ci/runner/components/cells/runner_summary_cell.vue @@ -1,6 +1,6 @@