diff --git a/.gitlab/ci/database.gitlab-ci.yml b/.gitlab/ci/database.gitlab-ci.yml index 577e0f4fdc0..1283f584fb3 100644 --- a/.gitlab/ci/database.gitlab-ci.yml +++ b/.gitlab/ci/database.gitlab-ci.yml @@ -45,59 +45,17 @@ db:rollback single-db: - .single-db - .rails:rules:single-db -db:migrate:multi-version-upgrade-1: - stage: test - image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/${BUILD_OS}-${OS_VERSION}-ruby-${RUBY_VERSION}:bundler-${BUNDLER_VERSION}-docker-${DOCKER_VERSION} - extends: - - .db-job-base - - .use-docker-in-docker - variables: - UPGRADE_STOP: 16.3.6-ee - UPGRADE_STOP_IMAGE: gitlab/gitlab-ee:${UPGRADE_STOP}.0 - UPGRADE_STOP_TAG: v${UPGRADE_STOP} - before_script: - # pull, seed, and export data from previous Upgrade Stop - - docker pull "${UPGRADE_STOP_IMAGE}" - - | - docker run \ - -d \ - -v ./scripts/data_seeder:/opt/gitlab/embedded/service/gitlab-rails/scripts/data_seeder \ - -v ./ee/db/seeds/data_seeder:/opt/gitlab/embedded/service/gitlab-rails/ee/db/seeds/data_seeder \ - -v ./ee/lib/tasks/gitlab/seed:/opt/gitlab/embedded/service/gitlab-rails/ee/lib/tasks/gitlab/seed \ - --name gitlab \ - "${UPGRADE_STOP_IMAGE}" - - docker exec gitlab bash -c "cd /opt/gitlab/embedded/service/gitlab-rails; REF='${UPGRADE_STOP_TAG}' . scripts/data_seeder/test_resources.sh" - - | - docker exec gitlab bash -c "cd /opt/gitlab/embedded/service/gitlab-rails; echo \"gem 'gitlab-rspec', path: 'gems/gitlab-rspec'\" >> Gemfile" - - docker exec gitlab bash -c "cd /opt/gitlab/embedded/service/gitlab-rails; ruby scripts/data_seeder/globalize_gems.rb; bundle install" - - docker exec gitlab bash -c "gitlab-ctl reconfigure" - - docker exec gitlab gitlab-rake "ee:gitlab:seed:data_seeder[bulk_data.rb]" - - # dump - - docker exec gitlab bash -c "mkdir /tmp/xfer; chown gitlab-psql /tmp/xfer" - - | - docker exec gitlab bash -c " \ - runuser -l gitlab-psql -c \"pg_dump -U gitlab-psql -h '/var/opt/gitlab/postgresql' gitlabhq_production | gzip > /tmp/xfer/gitlabhq_production.gz\" \ - " - script: - - docker cp gitlab:/tmp/xfer/gitlabhq_production.gz . - artifacts: - paths: ["gitlabhq_production.gz"] - expire_in: 3d - when: manual - allow_failure: true - -db:migrate:multi-version-upgrade-2: - stage: test +db:migrate:multi-version-upgrade: extends: - .db-job-base script: - - gunzip gitlabhq_production.gz + - curl -o latest_upgrade_stop.gz https://gitlab.com/gitlab-org/quality/pg-dump-generator/-/raw/main/pg_dumps/ee/latest_upgrade_stop.gz + - gunzip -c latest_upgrade_stop.gz > gitlabhq_production - bundle exec rake db:drop db:create - apt-get update -qq && apt-get install -y -qq postgresql - psql -h postgres -U postgres -d gitlabhq_test < gitlabhq_production - bundle exec rake gitlab:db:configure - needs: ["db:migrate:multi-version-upgrade-1"] + allow_failure: true db:migrate:reset: extends: .db-job-base diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 2974334990a..f497113edd3 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -161,9 +161,6 @@ .if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified: &if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_NAMESPACE =~ /^gitlab-org($|\/security$)/ && ($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $QA_TESTS' -.if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e: &if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_NAMESPACE =~ /^gitlab-org($|\/security$)/ && ($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $QA_MANUAL_FF_PACKAGE_AND_QA' - .if-dot-com-gitlab-org-and-security-tag: &if-dot-com-gitlab-org-and-security-tag if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_NAMESPACE =~ /^gitlab-org($|\/security$)/ && $CI_COMMIT_TAG' @@ -898,8 +895,6 @@ - <<: *if-merge-request changes: *dependency-patterns - <<: *if-merge-request-labels-run-all-e2e - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - <<: *if-merge-request changes: *feature-flag-development-config-patterns - <<: *if-merge-request @@ -985,9 +980,6 @@ changes: *nodejs-patterns - <<: *if-merge-request changes: *ci-qa-patterns - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - when: manual - <<: *if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified changes: *code-patterns - <<: *if-merge-request @@ -1016,8 +1008,6 @@ - <<: *if-merge-request changes: *dependency-patterns - <<: *if-merge-request-labels-run-all-e2e - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - <<: *if-merge-request changes: *feature-flag-development-config-patterns - <<: *if-merge-request @@ -1252,8 +1242,6 @@ # Rules to support .qa:rules:package-and-test - <<: *if-default-branch-schedule-nightly - <<: *if-merge-request-labels-run-all-e2e - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - <<: *if-merge-request changes: *dependency-patterns - <<: *if-force-ci @@ -1533,9 +1521,6 @@ allow_failure: true - <<: *if-merge-request-labels-run-all-e2e allow_failure: true - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - allow_failure: true - <<: *if-merge-request changes: *feature-flag-development-config-patterns allow_failure: true @@ -1561,8 +1546,6 @@ variables: OMNIBUS_GITLAB_BUILD_ON_ALL_OS: 'true' - <<: *if-merge-request-labels-run-all-e2e - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - <<: *if-merge-request changes: *feature-flag-development-config-patterns - <<: *if-merge-request @@ -1605,10 +1588,6 @@ OMNIBUS_GITLAB_BUILD_ON_ALL_OS: 'true' - <<: *if-merge-request-labels-run-all-e2e allow_failure: true - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - when: manual - allow_failure: true - <<: *if-merge-request changes: *feature-flag-development-config-patterns allow_failure: true @@ -1773,43 +1752,6 @@ - <<: *if-merge-request-and-specific-devops-stage when: never - !reference [".qa:rules:code-merge-request-manual", rules] - - <<: *if-dot-com-gitlab-org-schedule - when: never - - <<: *if-merge-request-targeting-stable-branch - changes: *setup-test-env-patterns - when: never - - <<: *if-ruby-branch - when: never - - <<: *if-merge-request - changes: *dependency-patterns - when: never - - <<: *if-merge-request-labels-run-all-e2e - when: never - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - when: manual - allow_failure: true - - <<: *if-merge-request - changes: *feature-flag-development-config-patterns - when: never - - <<: *if-merge-request - changes: *initializers-patterns - when: never - - <<: *if-merge-request - changes: *nodejs-patterns - when: never - - <<: *if-merge-request - changes: *ci-qa-patterns - when: never - - <<: *if-merge-request - changes: *qa-patterns - when: never - - <<: *if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified - changes: *code-patterns - when: never - - <<: *if-force-ci - when: manual - allow_failure: true # These are based on `.qa:rules:manual-omnibus-and-follow-up-e2e` but with manual jobs changed to automatic .qa:rules:follow-up-e2e: @@ -1820,41 +1762,6 @@ - <<: *if-merge-request changes: *code-patterns allow_failure: true - - <<: *if-dot-com-gitlab-org-schedule - when: never - - <<: *if-merge-request-targeting-stable-branch - changes: *setup-test-env-patterns - when: never - - <<: *if-ruby-branch - when: never - - <<: *if-merge-request - changes: *dependency-patterns - when: never - - <<: *if-merge-request-labels-run-all-e2e - when: never - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - allow_failure: true - - <<: *if-merge-request - changes: *feature-flag-development-config-patterns - when: never - - <<: *if-merge-request - changes: *initializers-patterns - when: never - - <<: *if-merge-request - changes: *nodejs-patterns - when: never - - <<: *if-merge-request - changes: *ci-qa-patterns - when: never - - <<: *if-merge-request - changes: *qa-patterns - when: never - - <<: *if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified - changes: *code-patterns - when: never - - <<: *if-force-ci - allow_failure: true # These are based on `qa:rules:package-and-test-ee` but with when:never in all except for code-patterns in merge requests .qa:rules:post-run-e2e-message: @@ -1871,9 +1778,6 @@ when: never - <<: *if-merge-request-labels-run-all-e2e when: never - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - when: never - <<: *if-merge-request changes: *feature-flag-development-config-patterns when: never @@ -3026,8 +2930,6 @@ changes: *code-backstage-qa-patterns - <<: *if-security-merge-request changes: *db-patterns - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns .as-if-foss:rules:start-as-if-foss:allow-failure:manual: rules: @@ -3126,10 +3028,6 @@ changes: *db-patterns allow_failure: true when: manual - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - allow_failure: true - when: manual .as-if-foss:rules:start-as-if-foss:allow-failure: rules: @@ -3205,9 +3103,6 @@ - <<: *if-security-merge-request changes: *db-patterns allow_failure: true - - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e - changes: *feature-flag-development-config-patterns - allow_failure: true ################## # as-if-jh rules # diff --git a/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue b/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue index 3a0fd376d3c..d9a5c0c7101 100644 --- a/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue +++ b/app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue @@ -20,7 +20,6 @@ import { totalArtifactsSizeForJob, mapArchivesToJobNodes, mapBooleansToJobNodes import bulkDestroyJobArtifactsMutation from '../graphql/mutations/bulk_destroy_job_artifacts.mutation.graphql'; import { removeArtifactFromStore } from '../graphql/cache_update'; import { - STATUS_BADGE_VARIANTS, I18N_DOWNLOAD, I18N_BROWSE, I18N_DELETE, @@ -351,7 +350,6 @@ export default { tdClass: 'gl-text-right', }, ], - STATUS_BADGE_VARIANTS, i18n: { download: I18N_DOWNLOAD, browse: I18N_BROWSE, diff --git a/app/assets/javascripts/ci/artifacts/constants.js b/app/assets/javascripts/ci/artifacts/constants.js index 166946035d1..fee969c357d 100644 --- a/app/assets/javascripts/ci/artifacts/constants.js +++ b/app/assets/javascripts/ci/artifacts/constants.js @@ -4,29 +4,6 @@ export const PAGE_TITLE = s__('Artifacts|Artifacts'); export const TOTAL_ARTIFACTS_SIZE = s__('Artifacts|Total artifacts size'); export const SIZE_UNKNOWN = __('Unknown'); -export const JOB_STATUS_GROUP_SUCCESS = 'success'; - -export const STATUS_BADGE_VARIANTS = { - success: 'success', - passed: 'success', - error: 'danger', - failed: 'danger', - pending: 'warning', - 'waiting-for-resource': 'warning', - 'failed-with-warnings': 'warning', - 'success-with-warnings': 'warning', - running: 'info', - canceled: 'neutral', - disabled: 'neutral', - scheduled: 'neutral', - manual: 'neutral', - notification: 'muted', - preparing: 'muted', - created: 'muted', - skipped: 'muted', - notfound: 'muted', -}; - export const I18N_DOWNLOAD = __('Download'); export const I18N_BROWSE = s__('Artifacts|Browse'); export const I18N_DELETE = __('Delete'); diff --git a/app/assets/javascripts/ci/artifacts/utils.js b/app/assets/javascripts/ci/artifacts/utils.js index 74ade7d48aa..b2644a3b61e 100644 --- a/app/assets/javascripts/ci/artifacts/utils.js +++ b/app/assets/javascripts/ci/artifacts/utils.js @@ -1,5 +1,5 @@ import { numberToHumanSize } from '~/lib/utils/number_utils'; -import { ARCHIVE_FILE_TYPE, METADATA_FILE_TYPE, JOB_STATUS_GROUP_SUCCESS } from './constants'; +import { ARCHIVE_FILE_TYPE, METADATA_FILE_TYPE } from './constants'; export const totalArtifactsSizeForJob = (job) => numberToHumanSize( @@ -19,7 +19,6 @@ export const mapArchivesToJobNodes = (jobNode) => { export const mapBooleansToJobNodes = (jobNode) => { return { - succeeded: jobNode.detailedStatus.group === JOB_STATUS_GROUP_SUCCESS, hasArtifacts: jobNode.artifacts.nodes.length > 0, hasMetadata: jobNode.artifacts.nodes.some( (artifact) => artifact.fileType === METADATA_FILE_TYPE, diff --git a/app/assets/javascripts/content_editor/components/wrappers/image.vue b/app/assets/javascripts/content_editor/components/wrappers/image.vue index b7031a4885c..bcafed00094 100644 --- a/app/assets/javascripts/content_editor/components/wrappers/image.vue +++ b/app/assets/javascripts/content_editor/components/wrappers/image.vue @@ -88,7 +88,7 @@ export default {